- 12 Jun, 2019 40 commits
-
-
Brett Kilty authored
Includes persistent=true to the manifest to allow for a lower oom_adj score when running the browser instance on Android Things so low memory killer doesn't incorrectly tear down required processes when under memory pressure. Bug: internal Change-Id: I34e04f8d4485c613fef3187a6e305e17b9e51855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653652 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Auto-Submit: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#668444}
-
Caleb Raitto authored
I have no idea what I'm doing (I'm not sure how to test this change), please review this carefully :) See the discussion at [1] for more context. Chromium documentation claims that LeakSanitizer runs on all ASan trybots [2], but I have been unable to replicate this behavior myself. To test, I created a CL (https://crrev.com/c/1550630/4) that intentionally leaks memory inside of a test. None of the trybots, including the ASan trybot, were able to find the leak. In contrast, a similar test that had a gtest expectation failure (https://crrev.com/c/1588945/1) and another test that had a use-after-free bug (https://crrev.com/c/1588858/1) were both successfully caught by the ASan trybot. Despite the inability to catch leaks using trybots, I was able to catch the leak locally on my workstation by following the instructions in [2]. I noticed that the trybot test was built with 'is_lsan=true' and 'is_asan=true' [3]. However, the runtime ASAN_OPTIONS listed in [4] do not include 'detect_leaks=1' as required by the documentation [2]. I found that running locally without the 'detect_leaks=1' in ASAN_OPTIONS, my leak test passed (that is, the leak wasn't caught). The src/testing/test_env.py script appears to add 'detect_leaks=1' to ASAN_OPTIONS if the script is passed the '--lsan' flag [5][6]. However, the script that calls test_env.py, tools/mb/mb.py, doesn't seem to ever pass this flag [7] -- that is what this CL attempts to fix. [1] https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/UEnRGM43MYE/3LnWa4k5BwAJ [2] https://www.chromium.org/developers/testing/leaksanitizer [3] https://ci.chromium.org/p/chromium/builders/try/linux_chromium_asan_rel_ng/264888 [4] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8914804258249981008/+/steps/cronet_tests__with_patch_/0/stdout [5] https://cs.chromium.org/chromium/src/testing/test_env.py?l=95&rcl=fba6691ffca770dd0c916418601b9c9c019a2929 [6] https://cs.chromium.org/chromium/src/testing/test_env.py?l=294&rcl=fba6691ffca770dd0c916418601b9c9c019a2929 [7] https://cs.chromium.org/chromium/src/tools/mb/mb.py?l=1229&rcl=57ddea756f68c9d95dcdec9e02b86fd1f5860b60 Bug: 948939 Change-Id: I7237e76aad395271ddc2403612a62aaaa18ae0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590404Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#668443}
-
Manas Verma authored
This CL allows for a payments request to include a FIDO assertion response instead of a CVC to unmask a credit card. Bug: 949269 Change-Id: Icdae1023f8b9f3eac1e6e19b595990229a3f9236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623920Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#668442}
-
Kristyn Hamasaki authored
Bug: 972687 Change-Id: I2fa46c1c503d3e6a319343eabf36bc74859e825d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650296 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#668441}
-
Richard Knoll authored
This fixes multi line elision for text that contains newline characters. This had the following two issues: 1) RenderText::Elide renders the given text on a single line. This is fixed by only passing in a single line when eliding the text in RenderText::UpdateDisplayText. 2) The HarfBuzzLineBreaker keeps track of the min and max ascent. This needs to ignore newline characters in multiline modes as they are not drawn. Bug: 972997 Change-Id: Ie7f6d84d61000595eaa53a660caff7b98b0fb17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649778 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#668440}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b8260a8e915d..6dd5f3358713 git log b8260a8e915d..6dd5f3358713 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 chrisforbes@google.com Fix Android build Created with: gclient setdep -r src/third_party/swiftshader@6dd5f3358713 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I3225509394b7188c9277986834237b620e5cfce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668439}
-
Olivier Robin authored
This CL adds Open in Chrome feature in Share extension. It also refactor the command system from the notification center extension in ios/chrome/common so they can be in share extension. Bug: 972076 Change-Id: If5d0592e2dd72a396958a496f0f7250a2481829c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643534 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#668438}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1750292dc4b6..b64faff265e8 git log 1750292dc4b6..b64faff265e8 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 khokhlov@google.com Make StoryRun manage its own artifacts Created with: gclient setdep -r src/third_party/catapult@b64faff265e8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:972025 TBR=simonhatch@google.com Change-Id: I75bbaf01b3a03472b93ce0688070f18aea205f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655043Reviewed-by:
-
Anders Hartvoll Ruud authored
The previous "extra field" VisitedLinkColor did not follow the pattern of having custom getter/setter in order to put them in the a private segment. This CL changes that to align with the other -color properties. Note that the "elif header" change in the .tmpl fixes a bug in the code generation where Apply*-functions could be incorrectly _declared_ in the .cc file, when it shouldn't have appeared there at all. Bug: 972388 Change-Id: I411b61eef7ad2a6cd9a61439351ddb7b09a28c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651813 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668436}
-
Arthur Hemery authored
Currently, it is possible to spoof the URL of a site by starting a navigation in the main frame and having a cross-site iframe initiating another navigation in its parent frame (with extra steps for it to be user visible). This can also be used to cancel any browser initiated navigation in the main frame. The CL adresses the issue by adding checks similar to what exists in BeginNavigation on the FrameProxy::OpenURL path. Bug: 966914 Change-Id: If547c2ef4b30b2e0323141005583412c12bfef8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643191Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#668435}
-
James Cook authored
This fixes a longstanding issue where guest mode users cannot change the browser's preferred language list. The main profile in guest mode is an off-the-record/incognito profile. This CL from 2.5 years ago https://codereview.chromium.org/2499093002 changed the settingsPrivate API in guest mode to use the backing ("recording") profile instead of the main incognito profile for pref writes. The languages UI continued to function because the incognito profile's preferences were "overlaid" onto the recording profile prefs. By default, all prefs were overlaid, except for a block-list. That block-list was changed to a whitelist, and the whitelisted prefs were gradually removed. This CL removed the language prefs from the list: https://chromium-review.googlesource.com/c/chromium/src/+/1174118/ which made the guest mode language section stop working. For guest mode we want to use the incognito pref store where possible. The incognito pref store is in-memory. The backing user profile is deleted after logout (it is on a tmpfs) but it's better to just avoid writing the prefs. Change the BCKSFactories to prefer the incognito profile. Return null services in tests because unit tests with TestingProfile generally don't need these services. Bug: 887383 Test: added to browser_tests, manual test in guest mode on eve Change-Id: Ib4bbe45662b13aa3b733eaddc4342de5b68086b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653748 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#668434}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/286660f0dde0..889ec0706417 git log 286660f0dde0..889ec0706417 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 saklein@chromium.org BinhostService: Fix prebuilts path fetch. Created with: gclient setdep -r src/third_party/chromite@889ec0706417 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I06bf84c08a4878aad73e4fece6fe9959a9736fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655046Reviewed-by:
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. The virtual functions of this class has been refactored as part of another cl. Bug: 959157 Change-Id: Ia73f41bcbb9bc1d4a8bfe1e57337e0d77be8dbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649550 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#668432}
-
Lukasz Anforowicz authored
This CL adds ScopedAllowRendererCrashes to browser tests that (expectedly or unexpectedly) might trigger a renderer crash. Right now a browser test might pass, even if a renderer process crashed during the test execution. After https://crrev.com/c/1650463 a renderer crash will trigger an explicit test failure, but before this enforcement can start, existing tests that experience renderer crashes (expectedly or unexpectedly) need to declare this via ScopedAllowRendererCrashes. This CL was uploaded by git cl split. R=ssid@chromium.org Bug: 972220 Change-Id: Ie70039609720ed091aa7efa5cb1ce5a3fd2f0c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653629 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#668431}
-
Lukasz Anforowicz authored
This CL adds ScopedAllowRendererCrashes to browser tests that (expectedly or unexpectedly) might trigger a renderer crash. Right now a browser test might pass, even if a renderer process crashed during the test execution. After https://crrev.com/c/1650463 a renderer crash will trigger an explicit test failure, but before this enforcement can start, existing tests that experience renderer crashes (expectedly or unexpectedly) need to declare this via ScopedAllowRendererCrashes. This CL was uploaded by git cl split. R=lfg@chromium.org Bug: 972220 Change-Id: Ia48b122e05426652171a4bbe3f95fef603823f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652379 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#668430}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/da1c65fb53c3..e794243650a0 git log da1c65fb53c3..e794243650a0 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 sprang@webrtc.org Remove PacedSender::PacketSender interface and use PacketRouter directly 2019-06-12 nisse@webrtc.org Delete StartRtcEventLog and StopRtcEventLog methods from FakeVoiceEngine 2019-06-12 chxg@google.com Add a tracker for RTCRtpContributingSource and RTCRtpSynchronizationSource. Created with: gclient setdep -r src/third_party/webrtc@e794243650a0 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I753757483084b7fc9315a8ee1f7044940d4da32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655044Reviewed-by:
-
Alexander Hendrich authored
This CL fixes comments about type CHECKs in base/value.h The comments used to say "fataly asserts if type is not dictionary" and was updated to "CHECKs if type is not dictionary" in https://chromium-review.googlesource.com/c/chromium/src/+/1550471 This CL updates removes the "not" from the comment. Bug: 646113 Change-Id: I50992da3fc82b67ad2d0cdeaa0ed3330444cfd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649495Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#668428}
-
Ahmed Mehfooz authored
Need to move notifications down whenever there is free space below. Bug: 920110 Change-Id: Ib49a4e22ee1cbb287095125fc29c623e47d20339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638142Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#668427}
-
Clark DuVall authored
The experiment using the no-op service has been run, and it is no longer needed. Bug: 923101 Change-Id: I927dd3f9815a9f67f0d12231f387e60b0245ea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652803 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#668426}
-
Aaron Krajeski authored
I've verified locally that this works for the four possible configurations of offscreen canvas: 1. On main thread with new OffscreenCanvas() 2. On main thread with canvas.transferControlToOffscreen() 3. On a worker with new OffscreenCanvas() 4. On a worker with canvas.transferControlToOffscreen() AFAIK there is no way to capture console output for testing. Bug: 967581 Change-Id: If06c7f15919f029e6f5f97b216f5ec4ac0698d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651060Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#668425}
-
Ben Pastene authored
Fixes include: - Using the system python when trying to invoke a python script. - Don't run the test via swarming on mac since there's no mac VMs available in chrome-swarming's test pool. Bug: 961548 Change-Id: Idad126d8b90ea77d772fc239d55f799864127eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654268Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Eric Willigers authored
Web Platform Tests for computed values of CSS Text properties https://drafts.csswg.org/css-text-3/#property-index Change-Id: I52b3de169752db63c96c8662819d3b8a1141d721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653608 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#668423}
-
Nektarios Paisios authored
When trying to retrieve the target of an in-page link accessibility node, testing if the node IsAnchor() is not enough. The accessibility node may have the correct role to be an anchor, but no anchor element might be present in the DOM. The user facing bug is that "Reply All" crashes in Gmail. TBR=aleventhal@chromium.org, gilmanmh@google.com Bug: 971188 Change-Id: I119e51678ddaf03d6142d70f0872af4538d7a820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654808Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#668422}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2589cdcc88ec..fce1e2d1e279 git log 2589cdcc88ec..fce1e2d1e279 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 jonahr@google.com Extend eglGetPlatformDisplay to allow feature overrides. Created with: gclient setdep -r src/third_party/angle@fce1e2d1e279 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Change-Id: Ia0649a281fa1ad236fb7967e34a19fabb9bf0709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655038Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b2e12b08cdc..07b9e9354427 git log 0b2e12b08cdc..07b9e9354427 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 primiano@google.com Merge "trace_processor: fix asan leak in gzip decoding" Created with: gclient setdep -r src/third_party/perfetto@07b9e9354427 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id21e4b186df4bd3d4a82cd5a24048dbe2b3d77cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655040Reviewed-by:
-
Bailey Berro authored
This is the first CL in a series of changes to the add printer dialog flow that will remove the configuring dialog where possible, switching to promises rather than WebUI events, and move setup errors to be shown inline rather than as a toast on the cups_printers settings page. This change removes the configuring dialog between the manually add printer dialog and the model/manufacturer dialog Change-Id: I43100a99c8ade7a5df582c3d2f6e06f9ee52671a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637531Reviewed-by:
-
Moe Ahmadi authored
Adds tests for: -Accessibility -Toggling the Translate Switch -Adding a language -Changing language details Bug: 957688 Change-Id: Icadc52b121c18f823bcd37515b46daa1a3bec949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653250 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#668418}
-
danakj authored
The default command line set up by InProcessBrowserTest for browser tests should also be used by AndroidBrowserTest. Move the set up of that command line to chrome/test/base/test_launcher_utils.cc and have AndroidBrowserTest call it. Some clean up in InProcessBrowserTest while we there, moving the shared constructor code into an Initialize() method, so that #ifdefs around TOOLKIT_VIEWS are more clear, move variable initialization to the header declaration, and pass in the ViewsDelegate directly instead of going through a Bind and a lambda when it is just called synchronously anyhow. R=jam@chromium.org Bug: 961849 Change-Id: I3c3fad2b18fbead231e24b4ece32049ca9d43fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652195Reviewed-by:
-
Tibor Goldschwendt authored
Previously, we created a SplitInstallManager _before_ calling SplitCompat.install(-), which breaks the module install flow on Android pre-Q. Bug: b/133669491 Change-Id: I0b317732ed364a592047eeb7387c74dd1ea1b258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646903 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#668416}
-
Rakesh Soma authored
R:tienmai,yusufsn Bug: 973105 Change-Id: Ib7c05f3d9cc70cab53b2a106f1ec5d44096d95c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652735Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#668415}
-
Allen Bauer authored
Bug: 945335 Change-Id: I5671a91452f9c286dbf656da6cb9f0b219f34a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652084 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
This cl is part of the effort to use CoreAccountId instead of std::string to denote account_id. The virtual functions of this class has been refactored as part of another cl. Bug: 959157 Change-Id: I9f1354af8d8958f4df097816a70e78278f319c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649682 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
-
James Cook authored
Bug: 720159 Test: compiles Change-Id: I54d5836d71f41b7ce4367e9d89e12e14ded587f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652663 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Joanmarie Diggs authored
We need to unref root_obj. Bug: 973185 Change-Id: Ie0a326c125fda8ef397d4c8f4b68cabd2c8e7365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655674Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#668411}
-
Evan Stade authored
In some cases in this class, we already return early if no Browser is found for the web contents. This updates one callsite of FindBrowserWithWebContents with an early return, and another with a DCHECK. See also crbug.com/737346 Bug: 971468 Change-Id: I04bbc26679d96f58c7a6d6402cde4bec1409375b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649374 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Hugo Holgersson authored
The HTML spec says: "The href attribute on a and area elements is not required; when those elements do not have href attributes they do not create hyperlinks." Background: Chrome already excludes unclickable <area>s, <area>s without a href attribute, from the tab order. Problem: Unclickable <area>s still show a "click me" hint. Solution: Mimick Firefox. Only show the pointer for actual <area> links. Note: Found during crrev.com/c/1632231. We don't want unclickable <area>s to act navigable. Bug: 972556 Change-Id: I9214171290659b8b800db3e462478e2a1327c832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653009 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#668409}
-
Nazerke authored
Simplify the favicon loader API by converting the FaviconLoader's methods to non-return-value methods. Unit tests are rewritten according to the new API. Bug: 967660 Change-Id: I23c0ec34ecaba1cd363a4e99d13b8aa3a45ccb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645305Reviewed-by:
-
Ioana Pandele authored
If the focused field changes between the user manually requesting to generate a password and the callback coming back from the renderer to show the dialog, the callback should be ignored and the dialog should not be shown. This is because it is no longer relevant to the current focused field. Bug: 835234 Change-Id: Ic778d504b9aa07c12238ddc8ad4dada317801542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655433Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#668407}
-
Peter Wen authored
BitmapCache is more of a utility than a fundamental base package class like ChromeApplication.java. This paves the way for moving it out of chrome_java into //chrome/lib/util. Bug: 846440 Change-Id: I7b465f0915c6b107da1b648d94a3b00c8300f26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646412 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#668406}
-
Rohit Rao authored
iOS 13 supports running UpsideDown on phone, so this test is updated with new expectations. BUG=973398 Change-Id: Ic4fad631af1a01b3a35423d9272d9ae5de92b062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655669Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#668405}
-
