GitLab

Bookmark matches' |allowed_to_be_default_match| depends on
|prevent_inline_autocomplete| being false. This field can be set and
copied before |prevent| is set. The bookmark provider was returning
cached results assuming |prevent| was still set. This CL changes the
bookmark provider to never cache, and always generate and return
fresh results.

Bug: 879905
Change-Id: I909364500417cd629cead52a6f430b6d488142b9
Reviewed-on: https://chromium-review.googlesource.com/1204270Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589385}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I3b0228176452a548e1c17fe8ebe6dcdb7201e538
Reviewed-on: https://chromium-review.googlesource.com/1211919Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589384}

We used to only check the policy on attaching, but we should
also check it when navigating, similar to other session restrictions.

Bug: 880476
Change-Id: I8cbfe149d67eadbc2f723652d140f2cd0925c44c
Reviewed-on: https://chromium-review.googlesource.com/1211948
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589383}

Following bot results are included.
9416 9428 9434 9436 9437 9440 9442 9443 9444 9452 9458 9469
9470 9473 9474 9476 9477 9481 9488

10 lines were removed and 5 lines were deflaked by consecutive
results since 9443.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I220acf8a940d306a081f8f453c18f87e8a4e3ac6
Reviewed-on: https://chromium-review.googlesource.com/1203482
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589382}

This a a follow-up to introducing viz::GpuHostImpl (crrev/c/1180658).
This includes:
 - Removing an expired CHECK;
 - Limiting GpuHost::SetChildSurface() to Windows;
 - Removing unused GpuProcessHost::OnDestroyingVideoSurfaceAck().

BUG=709332

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ida7488d887ff5d511b53e8e6997835486572b648
Reviewed-on: https://chromium-review.googlesource.com/1195545
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589381}

https://pdfium.googlesource.com/pdfium.git/+log/aaff8f8b902a..1881cb7591c7


git log aaff8f8b902a..1881cb7591c7 --date=short --no-merges --format='%ad %ae %s'
2018-09-06 tsepez@chromium.org Rename CFX_GifContext::ReadData() to ReadAllOrNone()


Created with:
  gclient setdep -r src/third_party/pdfium@1881cb7591c7

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I07169aee9ed2f25833025204464f6bff8a7bb279
Reviewed-on: https://chromium-review.googlesource.com/1211869Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589380}

Bug: 881619
Change-Id: I9a7916c4391117e570b08477852c3d77c8ce0468
Reviewed-on: https://chromium-review.googlesource.com/1212086Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589379}

This change fixes an issue where FileDescriptors were being duplicated,
and as a result leaked, when writing them into a proto to send over
D-Bus

Bug: chromium:881615
Change-Id: I6e7e7abce34a537c3d9228cf9baa6d1d9074625f
Reviewed-on: https://chromium-review.googlesource.com/1211877Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589378}

This was making refactoring for https://crbug.com/879958 difficult.

Closure-compile existing unit_tests for the image_loader extension, and
delete the handcrafted unittest.html files.

Bug: 860355
Change-Id: I0d99d0383eb8fe48813d9142a14ce9af28da2dc5
Reviewed-on: https://chromium-review.googlesource.com/1207784Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589377}

This replaces the hard-coded relay bandwidth cap of 8000Kbps with
the value of maxRateKbps (if present) in the ICE config response from
the TURN server. If the value is not present, no cap is applied.

Bug: 880462
Change-Id: I0d8d2a48f78559e93cff94055a65da7ec32de494
Reviewed-on: https://chromium-review.googlesource.com/1211668Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589376}

This CL is a part of changes for 'Drag and Drop' on wayland and
extends WaylandDataDevice, WaylandDataSource and WaylandDataOffer.

WaylandDataDevice registers event listeners for 'drag and drop',
has 'StartDrag' API connected with 'wl_data_device_start_drag' and
includes reading the data from Wayland.

WaylandDataSource registers event listeners for 'drag and drop' to
handle at a source side and writes the data to the fd delivered
from Wayland when it gets 'OnSend' event.

WaylandDataOffer gets the operation decided by Wayland and requests
the offered data by Wayland.

FakeServer is also extended to support the various compositor side
functionalities needed so that tests 'drag-and-drop' in
wayland_data_device_unittest.cc run. MockDataDevice, MockDataOffer
and MockDataSource classes are extended, implementing the respective
Wayland compositor hooks to communicate with Wayland clients
(eg Ozone/Wayland).

Flow:
1) Sending dragging
'WaylandDataDevice::StartDrag' triggers the drag action to Wayland,
Wayland requests the data through 'WaylandDataSource::OnSend' and
'WaylandDataSource' listens the status through 'OnCancel' or
'OnDnDDropPerformed'.

2) Getting dragging
'WaylandDataDevice' listens drag-and-drop status such as entered/
moved/dropped/left. When the drop action is performed,
'WaylandDataDevice' reads the data using 'WaylandDataOffer'.

BUG=875164
TEST=ozone_unittests

Change-Id: Ic1ad80fce4ac396385f3ba6780839ef31d717683
Reviewed-on: https://chromium-review.googlesource.com/1176891Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#589375}

https://skia.googlesource.com/skia.git/+log/e8161dd154d7..106d04e907c1


git log e8161dd154d7..106d04e907c1 --date=short --no-merges --format='%ad %ae %s'
2018-09-06 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 108f3e10f093..a062f321768d (1 commits)
2018-09-06 brianosman@google.com Only run image tests on Windows once
2018-09-06 mtklein@google.com clean up legacy flags
2018-09-06 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 787e3d5b4cb5..108f3e10f093 (1 commits)
2018-09-06 herb@google.com Calculate numPlotsY from height
2018-09-06 mtklein@google.com clamp after color pipeline when dst is normalized
2018-09-06 mtklein@google.com add profile->profile mode to imgcvt
2018-09-06 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader ad5c2952ca88..787e3d5b4cb5 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@106d04e907c1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I9cae32607cff30f1e77d6d12245c5e5405fc0192
Reviewed-on: https://chromium-review.googlesource.com/1211868Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589374}

Previously the clip mask was painted at wrong place.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I73ffd1011ae04c7751c1efff52e63bd6186a9483
Reviewed-on: https://chromium-review.googlesource.com/1211968
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589373}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b56a43a9064c..60e7f52377fd


git log b56a43a9064c..60e7f52377fd --date=short --no-merges --format='%ad %ae %s'
2018-09-06 nodir@google.com [bot_update] Stop using revision and parent_got_revision properties
2018-09-06 nodir@google.com [gclient] Start actively using repo_path_map
2018-09-06 nodir@chromium.org Revert "bot_update: Specify the target branch for patch_refs."


Created with:
  gclient setdep -r src/third_party/depot_tools@60e7f52377fd

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:877161,chromium:877161,chromium:870279
TBR=agable@chromium.org

Change-Id: I1d94db4d53689165b9e5e39e067650f62a7918ca
Reviewed-on: https://chromium-review.googlesource.com/1211870Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589372}

 - Nested controls are removed:
 The aria attributes of buttons inside <a> links are removed,
 so they won't be read twice by a screen reader.

 - Missing aria labels are added to radio buttons.

Bug: 853996
Change-Id: I9e009425c4d6cc0c03135856135fb830d96cf989
Reviewed-on: https://chromium-review.googlesource.com/1206810
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589371}

Background fetch wasn't unregistering the provider on destruction which
is why there was a crash when trying to open download home.

Bug: 877670
Change-Id: I955a65694fb67aa8d4285a8e18ff2a37f2b220cc
Reviewed-on: https://chromium-review.googlesource.com/1211623Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589370}

Offline Pages namespaces can be configured to only allow its pages to be
presented in their original tabs. This is enforced using an undeclared
convention that pages for these namespaces will store the tab id value
in the ClientId::id field for their pages. This change makes this
convention more explicit.

Bug: 879801
Change-Id: I3ab3d871abb41d6de9112c55d8b3d8b6491c7386
Reviewed-on: https://chromium-review.googlesource.com/1200389
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589369}

DirectoryLoader contains a feature where it can fast fetch a directory based on
the start page token for the parent and the start page token that represents the
last time the directory was fetched.

Each team drive has it's own start page token, and in this case we were not
passing the team_drive_id when fetching the start page token, which means we
were getting the start page token for the users default corpus, which
effectively broke fast fetching for team drives.

The fix is to pass the team drive id to directory loader so it can then
retrieve the right start page token from resource metadata.

Patch comes with a test \o/.

Bug: 783184
Change-Id: Ic8c19efe8ea9bbffa4c97ba0a0d49f5debe2c97b
Reviewed-on: https://chromium-review.googlesource.com/1207779
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589368}

Since desktop capture has moved to using its own buffer pool implementation,
method ResurrectLastForProducer() in media::VideoCaptureBufferPool is no
longer used. This CL removes the method.

Bug: 879264
Change-Id: Ia24c683c8e63bc5b0d1bdc800e8c7d491f7c7c89
Reviewed-on: https://chromium-review.googlesource.com/1208952Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589367}

This patch allows updateWith() take shippingAddressErrors parameter.

Test: chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

Bug: 861704
Change-Id: I6c67e0c6c8fbd56d389ab279a1bc7816983a6b65
Reviewed-on: https://chromium-review.googlesource.com/1201625Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#589366}

In AppCacheStorageImpl::StoreGroupAndCacheTask::Run(), it has not checked
whether new appcache usage exceeds the maximium cache size. This CL adds
the check condition to AppCacheStorageImpl::StoreGroupAndCacheTask::Run().

Bug: 824619
Change-Id: Ic289f69cebcc60f06fc852072e9c50af831b8737
Reviewed-on: https://chromium-review.googlesource.com/1203752Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#589365}

This CL adds detection of cached DRP responses for the purpose of making
different previews types (with different cache affinities) easier to
compare.

A follow-up will add whether the main frame response was cached or not
to the PLM pingback proto.

Bug: 880655
Change-Id: I1591d2f10823514648bb05bd0d26cb7ae97a7244
Reviewed-on: https://chromium-review.googlesource.com/1208938
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589364}

Bug: 879020
Change-Id: I17b124d79daf101778395b235ec503fcb9179ea5
Reviewed-on: https://chromium-review.googlesource.com/1211738Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589363}

Adds 5 new histograms:
* Previews.ServerLitePage.BlacklistReason - tracks blacklist usage
* Previews.ServerLitePage.FallbackPenalty - the amount of time spent on
  loading a fallback
* Previews.ServerLitePage.IneligibleReason - the reason a preview wasn't
  triggered
* Previews.ServerLitePage.ServerResponse - the response type of the
  previews server
* Previews.ServerLitePage.Triggered - whether or not the preview was
  triggered

Also fixes the subframe test case which was broken.

Bug: 864635
Change-Id: If61cbc65a272091172937dfa0d4833bf9ccb1f47
Reviewed-on: https://chromium-review.googlesource.com/1200074
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589362}

DataReductionProxyIOData historically added previews_decider_ member to
support AMP redirection, but this is not longer used.

Bug: 842233
Change-Id: If4b5a9a9a7c259fc0552de20a15e4d723a52e773
Reviewed-on: https://chromium-review.googlesource.com/1211842Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589361}

R=cmasso@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2f51a21a62b3de4a12b8a0af0f5d7bac44d71046
Reviewed-on: https://chromium-review.googlesource.com/1211914Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589360}

On Mac, tab fullscreen mode doesn't show top UI while browser fullscreen
mode may show top UI depending on user's preference. When Chrome exits
from tab fullscreen, it needs to reset the top UI style to the one
corresponding to browser fullscreen. In addition, if it exits from tab
fullscreen to browser fullscreen, a re-layout may be triggered if top
UI needs to be shown.

This CL fixes the problem by calling UpdateUIForTabFullscreen() when
Chrome exits tab fullscreen, no matter it is going back to browser
fullscreen mode or normal state. So it can update the top UI status
correctly.

This CL also adds reading initial toolbar style value from user
preference.

BUG=879158

Change-Id: I3f2742cad2107667c562701a981f3240f29538bf
Reviewed-on: https://chromium-review.googlesource.com/1208721Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589359}

This makes sure that if the user types in a property exactly, it will
always be the default selected suggested item.

Bug: 879351
Change-Id: I4425e105ff9381e164b3455f5e727c28e3b2d931
Reviewed-on: https://chromium-review.googlesource.com/1211862
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589358}

This CL updates the behavior of fullscreen such that the toolbars will
be re-shown when the user starts a scroll past the bottom of a page
when the toolbars are completely collapsed.

Bug: 841094
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9e2cb3a59e931f83bb43e8a68df48a80bb6d0c3b
Reviewed-on: https://chromium-review.googlesource.com/1200563
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589357}

Previously, if we save a card twice in a row, the second time the animation needs to be shown, it would just show static text. The animation continues to glitch for each subsequent use.
Now the animation works properly each time it is invoked.

This also applies to the pop-up blocker's "Pop-up blocked" text animation.

Bug: 855186,881324,881320
Change-Id: Ie6f8a53a24d5ec4dd06b9ead27b784fc46a26310
Reviewed-on: https://chromium-review.googlesource.com/1208140Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#589356}

Register and download the demo mode resources CrOS component during
online demo mode setup. This happens before online enrollment starts.

Also updates offline-enrolled Demo Mode to always use the offline
resources image instead of attempting to download the CrOS component.

Bug: 869455
Change-Id: I6a947eab916f68bba4730a9ab611136be7fe1bc1
Reviewed-on: https://chromium-review.googlesource.com/1198018
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589355}

Using wpt-import in Chromium a3895348.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24196

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Ib75a8ff8ee0a7f3bf3011ab31088fddcb4d37144
Reviewed-on: https://chromium-review.googlesource.com/1211843
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589354}

Clear the |*base|-address out-parameter to null in case of blocking, to
ensure that calling-code won't get confused by seeing a failure NTSTATUS
with a non-null base-address.  e.g. Win32's MapViewOfFile() returns the
base-pointer as its result, using null to indicate failure, and leaves
the Win32 GetLastError() set based on the NTSTATUS.

Bug: 864351, 870663
Change-Id: I0aa2aacd1075224100d10d6291a416849f6d227b
Reviewed-on: https://chromium-review.googlesource.com/1211322Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589353}

This reverts commit 0c9c754f.

Reason for revert: Underlying issue (crbug.com/880203) is fixed.

Original change's description:
> Mark InterstitialPageTest#testCloseInterstitial as flaky
> 
> Bug: 879757
> 
> Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24
> 
> TBR=boliu@chromium.org
> 
> Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24
> Reviewed-on: https://chromium-review.googlesource.com/1200165
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588214}

TBR=boliu@chromium.org,oksamyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 879757
Change-Id: I6c31bda83ad0a72c76fcb4054b14343478f7683f
Reviewed-on: https://chromium-review.googlesource.com/1211960Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589352}

Bug: 870903, 866839
Change-Id: I9747dfdb7c682c86c3aae201db7e74faa126aaf8
Reviewed-on: https://chromium-review.googlesource.com/1184314Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589351}

This CL fixed the CastRemotingConnector to support OffscreenTab
mirroring/remoting using Mirroring Service. However, when Mirroring
service is not used, remoting an OffscreenTab is still not supported.

Bug: 734672
Change-Id: I09aab2d76be9d1b466d5c54a3d5eb66c7a6ff83f
Reviewed-on: https://chromium-review.googlesource.com/1200321
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589350}

Add comments explaining different results for NetworkContextTest.ProxyErrorClientNotifiedOfPacError on iOS.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iee8707645813ad7af92f7a4e84403ccacc22abd0
Reviewed-on: https://chromium-review.googlesource.com/1208932
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589349}

Adds screen brightness mojo methods to assistant device API.  Generalizes
volume action methods to handle slider actions.

BUG:b/78189672
BUG:b/111130167

Change-Id: I5a8759478ec6ecef5b950839d644bca11cd88bbc
Reviewed-on: https://chromium-review.googlesource.com/1194984
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589348}

BUG=chromium:879737
TEST=This is a test case.

Change-Id: I57c11e9ad663081ec6ee56b5dd4afa58db470384
Reviewed-on: https://chromium-review.googlesource.com/1211113Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589347}

https://pdfium.googlesource.com/pdfium.git/+log/59d21660a3d9..aaff8f8b902a


git log 59d21660a3d9..aaff8f8b902a --date=short --no-merges --format='%ad %ae %s'
2018-09-06 hnakashima@chromium.org Discard deps that are not sync'ed anymore in safetynet_compare.py.


Created with:
  gclient setdep -r src/third_party/pdfium@aaff8f8b902a

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id9422dca4b077437ff7f7672fa01d7f3ab401435
Reviewed-on: https://chromium-review.googlesource.com/1211865Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589346}