GitLab

This silences a line of log spew that's generated on every launch of a local
debug build.

BUG=none
TEST=less log spew
R=rsesek@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/333493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276787 0039d316-1c4b-4281-b951-d872f2087c98

converted to use the new ActionRunner API.

BUG=361809

Review URL: https://codereview.chromium.org/321253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276786 0039d316-1c4b-4281-b951-d872f2087c98

We used to always recorded with LCD ON and if needed disabled it with an
SkFilter during rasterization. This is wasteful on platforms where LCD
text is always disabled. This patch records SkPicture with correct
setting. One downside to this approach is that we would need to
invalidate and record anytime the LCD text setting changes. But since
this can only happen once for a layer (all future changes are ignored),
this is not going to be a big performance issue.

On the positive side, this patch will simplify a lot of things on the
rasterization front - no SkDrawFilter, or LCD text tile versions, or
a special rasterization mode for disable LCD.

BUG=368513

Review URL: https://codereview.chromium.org/315393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276785 0039d316-1c4b-4281-b951-d872f2087c98

Appears to have broken
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/5246

  src/tools/android/adb_profile_chrome/main.py: Has executable bit but
  not shebang or ELF header.

Please add the shebang and reland. Sorry for the inconvenience.

> Move adb_profile_chrome under tools/android/
>
> Move adb_profile_chrome from build/android/ to tools/android/ to make
> its purpose clearer.
>
> BUG=375754
> TEST=tools/android/adb_profile_chrome/run_tests
>
> Review URL: https://codereview.chromium.org/310413003

TBR=skyostil@chromium.org

Review URL: https://codereview.chromium.org/330713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276784 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/328383003/)

Reason for revert:
browser_tests failures were caused by another CL:
http://src.chromium.org/viewvc/chrome?revision=276656&view=revision

This build which included revert of 276656 is green.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30917

Reverting revert.

Original issue's description:
> Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/318853004/)
> 
> Reason for revert:
> Appears to have broken the kiosk and auth browser tests in http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30916
> 
> Original issue's description:
> > Introduce SessionManager that will contain code to start user session on Chrome OS
> > 
> > Move profile creation / session initialization (prefs/RLZ) as well as some of OAuth session init
> > related code from LoginUtils to SessionManager. LoginUtils will temporarily implement
> > SessionManager::Delegate interface till existing test coverage is migrated from LoginUtils interface.
> > SessionManager will later use concept of UserSession (see design proposal at http://goto/cros-login-c14n).
> > 
> > LoginUtils::OnPrepareProfile() is split into
> > StartSession()
> > --PreStartSession() - things like switching logging dest
> > --CreateUserSession() - will eventually create UserSession instance
> > --StartCrosSession() - notify cros::SessionManager
> > --NotifyUserLoggedIn() - UserManager::UserLoggedIn()
> > --PrepareProfile()
> > 
> > PrepareProfile() - calls PM::CreateProfileAsync()
> > --OnProfileCreated()
> > ----InitProfilePreferences() - early initialization
> > ----UserProfileInitialized()
> > ------transfer signin profile auth date (cookies/proxy auth/certs)
> > ------RestoreAuthSessionImpl() - OAuth2LoginManager::RestoreSession()
> > ----FinalizePrepareProfile(()
> > ------Own TPM (if it didn't happen for some reason)
> > ------Notify SAML offline signin limiter
> > ------Notify ProfileImpl
> > ------chrome::NOTIFICATION_LOGIN_USER_PROFILE_PREPARED
> > ------InitRLZ (for primary user)
> >   
> > 
> > Minor cleanup
> > * Unify DemoApp profile initialization flow with regular one
> > * Don't pass display_email to LoginUtils::PrepareProfile
> > * Move powerwash related prefs registration to ResetScreenHandler
> > * Cleanup M31 migration code for |prefs::kProfileIsManaged| in LoginUtilsImpl::InitProfilePreferences()
> > 
> > BUG=370175,276163
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276626
> 
> TBR=antrim@chromium.org,bauerb@chromium.org,nkostylev@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=370175,276163
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276760

TBR=antrim@chromium.org,bauerb@chromium.org,rouslan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370175,276163

Review URL: https://codereview.chromium.org/333773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276783 0039d316-1c4b-4281-b951-d872f2087c98

The original change contained a use-after-free bug. This was caused by window crossfade animation during maximizing, combined with input event processing. The crossfade would take the current layer and delete it. However the next input event to the window tree would attempt to access the now deleted layer.

Original Code Review: https://codereview.chromium.org/271913002/
Revert Review: https://codereview.chromium.org/309973002/

Revert "Revert of Animate window control changes in TouchView (https://codereview.chromium.org/271913002/)"
This reverts commit 8863218a.

TBR=jamescook@chromium.org
TEST=FrameCaptionButtonContainerViewTest.AnimationUpdatesLayerTree
BUG=363717

Review URL: https://codereview.chromium.org/316693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276782 0039d316-1c4b-4281-b951-d872f2087c98

When a touch-move event is 'held', i.e. it is not dispatched, the event does
produce any gesture events. However, once this 'held' event is dispatched
(either because a touch-release event was encountered, or because
ReleasePointerMoves() was called on the dispatcher), it should be used to
generate the appropriate gesture events.

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/332703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276781 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/337543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276780 0039d316-1c4b-4281-b951-d872f2087c98

    
Move adb_profile_chrome from build/android/ to tools/android/ to make
its purpose clearer.
    
BUG=375754
TEST=tools/android/adb_profile_chrome/run_tests

Review URL: https://codereview.chromium.org/310413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276779 0039d316-1c4b-4281-b951-d872f2087c98

BUG=45650
TEST=none
NOTRY=true

Review URL: https://codereview.chromium.org/336613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276778 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383272

Review URL: https://codereview.chromium.org/329073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276777 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true
R=msw

Review URL: https://codereview.chromium.org/324983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276776 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328382

Review URL: https://codereview.chromium.org/319703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276775 0039d316-1c4b-4281-b951-d872f2087c98

Still not hooked up and not quite everything compiles but this should be the bulk of the functionality.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/328313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276774 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/336633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276773 0039d316-1c4b-4281-b951-d872f2087c98

This is forked off of https://codereview.chromium.org/266613002 The code to compile yasm itself is mostly from that patch, with a few updates for the other changes.

Adds a template for running compiled binaries. Compared to Albert's patch above, this assumes the binary is generated by the source tree so can have a cleaner interface (just specify the label of the tool you use).

The yasm rule is new compared to Albert's patch. It uses a special wrapper script instead of the new compiled_action templates so it can properly support depfiles. This also adds convenient support for defines and include dirs.

This adds some trivial ios changes to the content/public/browser. This should be a NOP now.

Fixes a bug in GN depfile creation. Previously, the .d file was emitted as an output of the script, but this confuses ninja. This change just removes that.

BUG=
R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/321323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276772 0039d316-1c4b-4281-b951-d872f2087c98

Previously, when a user blacklisted an iPhoto/iTunes library, there was no way to get it back without editing the preferences file by hand.

Now, when a user adds a directory under the iPhoto/iTunes library directory, it adds back the device library.

BUG=375503
TEST=manual tested iTunes on Win

Review URL: https://codereview.chromium.org/329643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276771 0039d316-1c4b-4281-b951-d872f2087c98

Unit test for the fix submitted with https://codereview.chromium.org/316553007

BUG=375921

Review URL: https://codereview.chromium.org/316403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276770 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378549

Review URL: https://codereview.chromium.org/329833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276769 0039d316-1c4b-4281-b951-d872f2087c98

Note that this doesn't apply to roots. If an app is embedded and its root node is reordered, there is no notification to the app. I figure this is up to the window manager to expose an API for this type of thing.

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/327073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276768 0039d316-1c4b-4281-b951-d872f2087c98

R=rouslan@chromium.org
TBR=rouslan@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=383975

Review URL: https://codereview.chromium.org/327323011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276767 0039d316-1c4b-4281-b951-d872f2087c98

TBR=antrim@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/337573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276766 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Introduce SessionManager that will contain code to start user session on Chrome OS (https://codereview.chromium.org/318853004/)

Reason for revert:
Appears to have broken the kiosk and auth browser tests in http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30916

Original issue's description:
> Introduce SessionManager that will contain code to start user session on Chrome OS
> 
> Move profile creation / session initialization (prefs/RLZ) as well as some of OAuth session init
> related code from LoginUtils to SessionManager. LoginUtils will temporarily implement
> SessionManager::Delegate interface till existing test coverage is migrated from LoginUtils interface.
> SessionManager will later use concept of UserSession (see design proposal at http://goto/cros-login-c14n).
> 
> LoginUtils::OnPrepareProfile() is split into
> StartSession()
> --PreStartSession() - things like switching logging dest
> --CreateUserSession() - will eventually create UserSession instance
> --StartCrosSession() - notify cros::SessionManager
> --NotifyUserLoggedIn() - UserManager::UserLoggedIn()
> --PrepareProfile()
> 
> PrepareProfile() - calls PM::CreateProfileAsync()
> --OnProfileCreated()
> ----InitProfilePreferences() - early initialization
> ----UserProfileInitialized()
> ------transfer signin profile auth date (cookies/proxy auth/certs)
> ------RestoreAuthSessionImpl() - OAuth2LoginManager::RestoreSession()
> ----FinalizePrepareProfile(()
> ------Own TPM (if it didn't happen for some reason)
> ------Notify SAML offline signin limiter
> ------Notify ProfileImpl
> ------chrome::NOTIFICATION_LOGIN_USER_PROFILE_PREPARED
> ------InitRLZ (for primary user)
>   
> 
> Minor cleanup
> * Unify DemoApp profile initialization flow with regular one
> * Don't pass display_email to LoginUtils::PrepareProfile
> * Move powerwash related prefs registration to ResetScreenHandler
> * Cleanup M31 migration code for |prefs::kProfileIsManaged| in LoginUtilsImpl::InitProfilePreferences()
> 
> BUG=370175,276163
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276626

TBR=antrim@chromium.org,bauerb@chromium.org,nkostylev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370175,276163

Review URL: https://codereview.chromium.org/328383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276760 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276759 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13310: (dyen) Commands for toolchain_build are now filtered before invoking anything.
r13311: (dyen) Fix for needing to push to ssh URL for toolchain_build sources.
r13312: (mcgrathr) Disable seccomp-bpf tests under ASan
r13313: (mcgrathr) Disable LSan (leak detection) in ASan tests
r13314: (mseaborn) Enable the -Wstrict-prototypes warning for untrusted code in the Gyp build
r13315: (dyen) Python logging now organized to use loggers instead of global variables.
r13316: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13317: (jfb) Update revision for PNaCl r13281->r13311
r13318: (jfb) Update revision for PNaCl r13311->r13316
r13319: (mcgrathr) Fix leaks in gio tests
r13320: (mcgrathr) Fix leak of SRPC string argument template buffers
r13321: (dyen) Make sure git cache dir is not referenced directly in case of cygwin.
r13322: (noelallen) Roll bionic
r13323: (mcgrathr) Don't close stderr in ncval_stubout
r13324: (jvoung) Change torture_test.py to use toolchain_build/src instead of pnacl/git.
r13325: (mcgrathr) Use LC_ALL=C rather than LANG=en_US.UTF-8 in build_nexe.py
r13326: (mcgrathr) meaningless change to kick bots
r13327: (petarj) [MIPS] Accept SIGTRAP from __builtin_trap
r13328: (mseaborn) Untrusted Gyp build: Apply -Wstrict-prototypes to NaCl-side code only

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/333503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276758 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg@chromium.org
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/334713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276757 0039d316-1c4b-4281-b951-d872f2087c98

This is the first half of the work to disambiguate the message center
notifications originated from different profiles.
It clarifies the semantics of message center as the backend of
notification by:

1) Adding comments on the usage of id in the MessageCenter interface.
2) Adding a FindVisibleNotificationById(id) method to message center
interface so users can directly find backend notifications without
going to the notification ui manager interface.
3) Removing the redundant HasNotification() method since the
FindVisibleNotificationById() can server the same purpose. 

Reviewers:
* davemoore: please review chrome/browser/chromeos/*
* jamescook: please review ash/*

TBR=davemoore@chromium.org
BUG=297867

Review URL: https://codereview.chromium.org/324583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276756 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/330653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276755 0039d316-1c4b-4281-b951-d872f2087c98

The behavior once invoked by the
SkPicture::kUsePathBoundsForClip_RecordingFlag is now
 the default so this flag is going away.
Skia 9f1c241e 
(Remove SkPicture::kUsePathBoundsForClip_RecordingFlag -
 https://codereview.chromium.org/316143003/)

cc: enne@
skia: fmalita@

Review URL: https://codereview.chromium.org/322123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276754 0039d316-1c4b-4281-b951-d872f2087c98

cc side of change.

TBR=phajdan.jr@chromium.org
BUG=382738

Review URL: https://codereview.chromium.org/326283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=covered
R=asvitkine@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/325423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276752 0039d316-1c4b-4281-b951-d872f2087c98

This provides the Service Worker for the implementation of navigator.serviceWorker.waiting in Blink. This will be covered by subsequent layout tests in Blink.

BUG=379012

Review URL: https://codereview.chromium.org/317953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276751 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276750 0039d316-1c4b-4281-b951-d872f2087c98

R=niklase@chromium.org

Review URL: https://codereview.chromium.org/329773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276749 0039d316-1c4b-4281-b951-d872f2087c98

Particularly the '\\' in fileline_prefix would need to be '\\\\' in a
normal (non-raw) python string.

NOTRY=true

Review URL: https://codereview.chromium.org/330573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276748 0039d316-1c4b-4281-b951-d872f2087c98

content_browsertests with Dr.Memory MFYI bot

TBR=thestig@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/337553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276747 0039d316-1c4b-4281-b951-d872f2087c98

This will be used on Clusterfuzz, and we might ship this on the Canary sometimes if the performances are reasonable.

BUG=

Review URL: https://codereview.chromium.org/321303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276746 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/324823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276745 0039d316-1c4b-4281-b951-d872f2087c98

Missing header include would result in symbols being defined locally
only.

TBR=spang@chromium.org
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/335663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276744 0039d316-1c4b-4281-b951-d872f2087c98

> Turn FaviconClient into a Keyed service.
> 
> This is an intermediary CL.
> The end goal is having the FaviconServiceFactory be able to obtain a FaviconClient to pass it to the FaviconService's constructor.
> 
> BUG=377505
> 
> Review URL: https://codereview.chromium.org/301613004

TBR=jif@chromium.org
BUG=383952

Review URL: https://codereview.chromium.org/334613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276743 0039d316-1c4b-4281-b951-d872f2087c98