GitLab

Review URL: https://codereview.chromium.org/469203002

git-svn-id: svn://svn.chromium.org/blink/trunk@180373 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rename CollectionIndexCache API to not use 'Element':
- traverseToFirstElement() -> traverseToFirst()
- traverseToLastElement() -> traverseToLast()

Using Element is confusing because some CollectionIndexCache users like
ChildNodeList deal with pure Nodes. The Node type is a template parameter
of the CollectionIndexCache class so the API should be seem to be Element
specific.

R=rob.buis@samsung.com

Review URL: https://codereview.chromium.org/469913002

git-svn-id: svn://svn.chromium.org/blink/trunk@180371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/479563002

git-svn-id: svn://svn.chromium.org/blink/trunk@180370 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in RadioNodeList::elementMatches() to give C++11 compilers
a chance to devirtualize the call to HTMLImageElement::formOwner().

R=adamk@chromium.org

Review URL: https://codereview.chromium.org/475613003

git-svn-id: svn://svn.chromium.org/blink/trunk@180369 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use an AtomicString as key in DocumentOrderedMap instead of a StringImpl*.
This is safer as the HashMap Traits rely on the StringImpl* to not be a
dangling pointer (it is calling StringImpl::hash()). Using an AtomicString
as key will make sure we don't experience use-after-free such as in Bug
402255.

I ran Bindings/get-element-by-id.html test and did not see any performance
regression.

R=esprehn@chromium.org, morrita@chromium.org
BUG=402255

Review URL: https://codereview.chromium.org/467973003

git-svn-id: svn://svn.chromium.org/blink/trunk@180365 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The SVG instance tree was recently removed which also removed most of the gnarly event handling in SVG. Now we can support SVG also in event.path.

BUG=402721

Review URL: https://codereview.chromium.org/477883003

git-svn-id: svn://svn.chromium.org/blink/trunk@180364 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduce HasHTMLTagName functor and use it with ElementTraversal to simplify
the code a bit.

R=adamk@chromium.org

Review URL: https://codereview.chromium.org/471173003

git-svn-id: svn://svn.chromium.org/blink/trunk@180363 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now documentation context menu item appears without token selection.

BUG=391593

Review URL: https://codereview.chromium.org/471583003

git-svn-id: svn://svn.chromium.org/blink/trunk@180362 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When using a "pixel-moving" filter (ie., drop-shadow or blur), we
disable the normal clip operation, since we want to want to render
the full results of the element pre-clip for filtering. Clipping is
then applied just before drawing the filtered result.

However, we shouldn't disable *all* clipping recursively, since we
want children which clip themselves to still continue to be clipped.
The fix is to pass the original (unmodified) paintingInfo to
paintChildren().

BUG=350411

Review URL: https://codereview.chromium.org/476953003

git-svn-id: svn://svn.chromium.org/blink/trunk@180361 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this CL, we use bool flags to indicate which value should be
returned. We can use Nullable<T> instead.

Review URL: https://codereview.chromium.org/466323002

git-svn-id: svn://svn.chromium.org/blink/trunk@180360 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves insert style rule button further to the left to not overlap with scrollbar. It also fixes its width.

As a drive-by, this patch sets "translateZ" rule hack on styles sidebar pane as a workaround for compositor bug. This makes scrollbar appear on MB Air.

BUG=404102
R=pfeldman

Review URL: https://codereview.chromium.org/477113002

git-svn-id: svn://svn.chromium.org/blink/trunk@180359 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/477913002

git-svn-id: svn://svn.chromium.org/blink/trunk@180358 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With the shutdown crashes involving InjectedScriptManager::CallbackData
having been addressed, remove some crash test expectations.

R=ager@chromium.org
BUG=398472
NOTRY=true

Review URL: https://codereview.chromium.org/478643002

git-svn-id: svn://svn.chromium.org/blink/trunk@180357 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The blob: scheme is not handled by ParsedURL, so it is
impossible to compute the human-readable worker name
for them using the common scheme.

R=pfeldman, vsevik
BUG=404098
NOTRY=true

Review URL: https://codereview.chromium.org/471413002

git-svn-id: svn://svn.chromium.org/blink/trunk@180356 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, importScript function gets scripts to load which contain "../"
in their path. These are written in their sourceURL's, but they should
be actually normalized to match network resource.

R=vsevik, apavlov, pfeldman

Review URL: https://codereview.chromium.org/475073002

git-svn-id: svn://svn.chromium.org/blink/trunk@180355 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ServiceWorkerContainer.unregister() is going away but the change will be
done in steps. This patch updates some select tests focused on
unregistration to use the new unregister() function.

BUG=404064

Review URL: https://codereview.chromium.org/474193002

git-svn-id: svn://svn.chromium.org/blink/trunk@180354 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dgozman

Review URL: https://codereview.chromium.org/472273002

git-svn-id: svn://svn.chromium.org/blink/trunk@180353 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of listening to particular model notifications it is enough to listen for profiling lock changes.

BUG=403684
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/471013002

git-svn-id: svn://svn.chromium.org/blink/trunk@180352 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should pause any actions that could affect performance if any of the targets is being profiled, not only current target.

Compared to r180336 profiling lock is now initialized in Locks.js

BUG=403684
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/472263002

git-svn-id: svn://svn.chromium.org/blink/trunk@180351 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Timeline extension API is removed from DevTools front-end.

BUG=403684
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/477103002

git-svn-id: svn://svn.chromium.org/blink/trunk@180350 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=403684,398785
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/476773002

git-svn-id: svn://svn.chromium.org/blink/trunk@180349 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To achieve the specified goal, the patch does the following:
- StylePropertiesSection.styleRule no longer has sourceURL as it could
be always fetched from styleRule.rule
- StylePropertiesSection._createRuleOrigin is receiving CSSRule and
ruleLocation as arguments
- BlankStylePropertiesSection is taught to infer the actual rule
location of the rule that will be inserted

Layout Test change: the CSSOM rule now don't show source location (used to be "located" on first line)

R=pfeldman, vsevik, apavlov

Review URL: https://codereview.chromium.org/474433004

git-svn-id: svn://svn.chromium.org/blink/trunk@180348 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The parsing logic for clip-path and filter is identical to that for
marker-start, etc.

BUG=404023

Review URL: https://codereview.chromium.org/475303002

git-svn-id: svn://svn.chromium.org/blink/trunk@180346 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=404091
NOTRY=true

Review URL: https://codereview.chromium.org/468223005

git-svn-id: svn://svn.chromium.org/blink/trunk@180345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch synchronizes diverged pseudoId names in Style Sidebar Pane
with RenderStyleConstants.h. Ideally, they should be generated, but so
far we don't have a solution for this.

BUG=380644
R=apavlov

Review URL: https://codereview.chromium.org/476803002

git-svn-id: svn://svn.chromium.org/blink/trunk@180344 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The codemirror got frozen because selection from its
input text area was stolen via "add new property" editing functionality.

BUG=402838
R=apavlov, vsevik

Review URL: https://codereview.chromium.org/476893002

git-svn-id: svn://svn.chromium.org/blink/trunk@180343 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Make profiling lock global rather than per Target (patchset #2 of https://codereview.chromium.org/475803002/)

Reason for revert:
'common' should not be aware of profiler.

Original issue's description:
> Make profiling lock global rather than per Target
> 
> We should pause any actions that could affect performance if any of the targets is being profiled, not only current target.
> 
> BUG=403684
> R=sergeyv@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180336

TBR=sergeyv@chromium.org,apavlov@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403684

Review URL: https://codereview.chromium.org/471393002

git-svn-id: svn://svn.chromium.org/blink/trunk@180342 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We show a console message if:
 - An invalid string is set to 'value' IDL attribute.
 - An invalid string is set to 'value' content attribute.
 - 'date' is set to 'type' attribute and existing 'value' content attribute is
   invalid.
 - 'date' is set to 'type' attribute and existing user-specified value is
   invalid.

BUG=397952
TEST=Update expectations of automated tests.

Review URL: https://codereview.chromium.org/461323006

git-svn-id: svn://svn.chromium.org/blink/trunk@180341 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are crashing on layout tests in the oilpan build. The reason is
that with oilpan these are just raw pointers and are therefore not
default initialized to null.

R=haraken@chromium.org, oilpan-reviews@chromium.org, timloh@chromium.org

Review URL: https://codereview.chromium.org/473163002

git-svn-id: svn://svn.chromium.org/blink/trunk@180340 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently there is a bug on V8 APIs on Message objects, and they don't return valid values
when they are called at the first time if V8 has a pending exception.
We need to call twice in order to get valid values.

This is a temporary fix in the Blink side until we fix the V8 side.

BUG=341031

Review URL: https://codereview.chromium.org/478623002

git-svn-id: svn://svn.chromium.org/blink/trunk@180339 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is probably already true in the code base (we mostly require 2.7
for everything except for some things in ChromiumOS), so this is just
cleanup.

I also fixed a few other nits while touching everything (sorting imports,
fixing shebangs and file permissions).

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/478553002

git-svn-id: svn://svn.chromium.org/blink/trunk@180338 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- WebLocalFrameImpl::initializeWebCoreFrame
- WebLocalFrameImpl::setWebCoreFrame
- WebRemoteFrameImpl::initializeCoreFrame
- WebRemoteFrameImpl::setWebCoreFrame
- WebViewImpl::focusedCoreFrame
- toWebCoreFrame
- updateWebMouseEventFromWebCoreMouseEvent

BUG=none
TEST=none; no behavior changes.

Review URL: https://codereview.chromium.org/474143002

git-svn-id: svn://svn.chromium.org/blink/trunk@180337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should pause any actions that could affect performance if any of the targets is being profiled, not only current target.

BUG=403684
R=sergeyv@chromium.org

Review URL: https://codereview.chromium.org/475803002

git-svn-id: svn://svn.chromium.org/blink/trunk@180336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a part object has a virtual trace method we need to check the vtable
before calling the trace method. This is necessary because conservative
GCs can see the part object before it has been constructed (if there
is an allocation during the construction of the containing object.)

Added simple regression test that illustrates the issue.

R=erik.corry@gmail.com, zerny@chromium.org

Review URL: https://codereview.chromium.org/455363002

git-svn-id: svn://svn.chromium.org/blink/trunk@180335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CSS_PARSER_INTEGER is only used as an alias for CSS_NUMBER, and the
enums CSS_PARSER_OPERATOR and CSS_PARSER_IDENTIFIER are both unused.

Review URL: https://codereview.chromium.org/476693002

git-svn-id: svn://svn.chromium.org/blink/trunk@180334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just a clean-up of idl_reader.py.

BUG=341031

Review URL: https://codereview.chromium.org/469253004

git-svn-id: svn://svn.chromium.org/blink/trunk@180333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add an assertion to make sure NodeRenderingTraversal::parent is not called with a dirty distribution result.

Review URL: https://codereview.chromium.org/448893003

git-svn-id: svn://svn.chromium.org/blink/trunk@180332 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The value minRepetitions is actually used as an upper bound. Looks like
this was a misunderstanding of a review comment in
https://codereview.chromium.org/251643002.

BUG=404023

Review URL: https://codereview.chromium.org/479493002

git-svn-id: svn://svn.chromium.org/blink/trunk@180331 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we have the following two flags:

- m_didCallDispose is used to know whether AudioContext::dispose() is called or not.
- m_isMarkedForDeletion is used to guarantee the following facts:

--- AudioNode should not be re-registered to AudioNode::m_outputs after AudioNode::dispose is called.
--- AudioNode should not get marked as dirty after AudoNode::dispose is called.

We don't need the two flags; just one flag that is set in AudioContext::dispose() is enough.

This CL removes m_didCallDispose and m_isMarkedForDeletion and introduces m_isDisposeCalled. This CL doesn't change any behavior.

BUG=340522

Review URL: https://codereview.chromium.org/460303003

git-svn-id: svn://svn.chromium.org/blink/trunk@180330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Add lextab.pyc as an output of the cached_lex_yacc_tables action (patchset #1 of https://codereview.chromium.org/463063003/)

Reason for revert:
This CL added the assumption that Python will write the lextab.pyc file. If that's a wrong assumption, which seems to be the case in some situations, the result is that the cached_lex_yacc_tables target never becomes clean, which in turn means that all IDL files are recompiled on each build.

The problem fixed by this CL was cosmetic only, so is not worth the risk.

Original issue's description:
> Add lextab.pyc as an output of the cached_lex_yacc_tables action
> 
> The primary output is lextab.py, but since it is imported, Python also
> writes lextab.pyc. Listing it too as an output means it won't be left
> around by "ninja -t clean" (and not much else, I think.)
> 
> Prior to the patch
>   https://codereview.chromium.org/425953002/
> the result of not having lextab.pyc listed as an output and running
> "ninja -t clean" was a tree that would build correctly, but that would
> always rerun all the IDL code generation scripts, and thus never become
> "clean".
> 
> BUG=397909
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180142

TBR=haraken@chromium.org,nbarth@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397909

Review URL: https://codereview.chromium.org/468743003

git-svn-id: svn://svn.chromium.org/blink/trunk@180329 bbb929c8-8fbe-4397-9dbb-9b2b20218538