GitLab

BUG=451624
R=raymes@chromium.org

Review URL: https://codereview.chromium.org/874703003

Cr-Commit-Position: refs/heads/master@{#313355}

Cherry-pick potential divide-by-zero fix
https://codereview.chromium.org/877783004

This also removes the last remnants of the AVX attempts:
https://codereview.chromium.org/873313005
It should have been a no-op since it only changes cpu detection. The functions
themselves have been disabled and are not compiled so this is the last remaining
related change.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_vista_rel_ng

R=tomfinegan@chromium.org
BUG=396572

Review URL: https://codereview.chromium.org/877123002

Cr-Commit-Position: refs/heads/master@{#313354}

The test fails or times out.

NOTRY=True
TBR=phoglund@chromium.org
BUG=452623

Review URL: https://codereview.chromium.org/882713003

Cr-Commit-Position: refs/heads/master@{#313353}

R=lcwu@chromium.org,servolk@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/878843004

Cr-Commit-Position: refs/heads/master@{#313352}

This adds a Finch trial that can enable and disable bubbles as needed.
The flags will still override the Finch trial.

BUG=364686
TEST=
Visit https://adrifelt.github.io/bubble-demo.html and check to see if
you get a permission bubbles or an infobar, depending on the setting:
1. Infobar: set chrome://flags/#enable-permissions-bubbles to 'Disabled'
2. Bubble: set chrome://flags/#enable-permissions-bubbles to 'Enabled'
3. Infobar: set chrome://flags/#enable-permissions-bubbles to 'Default'
4. Infobar: --force-fieldtrials=PermissionBubbleRollout/Disabled/
5. Bubble: --force-fieldtrials=PermissionBubbleRollout/Enabled/

Review URL: https://codereview.chromium.org/791033004

Cr-Commit-Position: refs/heads/master@{#313351}

BUG=none

Review URL: https://codereview.chromium.org/873643002

Cr-Commit-Position: refs/heads/master@{#313350}

This patch adds conversion rule for aria-grabbed attribute and
exposes it only when it's defined.

The related patch is
https://codereview.chromium.org/736943002/

BUG=98817

Review URL: https://codereview.chromium.org/736023002

Cr-Commit-Position: refs/heads/master@{#313349}

R=mbarbella@chromium.org, tsepez@chromium.org
BUG=450268

Review URL: https://codereview.chromium.org/881883002

Cr-Commit-Position: refs/heads/master@{#313348}

BUG=451173
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/880603002

Cr-Commit-Position: refs/heads/master@{#313347}

Revert of [Chromoting] Enable AppRemoting sample apps by default in all.gyp. (patchset #4 id:60001 of https://codereview.chromium.org/878793003/)

Reason for revert:
Broke the official builders:
Traceback (most recent call last):
  File "../remoting/webapp/build-webapp.py", line 413, in <module>
    sys.exit(main())
  File "../remoting/webapp/build-webapp.py", line 409, in main
    service_environment)
  File "../remoting/webapp/build-webapp.py", line 198, in buildWebApp
    + buildtype + ': ' + service_environment)
Exception: Invalid service_environment targeted for Official: dev
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/55334/steps/compile/logs/stdio#error1

Original issue's description:
> [Chromoting] Enable AppRemoting sample apps by default in all.gyp.
>
> Where "by default" = whenever we build Chromoting.
>
> BUG=
>
> Committed: https://crrev.com/e0bf65f1e2fcd3515b92c1b49f04aa30fd0d47e6
> Cr-Commit-Position: refs/heads/master@{#313324}

TBR=scottmg@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/880083002

Cr-Commit-Position: refs/heads/master@{#313346}

Revert of Plumb allow_overlay flag for video path into cc (patchset #3 id:80001 of https://codereview.chromium.org/806413004/)

Reason for revert:
This breaks the Chrome OS daisy (32-bit ARM) builder:

http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/4364/steps/BuildPackages/logs/stdio

It just looks like a missing callsite.

Original issue's description:
> Plumb allow_overlay flag for video path into cc
>
> This will allow hardware video overlays to be enabled in the compositor
>
> Committed: https://crrev.com/32c0609baa6c3eea2400c6fe899a0ff60a1358dd
> Cr-Commit-Position: refs/heads/master@{#313310}

TBR=jschuh@chromium.org,piman@chromium.org,alexst@chromium.org,dalecurtis@chromium.org,posciak@chromium.org,achaulk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/881893002

Cr-Commit-Position: refs/heads/master@{#313345}

There is a small API change in a recently-added pdfium API exposed by
this roll, so pdfium_engine.cc is simultaneously updated to match.

This pulls in:
eef0050 Kill scattered extern _PDF_CharType declarations.
a039323 Fix infinite recursion in CPDF_Parser::ParseIndirectObjectAt().
fa370ac Fix test naming in previous commit.
e0bbe4a Fix null crash in CheckTrailer.
af9be4f Add pdfium_embeddertests to BUILD.gn
36faa4a Fix build of pdfium_embeddertest under V8_USE_EXTERNAL_STARTUP_DATA.
219e462 Use IPDF_DataAvail interface to hide CPDF_DataAvail.
83f96a0 Add API tests: NamedDestsByName, DestGetPageIndex.
9dcd7b8 Add tests for GetNamedDests() API.
dc43b32 Use signed long for FPDF_GetNamedDest buffer length.
0185408 Simplify UTF16LE_Encode and add unittest.

Review URL: https://codereview.chromium.org/881013002

Cr-Commit-Position: refs/heads/master@{#313344}

d:\src\cr3\src\base\strings\safe_sprintf.cc(513): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\strings\safe_sprintf.cc(513): warning C4456: declaration of 'ch' hides previous local declaration
d:\src\cr3\src\base\strings\safe_sprintf.cc(450): note: see declaration of 'ch'

R=thestig@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/868023005

Cr-Commit-Position: refs/heads/master@{#313343}

d:\src\cr3\src\base\threading\thread_local_storage.cc(143): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\threading\thread_local_storage.cc(143): warning C4457: declaration of 'value' hides function parameter
d:\src\cr3\src\base\threading\thread_local_storage.cc(110): note: see declaration of 'value'

R=thakis@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/880023002

Cr-Commit-Position: refs/heads/master@{#313342}

BUG=447277

Review URL: https://codereview.chromium.org/878673004

Cr-Commit-Position: refs/heads/master@{#313341}

Review URL: https://codereview.chromium.org/875593002

Cr-Commit-Position: refs/heads/master@{#313340}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f77365f..52b64b4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/883693003

Cr-Commit-Position: refs/heads/master@{#313339}

- Make all Tab#initialize(0 methods take a WebContents instead of a native WebContents pointer or a ContentViewCore.
- Make ContentViewCore#initialize() take a java WebContents
- Update methods in ContentViewUtil to no longer expose native WebContents.
- Add WebContents#destroy() to handle deleting a native WebContents and Java WebContents object.
- Remove many other references that cascade from these changes.

Review URL: https://codereview.chromium.org/831523005

Cr-Commit-Position: refs/heads/master@{#313338}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/866893002

Cr-Commit-Position: refs/heads/master@{#313337}

Constrain the mouse cursor to the painted region of the screen when overscan
insets are set.

BUG=427619
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/873563002

Cr-Commit-Position: refs/heads/master@{#313336}

Yet another cluster-fuzz crash happens due to invalid
render_frame_message_source_. As I see the code, this field is
always reset to NULL at the every IPC message but not initialized
at all, therefore the crash may still happen if the message is
the very first message to the object.

BUG=451755
R=jam@chromium.org

Review URL: https://codereview.chromium.org/869053004

Cr-Commit-Position: refs/heads/master@{#313335}

The CL [1] tightened the error check too much and revealed
an existing inconsistency and resulted a production crash.
This CL makes a workaround to that crash, turning a PCHECK()
to DPCHECK().

This is the second attempt. The first one was reverted at [2]

[1] https://crrev.com/ce44fef5fd60dd2be5c587d4b084bdcd36adcee4
[2] https://crrev.com/b83c03c7b691914a054abaab13fb9131b4e0152b

BUG=449233,448245
R=agl@chromium.org,jam@chromium.org

Committed: https://crrev.com/cf3eae19b456536c5ff8dacf8800ec09f9af4bca
Cr-Commit-Position: refs/heads/master@{#313188}

Review URL: https://codereview.chromium.org/882543002

Cr-Commit-Position: refs/heads/master@{#313334}

Damien mentioned an odd issue when adding this about it not compiling
correctly at the time. It compiles fine for me now.

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/881043002

Cr-Commit-Position: refs/heads/master@{#313333}

Modifies media/filters/skcanvas_video_renderer to expose its utility
method to convert YUV VideoFrames to RGB.

BUG=450205

Review URL: https://codereview.chromium.org/864113002

Cr-Commit-Position: refs/heads/master@{#313332}

* Gives the two classes a common base class called
  TabPersister to extend.

* Moves some functions for dealing with TabStates into
  the TabState class.

* Starts combining logic for saving Tabs between the
  StorageDelegate and the TabPersistentStore.

BUG=443773,451280

Review URL: https://codereview.chromium.org/868323003

Cr-Commit-Position: refs/heads/master@{#313331}

If the tile is solid, don't create a resource.  In tile manager,
check for null resources before attempting to release.

BUG=445919

Review URL: https://codereview.chromium.org/884453003

Cr-Commit-Position: refs/heads/master@{#313330}

Since we don't swap tilings anymore, we only need to push properties
when a property, or a tiling, or the raster source (invalidation) has
changed.

R=vmpstr
BUG=303943

Review URL: https://codereview.chromium.org/874613003

Cr-Commit-Position: refs/heads/master@{#313329}

BUG=452279

Review URL: https://codereview.chromium.org/878223003

Cr-Commit-Position: refs/heads/master@{#313328}

The recent change to add jscompile annotations include a change that
breaks that default OK/Cancel button of the loading window (because
of the number -> string conversion).

This cl removes the conversion that was added and and updates the
type annotation for sendReply_ to address the jscompile warning.

NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/883813002

Cr-Commit-Position: refs/heads/master@{#313327}

This will include the recent fix to fancy_urllib when running Python 2.7.9

BUG=452137
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/880963003

Cr-Commit-Position: refs/heads/master@{#313326}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/864333003

Cr-Commit-Position: refs/heads/master@{#313325}

Where "by default" = whenever we build Chromoting.

BUG=

Review URL: https://codereview.chromium.org/878793003

Cr-Commit-Position: refs/heads/master@{#313324}

NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/868393003

Cr-Commit-Position: refs/heads/master@{#313323}

The new flag is
    --gpu-rasterization-msaa-sample-count=X

similar to the existing
    --canvas-msaa-sample-count=X

where X is the sample count.

Review URL: https://codereview.chromium.org/881513004

Cr-Commit-Position: refs/heads/master@{#313322}

We've had problems with this linker flag in --as-needed a few times now;
just disable it if we're doing a sanitizer build.

BUG=452105

Review URL: https://codereview.chromium.org/882443003

Cr-Commit-Position: refs/heads/master@{#313321}

This class reads the settings, enables/disables the data reduction
proxy, and sets the data reduction proxy auth key.

BUG=451287

Review URL: https://codereview.chromium.org/870883002

Cr-Commit-Position: refs/heads/master@{#313320}

I'm not sure why this was working on the bots, but the sdk build was no longer
working on my Windows machine. After some research, I found that Chromium must
be built with vs2013, which was not supported by build_sdk, or by the Native
Client build (see https://code.google.com/p/nativeclient/issues/detail?id=4022)

This change modifies build_sdk.py (and build_artifacts.py) to use VS2013 from
depot_tools if it is available, as well as switching to using gyp_chromium
instead of gyp_nacl for building Native Client host binaries.

BUG=none
R=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/811533002

Cr-Commit-Position: refs/heads/master@{#313319}

Revert of Revert of Enable ChannelMojo (patchset #1 id:1 of https://codereview.chromium.org/875333002/)

Reason for revert:
This revert was innocent. The culprit was
https://codereview.chromium.org/878843002/

Original issue's description:
> Revert of Enable ChannelMojo (patchset #3 id:40001 of https://codereview.chromium.org/857483004/)
>
> Reason for revert:
> many ipc test failed.
> https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/10036
>
> Original issue's description:
> > Enable ChannelMojo
> >
> > As we addressed certain amount of the performance problem,
> > it's time to give it another try.
> >
> > R=viettrungluu@chromium.org
> > BUG=377980
> >
> > Committed: https://crrev.com/a06cd1b2fe83b51b0874ca504066f00a17192026
> > Cr-Commit-Position: refs/heads/master@{#313184}
>
> TBR=viettrungluu@chromium.org,morrita@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=377980
>
> Committed: https://crrev.com/af01416ada7b968c55224be9e61272ad73e59fe1
> Cr-Commit-Position: refs/heads/master@{#313225}

TBR=viettrungluu@chromium.org,yoichio@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=377980

Review URL: https://codereview.chromium.org/881863002

Cr-Commit-Position: refs/heads/master@{#313318}

This used to work, but was broken by d0a0c992

BUG=none

Review URL: https://codereview.chromium.org/872713005

Cr-Commit-Position: refs/heads/master@{#313317}

Due to the odd implementation of MCPopupController, all the clean up happens in
-close rather than -dealloc. In all instances but one, the owner would destroy
MCPopupController by calling -close or -closeWithAnimation. There was one
instance where the owner was calling -release, which was preventing
MCPopupController from properly cleaning up.

BUG=423001

Review URL: https://codereview.chromium.org/857463003

Cr-Commit-Position: refs/heads/master@{#313316}