- 12 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9642d3ae12e4..67615460bea4 2020-08-12 nisse@webrtc.org Move H264::Profile to h264_profile_level_id.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie530035682c0fe2ed15aa289d6bace47af7d6b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352361Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797289}
-
Aaron Leventhal authored
Adjust menu controller to ensure correct number of kSelection events. These are turned into focus events under MSAA. - Regular menu items: we were firing extra events even when selection didn't change. - Hot button menu items, such as zoom-related, cut/copy/paste in edit menu, were not firing any events on hover, because the button already considered itself hot tracked via the button controller's mouse handling. AX-Relnotes: avoid missing or duplicate menu item announcements when using mouse Bug: 1077755, 1106916 Change-Id: Ie933146b647d56f7665cfc72bb708e9f7bdd71de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350483 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797288}
-
Andrew Xu authored
Bug: 1114880 Change-Id: I84ab8b5491aa9039696249851f44d0aef59b7925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351119Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797287}
-
Naomi Musgrave authored
Fetch the certificate from the CertificateManager, to pass to CreateShareTarget. This is a follow-on from a comment on I1b1ed2252baa59e68f4daa1e772a51e9cf32eff4. Bug: 1084644 Change-Id: Ie42ae628517716cc64e7d57011079497e803f260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346390 Commit-Queue: Naomi Musgrave <nmusgrave@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Auto-Submit: Naomi Musgrave <nmusgrave@chromium.org> Cr-Commit-Position: refs/heads/master@{#797286}
-
Nick Diego Yamane authored
Also export WmMoveResizeHandler and do a few more minor cleanups. R=sky@chromium.org Bug: None Change-Id: Ic627348b14d624641bf0adf6b30732e17f13b8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348692 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#797285}
-
Sebastien Lalancette authored
CreateFullPagePdf will check if the current page is an about scheme/app specific page (or an invalid URL), and if so will invoke the completion callback with nil NSData. Added a new unit test for the new logic. Bug: 1103777 Change-Id: I2eebd0d65ffe3c4c368893dff7fb8e1c53276ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340413 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#797284}
-
Michael Crouse authored
No logic change, only enums.xml. Change-Id: Id50d548062ded1894397feb73ff7068e5f08c89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352609 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#797283}
-
Alice Wang authored
This CL separates account picker bottom sheet render tests into a different file to make it easier to test more screens in both light and dark modes. Bug: 1090356 Change-Id: I98b8a01d1c54b95c4653d055af3f0666804afd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346428Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797282}
-
Pâris MEULEMAN authored
also add Arthur as an owner as this has indrect implications to his work on access-reporting. Bug: 1059303 Change-Id: I5c579f89894dddb637ffeb3d1879249434cfd42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351998 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797281}
-
Robert Phillips authored
SkDeferredDisplayListRecorder::makePromiseTexture can fail for a variety reasons (in the repro case the requested width/height is 320/10048 while the max texture size is 8192) so try to fail gracefully. Bug: 1068253 Change-Id: I5fcb25343fe397240330e23db902c97cee71c239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351955Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#797280}
-
Chris Hamilton authored
This migrates all current usage at the same time. BUG=1113677 Change-Id: Ibdb4b69591d62c5e1673919811b33cfec0ea0f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341145Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#797279}
-
Dan Harrington authored
Don't report this journey at all if the GetMore request was not allowed. This can happen if there's no next page token for example, which is expected at the end of stream. Bug: 1044139 Change-Id: I3330918653b012e4d85d595beef0db61d6c96f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346794 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#797278}
-
Wez authored
Under Windows and Fuchsia the TestLauncher runs test batch processes in their own jobs, allowing any leaked sub-processes leaked by tests to be cleaned up. Under POSIX platforms each batch is run in its own process group, but the group was only being kill()ed if the test batch failed or crashed. TestLauncher now proactively kill()s each test batch's process group. The result of the call is also checked, and the test batch marked as failed unless kill() reports that the process-group was already gone. Note that this will still miss processes launched into new process groups by tests. Bug: 1094369 Change-Id: If379d200953a823b2020766cda73f8cf27bfdb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346388 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#797277}
-
Jonah Ryan-Davis authored
Add option --use-angle=metal to gl_switches, and forward this through EGL surface creation. Add proper piping of TEXTURE_2D for Metal. Add necessary options for Metal testing and expectations. Bug: angleproject:4847 Change-Id: I8f117f3a68ef33ea30e87fd3208ef5aedc3b0e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302915 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797276}
-
Dan Harrington authored
Bug: 1044139 Change-Id: I5eb68cfb99aa5a849b1bde708e2c91b8a2fba43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350880 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#797275}
-
Guillaume Jenkins authored
Implements the missing delegate methods for enrollment and policy fetch. Note that there is still an issue with the specific URLLoaderFactory implementation handling the requests that prevents the end-to-end flow from working properly. This is being investigated separately. Also adds CloudManagementEnrollmentToken to the list of supported policies (even though it's read directly from NSUserDefaults). #Squeegee Bug: 1066495, 1111145 Change-Id: I21c1ee3b26bc413ff26ad4031b44ebda5086e936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337267 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797274}
-
Andy Lu authored
Changed the parameter name from "Open {URLs} in Incognito" to "Open {URL} in Incognito" for the Open URLs in Chrome Incognito Siri shortcut. This makes more sense since the UI shows one URL to enter at a time, and only one URL can be entered in that field. Added in the new screenshot associated with this parameter change. Bug: 1115243 Change-Id: I0a821b36c838b1b033f745875f11c99c046ef0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350236Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Andy Lu <andyhylu@google.com> Cr-Commit-Position: refs/heads/master@{#797273}
-
Ben Kelly authored
This CL updates the testing config to match the new trial launch target of 8 maximum parallel cache operations. Bug: 960012 Change-Id: I7d7b973ffaf257683a2c8fb5913b375b4bd205d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343223Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#797272}
-
Karel Král authored
Implement tracing of mojo async response parameters. Add a |parameter_group| argument to |trace_event| macro to provide more flexibility when naming the traced parameters. Thus provide debugging information for asynchronous response parameters as well. Bug: 1103623 Change-Id: I7e38d8cc53ba8eff30c207defc0467674be50f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339632 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#797271}
-
Josh Nohle authored
The Nearby Share protocol uses HKDF with an authentication token, using a certificate's secret key as the salt and a trivial info, to generate a hash. Both parties--the receiver and sender--confirm this hash. This, along with a standard signing/verification flow, is used to establish an authenticated connection between devices. See go/nearby-chrome-cert. This CL implements a hashing method for both the private and decrypted-public certificate classes. We add tests using test vectors that are also used in GmsCore unit tests (cl/326170193) to ensure consistency across platforms. Fixed: 1115320 Change-Id: I5aa9f7de5340a537a57c323a5afb97f6a83a4b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351709Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#797270}
-
Ioana Pandele authored
This changed tests the creation logic for CompromisedCredentialForUI, which is part of GetCompromisedCredentials. Bug: 1102025 Change-Id: I5b4af3f9b13abc1eb16948abddf587b9b925fab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346438 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#797269}
-
Victor Hugo Vianna Silva authored
The CL calls the incrementer from crrev.com/c/2340966 (later renamed). Now, a per-Gaia-account counter is incremented whenever the move bubble is shown and the user is not opted-in to the account-scoped passwords storage. The bubble won't be shown for users whose count is above a certain threshold (see crrev.com/c/2345309). Bug: 1082152 Change-Id: Id0ef7fd6b85598a1cb0651435a5c6f9bf6214049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351995Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#797268}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4451adcce85..5697d3550bc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6b20b774c51afa733e9c49e3378b083430b321fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351369Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797267}
-
Alexander Timin authored
Add a dedicated helper struct for holding WebContentsObservers. This allows us to ensure that iteration over all observers can be detected: - This can replace existing is_notifying_observer_ WebContentsImpl member and ensure that it's set for almost all observer iterations. - This allows us to emit a trace event covering observer iteration. Escape hatch is kept for now for the three places which want to return value as soon as matching observer is found. Also WeakPtr-based logic is added to RenderViewTerminated as some observers are actually trying to delete WebContents there. R=nasko@chromium.org Change-Id: Ic94cf9bbc83b2d9bfe93a3090a4f4af3fd8f60dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343269Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797266}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3e586480ca0f..51d97b104f79 2020-08-12 szuend@chromium.org [ts] Type-check ui/ThrottledWidget.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Type-check ui/ResizerWidget.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Type-check ui/Widget.js with TypeScript 2020-08-12 wolfi@chromium.org Show 'Opened Windows' in Application panel's frame tree 2020-08-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-12 szuend@chromium.org [ts] Type-check ui/SegmentedButton.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Type-check ui/RootView.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Store Widget scroll positions in WeakMap instead of the element 2020-08-12 szuend@chromium.org [ts] Move Element prototype wrangling to DOMExtension.js 2020-08-12 jacktfranklin@chromium.org Fix non-nullable bug in bridges interface output If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1107766 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id64662d12b5e8cdd8a786810cc004ba94ff90985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352353Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797265}
-
Jan Wilken Dörrie authored
This change updates Chromium's copy of affiliation_api.proto to include the latest server side changes with regard to change password URLs. Bug: 437865 Change-Id: I566a5e05ff89ecc8d82d33e2a12dac5f28253522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351997 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#797264}
-
Karel Král authored
Add support for tracing of mojo sync response parameters in auto-generated methods. Thus provide more information for the developers who are debugging. Bug: 1103623 Change-Id: Ie0edadbe6007f0156d4c291775dba2e8777a2ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332819 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797263}
-
Peter Kasting authored
No need for temps if we call AddChildView() when constructing. Also, calling SizeToPreferredSize() in teh constructor allows simplifying Layout(). Bug: none Change-Id: I7a215cae407f9b48132045111c2818a467be6aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348196 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797262}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5697d3550bc8..09afd88dfed8 2020-08-12 treehugger-gerrit@google.com Merge "Check for failed OpenFile." 2020-08-12 taylori@google.com Merge "Roll trace_processor" 2020-08-12 hjd@google.com Merge "trace_processor: Add diff test for displayTimeUnit" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iffde4337fb876795160d339ea597fe4201a61afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797261}
-
David Jean authored
Reset insets after changing configuration during a size change. Bug: 1114134 Change-Id: I3d32d5db03f5c2446830336d07821e325a443d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351833Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#797260}
-
Noel Gordon authored
Test is top flake in chromium as of today, mark as a [ Pass Failure ] on all bots. Tbr: sheriff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1049641 Change-Id: Ic56db02a7013af194ba8053aa2cc00de47368925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352570 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797259}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ca6a7f44301..780679454319 2020-08-12 fmalita@chromium.org [skottie] Initial audio layer plumbing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Iba767c8600ff1e8a19123fe27ce7bf217b64ce22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351158Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797258}
-
Victor Hugo Vianna Silva authored
None of the regressions from the previous rollout manifested so far, so let's try to enable by default again. This has no effect on Canary/Dev anyway since there's an ongoing experiment for the feature there. Bug: 906995 Change-Id: I4c9ca67c0e993f09b4903bae108fe25f9cfb2294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335452 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#797257}
-
Gayane Petrosyan authored
Create TextFragmentSelectorGenerator with page and set selection information when context menu is shown. This is done so that Java code can just call the GenerateSelector function without any arguments and generation can happen for the latest selected text. Follow-up CL https://chromium-review.googlesource.com/c/chromium/src/+/2341662 will connect to browser-side component. Bug: 1102382 Change-Id: I5574f5b40e5a74bef56698e2de5a9b1fea17e0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340734Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#797256}
-
Stephen McGruer authored
This reverts commit 4aa12de8. Reason for revert: Tentative revert as one possible cause of https://crbug.com/1115532 If revert doesn't fix failures, will reland (with apologies :)) Original change's description: > Oobe: add browser test for gaia screen > > Add browser test to verify behavior for back button on the gaia screen when kChildSpecificSignin feature is enabled. > > Bug: 1101318 > Change-Id: Ibaff1cf629520b3fbbe8cd620d8727bd35922295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343068 > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797176} TBR=antrim@chromium.org,rsorokin@chromium.org,yunkez@google.com Change-Id: I8347e80a1b22ab63f60688a8a23809be796b5039 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101318, 1115532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352550Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797255}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/17a165467087..9642d3ae12e4 2020-08-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e697f4f1..54b8c1d0 (797077:797178) 2020-08-12 danilchap@webrtc.org Use non-deprecated EncodedImageCallback::OnEncodedImage in rtc_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic41ef82be2bfec2153a31772c07ffba0e622480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797254}
-
sauski authored
Introduces functionality to the HatsNextWebDialog to support resizing of the dialog based on the size of the survey within the web contents. Size information is passed from the HaTS Next JS library through to native code by pushing URL fragments. Bug: 1110888 Change-Id: I70d7268cbc10c2da9e34d7dec338180a975f059f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274603 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797253}
-
Michael Ershov authored
Before this CL tpm_challenge_key_unittest.cc contained tests for TpmChallengeKey, TpmChallengeKeySubtle and TpmChallengeKeyResult. Now it will test only TpmChallengeKey, other parts are separated into their own test sets (in previous CL). Bug: 1090723 Test: TpmChallenge* Change-Id: I66aa20a6d69e77a2865b77bacc819d0be61756d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228555 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#797252}
-
harrisonsean authored
Add support for safety check safe state and issues. Issues support includes deleting/managing in settings and on site. Add support for password check error popovers. Tests coming in later cl Bug: 1078782 Change-Id: I6c2b388fce4d397a1c1e01d161b4e0b35c91e9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339322Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#797251}
-
Fergal Daly authored
Fix some grammar problems. Also mark "unload" as a non-translatable term. Change-Id: I422a2ad871a202c8576ad72b0166e8a4107dedab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342536 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797250}
-