- 05 Nov, 2020 40 commits
-
-
Avi Drissman authored
New macOS capabilities, more utilities in Chromium. Bug: 1145672, 1145792, 1142017 Change-Id: Ibd10501429aba40aacb4db7c751385428115941d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518258 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824329}
-
Mikel Astiz authored
These new metrics can be derived from existing metrics but simplify the analysis, in line with the general guidance by the metrics team. Change-Id: Ic0f1c59a590dbb9be43b5ee45f37a808b352cca9 Bug: 1068378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517681Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824328}
-
Alexey Baskakov authored
This CL introduces no behavior changes. WebAppProvider class must not depend on extensions, only forward declarations are visible. All extensions-specific code and includes have been isolated in chrome/browser/web_applications/extensions/bookmark_app_provider.cc file. In long term, the whole chrome/browser/web_applications/extensions/ code directory must be deleted (see README.md in that folder) This is a preparation CL to delete web_applications_on_extensions GN source set. TBR=ccameron@chromium.org Bug: 1065748 Change-Id: I7fa1306694e80dbda8aab7159a075919ec2c42b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517233Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#824327}
-
Alexey Baskakov authored
This CL introduces no behavior changes. chrome/browser/web_applications/web_app_migration_user_display_mode_clean_up.h must not depend on extensions, only forward declarations are visible. This is a preparation CL to remove web_applications_on_extensions GN node. WebAppProvider will be moved from web_applications_on_extensions to general web_applications GN node. Bug: 1065748 Change-Id: I4a67398ad7db8107010d4b7cd165657fe1e64ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517190Reviewed-by:
-
Shik Chen authored
Bug: b:172346047 Test: Pass Closure Compiler checks. Change-Id: I79ee47ee084149f4168978307af3c75cbade29f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515868 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#824325}
-
Xiaocheng Hu authored
Bug: 1145406 Change-Id: I2bcc50fe3c6799586643750e7c655be0cac979dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519860 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#824324}
-
Darren Shen authored
FinishComposingText saves the old selection in order to reapply it after the composition is finished. However, it needs to also maintain the direction (the order of base vs. extent), or else a backward selection will be restored as a forward selection after calling FinishComposingText. Bug: 1145727, b/172284191 Change-Id: Ie1e8ef69fcabcb11aebbbc5003e044f70e6535d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518309 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824323}
-
rbpotter authored
Bug: 1132403 Change-Id: I809b1a97e43457b92ac67fde208b200bfbf37d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507400 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824322}
-
Hitoshi Yoshida authored
If we enable same-site backward/forward cache, backward navigation does not trigger onload event. This CL updates a WPT that depends on the onload event to handle pageshow event and makes it work with backward/forward cache. Bug: 1132180 Change-Id: I663f9c78e8b9835f081c5262b446bd56dba07cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520558Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#824321}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/431aae870034..1d09ab6b6ebf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jshikaram@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142017 Tbr: jshikaram@google.com Change-Id: I5d632786909f83ce3878e6b65cfaa4cbfff8417d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824320}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/6WExfJ6Fz87xiWv Bug: 889763 Change-Id: If0831adeae13f8cc47280bfb1fd117f857622db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518521 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824319}
-
Ramin Halavati authored
A few commands are updated in browser command controller for ephemeral Guest profiles and the tests are updated to cover both old (OTR) Guest profiles and the new ephemeral ones. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ifa4890dab8d971aada471fca0a03861ca14c5e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517588Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#824318}
-
Wei Lee authored
Since we changed the url of CCA to: chrome://camera-app/views/main.html instead of chrome://camera-app/src/views/main.html This CL fixes the consistent parts regarding to the app id. Bug: 980846 Test: None Change-Id: I21bd97639bf44383e31147e42c98fd4ac2d3aea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519681Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#824317}
-
Koji Ishii authored
When painting and hit-testing NG fragments, |NGBoxFragmentPainter| falls back to |LayoutObject| at the BFC boundary, because we already have a logic in |LayoutObject| to switch painters for NG and legacy. This patch changes to do so only when |!CanTraverse|, because |LayoutObject| cannot handle block fragmented NG objects. This patch eliminates |CurrentFragment| from |LayoutNGBlockFlowMixin::Paint| by making sure it is not block fragmented. Also changes |HitTestChildBoxFragment| so that it can handle atomically-painted objects in NG code path. Due to the change in |FragmentRequiresLegacyFallback|, such objects go to NG code path without going through |LayoutObject|. Bug: 1061423, 829028 Change-Id: Ife31d6dcd209668a489243b1158112dac44fc273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515429 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#824316}
-
Solomon Kinard authored
In Manifest V3, extensions will have finer grained control over web-accessible resources, with the ability to restrict embedding to specific URL patterns or extension IDs. This CL introduces the parsing for a new format in the manifest.json to support taking a list of objects, rather than a list of strings: "web_accessible_resources": [ { “resources”: [“file.gif”], “matches”: [*://*.chromium.org/*], “extension_ids”: [“abcdefghijklmnopabcdefghijklmnop”] } ] This CL only parses and stores matches and ids alongside resources. Permission checking based on those two fields to be done subsequently. Bug: 1133624 Change-Id: Ice0374d4de433d23700a6c7b03ff3d76cd0bd9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439795 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824315}
-
David authored
JS crash reports may occur from a regular tab, app window or SWA window. This is not currently logged. Logging this will help us track down a potential race condition where a SWA url may not be recognised which may be the root cause of b/162791595. A note about tests: It is a little weird getting tests to work for window type as we can't grant a |WebContent| permissions to use |CrashReportPrivate| on the fly. This cl works around that by opening the target window window type, then navigating a url that has access to |CrashReportPrivate|. Bug: b/162791595, b/169635499 Change-Id: I358a380b6742bd44f56a5a46f51182b9df26c693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489123 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#824314}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68dcf542b79f..906501df4f0c 2020-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 31e28d20f878 to ad54c71632cc (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I388344849626dbcf7dcd855193dc6d88a7892f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520020Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824313}
-
David Black authored
Currently HoldingSpaceTrayIcon is updating preferred size when shelf alignment changes. This is desired behavior when the content forward entry point is enabled, but this is *not* desired behavior when the content forward entry point is disabled. Bug: 1142572 Change-Id: I6ae728cf9968af87934d694a51b293ae64e7e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520380Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#824312}
-
Maksim Sisov authored
All the tests except DesktopWidgetTest.MinimumSizeConstraints pass without any modifications. The DesktopWidgetTest.MinimumSizeConstraints required providing minimum size during the call to WidgetTest::GetNativeWidgetMinimumContentSize. Bug: 1001075, 1109114 Change-Id: I4bc0b76d39f981694441d9d0e78d58d4cc5345d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444312Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8ca189d4e5b8..b503f5ff6b58 2020-11-05 chanli@chromium.org move the cipd pin of infra/tools/rdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137513 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I468f8d6f80d9f325f15a085ea890c1063dbd4634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520446Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I09cb40756590ec1facae3af2c10a45c376dd027c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520438 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/33001e2632db..8532ef05056c 2020-11-04 nigi@chromium.org Move the Noto font file for testing to top-level third-party directory. 2020-11-04 tsepez@chromium.org Remove some calls to CFXJSE_Value::ForceSetValue() 2020-11-04 tsepez@chromium.org Remove arg from CFXJSE_Value's constructor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I18e5f208686300d789d283c854c3bc0964abb491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520442Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/658ede5d8c5c..1e494cae8d48 2020-11-05 b.schade@samsung.com Vulkan: Add support for EXT_copy_image If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: dEQP-GLES31.functional.copy_image.* Change-Id: Ic4c267655ff66f279b9aff43924dac3592116afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520326Reviewed-by:
-
Yuzu Saijo authored
This CL creates a new task type kNetworkingUnfreezable that is passed to URLLoaderClientImpl, so that the loading tasks keep running when the context is frozen. This CL also plumbs this unfreezable task runner to URLLoader. At the moment URLLoader uses only freezable task runner, but as we support the network requests handling for frozen pages, we will start using unfreezable task runner, and in the end state we will only have unfreezable task runner for URLLoader. This task type is guarded with loading-tasks-unfreezable flag. Without the flag, this task type is freezable and the loading tasks are freezable as they used to be. Bug: 1137682 Change-Id: I131e8682d1f018ece9c2ab91bdc480be8007d495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465441 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#824306}
-
Darwin Huang authored
This ensures member variables aren't accessed or modified from more than one thread at a time. Bug: 1099089 Change-Id: I644c30423d2ed999c3b316c4a76916a61ba1e1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518253 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824305}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604512659-d9763b7a65f794f5c7fc74561c1fa38d29e0d735.profdata to chrome-win64-master-1604534391-78c794948f9915d6943b9f032cad3893f5df2156.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3107638839ff2f63e620474b5f547240984e504a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520018Reviewed-by:
-
Ben Reich authored
Multiple tests will output separate JavaScript code coverage files containing multiple ScriptCoverage objects. The special functions added in this CL: |_convert_to_disjoint_segments| |_merge_segments| merge the output from multiple tests into a single file, and ported from their JavaScript equivalents in Chrome Devtools [1,2]. Add merge_js_lib_test.py; a set of tests to verify the behaviour of the special functions. These tests need to be ran manually for each change to merge_js_lib.py. The underlying assumption is files that have reported coverage have a sourceURL appended so that the coverage data maps back to the original source file path. Any files without a sourceURL are ignored to avoid mapping to data that has not opted into JavaScript code coverage. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/coverage/CoverageModel.js;l=474-514;drc=a2092ffd013f71594ffa7fccf5823c3758e4d445 [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/devtools-frontend/src/front_end/coverage/CoverageModel.js;l=804-837;drc=a2092ffd013f71594ffa7fccf5823c3758e4d445 Bug: 1113941 Test: ./merge_js_lib_test.py Change-Id: I4f94758fa85453e1f9092080ef8d8f4e749f8096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506363Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Ben Reich <benreich@chromium.org> Cr-Commit-Position: refs/heads/master@{#824303}
-
Leo Lai authored
There are some inconsistent comments and function calls after the migration. BUG=b:158955123 TEST=unit_tests. Change-Id: I1038e52492e5c4a45e422b4d1cf7ac086cc31e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519638Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#824302}
-
Ken Rockot authored
This code was originally landed when sandbox stuff was still in Service Manager. It's not in Service Manager anymore, and Service Manager code is on its way to the great Git repository in the sky. Bug: 977637 Change-Id: I10c2c02cbd70bc3f99fb0dfdb26319003b0047c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520317 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/422eb910890c..431aae870034 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jshikaram@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1145760 Tbr: jshikaram@google.com Change-Id: I15258f114c0a27243cfb9f9f96fbad1901f362dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520439Reviewed-by:
-
Melissa Zhang authored
This CL ensures ShareAction icon colors change with the theme. ShareActions define VectorIcons instead of ImageSkias, which are passed through to the |sharesheet_bubble_view| to be used to generate ColorTrackingIconViews. Bug: 1127750 Change-Id: If2b16ee72c11071931541e63b00a2cd8b9c5ad10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505255 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#824299}
-
Liviu Tinta authored
Bug: 1132544 Change-Id: I5bcb7698fba041cd87917794076b95c44d5e268a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509013Reviewed-by:
Lan Wei <lanwei@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#824298}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for: - LayoutSVGImage - LayoutSVGInline - LayoutSVGInlineText - LayoutSVGResourceContainer - LayoutSVGRoot - LayoutSVGShape - LayoutSVGText - LayoutSVGTextPath - LayoutSVGTransformableContainer - LayoutSVGViewportContainer This CL has no behavior changes. Bug: 891908 Change-Id: I31dc8eb8d645a19dba09d3817e4f7a9e74c15a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519178 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#824297}
-
Kent Tamura authored
This CL converts DEFINE_INLINE_BOX_TYPE_CASTS() to DowncastTraits<> for: - InlineTextBox - InlineFlowBox This CL has no behavior changes. Bug: 891908 Change-Id: I5592a7523d570aebdd6bfb5875b7d815dd56f509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519678 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Daniil Lunev authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9e8d3a2d7e05..284391894473 $ git log 9e8d3a2d7..284391894 --date=short --no-merges --format='%ad %ae %s' 2020-11-04 dlunev system_api: add CRYPTOHOME_ERROR_VAULT_UNRECOVERABLE 2020-10-19 hardikgoyal system_api: Marking KeyPrivilege::mount as reserved 2020-10-29 fletcherw lorgnette: add CancelScan D-Bus call 2020-10-28 fletcherw lorgnette: handle reporting scan cancellation 2020-10-27 wvk vm_tools: Add VmIdChanged signal for Concierge 2020-11-02 sidereal Revert "Revert "vm_tools: concierge: Allow to specify kernel/rootfs paths for Termina"" 2020-11-02 sidereal Revert "Revert "vm_tools: Add initrd field to the concierge protocol."" 2020-11-02 sidereal Revert "Revert "vm_tools: concierge: Rename allow_untrusted flag to run_as_untrusted"" 2020-11-02 sidereal Revert "vm_tools: concierge: Rename allow_untrusted flag to run_as_untrusted" 2020-11-02 sidereal Revert "vm_tools: Add initrd field to the concierge protocol." 2020-11-02 sidereal Revert "vm_tools: concierge: Allow to specify kernel/rootfs paths for Termina" 2020-10-29 fletcherw lorgnette: report 1-indexed page numbers 2020-10-27 jiahe.zhang power: Add GetThermalState API Created with: roll-dep src/third_party/cros_system_api Bug: 1140868 Change-Id: I27788e343c14a3f6ac503d745f81014beb218b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519338Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniil Lunev <dlunev@chromium.org> Cr-Commit-Position: refs/heads/master@{#824295}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for: - LayoutInsideListMarker - LayoutListItem - LayoutListMarker - LayoutListMarkerImage - LayoutOutsideListMarker - LayoutNGInsideListMarker - LayoutNGListItem - LayoutNGOutsideListMarker This CL has no behavior changes. Bug: 891908 Change-Id: I22caaff015f1dc1af22850f5a4e8ffefee9ae121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519342 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1e2067d345cc..2876f93d9628 2020-11-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6b27e1bdcf084bf489018473af036453cca728a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520079Reviewed-by:
-
Nidhi Jaju authored
This CL adds the WebIDL files and relevant C++ stubs for the ReadableStreamBYOBRequest and ReadableByteStreamController classes according the the Streams API Standard[1][2]. This is a follow on from adding the ReadableStreamBYOBReader WebIDL files in an effort to add the stubs before implementing readable byte streams. This feature will be runtime enabled under the flag "ReadableByteStream". [1] https://streams.spec.whatwg.org/#rbs-controller-class [2] https://streams.spec.whatwg.org/#rs-byob-request-class Bug: 614302 Change-Id: I26b0f91c8ec60e7a0b74581a0d857a2536af27ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517349 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#824292}
-
Minggang Wang authored
As part of the OnionSoup project, this patch moves the following classes: - TrackedChildPendingURLLoaderFactoryBundle - TrackedChildURLLoaderFactoryBundle - HostChildURLLoaderFactoryBundle into blink. Bug: 1110026 Change-Id: I3aa6c2f744971f95ca81f672c8f3dd1adbdd56df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514064 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Leo Lai authored
It is just a stale object after migrating to AttestationClient. BUG=b:158955123 TEST=unit_tests. Change-Id: Icc572c5594562e45e5adc428309b7363500104f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517234 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
