GitLab

Cache and reset the intrinsic content logical height of children when stretching them
in FlexBox. This is to avoid them reseting it to the stretched height, which leads
us to improperly avoiding layout later when stretching is no longer necessary.

This solution is too fragile, but I couldn't come up with one that was more robust
but doesn't break the optimization.

BUG=409779

Review URL: https://codereview.chromium.org/715083002

git-svn-id: svn://svn.chromium.org/blink/trunk@185173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185157

BUG=420901
TBR=bungeman@chromium.org

Review URL: https://codereview.chromium.org/717043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185161

BUG=423834
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/716973003

git-svn-id: svn://svn.chromium.org/blink/trunk@185171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having fragmentation data be lazy on RootInlineBox only saves us a single
int (due to the pointer and the fact that we have room to pack its bool
into InlineFlowBox's bitfields), and the allocation overhead was large enough
it appeared on performance tests (see bug).

BUG=313700

Review URL: https://codereview.chromium.org/715973004

git-svn-id: svn://svn.chromium.org/blink/trunk@185170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL ensures ResourceFetcher::requestPreload to request with
an appropriate context, RequestContextPrefetch.
This CL fixes the issue that ASSERT in
MixedContentChecker::contextTypeFromContext is hit when preloader
is invoked.

This is to prepare for CL http://crrev.com/673603002 , which makes
preloader to be invoked more often.

TESTS=http/tests/security/mixedContent
BUG=421300

Review URL: https://codereview.chromium.org/711213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185169 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since ContentDecryptionModuleResult objects are often used to return
promises, add ContentDecryptionModuleResultPromise as a base class
that includes the promise and allow existing classes to only override
the complete() method that they expect to get called.

BUG=358271
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/687533004

git-svn-id: svn://svn.chromium.org/blink/trunk@185168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423071

Review URL: https://codereview.chromium.org/716023002

git-svn-id: svn://svn.chromium.org/blink/trunk@185167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Makes CSSRule and its subclasses inherit from ScriptWrappable.

Amongst top 10 mobile web sites, only one web site instantiates
only one instance of CSSRule unless Developer Tools is opened.
Most of web pages don't instantiate CSSRules and its subclasses
(unless Developer Tools is opened), so it should be okay to make
CSSRule inherit from ScriptWrappable, although it increases the
size of CSSRule by 4 or 8 bytes (= the size of v8::Persistent).

BUG=390065

Review URL: https://codereview.chromium.org/699043003

git-svn-id: svn://svn.chromium.org/blink/trunk@185166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue, CSSPrimitiveValue, etc. are no longer
web-exposed, we should stop testing them so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/715913003

git-svn-id: svn://svn.chromium.org/blink/trunk@185165 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Apache gets stuck when the pipe connected to stderr gets filled up and
not read. This patch makes stderr of apache directly goes to build log.

BUG=30536, 431172

Review URL: https://codereview.chromium.org/712253002

git-svn-id: svn://svn.chromium.org/blink/trunk@185164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/713823005

git-svn-id: svn://svn.chromium.org/blink/trunk@185163 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need a way to show hidden transition elements when coming back from native app (when back button is pressed).

This is the Blink side of the CL. The Chrome side is here: https://codereview.chromium.org/712183002/

BUG=370696

Review URL: https://codereview.chromium.org/715653004

git-svn-id: svn://svn.chromium.org/blink/trunk@185162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a pixel bleed issue on very high-DPI screens.

BUG=423834

Review URL: https://codereview.chromium.org/711163002

git-svn-id: svn://svn.chromium.org/blink/trunk@185161 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This avoids doing a null check in this method, adjust
all call sites.

Review URL: https://codereview.chromium.org/715023002

git-svn-id: svn://svn.chromium.org/blink/trunk@185160 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Nobody uses this anymore.

R=haraken@chromium.org, tkent@chromium.org
BUG=263316

Review URL: https://codereview.chromium.org/705363003

git-svn-id: svn://svn.chromium.org/blink/trunk@185159 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185149

TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/721543002

git-svn-id: svn://svn.chromium.org/blink/trunk@185158 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Related skia change:
https://codereview.chromium.org/692083002/

BUG=420901

Review URL: https://codereview.chromium.org/718673004

git-svn-id: svn://svn.chromium.org/blink/trunk@185157 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/704303004

git-svn-id: svn://svn.chromium.org/blink/trunk@185155 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use existing AtomicStrings instead of a string literals
that need to be converted to them.

Review URL: https://codereview.chromium.org/716873002

git-svn-id: svn://svn.chromium.org/blink/trunk@185154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=374270

Review URL: https://codereview.chromium.org/710213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that the Blink IDL supports the Promise<T> syntax, update
the EME idl files with the promise type.

BUG=358271
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/694773004

git-svn-id: svn://svn.chromium.org/blink/trunk@185152 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Things that make you go 'WAT.' This comment was added in the patch
that split RenderBoxModelObject out of RenderBox --
eb6efbfaa79de8624ce72ad4e26ef0d3f808650e -- without any additional
explanation. I don't think it's helping anyone.

H/T to Ojan for finding today's WAT.

Review URL: https://codereview.chromium.org/718843002

git-svn-id: svn://svn.chromium.org/blink/trunk@185151 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The iframe load was racing with the main frame setting the onmessage
event handler. To fix this, defer the iframe loads until the main frame
onmessage event handler has already been set.

BUG=none

Review URL: https://codereview.chromium.org/704413010

git-svn-id: svn://svn.chromium.org/blink/trunk@185150 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The math to position the host layer does not account for scrolling, and
this causes incorrect behavior with nested scrollers.

BUG=None

Review URL: https://codereview.chromium.org/667913003

git-svn-id: svn://svn.chromium.org/blink/trunk@185149 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Take the text path (simple vs complex) into account when computing the
width of a space character used to strip leading and trailing spaces.

R=leviw@chromium.org
BUG=427415
TEST=fast/text/international/complex-text-leading-space-wrapping.html

Review URL: https://codereview.chromium.org/721433002

git-svn-id: svn://svn.chromium.org/blink/trunk@185148 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently animation-test-helpers.js supports prefixing element ids with
"static:". This patch removes this prefix as we just just remove them
and do nothing differently.

Review URL: https://codereview.chromium.org/693613006

git-svn-id: svn://svn.chromium.org/blink/trunk@185147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Restarting content_shell periodically helps keep memory usage down. This should
improve cycle times on bots by preventing the machines from going into swap.

BUG=427569
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/709603005

git-svn-id: svn://svn.chromium.org/blink/trunk@185146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The main frame's size is no longer simply the viewport size. Instead,
WebViewImpl sizes it after layout to be the either the content width with
a height matching the viewport aspect ratio, or the viewport at minimum page
scale. This fixes a bug where the innerWidth/innerHeight values would be
wrong during an onload event if the onload would happen before the content was
properly sized.

BUG=431097,428722

Review URL: https://codereview.chromium.org/705423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185145 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch passes 'true' value for layoutPositionedObjects() in case of size change.
It helps to avoid unneccessary setChildNeedsLayout() and setPreferredLogicalWidthsDirty() calls.

Review URL: https://codereview.chromium.org/714933002

git-svn-id: svn://svn.chromium.org/blink/trunk@185144 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make clear that imageLoader is potentially constructing the
ImageLoader by renaming to ensureImageLoader. Also rename
hasImageLoader to imageLoader and make it return a pointer,
so it can be used both to check if the ImageLoader is created
as well as use it if not null.

http://trac.webkit.org/changeset/175764

Review URL: https://codereview.chromium.org/715633005

git-svn-id: svn://svn.chromium.org/blink/trunk@185143 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use onmessage instead of the iframe onload event, since the test itself
triggers navigation. Depending on the timing, the iframe onload handler
may run more than once.

BUG=381464

Review URL: https://codereview.chromium.org/713453003

git-svn-id: svn://svn.chromium.org/blink/trunk@185142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yurys, haraken, keishi, oilpan-reviews

Review URL: https://codereview.chromium.org/707273003

git-svn-id: svn://svn.chromium.org/blink/trunk@185141 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web to native app navigation transition uses Activity Transitions APIs in Android L. It requires the names and rects of transition elements. This CL gets the names and rects and pass them to TransitionRequestManager.

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit#
Demo video: https://drive.google.com/a/google.com/file/d/0B3hetueIc91Gd01DU25uT2hWU2M/view?usp=sharing
Activity Transitions in Android L: https://developer.android.com/preview/material/animations.html#transitions

================

Originally this was a 3-way patch since it involves API change in WebFrameClient.h. After the chrome side impl was committed (step 1), we found that it is better to pass struct instead of long list of params. So this turns out to be a 5-way patch.

Here are the 5 steps:
1. Chrome side - save the data (https://codereview.chromium.org/652283002/).
2. Blink side - getting the data and introduce struct WebTransitionElementData, but still using long list of params (this CL).
3. Chrome side - implement the API with WebTransitionElementData (https://codereview.chromium.org/679813003/).
4. Blink side - remove old APIs that use long list of params and start to use new API with WebTransitionElementData.
5. Chrome side - remove redundent implmentations of the old APIs.


BUG=370696

Review URL: https://codereview.chromium.org/654953002

git-svn-id: svn://svn.chromium.org/blink/trunk@185140 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yhirano

Review URL: https://codereview.chromium.org/714153003

git-svn-id: svn://svn.chromium.org/blink/trunk@185139 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185129

BUG=377845
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/707753007

git-svn-id: svn://svn.chromium.org/blink/trunk@185138 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8PerIsolateData cannot own IDBPendingTransactionMonitor, because
IDBPendingTransactionMonitor is defined in modules/indexeddb and
V8PerIsolateData is defined in bindings/core. Replace the monitor
entirely by having IDBTransactions register tasks to be run once
the scopes are unwound.

BUG=358074
R=haraken,tasak,adamk

Review URL: https://codereview.chromium.org/686153003

git-svn-id: svn://svn.chromium.org/blink/trunk@185137 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a partial interface in modules extends an interface in core and uses
any union types, the generated bindings/modules/v8/V8*Partial.cpp file
needs to include UnionTypesModules.h. This did not happen, since use of
union types was only tracked per main (non-partial) interface.

BUG=240176

Review URL: https://codereview.chromium.org/684653009

git-svn-id: svn://svn.chromium.org/blink/trunk@185136 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=401424

Requires https://codereview.chromium.org/677073002

Review URL: https://codereview.chromium.org/676003002

git-svn-id: svn://svn.chromium.org/blink/trunk@185135 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reduces the number of targets that have to be built when changing the
status of a runtime-enabled feature dramatically (for content_shell, from
1229 to 44), because these changes only affect the source file and not the
header.

In such cases, ninja notices when the modification time is left alone, and
it can propagate this "clean" (not changed) state to dependent targets.

Review URL: https://codereview.chromium.org/688443007

git-svn-id: svn://svn.chromium.org/blink/trunk@185134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the only internal usage of DOMImplementation::hasFeature(), and
the only way that svg:requiredFeatures is observable, other than the
it->isEmpty() case.

If usage is low, DOMImplementation.hasFeature() and this internal usage
can be changed together, see
https://groups.google.com/a/chromium.org/d/msg/blink-dev/r2aARnIHG4k/_dN33g65mYgJ

Review URL: https://codereview.chromium.org/712813002

git-svn-id: svn://svn.chromium.org/blink/trunk@185133 bbb929c8-8fbe-4397-9dbb-9b2b20218538