GitLab

Rather than a list of parameters, PasswordCredential is defined[1] to
take a PasswordCredentialData object. We defined that object long ago
(in [2]), but apparently never actually used it. This patch fixes that
oversight.

As a drive-by, this patch also stops exposing the PasswordCredential
and FederatedCredential to Workers, as per spec.

[1]: https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-credential-types-passwordcredential
[2]: https://codereview.chromium.org/1162883002

BUG=494880

Review URL: https://codereview.chromium.org/1314673007

git-svn-id: svn://svn.chromium.org/blink/trunk@201723 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScriptRunIterator takes a pointer to a UTF-16 text run, and a starting
script value, then consume() can be called on it to retrieve the limit
and script value of the next segmented script run. It takes care of
matching brackets when resolving script runs.

This functionality is needed for changing HarfBuzzShaper.cpp so that
we do not need to pre-split and store the TextRun into HarfBuzzRuns.
We can improve our script segmentation and integrate script splitting
and shaping in one loop.

Original code written by Doug Felt, big thanks!

BUG=526095
R=eae,behdad

Review URL: https://codereview.chromium.org/1323513006

git-svn-id: svn://svn.chromium.org/blink/trunk@201722 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
R=fs@opera.com

Review URL: https://codereview.chromium.org/1328723004

git-svn-id: svn://svn.chromium.org/blink/trunk@201721 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A partition page is not ‘typically’ 16 kB, it is always defined to be 16 kB.
Also drive-by fixes for line wrapping and typos.

Review URL: https://codereview.chromium.org/1323093004

git-svn-id: svn://svn.chromium.org/blink/trunk@201720 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See: https://codereview.chromium.org/1308033003

BUG=522797
TBR=jbroman
NOTRY=true

Review URL: https://codereview.chromium.org/1319023004

git-svn-id: svn://svn.chromium.org/blink/trunk@201719 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=524134, 522797
TBR=wangxianzhu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1314843011

git-svn-id: svn://svn.chromium.org/blink/trunk@201718 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r201698 forgot to change one RefPtrWillBeRawPtr<AnimatableColor> to RefPtr<AnimatableColor>.
This caused a couple of crashes in oilpan builds.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20%28dbg%29/builds/3869

BUG=
TBR=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1302233010 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201717 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527743
NOTRY=true
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/1317013004

git-svn-id: svn://svn.chromium.org/blink/trunk@201716 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r201633 shipped oilpan for core/animations/, but I removed !ENABLE(OILPAN) code too much.
Some of them shouldn't be removed until we ship Oilpan for the Node hierarchy.

This CL recovers the code to clear KeyFrameEffect::m_target when the target Element gets destructed.

BUG=527520

Review URL: https://codereview.chromium.org/1322883003

git-svn-id: svn://svn.chromium.org/blink/trunk@201715 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Opaque FormData objects created from 'PasswordCredential::toFormData()'
need to persist their opacity through to Request objects, as defined in
https://w3c.github.io/webappsec/specs/credentialmanagement/#opaque-formdata-algorithms

This patch adjusts 'RequestInit', 'Body', and 'Request' such that opaque
'FormData' bodies lead to opaque 'Body' objects that reject read
attempts from JavaScript.

BUG=526995

Review URL: https://codereview.chromium.org/1305183009

git-svn-id: svn://svn.chromium.org/blink/trunk@201714 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TimingFunction is off-heap, so it's just wrong to use WillBe types.
This CL removes them.

BUG=

Review URL: https://codereview.chromium.org/1305063007

git-svn-id: svn://svn.chromium.org/blink/trunk@201713 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes CSSStyleSheet::insertRule to respect the default
namespace a stylesheet. The default namespace is currently only stored
during initial parsing of a stylesheet, so this moves the value to be
stored on the StyleSheetContents. This is stored separately to the rest
of the namespaces to avoid an extra hash map lookup, but could probably
be added to the m_namespaces map keyed off a null AtomicString.

The added test passes in FF and IE, but fails in Safari.

Review URL: https://codereview.chromium.org/1322543004

git-svn-id: svn://svn.chromium.org/blink/trunk@201712 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For the same runtime enabled flag, the constant configuration installation should be
moved into a single |if| block instead of multiple blocks.

This patch also reduces the size of .text segment of 
libmodules.so by ~4k (component build on linux 64bit)

R=haraken

BUG=469961

Review URL: https://codereview.chromium.org/1329653003

git-svn-id: svn://svn.chromium.org/blink/trunk@201710 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of redundant |using| statements in "VisibleUnit.cpp"
for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1305973006

git-svn-id: svn://svn.chromium.org/blink/trunk@201709 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes |previousBoundary()| to use |Position::afterNode()| instead
of |Range| object to avoid registering temporary |Range| object to |Document|
and as a preparation of |previousBoundary()| to work on composed tree by
templatization.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=388681, 513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1307233006

git-svn-id: svn://svn.chromium.org/blink/trunk@201708 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=527054
NOTRY=true

Review URL: https://codereview.chromium.org/1308053007

git-svn-id: svn://svn.chromium.org/blink/trunk@201707 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I have already subscribed to the blink-reviews-bindings mailing list.

TBR=haraken

NOTRY=true

Review URL: https://codereview.chromium.org/1308053008

git-svn-id: svn://svn.chromium.org/blink/trunk@201706 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=chromium::527009
LOG=n
R=machenbach@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1317713005

git-svn-id: svn://svn.chromium.org/blink/trunk@201705 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the Layout Test that refers to crrev.com/1325803002. This 
patch applies skew on both axes together rather than calling 
skewX(angle_x) and skewX(angle_Y) sequentially.

BUG=268468

Review URL: https://codereview.chromium.org/1315973003

git-svn-id: svn://svn.chromium.org/blink/trunk@201704 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes |nextBoundary()| to use |lastPositionInNode()| instead of
|RangeBoundaryPoint::setToEndNode()| as preparation of making |nextBoundary()|
to work on composed tree, since |Position| class is templatzied to support
composed tree but |RangeBoundaryPoint| isn't.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1321133003

git-svn-id: svn://svn.chromium.org/blink/trunk@201703 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The changes include
1) Refactoring HTMLTextFormControlElement to have an explicit visible placeholder state.
2) Adding support for :placeholder-shown pseudo class
Taken reference from webkit: trac.webkit.org/changeset/172826

BUG=451120

Review URL: https://codereview.chromium.org/1280423002

git-svn-id: svn://svn.chromium.org/blink/trunk@201702 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- modified: modules/gamepad, geofencing, geolocation, indexeddb, mediasession, mediastream,
  navigatorcontentutils, permissions, presentation, push_messaging, quota, screen_orientation,
  serviceworkers, speech, storage, vibration, vr, webaudio, webdatabase, webmidi, websockets,
  and platform/audio.

- Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
  instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1318793005

git-svn-id: svn://svn.chromium.org/blink/trunk@201701 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1330573002

git-svn-id: svn://svn.chromium.org/blink/trunk@201700 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We decided to unship oilpan from temporary animation objects
(i.e., AnimatableValues, InterpoableValues, Interpolations and its associated objects) for the following reasons:

- The balls_css_properties_* benchmarks allocate an incredible number of AnimatableValues & InterpolableValues.
If we put those temporary objects on Oilpan's heap, they add a significant pressure on the heap.

- There is no advantage in putting those temporary objects on Oilpan's heap because their lifetime is very clear.

- I have tried a bunch of approaches to resolve the regression but concluded that we won't be able to resolve the regression
without introducing an incremental marking or/and a generational GC to Oilpan. I don't think that
the engineering cost and the complexity outweighs the benefit. At the very least, it won't be a task of Oilpan v1.

c.f., we already shipped oilpan for other animation objects (https://codereview.chromium.org/1318543009/).

For more details, see this thread: https://groups.google.com/a/chromium.org/d/topic/oilpan-reviews/V7d-7o4AbeA/discussion

BUG=340522

Review URL: https://codereview.chromium.org/1276183004

git-svn-id: svn://svn.chromium.org/blink/trunk@201698 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1308383007

git-svn-id: svn://svn.chromium.org/blink/trunk@201696 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There does not seem to be a reason to use implicit for the 'auto' initial
value. Also this way we can simplify the logic somewhat.

BUG=471917

Review URL: https://codereview.chromium.org/1311503006

git-svn-id: svn://svn.chromium.org/blink/trunk@201695 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is to allow invalidation during painting which is needed by paint
offset change detection during painting.

BUG=410097

Review URL: https://codereview.chromium.org/1315303007

git-svn-id: svn://svn.chromium.org/blink/trunk@201694 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is just a consolidation. No observed bug.

Non-cacheable display items might use different early return policy
during painting and make clientCacheIsValid true even if there is no
cached cacheable display items.

Review URL: https://codereview.chromium.org/1323253002

git-svn-id: svn://svn.chromium.org/blink/trunk@201692 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1317743006

git-svn-id: svn://svn.chromium.org/blink/trunk@201691 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently absent from specifications and seeing very low usage. We can
restore this functionality in the future un-prefixed if/when it's
clarified in a spec.

Usage: 0.0221%

Intent To Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/rKDXtqvgDv4/1Q5ByQllDAAJ

BUG=522215

Review URL: https://codereview.chromium.org/1328673003

git-svn-id: svn://svn.chromium.org/blink/trunk@201690 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=527611

Review URL: https://codereview.chromium.org/1327903003

git-svn-id: svn://svn.chromium.org/blink/trunk@201689 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=526826

Review URL: https://codereview.chromium.org/1326053002

git-svn-id: svn://svn.chromium.org/blink/trunk@201688 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=483272

Review URL: https://codereview.chromium.org/1328723003

git-svn-id: svn://svn.chromium.org/blink/trunk@201687 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1305343003

git-svn-id: svn://svn.chromium.org/blink/trunk@201686 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of DevTools: [security] open certificate viewer from devtools security overview (blink) (patchset #3 id:40001 of https://codereview.chromium.org/1327593003/ )

Reason for revert:
Broke the front_end compilation.

Original issue's description:
> DevTools: [security] open certificate viewer from devtools security overview (blink)
> 
> BUG=506468
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201676

TBR=lgarron@chromium.org,dgozman@chromium.org,estark@chromium.org,pfeldman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=506468

Review URL: https://codereview.chromium.org/1318003004

git-svn-id: svn://svn.chromium.org/blink/trunk@201685 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The assertion failure occurs in the following sequence:
- Out-of-order matching to n-th item;
- Synchronized matching to (n+m)-th item;
- Out-of-order matching to (n-k)-th item;
- Out-of-order matching to (n+m+l)-th.

The problem is that we only update nextItemToIndex during out-of-order
matching, but not during synchronized matching, causing we tried to
index already copied items (n to n+m).

BUG=526590
TEST=DisplayItemListTest.OutOfOrderNoCrash

Review URL: https://codereview.chromium.org/1307653007

git-svn-id: svn://svn.chromium.org/blink/trunk@201684 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change fixes several issues with tooltip UI:
 - Fixes overflow issue regressed in https://codereview.chromium.org/1300743002
 - Displays media queries tooltips on top and under the cursor instead of left
   aligned.
 - Closes tooltips when the mouse leaves devtools
 - Closes tooltips on any keyboard press
 - Aligns tooltips for palette colors above the anchor

This change also changes the default behaviour of tooltips to track the cursor except when used in the toolbars (buttons/labels).

BUG=525721,525609,521200,524371,526936,526972

Review URL: https://codereview.chromium.org/1318903007

git-svn-id: svn://svn.chromium.org/blink/trunk@201683 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=501896

Review URL: https://codereview.chromium.org/1317913004

git-svn-id: svn://svn.chromium.org/blink/trunk@201681 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When tying floats in a block-flow to the last linebox stop when we hit a float that sits
in clean lines in the block-flow.

BUG=492918

Review URL: https://codereview.chromium.org/1306733003

git-svn-id: svn://svn.chromium.org/blink/trunk@201680 bbb929c8-8fbe-4397-9dbb-9b2b20218538

validateTexFuncLevel is called twice from validateTexFunc and
validateTexFuncParameters. Move validateTexFuncLevel out of
validateTexFuncParameters.

BUG=295792

Review URL: https://codereview.chromium.org/1326653002

git-svn-id: svn://svn.chromium.org/blink/trunk@201679 bbb929c8-8fbe-4397-9dbb-9b2b20218538