- 21 Mar, 2018 40 commits
-
-
Aleks Totic authored
I had to update bad expectations for several files. New expectations match Legacy. Bug: 728378 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I64c10c269dd38f55a707cb7a0135f9f3a1207b97 Reviewed-on: https://chromium-review.googlesource.com/971465Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#544643}
-
Andre Goddard Rosa authored
There were unused typedefs and they also don't improve legibility of the code. While at it, in the Ozone case, rename |cursors_| for |image_cursors_| that states what the map holds, similarly to how it's implemented in X11. Change-Id: Id5a58cf106a2c7dcf24e1c66e3603626bac897b7 Reviewed-on: https://chromium-review.googlesource.com/967376Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Andre Goddard Rosa <andre.rosa@lge.com> Cr-Commit-Position: refs/heads/master@{#544642}
-
Koji Ishii authored
This patch fixes lines after ::first-line to use correct styles and line metrics. NGInlineLayoutAlgorithm keeps track of the style and text metrics of the current tag in NGInlineBoxStateStack. This stack is kept alive in NGInlineBreakToken and cloned for the next line. When the previous line had ::first-line style, styles and text metrics in the stack may be different. This patch rebuilds the stack in such case. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I185bba37fc9844e131ec7a65f43347b6ee2ac7b1 Reviewed-on: https://chromium-review.googlesource.com/972221 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#544641}
-
Yuly Novikov authored
Also in roll scripts TBR=kbr@chromium.org TBR=sky@chromium.org BUG=731979 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic160cb4fab54d32647da0df364891aa670cdaa65 Reviewed-on: https://chromium-review.googlesource.com/972634Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#544640}
-
Zhongyi Shi authored
Change-Id: I08f31c0bf1414720ce72302411d1d57fd0aa512e Reviewed-on: https://chromium-review.googlesource.com/972357Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544639}
-
Chirantan Ekbote authored
Add labels for the VM events that are reported via the CrOSEvent histogram. BUG=none Signed-off-by:
Chirantan Ekbote <chirantan@chromium.org> Change-Id: I94fa2f83e0c2d7829f458340f8eb3998493fe410 Reviewed-on: https://chromium-review.googlesource.com/972549Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#544638}
-
Chris Harrelson authored
Currently, the overflow clip of these layers is not applied. This can lead to an overly large interest rect, in case when the overflow clip is significantly smaller than the clip of the root frame. This CL also makes regular box scrollers have the same behavior as composited LayoutViews. The latter receive the clip due to special logic in LayoutView::MapToVisualRectInAncestorSpaceInternal that intersects with the ViewRect. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1a585d0a69e2dbd82ecc515ea0782fea6f651d4b Reviewed-on: https://chromium-review.googlesource.com/967870 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544637}
-
Christopher Lam authored
Bug: 707014 Change-Id: I5905904fe6b752129881a45453643fef9a8ed3b4 Reviewed-on: https://chromium-review.googlesource.com/954623Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#544636}
-
Pavel Feldman authored
Change-Id: I7478de0cf171d84b7cc6f335e772650ac62799bd Reviewed-on: https://chromium-review.googlesource.com/972200Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544635}
-
Devlin Cronin authored
Manifest v1 extensions did not have any forced CSP, whereas manifest v2 extensions do. Remove the special handling for manifest v1 extensions, so that all loaded extensions are given a CSP. Update a number of tests that needed to be changed because of inline JS (pulling the script out the a separate JS file). In the case of chrome/test/data/extensions/autoupdate and chrome/test/data/extensions/install, also remove the .crx versions where they were simply packed versions of the others, and instead pack th extension in the test to make future changes easier. Leave autoupdate/v3.crx, which is (deliberately) packaged incorrectly (to test error handling). Also remove unneeded "toolstrip.html" file references from these tests. Bug: 816677 Change-Id: I3ee9930007d6674b0cdf31999fd7a1612ef3cfee Reviewed-on: https://chromium-review.googlesource.com/953175Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544634}
-
https://chromium.googlesource.com/angle/angle.git/+log/427071ea307a..b2c60b1a1950 $ git log 427071ea3..b2c60b1a1 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 ynovikov cq.cfg: equivalent_to to 100% for Android tryservers. 2018-03-01 ynovikov Rename vulkan_loader to libvulkan Created with: roll-dep src/third_party/angle BUG=chromium:731958,chromium:759301 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I0a951e66d97503d0726099273d6251dee4366bff Reviewed-on: https://chromium-review.googlesource.com/972637 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544633}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d77b019f. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14275 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor TBR=kereliuk No-Export: true Change-Id: Iea0ce05ee67ac6888be51fddef68474b5f0d2656 Reviewed-on: https://chromium-review.googlesource.com/972614 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#544632}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c88bd16..0ddc6a12 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I84cc80e7b62912bd423e850c1d2ccc1928cf0b8c Reviewed-on: https://chromium-review.googlesource.com/972564Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544631}
-
Emil A Eklund authored
Refactor the NGInlineItemsBuilder class to make it easier to understand, maintain, and use. Removes the is_svg_text_ field which changes behavior of the append method and wasn't tested. Instead that logic is now in the append method itself. Also renames methods for consistency. No CamelCase for whitespace and newline to match other uses and the style enum value. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I40ca62c7b726720dda01bf61cc4191fba4c552a0 Reviewed-on: https://chromium-review.googlesource.com/972589 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iac4ca741dea1e3682e16696b4f3eefad4c11494f Reviewed-on: https://chromium-review.googlesource.com/972639Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#544629}
-
https://skia.googlesource.com/skia.git/+log/5c4b33bce10b..ba7b7abda177 $ git log 5c4b33bce..ba7b7abda --date=short --no-merges --format='%ad %ae %s' 2018-03-20 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b391ec408..427071ea3 (3 commits) 2018-03-20 benjaminwagner Switch to new NVIDIA drivers on Win2k8 Golo bots. Created with: roll-dep src/third_party/skia BUG=chromium:823867 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Iea377f0adbab2a8b69d060e0753e1970245572bd Reviewed-on: https://chromium-review.googlesource.com/972569 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544628}
-
https://pdfium.googlesource.com/pdfium.git/+log/2e6405c333d8..40d37b1a8077 $ git log 2e6405c33..40d37b1a8 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 thestig Rename "RGB" methods/variables to "ColorRef" in CPDF_ColorState. 2018-03-20 thestig Simplify code in CPDF_TextPage. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I41fe0426a7d38309ea11edf7ef16d82041ceab35 Reviewed-on: https://chromium-review.googlesource.com/972432Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544627}
-
Eugene But authored
This is an existing action logged for the Old Download Manager which is already defined in a private repository. This CL adds action to actions.xml. MobileDownloadRetryDownload will be removed from private repository in a separate CL. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5e4d8d057e245bd8c89471a46e0db4f0c4c93614 Reviewed-on: https://chromium-review.googlesource.com/965241 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#544626}
-
Yuichiro Hanada authored
The build target is used to separate dependency to //contents in ui/keyboard, but that dependency was removed. We don't have any reason to have the separate build target anymore. This CL does: - Remove 'keyboard_with_content" build target. - Merge files in ui/keyboard/content into ui/keyboard/keyboard_resource_util. - Remove redundant includes. Test: Unit tests pass. Bug: None Change-Id: Ibdb47c4c170381da28f4aaad8cc606dbaab9f687 Reviewed-on: https://chromium-review.googlesource.com/970102 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#544625}
-
Philip Rogers authored
This patch extracts out the existing root scroll compositing logic into CompositingReasonFinder::RequiresCompositingForRootScroller and uses it for SPV2. This fixes a bug where the document was not scrollable with the mousewheel when --enable-slimming-paint-v2 was used. This layout test now passes: background-paint-into-scrolling-contents-layer-with-root-layer-scrolls-offset.html Although there are spv2 differences, these look to be newly passing: paint/invalidation/scroll/outline-change-scrollable.html paint/invalidation/outline/outline-change-vertical-rl.html This layout test now shows a failure: paint/invalidation/reflection/scroll-absolute-layer-with-reflection.html These tests had minor pixel differences: fast/css/sticky/sticky-both-sides-top-left-constrained.html fast/dom/scroll-reveal-top-overflow.html fast/css/sticky/sticky-overflowing.html fast/overflow/overflow_hidden.html fast/css/sticky/sticky-vertically-overconstrained.html fast/dom/scroll-reveal-left-overflow.html fast/writing-mode/border-radius-clipping-vertical-lr.html Bug: 693741 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I467008ac569ce1dd998caba7689c50b91d3687e4 Reviewed-on: https://chromium-review.googlesource.com/968983Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544624}
-
Sorin Jianu authored
An UpdateContext is looked up by its session id. TBR: waffles Bug: 822990 Change-Id: I0fb88ad98272082a725e1cd74bbc2fa4303e75fc Reviewed-on: https://chromium-review.googlesource.com/971262Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544623}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0b89935ad6fe..6f64a0522bb8 $ git log 0b89935ad..6f64a0522 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 ehmaldonado Reland "gclient: Add commands to edit dependencies and variables in DEPS" 2018-03-20 jbudorick [gclient] Use a single CIPD root for an entire gclient checkout. 2018-03-19 thestig Add debugging info when gclient deletes an old DEPS entry. 2018-03-19 thestig Remove nested ifs in GClientSmokeBase.splitBlock(). Created with: roll-dep src/third_party/depot_tools BUG=chromium:760633,chromium:755920,chromium:823586 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4a24b063813215bfa046139f4241bd8723063137 Reviewed-on: https://chromium-review.googlesource.com/972434 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544622}
-
Pavel Feldman authored
Bug: 747349 Change-Id: I4569b4107536ed02038c2b736a30dd93cf977fce Reviewed-on: https://chromium-review.googlesource.com/972451Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544621}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ceb1b20c4313..ca08cc1b0773 $ git log ceb1b20c4..ca08cc1b0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:None The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7e2f5817e38b027e970829b1abee64d079f849cf Reviewed-on: https://chromium-review.googlesource.com/972441Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544620}
-
Ella Ge authored
This CL changes WebGestureEvent coordinates to private and float to match other Web* class e.g. WebMouseEvent. x, y -> position_in_widget_ global_x, global_y -> position_in_screen_ This also changes source_device to private source_device_. Add set source_device_ in constructor, and add setter and getter. SetSourceDevice will be eliminated in future CL (should be set in constructor) Bug: 817104 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iea504fdf4ef1c66610e221343031a6b0f38e7a04 Reviewed-on: https://chromium-review.googlesource.com/953655Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#544619}
-
Pavel Feldman authored
Change-Id: I63cb8763ff40bb86aa70200c387aa2b376dfd41f Reviewed-on: https://chromium-review.googlesource.com/972577Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544618}
-
agrieve authored
This reverts commit be9a5dbb. Reason for revert: Broke resources on Monochrome Original change's description: > android build: Split process_resources GN rule and script. > > This is a reland of [1] which got reverted in [2] because the > former actual broke the internal official build of Clank. > > It turns out that instead of removing |app_as_shared_library = true|, > for the monochrome apk template, it should be turned into > |shared_resources = true|. > > Apart from that, see description of the change in the original > CL, everything still applies. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/957095 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/968461 > > R=agrieve@chromium.org,yfriedman@chromium.org,estevenson@chromium.org,trevordixon@chromium.org > > Bug: 820459 > Change-Id: I6f6e71c3a13a388c67b68b684c733cd549a2cef0 > Reviewed-on: https://chromium-review.googlesource.com/968870 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: David Turner <digit@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544300} TBR=digit@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,estevenson@chromium.org,trevordixon@chromium.org Change-Id: I2906cc84ab3bf07504a5de6846ec4a747a4f92fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820459, 820591 Reviewed-on: https://chromium-review.googlesource.com/972632Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544617}
-
Charles Harrison authored
This experiment is enabled by default in M67. R=isherman@chromium.org Bug: None Change-Id: Idde157787802913ee57932d1836be9622f7fde5c Reviewed-on: https://chromium-review.googlesource.com/972371Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544616}
-
Xing Liu authored
This CL adds a few download data into in InProgressCache, including custom http request headers, so they will be used in download resumption. Also fixes issues related to InProgressCache. Bug: 817871 Change-Id: Ib21adb630e0abb59c95b2244a56f443077206172 Reviewed-on: https://chromium-review.googlesource.com/967076 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#544615}
-
Khushal authored
Since we don't analyze or decode images in PaintFilters in cc, they completely skip our image decode and animation stack. This change ensures that we analyze images in these cases to track their invalidation rects and register them with the animation system, and creates a snaphot of the filter, if it has an animated image, during raster. This ensures we use the correct frame for this image. Since its not performant to re-create the filter graph for every raster, the change is restricted to filters with animated images. In addition, since its not easy to figure out the final scale for these images, we decode them at the original size. This also (hopefully) ties the last loose end where an image in a paint recording could be skipped in cc. R=chrishtr@chromium.org, enne@chromium.org Bug: 821031 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I4a0ecb1c6dff8b816861ffbcf68bdd2cd5aa5973 Reviewed-on: https://chromium-review.googlesource.com/965442Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#544614}
-
Becky Zhou authored
Bug: 821462 Change-Id: I35159f00ec55c97a89caef1802edcdfe42e4963c Reviewed-on: https://chromium-review.googlesource.com/972190Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#544613}
-
Antoine Labour authored
It returns GLuint, not void. Bug: 786591 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5d684c194d121cc0924ee25e377e49e18178cde4 Reviewed-on: https://chromium-review.googlesource.com/967568Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544612}
-
Jiaquan He authored
This commit moves those data structures shared between Chrome and Ash from SearchResult to ash/public/cpp/app_list/app_list_types, creates corresponding mojo structures, and type-maps them. Bug: 733662 Change-Id: I5af815ee789b2b9d4653689fbc619733a57e7801 Reviewed-on: https://chromium-review.googlesource.com/965922 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Justin Cohen authored
Adds new enum for when remote suggestions are collapsed. Bug: 805638 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5c2c1f851a116885b36c08fc334e0deef5a759cb Reviewed-on: https://chromium-review.googlesource.com/971023Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
This is a quick followup to r540997 to move initialization of RenderFrameHostImpl's discarded state a bit later in the commit process, once we know that the commit will be successful. This will prevent updating wasDiscarded if the commit fails, for example due to failing ValidateDidCommitParams or a couple of other cases in RenderFrameHostImpl::DidCommitProvisionalLoad(). Bug: 816454 Change-Id: Ib1a1a9ef562c8ea74f001d08eeb26220a0a791bf Reviewed-on: https://chromium-review.googlesource.com/952572Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#544609}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b84994071091..6792b856916a $ git log b84994071..6792b8569 --date=short --no-merges --format='%ad %ae %s' 2018-03-15 dgarrett chromeos_config: incremental, full, informational use -tryjob. Created with: roll-dep src/third_party/chromite BUG=chromium:822491 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If98ccbaf2fcc549dd8892a259163e1f81dbcf762 Reviewed-on: https://chromium-review.googlesource.com/972164 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544608}
-
Christopher Cameron authored
The patch that fixed this for the zoom-for-DSF mode broke the non-zoom-for-DSF mode. There exists a fear that this patch just returns to a "one miscalculation cancels another" state that we were in before. This in effect reverts crrev.com/541923 for non-zoom-for-DSF. Bug: 822252 Change-Id: I60b3fc01296bb8dfe248a508c7b36d5f00e55726 Reviewed-on: https://chromium-review.googlesource.com/972324 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544607}
-
Andrey Lushnikov authored
This patch teaches Persistence2 to bind against original contents instead of working copies. As a result, not saving CSS files and consequently reloading the page doesn't affect the binding status. R=dgozman, einbinder Change-Id: Ied08a4ddfc6760b52b2386d5ffa31f939d672dc7 Reviewed-on: https://chromium-review.googlesource.com/969748 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
-
chrome://inspectDmitry Gozman authored
Bug: 822352 Change-Id: Ib6fbf66930ef919c421cc1d2f59ac9ffae9b4844 Reviewed-on: https://chromium-review.googlesource.com/972326 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544605}
-
Justin Novosad authored
A number of rendering glitches have been reported after landing https://chromium-review.googlesource.com/924616 I have not been able to reproduce any of these bugs using the hardware at my disposal. However, by inspecting the screenshots and other data provided in the bug reports, I've ascertained that the cause is probably a stale texture binding or a stale frame buffer binding. Therefore, a likely cause is the under-invalidation of skia's GL state. After a thorough manual review. I've found additional API entry points that need to report state invalidations, which were not handled in the CL that caused the regression (asuming it is indeed the cause). Because I was not able to reproduce the bugs, I don't know which call sites and which OpenGL entry points are to blame, and I am unable to verify whether this fixes the bugs in question. Will have to rely on Canary channel users and test engineers for verification. BUG=823608,823232,823209 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I67615825e87573674a2b93e4c9dd5017115d7c1c Reviewed-on: https://chromium-review.googlesource.com/972141Reviewed-by:
-
