- 18 Nov, 2018 1 commit
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8efc4410d6eb..3cddf133cdf5 Created with: gclient setdep -r src-internal@3cddf133cdf5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1cf299c9d86d90fd06b2fa5957af5f7d9d36af9b Reviewed-on: https://chromium-review.googlesource.com/c/1341276Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609125}
-
- 17 Nov, 2018 39 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a5eb7896cf05..8efc4410d6eb Created with: gclient setdep -r src-internal@8efc4410d6eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie57f602303ed51bb11f163f8d7b6e0e78ab1f30b Reviewed-on: https://chromium-review.googlesource.com/c/1341274Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/73b4a1f57254..7e9ea391cfce git log 73b4a1f57254..7e9ea391cfce --date=short --no-merges --format='%ad %ae %s' 2018-11-17 herb@google.com Have the SDF MaskFilter convert LCD16 to a distance field. Created with: gclient setdep -r src/third_party/skia@7e9ea391cfce The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I46b78ee48d065b96c02de3a9df79f6b401a5cd11 Reviewed-on: https://chromium-review.googlesource.com/c/1341271Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609123}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55b3f8b6213e..a5eb7896cf05 Created with: gclient setdep -r src-internal@a5eb7896cf05 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0e3dedb070b4bb2b14ab7d1f149576acf03567e8 Reviewed-on: https://chromium-review.googlesource.com/c/1341273Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/484e9b33f1d4..55b3f8b6213e Created with: gclient setdep -r src-internal@55b3f8b6213e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I77b1263899f60eda5178c95cc0f183036cf4d02b Reviewed-on: https://chromium-review.googlesource.com/c/1341272Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/705e4831097c..484e9b33f1d4 Created with: gclient setdep -r src-internal@484e9b33f1d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I65605aaa9552f4870d02a6d494669ff34fc8e4b0 Reviewed-on: https://chromium-review.googlesource.com/c/1341270Reviewed-by:
-
Koji Ishii authored
This patch normalizes Katakana to Hiragana in ScriptData, and thus in ScriptRunIterator. There are 3 ICU script code for kana; USCRIPT_HIRAGANA, USCRIPT_KATAKANA, and USCRIPT_KATAKANA_OR_HIRAGANA. However, OpenType has only one 'kana' for all these 3 script codes. When shaping, HarfBuzz handles the normalization. However, Blink splits the incoming string by the ICU scripts. Splitting these 3 scripts is not useful but consumes CPU and memory. By normalizing in ScriptRunIterator, all types of Kana are in single run. timeToFirstContentfulPaint:layout shows ~3% improvements https://pinpoint-dot-chromeperf.appspot.com/job/10d9760fe40000 though bink_perf.layout does not show much differences https://pinpoint-dot-chromeperf.appspot.com/job/14f19c00140000 This is probably because Katakana characters are not used much in `japanese-kokoro-insert` (written in ~100 years ago,) while they are more used in modern pages. Bug: 636993 Change-Id: If692bb575f2232b8fca10cd2ea87e3022debdf05 Reviewed-on: https://chromium-review.googlesource.com/c/1337650 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#609119}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e84bc3d. With Chromium commits locally applied on WPT: c852d472 "Implement RTCQuicStream.waitForReadable()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic2fb1f70457d958b849c8936c4dd1bd025548d60 Reviewed-on: https://chromium-review.googlesource.com/c/1341138 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609118}
-
Anna Malova authored
Bug: 885099 Change-Id: If444f4cf341c83647bd126d2519ff8cedb8da621 Reviewed-on: https://chromium-review.googlesource.com/c/1340002 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609117}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4663df42f5be..705e4831097c Created with: gclient setdep -r src-internal@705e4831097c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iccca2e1ccfd108123e973489bb7cbfd1401ac9d0 Reviewed-on: https://chromium-review.googlesource.com/c/1341269Reviewed-by:
-
Marcin Wiacek authored
@IntDef annotation are preferred way for declaring set of int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is replacing ChipStyle enum to the style common with other @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface Change-Id: I19e43717e9ddf46efc3978d25ed2f2d698a204d8 Reviewed-on: https://chromium-review.googlesource.com/c/1338620 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609115}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a73c9823f6c5..4663df42f5be Created with: gclient setdep -r src-internal@4663df42f5be The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia10d366ce3dd4cfc67fdefc2da04a7444089b5a1 Reviewed-on: https://chromium-review.googlesource.com/c/1341268Reviewed-by:
-
Jamie Madill authored
Instead of setting a single global we now pass argc and argv to a handler function. Note that we must call base's command line init first for reasons similar to https://crrev.com/c/1121039 . Bug: angleproject:2923 Change-Id: I521e07a35537e5167781673564527572d70d18cf Reviewed-on: https://chromium-review.googlesource.com/c/1338228Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#609113}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7bea6d7534a2..a73c9823f6c5 Created with: gclient setdep -r src-internal@a73c9823f6c5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idc3982801bac4f4895273c346b3aaaacfc2e85eb Reviewed-on: https://chromium-review.googlesource.com/c/1341267Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/853f0d33622f..7bea6d7534a2 Created with: gclient setdep -r src-internal@7bea6d7534a2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1ea84bdf3bfa734d34d802a6c82082a96eadc679 Reviewed-on: https://chromium-review.googlesource.com/c/1341266Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium beffb276. With Chromium commits locally applied on WPT: c852d472 "Implement RTCQuicStream.waitForReadable()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I242e092e18fc94997ebd9af66441f370f464c319 Reviewed-on: https://chromium-review.googlesource.com/c/1341136 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Michael Lippautz authored
No-try: true Tbr: haraken@chromium.org Bug: 843903 Change-Id: I9a130a70247807c593f94eff112d37d043055db2 Reviewed-on: https://chromium-review.googlesource.com/c/1340278Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609109}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bdbe9da807d..853f0d33622f Created with: gclient setdep -r src-internal@853f0d33622f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6bde65eabad5fb2fa77d5bd80f27b0817c67bd21 Reviewed-on: https://chromium-review.googlesource.com/c/1341262Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b64be71a. With Chromium commits locally applied on WPT: c852d472 "Implement RTCQuicStream.waitForReadable()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I19ea354e59e84c3f1c692e9f0fdb77174e5616f7 Reviewed-on: https://chromium-review.googlesource.com/c/1341135 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ac2baab60b9e..cf927b1f0823 git log ac2baab60b9e..cf927b1f0823 --date=short --no-merges --format='%ad %ae %s' 2018-11-17 thestig@chromium.org Simplify EncodeToC40Codewords(). Created with: gclient setdep -r src/third_party/pdfium@cf927b1f0823 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iacefe91875a08b77e64fa4ce2ff3d2f489e5c676 Reviewed-on: https://chromium-review.googlesource.com/c/1341265Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b1024319521e..ac2baab60b9e git log b1024319521e..ac2baab60b9e --date=short --no-merges --format='%ad %ae %s' 2018-11-17 thestig@chromium.org Get rid of more "exceptions" in fxbarcode. Created with: gclient setdep -r src/third_party/pdfium@ac2baab60b9e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib7d0af289896b348f596e3fc55ef773afeb76952 Reviewed-on: https://chromium-review.googlesource.com/c/1341264Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e25cbbb8e5fa..73b4a1f57254 git log e25cbbb8e5fa..73b4a1f57254 --date=short --no-merges --format='%ad %ae %s' 2018-11-17 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@73b4a1f57254 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ib4b7ec10f6caf21ed7c9c1016f9a823474233cce Reviewed-on: https://chromium-review.googlesource.com/c/1341263Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7fb30f11a055..e25cbbb8e5fa git log 7fb30f11a055..e25cbbb8e5fa --date=short --no-merges --format='%ad %ae %s' 2018-11-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e4634a13a74d..778bf09deea4 (2 commits) Created with: gclient setdep -r src/third_party/skia@e25cbbb8e5fa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ic66e75d5ffa6f33de8d6b43a23cd7183caebc731 Reviewed-on: https://chromium-review.googlesource.com/c/1341261Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9bb294b67967..6bdbe9da807d Created with: gclient setdep -r src-internal@6bdbe9da807d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9f0263d7f27d6d3f05a65702616bd310fad07eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1341260Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/281224020a57..7fb30f11a055 git log 281224020a57..7fb30f11a055 --date=short --no-merges --format='%ad %ae %s' 2018-11-17 reed@google.com use font for settings Created with: gclient setdep -r src/third_party/skia@7fb30f11a055 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I12fc0ec41bf80d759e3b8be8ee8f6caf3fe57893 Reviewed-on: https://chromium-review.googlesource.com/c/1341018Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c441075c9ca9..9bb294b67967 Created with: gclient setdep -r src-internal@9bb294b67967 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id528db875a354c7e945413862fee16058de293cf Reviewed-on: https://chromium-review.googlesource.com/c/1341017Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b0273016734..a91e38e61cfb git log 8b0273016734..a91e38e61cfb --date=short --no-merges --format='%ad %ae %s' 2018-11-17 manojgupta@google.com cros_setup_toolchains: Switch aarch64 linker to gold. Created with: gclient setdep -r src/third_party/chromite@a91e38e61cfb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I24034e0a18f596314fc3a237dfc8f4b54f4559d3 Reviewed-on: https://chromium-review.googlesource.com/c/1341259Reviewed-by:
-
Jazz Xu authored
Change-Id: I7b8e4c989b0ec0d21b5620ab2ece577fc61ce11b Reviewed-on: https://chromium-review.googlesource.com/c/1336060 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609098}
-
Justin Cohen authored
This reverts commit d3708f20. Reason for revert: This is failing all over downstream: PageInfoTestCase/testShowPageInfoAndDismissOnDeviceRotation: ../../ios/chrome/browser/ui/page_info/page_info_egtest.mm:45: error: -[PageInfoTestCase testShowPageInfoAndDismissOnDeviceRotation] : Exception: AssertionFailedException It looks like when this fails, it leaves the simulator in the rotated state, and causes a bunch of other tests to fail too. Link for example of failure: https://logs.chromium.org/logs/chrome/bb/internal.bling.main/ipad11-simulator-x64/9508/+/recipes/steps/ios_chrome_ui_egtests__iPad_Air_iOS_11.4__on_Mac/0/logs/PageInfoTestCase__x2f_testShowPageInfoAndDismissOnDeviceRotation/0 Original change's description: > [ios] Create UI test for page info (site info) > > This CL creates an UI integration test that tests that the > page info view gets automatically dismissed on device rotation. > > Change-Id: I02611cc2fab5a214b74af01d15cd8d12e19eff6e > Reviewed-on: https://chromium-review.googlesource.com/c/1338561 > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608844} TBR=rohitrao@chromium.org,edchin@chromium.org,gambard@chromium.org Change-Id: I383646fb5c9be8bf8bff4dd54d2dc9d46cf14a5a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1341203Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609097}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7ca119974ac4..b1024319521e git log 7ca119974ac4..b1024319521e --date=short --no-merges --format='%ad %ae %s' 2018-11-17 tsepez@chromium.org Remove BC_Utils.cpp. Created with: gclient setdep -r src/third_party/pdfium@b1024319521e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2b70c17b0ad4b7f8324cfda68bc6926365a42358 Reviewed-on: https://chromium-review.googlesource.com/c/1341016Reviewed-by:
-
Khushal authored
We currently mark the RasterDecoderContextState dirty at all entry points where skia may have used it, except when uploading images using it during transfer cache deserialization. We should do that here too. R=enne@chromium.org, piman@chromium.org Bug: 897637 Change-Id: Ie713728eab9f33a7e14ed983e574e43e4053124c Reviewed-on: https://chromium-review.googlesource.com/c/1341141Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#609095}
-
Peter Kasting authored
This factors DefaultEventGeneratorDelegate out to a separate file and uses it in chromecast/. It also adds a default ScreenPositionClient getter to EventGeneratorDelegateAura and removes the duplicate overrides in various subclasses. Bug: none Change-Id: I449cf1c10daa4a23b197679dcb428acbbe54a52f Reviewed-on: https://chromium-review.googlesource.com/c/1338577 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#609094}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ied3dda8c811cf9978da7c402582f945733e42493 Reviewed-on: https://chromium-review.googlesource.com/c/1341202Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#609093}
-
Sunny Sachanandani authored
Bug: 869677 Change-Id: I0f5e37ef5fbb2ca8853bab98cc10f822fab274df Reviewed-on: https://chromium-review.googlesource.com/c/1340277Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#609092}
-
danakj authored
From https://crrev.com/c/1336218 R=creis@chromium.org Change-Id: Ic172b109019fad339173393e29da6870e7774fa1 Bug: 905191, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1341077Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609091}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e46c4fe. With Chromium commits locally applied on WPT: c852d472 "Implement RTCQuicStream.waitForReadable()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Id11f36d11e63f57193c8bec46175bd6dcf86333d Reviewed-on: https://chromium-review.googlesource.com/c/1341240 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Victor Vasiliev authored
Add tests for long and very long values, including the maximum supported value. Test encoding in one byte fragments as well as encoding in a single ResumeEncoding() call into a large enough buffer. Merge internal change: 215203050 R=bnc@chromium.org Change-Id: Iebb2f0ede63a84a01542a29a2d447aae0e298ad3 Reviewed-on: https://chromium-review.googlesource.com/c/1340530Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#609089}
-
rbpotter authored
In kiosk mode, the PDF printer is not available. If there are no recent destinations, no system default, and no default destinations configured, the preview will spin forever. Instead, select the first printer that is detected. Bug: 901115 Change-Id: I048a973b8c8161459f8ef724a57616fb5298f21e Reviewed-on: https://chromium-review.googlesource.com/c/1332721 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#609088}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c217842bdd51..281224020a57 git log c217842bdd51..281224020a57 --date=short --no-merges --format='%ad %ae %s' 2018-11-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@281224020a57 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I6f6bf5c29fd728e2c3ad3912db0e4a5f6eec3041 Reviewed-on: https://chromium-review.googlesource.com/c/1341013Reviewed-by:
-
iOS Autoroller authored
TBR=smut Change-Id: I6d7359d47acb175d55104777dbb53d162d0156cf Reviewed-on: https://chromium-review.googlesource.com/c/1341201Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#609086}
-
