- 18 Apr, 2018 40 commits
-
-
Kyle Horimoto authored
This CL modifies CryptAuthEnrollerImpl and CryptAuthDeviceManagerImpl to take a CryptAuthClientFactory* instead of a std::unique_ptr<CryptAuthClientFactory> in their constructors. It was unnecessary to have each class own its own instance of the factory, and this refactor will help as I add an instance of the factory to the DeviceSync service. Bug: 824568, 752273 Change-Id: Ie3818cb7d81439689e4edb60f6c024f0e5069435 Reviewed-on: https://chromium-review.googlesource.com/1017307 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551798}
-
Jonathan Backer authored
This CL makes --enable-oop-rasterization --enable-raster-decoder work on desktop linux builds of chromium. Changes: - Update raster_cmd_buffer_functions.txt with changes in gles2_cmd_buffer_functions.txt and regenerate autogen files. - Copy code from RasterImplementationGLES into RasterImplementation. - Copy code from GLES2DecoderImpl into RasterDecoderImpl Bug: 789238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia7b50acc843ecd641a8a74927d94303138849e86 Reviewed-on: https://chromium-review.googlesource.com/1011203Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#551797}
-
btolsch authored
Using only AF_INET to probe a Wifi interface that IPv6-only will fail, even though the interface is functional. This change adds an AF_INET6 check if AF_INET fails. Bug: None Change-Id: I81f9c2a2a51041597ee384804018b4de7dccc88d Reviewed-on: https://chromium-review.googlesource.com/1017344 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Adam Parker <amp@chromium.org> Cr-Commit-Position: refs/heads/master@{#551796}
-
Paul Miller authored
Context.getDir() creates Chrome's data directory, app_chrome/, with rwxrwx--x. ChromeMainDelegateAndroid::RunProcess() then limits this to rwx------. RunProcess() goes out of its way to avoid granting any user permissions that weren't already present, but this seems like a mistake; it shouldn't be possible for app_chrome/ to have fewer permissions than rwx------. So RunProcess is simplified to set the permissions to exactly rwx------. Also don't print data_path in the error message because if PathService::Get() failed, data_path is empty. Also restrict WebView's directory, app_webview/, using Os.chown(). Doing this in PathUtils covers both Chrome and WebView. However, Os.chown() requires API >= 21, which is the case for WebView but not Chrome, so Chrome's RunProcess() code must stay for now. Rehabilitate //chrome/test:chrome_app_unittests to run on Android (crbug 609855 says it was broken but it seems to work now) and add a unit test for the simplified native code. BUG=832388,609855 internal bug b/19993402 Change-Id: I1bcfe72940ddc1fb23f2b0bef50775853843ea76 Reviewed-on: https://chromium-review.googlesource.com/984773 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#551795}
-
Sigurdur Asgeirsson authored
This avoids creating a new entry in the map for each process on each cycle on Windows, which was happening as of my last change. Add a state variable to keep track of when a measurement cycle is underway in preparation for allowing measurement requests at arbitrary times. Replace the delegate class with a simple virtual function, and use protected access control in combination with a Testing* subclass to expose class' internal state for testing. This allows removing all test-specific code from the class declaration. Bug: 755840 Change-Id: I7658a355525fffe92327bb85151ba124cc81d371 Reviewed-on: https://chromium-review.googlesource.com/1015299 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#551794}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/85c75025906a..9ccad5689c09 $ git log 85c750259..9ccad5689 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 jbudorick bot_update: Ensure create_manifest ignores repos with explicit None urls. Created with: roll-dep src/third_party/depot_tools BUG=chromium:830306 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2c6e4e6659349d3360e31b8cbf94cb5fd940bca5 Reviewed-on: https://chromium-review.googlesource.com/1017381 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551793}
-
https://chromium.googlesource.com/angle/angle.git/+log/eb79e337c9f7..427064d2ac0b $ git log eb79e337c..427064d2a --date=short --no-merges --format='%ad %ae %s' 2018-04-13 jmadill Fix perf regression with checkStatus. 2018-04-10 courtneygo Vulkan: Add build toggle for validation layers. 2018-04-17 jmadill Optimize ValidateDrawAttribs: Part 2. 2018-04-16 lucferron Vulkan: Use SH_INITIALIZE_UNINITIALIZED_LOCALS in ShaderVk 2018-04-16 lucferron Vulkan: Implement depth_range dirty bit and enable tests 2018-04-16 lucferron Vulkan: Fix the issue with unused attributes / varyings 2018-04-18 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation (2nd try) 2018-04-13 oetuaho Refactor GL tests to use a shader library Created with: roll-dep src/third_party/angle BUG=chromium:822235 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I99521579232a65d62698e7c4f73aa0b697f219fc Reviewed-on: https://chromium-review.googlesource.com/1017318 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551792}
-
crystallambert@chromium.org authored
There is currently false information on Options Version 2 doc related to deprecation of options manifest registration. This update removes this language. Bug: none Change-Id: I5c8864a18dcc8dd6c01b1bd7932bfa69e6030656 Reviewed-on: https://chromium-review.googlesource.com/990934Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#551791}
-
bsheedy authored
Forces the VR bisect script to use a detached head state when determining initial values. This prevents us from accidentally dirtying the current branch if --apply-stash-before-sync is used, while also fixing an issue with --apply-stash-before-sync if both the good and bad values need to be determined where the stash application from the good run would still be around during the bad run. Change-Id: I039959a3bdd3d9fff56a32e19097b03c946c5838 Reviewed-on: https://chromium-review.googlesource.com/1017313 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551790}
-
Jun Choi authored
CTAP HID transport protocol uses 4 byte channel ID to check that the message sent by the authenticator is only received and processed by the correct client process. On the other hand, CTAP BLE transport protocol defines no such mechanism to differentiate incoming BLE fragments. This, under some circumstances, enables relying parties to receive response from authenticators that was intended for different site. In order to prevent malicious RP from receiving authenticator response intended for different site, check relying party ID hash returned from the authenticator in response to MakeCredential and GetAssertion response. Bug: 828507 Change-Id: I3b743fc9b9f79284ab4b979d17c75ccc9e5a889c Reviewed-on: https://chromium-review.googlesource.com/1004118 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551789}
-
Wez authored
We work-around shared global state in component builds of the Cronet native library by avoiding creating the AtExitManager in those builds. The condition for that is fixed here, from being based on Debug build to depending directly on whether this is a component build. The tests are also enabled on Fuchsia/Debug, where they now pass. Bug: 833401, 816705 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1401c0dcaa8e893c6cd4bcbf75f8d4d30ccd0116 Reviewed-on: https://chromium-review.googlesource.com/1014642 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#551788}
-
Doug Arnett authored
Bug: 834338 Change-Id: Id209b84b7546d9cb0c374f9779bebf6f7d20a9c5 Reviewed-on: https://chromium-review.googlesource.com/1017306Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#551787}
-
Matthew Jones authored
This change adds a TabModelSelectorObserver for the bottom sheet to observe tab model changed. If the tab model changes, the sheet is hidden. The sheet also no longer tries to peek when loading a URL since 'peek' is no longer the minimum state. This patch also includes a change to the open/close events which are now driven off of the sheet's height rather than its state. This prevents a crash where a URL is loaded and the sheet closes and immediately tries to re-peek. Bug: 832814 Change-Id: I41c88599b55a2b763dbaa94adca2117594b88f2a Reviewed-on: https://chromium-review.googlesource.com/1014712 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Florin Malita authored
SK_SUPPORT_LEGACY_A8_MASKBLITTER, for https://skia-review.googlesource.com/c/skia/+/121642 Change-Id: Id47e95cb764c526864f3af8350a546254ee1c54d Reviewed-on: https://chromium-review.googlesource.com/1016670Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#551785}
-
Ahmed Fakhry authored
This CL adds ability to set CRTC color matrix to the DisplayColorManager and combine it with whatever calibration matrix available for the respective display. This CL also optimizes DrmDevice::SetColorCorrection() and improves it for the use cases when it is only desired to set the color transform matrix without gamma/degamma. BUG=749250 TEST=ash_unittests --gtest_filter=DisplayColorManagerTest.SetDisplayColorMatrix* Change-Id: I748da11b06a8100d7fa1de8d18f00a95602d3057 Reviewed-on: https://chromium-review.googlesource.com/1013302Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551784}
-
wutao authored
This cl adds the framework to search Settings shortcuts in launcher. Changes: 1. Add feature flag to enable Settings shortcut search in launcher. 2. New class SettingsShortProvider. 3. New class SettingsShortResult. 4. New struct SettingsShortcutMetadata. Bug: 834049 Test: SettingsShortcutProviderTest.Basic and SettingsShortcutResultTest.Basic Change-Id: Ib25f2d18487b77c138b7d550ad06b6f2ac73f6c2 Reviewed-on: https://chromium-review.googlesource.com/1016128Reviewed-by:
-
Mikel Astiz authored
A common interface (AbstractSessionsSyncManager) is introduce with two implementations of session sync: 1. SessionsSyncManager (Directory-based, legacy). 2. SessionSyncBridge (USS-based, new). A feature toggle controls which of the two is used by the browser (no behavioral change by default). Bug: 681921 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8ccf7747b785134a23814a63f0e9d8ac9a47facf Reviewed-on: https://chromium-review.googlesource.com/1013522 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#551782}
-
Danyao Wang authored
Fixed broken unit test reported in crbug.com/834307 This is a reland of f1291fb3 Original change's description: > [Nav Experiment] Propagate virtual URL in ReloadWithUserAgentType. > > This hides the internal URL used by WKBasedNavigationManager to force > create an entry in WKBackForwardList when reloading with a different > user agent type (see crrev.com/c/919175). > > Also fixed a bug in NavigationManagerTest which wasn't testing the > redirect case when GetParam() == TEST_WK_BASED_NAVIGATION_MANAGER. > > Bug: 833958 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I095178302bfc4d209c2d058aab736777cc8b2de4 > Reviewed-on: https://chromium-review.googlesource.com/1016002 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551548} Bug: 833958,834307 Change-Id: I9856f340e408d92fbce934f8ae2bbddb119b066d Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1017005Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551781}
-
rbpotter authored
Add a HeaderFooter test to verify that the header footer option appears and disappears correctly for different margin and paper size settings. Migrated from tests in print_preview_tests.js. Bug: 814860 Change-Id: I18012eb26ccd261b94a88f70ef24746e872910ba Reviewed-on: https://chromium-review.googlesource.com/1013301 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551780}
-
Qiang Xu authored
Changes: This is a preparation CL. MagnificationManager could just be a concrete class. Bug: 817157 Test: compiles Change-Id: If2d1e94e2679d220df142d115eaf36c93d456b6b Reviewed-on: https://chromium-review.googlesource.com/1016321Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#551779}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/eb7c3008cc85c9cfedca7690f147f5773483f941..9f0e7cb314ae64234b928fd379381ae9760a9a5f BUG=none Change-Id: I0397a3370e57d6ba85d4d7f3162af08f693d5455 Reviewed-on: https://chromium-review.googlesource.com/1014028 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#551778}
-
Seth Hampson authored
Chrome that was previously undetected until now. This hangs on QOSCreateHandle which is created to set DSCP labels appropriately for Windows. This change disables the call being made from the P2PSocketHostUdp object, which is used in WebRTC code. UDPSocketWin: :SetDiffServCodePoint creates a hanging IO thread in Bug: 812137 Change-Id: I57a252a9f832aebcd02a9b4d6de781689c5031c0 Reviewed-on: https://chromium-review.googlesource.com/1005961 Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Taylor Brandstetter <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#551777}
-
Wez authored
This is a reland of f0acd4fc, which mistakenly replaced some EXPECT_DCHECK_DEATH() checks with EXPECT_DEATH() even though the code under test really was DCHECKing. Original change's description: > Fix SampleVector tests to expect CHECK rather than DCHECK deaths. > > Bug: 832728 > Change-Id: I9a2d2d330aa4d250c925b7a614780acbf40dce3f > Reviewed-on: https://chromium-review.googlesource.com/1012732 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551483} Bug: 832728 Change-Id: I046d3ad35a9b9b7e6d3f214029dfcfaeba81243d Reviewed-on: https://chromium-review.googlesource.com/1016861 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#551776}
-
Benjamin Pastene authored
Whoops TBR=dpranke@chromium.org Bug: 832374 Change-Id: Ib2caf7bcb5d6cc8e15312122d8cb24f6eb0ca23c Reviewed-on: https://chromium-review.googlesource.com/1015408Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Vlad Tsyrklevich authored
BUG=701919 Change-Id: I1e145f996f091a8e653190d94392119902e757b3 Reviewed-on: https://chromium-review.googlesource.com/1010836Reviewed-by:
-
Chris Hamilton authored
BUG=755840 Change-Id: I577b0f0c272d6de1debef88d088231a5f110c825 Reviewed-on: https://chromium-review.googlesource.com/1016025 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#551773}
-
Devlin Cronin authored
A crash could occur in ExternalInstallManager if an extension was unacknowledged (and thus in ExternalInstallManager::unacknowledged_ids_), had reached the maximum number of prompts (3), and hadn't had an error shown for it during the session. If this happened, the entry would remain in unacknowledged_ids_ and the extension wouldn't have an entry in shown_ids_, so that if the extension later became loaded (or another external extension was installed), the extension would no longer be present in disabled extensions in the registry. This caused a failed CHECK() in ExternalInstallManager::UpdateExternalExtensionAlert(). Fix this case by properly erasing the entry from unacknowledged_ids_ when the extension reaches the prompt count. Add a unittest to cover the case. Bug: 736292 Change-Id: If7cbf87e3a757e66930c0cfda40ed229a2e37166 Reviewed-on: https://chromium-review.googlesource.com/1012491Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551772}
-
Devlin Cronin authored
Update ExtensionTabsTest to manifest v2 and remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ib718a2169cf42c81f640780884d9a824eca63534 Reviewed-on: https://chromium-review.googlesource.com/1014716Reviewed-by:
-
liberato@chromium.org authored
Bug: 805669 Change-Id: Ibd40c7bde9f913cd3ed75f4c0aa67880716eafbe Reviewed-on: https://chromium-review.googlesource.com/1017309Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#551770}
-
https://chromium.googlesource.com/catapult.git/+log/a903f96d720c..a4264f97124c $ git log a903f96d7..a4264f971 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 nednguyen Remove PGO profiler Created with: roll-dep src/third_party/catapult BUG=chromium:713328 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I2865ddcff394972b702a750fc2fc22c54611adbf Reviewed-on: https://chromium-review.googlesource.com/1017223Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551769}
-
Koji Ishii authored
Following the CL:916262 that allowed zero-width layout opportunities, this patch allows negative-width layout opportunities (e.g., 120%-width floats.) Zero-width lines (<br> only) can fit into such opportunities. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I66cf214732a0618500f2422a285282deda4f7eb3 Reviewed-on: https://chromium-review.googlesource.com/870950 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#551768}
-
David Tseng authored
Sometimes, we get inline text boxes containing only whitespace in the middle or end of a line. This is typically fine if the whitespace is the only text. However, there are situations where we want this whitespace not to be queued. When there is non-whitespace text in the line: inLineTextBox: "this is a soft-wrap" inLineTextBox.nextOnLine: " " inLineTextBox: "of text" becomes (for the first line): "this is a soft-wrap", "space" inlineTextBox: "this" inLineTextBox.nextOnLine: " " inLineTextBox.nextOnLine.nextOnLine: "is" becomes "this", "space", "is" Test: manual. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If8524c90f4187704bbf1dcfb5580e5697eedeccf Reviewed-on: https://chromium-review.googlesource.com/1015657Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#551767}
-
Benjamin Pastene authored
Bug: 833632 Change-Id: I06da0333072b85b1b00f7954f008d39fe3689306 Reviewed-on: https://chromium-review.googlesource.com/1014639Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#551766}
-
Kevin Bailey authored
Currently we only attempt to convert history provider suggestions to tab switch suggestions. This change moves the code to autocomplete result and calls it from the controller after settling on the best matches. Also moves the unit test. Bug: 780835 Change-Id: Ide8e7998911455766b8157d6dcbf8d65d32fd179 Reviewed-on: https://chromium-review.googlesource.com/1007482 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#551765}
-
Mohsen Izadi authored
In OOP-D, there are situations that the GPU (Viz) process is run, but no GL should be initialized (when both hardware acceleration and SwiftShader are disabled). A new "disabled" value is added to --use-gl flag to convey this to the GPU process and prevent unnecessary GL initialization. BUG=799478 TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3a42ab0f72b10e9b2a7b231673ace81adef3847b Reviewed-on: https://chromium-review.googlesource.com/1014250 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551764}
-
https://skia.googlesource.com/skia.git/+log/2f54f2c31572..366fc2475261 $ git log 2f54f2c31..366fc2475 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 angle-skia-autoroll Roll third_party/externals/angle2/ c90d4d38c..5804dc8ea (2 commits) 2018-04-18 herb Simplify strike cache Node 2018-04-18 egdaniel Remove persp_shader gms from DDL blacklist Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I797d90b04da211a8686aa03ead9284902f4f9b07 Reviewed-on: https://chromium-review.googlesource.com/1017226Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551763}
-
Peter Boström authored
This adds profile icons to the toolbar avatar button that is available under Material refresh. These icons are a visible badging of the current user. It also enlarges the avatar icon to 20 dips matching the avatar menu. 16 dips was very cramped here for several built-in avatar icons as well as profile pictures. Bug: chromium:822070 Change-Id: I195fc161639cf31479bc20440b37a2eb1c3039e3 Reviewed-on: https://chromium-review.googlesource.com/1015795Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#551762}
-
Sergey Poromov authored
This function was extracting domain from username in PolicyData which could be not up-to-date after domain rename. It's better to get rid of as much |username| usages as possible. BUG=780792 TEST=Trybots Change-Id: I6aba952cb63d4450863ac7f3ee30c18a3a9830d1 Reviewed-on: https://chromium-review.googlesource.com/1017122Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551761}
-
Dmitry Skiba authored
MemoryPressureMonitor is supposed to be called only from UI thread (as defined by ThreadUtils), but was called from a binder thread by ChildProcessService$1.onMemoryPressure (see the bug). The issue was introduced because MemoryPressureMonitor.notifyPressure() is an exception from MemoryPressureMonitor "UI thread only" rule, and can be called from any thread. When onMemoryPressure() was initially added, it had just a single notifyPressure() call, so no posting to UI thread was necessary. Later getLastReportedPressure() call was added, but issue with calling it on non-UI thread was overlooked. This CL fixes the original issue, and also removes notifyPressure() special case, avoiding similar threading mistakes in the future. Bug: 834099 Change-Id: Idc5cc478eac217f2c49d642187677e9bf7a5309f Reviewed-on: https://chromium-review.googlesource.com/1016095Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#551760}
-
Hongchan Choi authored
A follow up CL from: https://chromium-review.googlesource.com/c/chromium/src/+/1015201 Bug: 833766 Change-Id: Iaabea9e2801a43257871eeee2013e91fdb0f3d20 Reviewed-on: https://chromium-review.googlesource.com/1017003Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551759}
-
