GitLab

BUG=244420
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15912008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202567 0039d316-1c4b-4281-b951-d872f2087c98

This is a revert of issue https://chromiumcodereview.appspot.com/14471033/

BUG=234231

Review URL: https://chromiumcodereview.appspot.com/15891005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202566 0039d316-1c4b-4281-b951-d872f2087c98

This was necessary prior to m27, now on stable channel.

BUG=177053

Review URL: https://chromiumcodereview.appspot.com/16000002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202564 0039d316-1c4b-4281-b951-d872f2087c98

This patch now also always calls MakeVirtuallyCurrent during initialize and
MakeCurrent, such that the next context will always restore. The context state is
restored only if the API has changed or the virtually current context has changed,
so we should never skip calling MakeVirtuallyCurrent.

BUG=241188

Review URL: https://chromiumcodereview.appspot.com/15841002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202561 0039d316-1c4b-4281-b951-d872f2087c98

There are situations like running tests where it's not necessary to run envsetup.sh.
However, build/android/pylib requires adb to be in the path.
Rather than requiring envsetup, it can be smart enough to set the path itself.

BUG=242960

Review URL: https://chromiumcodereview.appspot.com/15891002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202558 0039d316-1c4b-4281-b951-d872f2087c98

My CL  https://codereview.chromium.org/15563004 broke this test.

http://build.chromium.org/p/chromium.memory.fyi/
Failure notification for "memory test: media" on "Chromium Mac (valgrind)(1)".
Please see if the failures are related to your commit and take appropriate actions (e.g. revert, update suppressions, notify sheriff, etc.).

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%281%29/builds/20942

Revision: 202536, 202537, 202538, 202540, 202541, 202542
Blame list: eseidel@chromium.org,glider@chromium.org,henrika@chromium.org,kinuko@chromium.org,mtomasz@chromium.org,tzik@chromium.org

BUG=see details above
TEST=media_unittests --gtest_filter=AudioInputVolumeTest.InputVolumeTest* in Debug mode on device with audio hardware
R=xians@chromium.org

Review URL: https://codereview.chromium.org/15688007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222876
TBR=bruening
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/16151002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241737

Review URL: https://chromiumcodereview.appspot.com/15738020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202554 0039d316-1c4b-4281-b951-d872f2087c98

This patch aligns the gear menu's top with the horizontal line from the Files.app's window's header.

TEST=Enter Files.app, click on the gear button.
BUG=239300

Review URL: https://chromiumcodereview.appspot.com/16132003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202553 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, if there's e.g. still a download in flight, we might open a new
window after closing all windows but before starting the next test

BUG=111316
R=marja@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16074003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202552 0039d316-1c4b-4281-b951-d872f2087c98

This CL added an Esc key handler to the search box, which sets the focus to main
view (the file list or the thumbnail grid) when the search box has no query.

BUG=239307
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/16018008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96684
TBR=bruening@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15975006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202550 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202549 0039d316-1c4b-4281-b951-d872f2087c98

Not having full coverage yet. Preliminarily adding tests
necessary for resolving bug 244316.

BUG=147728

Review URL: https://chromiumcodereview.appspot.com/15939005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202548 0039d316-1c4b-4281-b951-d872f2087c98

This CL splits out quota related callbacks to separate file.
After this CL lands, quota_types.h is only depended file from non-browser directory.

TBR=markusheintz@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15892009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202547 0039d316-1c4b-4281-b951-d872f2087c98

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/15824004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202546 0039d316-1c4b-4281-b951-d872f2087c98

We only need the webkit test plugin during layout tests

BUG=242291
R=abarth@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15820007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244175
TEST=interactive_ui_tests:CaptivePortalWindow*

Review URL: https://chromiumcodereview.appspot.com/15780006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202544 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202543 0039d316-1c4b-4281-b951-d872f2087c98

As all of the code are browser-specific.

BUG=239710
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/16010006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202542 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151204:151225&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16072004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202541 0039d316-1c4b-4281-b951-d872f2087c98

This CL add GetGlobalLimitedUsage to UsageTracker and
replace GetGlobalUsage in QuotaManager with limited usage version.

BUG=220029
TEST=existing test should keep green

Review URL: https://chromiumcodereview.appspot.com/15907004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202540 0039d316-1c4b-4281-b951-d872f2087c98

This CL serves two purposes:

1) Improve the existing "mic-volume-checking"-scheme by ensuring that we no longer calls native audio functions from the core capture thread.
2) Prepare for adding AGC to the live-audio backend.

TBR=tommi@chromium.org
BUG=none
TEST=WebRTC loopback tests in Chrome where I monitor the microphone volume while speaking into the mic.

Review URL: https://codereview.chromium.org/15563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202538 0039d316-1c4b-4281-b951-d872f2087c98

Pass -lrt when linking AddressSanitizer, ThreadSanitizer, MemorySanitizer binaries on Linux only (was: AddressSanitizer, everywhere)

BUG=234010
TBR=hans

Review URL: https://codereview.chromium.org/16018009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202537 0039d316-1c4b-4281-b951-d872f2087c98

This patch tests if the audio player handles OGG audio files properly. The added tests validate if the window has been opened, if the audio tag is loaded and if the title and artist field are filled out correctly.

TBR=yoshiki@chromium.org
TEST=browser_tests
BUG=244146

Review URL: https://chromiumcodereview.appspot.com/16092002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202536 0039d316-1c4b-4281-b951-d872f2087c98

This is less fragile to target shuffles inside Blink.

R=abarth

Review URL: https://chromiumcodereview.appspot.com/16010005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202535 0039d316-1c4b-4281-b951-d872f2087c98

The barcode_decoder and frame_analyzer steps have been
simplified to execute by the new compare_videos.py script
in http://review.webrtc.org/1320007/

This CL removed unnecessary boilerplate code for the 
WebRTC Video Quality test.

BUG=none
TEST=chrome/test/functional/webrtc_video_quality.py (since the compare_videos.py script is present as webrtc_revision in Chrome DEPS is >4022)
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/14208006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244348
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/15915008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202533 0039d316-1c4b-4281-b951-d872f2087c98

Stop using *OnUIThread methods of ResourceMetadata and FileCache from UpdateOperation.
Make FileCache::ClearDirty public.

BUG=231221,231222
TEST=unit_tests

Review URL: https://chromiumcodereview.appspot.com/15974004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202532 0039d316-1c4b-4281-b951-d872f2087c98

Language decision is made by heuristics using Content-Language and CLD
determined language. This change adds html lang attribute, e.g.,
<html lang="ja">, as a third hint for language decision.
Content-Language is often invalid due to invalid server configuration.
On the other hand, lang attribute is provided by pages, or authoring
tools or authors themselves. As a result, they are more reliable than
Content-Language. With this change, language decision uses html lang
attribute instead of Content-Language if valid value is provided.
Other dicision process is not changed at all.

BUG=222073
TEST=unit_tests, browser_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201856

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202427

Review URL: https://chromiumcodereview.appspot.com/15728002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202531 0039d316-1c4b-4281-b951-d872f2087c98

The Android build system already defines $(PWD) to be the top of the
source directory as an absolute path, so there's no need for us to
define our own $(GYP_ABS_ANDROID_TOP_DIR) which was being used
incorrectly in some other cases. Replace it in GYP_DEFINES.

BUG=
R=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/16144002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244340

Review URL: https://chromiumcodereview.appspot.com/15785004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202529 0039d316-1c4b-4281-b951-d872f2087c98

This CL added a header element to main_new_ui.html and updated CSS to match the
height of items in the directory tree and the files list.

BUG=239283
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/16043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202528 0039d316-1c4b-4281-b951-d872f2087c98

Before adding alpha language display name conversion, split language list
related codes to TranslateLanguageList to make maintenance easy.

This patch contains no functional changes.

BUG=242178
TEST=build all, and run all existing tests

Review URL: https://chromiumcodereview.appspot.com/15317007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202527 0039d316-1c4b-4281-b951-d872f2087c98

Cropping over the right arrow was malfunctioning because of a bug in coordinates calculation. The mouse move handler was interpreting relative position (here on the arrow) instead of the page coordinates. This patch fixes it by using page coordinates instead of relative ones.

TEST=Edit a photo, crop, drop the area very fast over the right arrow.
BUG=244046

Review URL: https://chromiumcodereview.appspot.com/16080002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202526 0039d316-1c4b-4281-b951-d872f2087c98

This patch sets the minimum width of the progress bar's bar equal to it's height to make it look like a dot in the early stage.

TBR=yoshiki@chromium.org
TEST=Copy a file in Files.app. Observer the butter bar.
BUG=239301

Review URL: https://chromiumcodereview.appspot.com/15706010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202524 0039d316-1c4b-4281-b951-d872f2087c98

Should fix reliability_tests under Valgrind

BUG=163314
TBR=glider@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/15675005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202523 0039d316-1c4b-4281-b951-d872f2087c98

Breaks CrOS test: SelectFileDialogExtensionBrowserTest.SelectFileAndOpen
http://goo.gl/eoUBv http://goo.gl/uzb7V

> Made the open menu item in the context menu updated when the context menu is open.
> 
> Originally, FileSelectionHandler#updateFileSelectionAsync have the complex
> conditional statements. And when util.platform.newUI() is true and
> selection.totalCount is zero, updateContextMenuActionItems that updates the open
> menu item is not called.
> 
> This CL arranged the statements by the target of update and added some comments.
> 
> BUG=243687
> TEST=manually
> 
> Review URL: https://chromiumcodereview.appspot.com/15950003

TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/15742020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202522 0039d316-1c4b-4281-b951-d872f2087c98

This was a race because PolicyDomainDescriptors are passed from the UI to the
FILE thread in scoped_refptrs, but the class derived from RefCounted instead
of RefCountedThreadSafe. The fix was in http://crrev.com/202452.

BUG=243963

Review URL: https://chromiumcodereview.appspot.com/16018007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202520 0039d316-1c4b-4281-b951-d872f2087c98

These test files are used by https://codereview.chromium.org/16102004.
Uploading in a separate CL so that the other CL can be sent to the try bots.

BUG=237495
R=bartfab@chromium.org

Review URL: https://codereview.chromium.org/16137002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202519 0039d316-1c4b-4281-b951-d872f2087c98