GitLab

Blink should not share StyleSheetContents cache between different WebFrames.

If shares, WebFrameImpl::reload uses StyleSheetContents created by another WebFrameImpl.

So when changing allowImage setting (controlled by chrome) and reloading some page, the
reloaded frame might use StyleSheetContents cache.

Since StyleImages are cached in CSSValues and are not managed by FrameLoader, allowImage
change doesn't work.

BUG=346264
TEST=fast/css/background-image-reload.html, fast/css/two-different-iframe-not-share-style-image.html

Review URL: https://codereview.chromium.org/179873014

git-svn-id: svn://svn.chromium.org/blink/trunk@169414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG= 353257
TBR=vsevik

Review URL: https://codereview.chromium.org/202623003

git-svn-id: svn://svn.chromium.org/blink/trunk@169413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Replace elementHasLegalLinkAttribute() helper with virtual function on Element:
hasLegalLinkAttribute(). elementHasLegalLinkAttribute() was a bit complex due
to all the branching. Using a virtual function distributes the code to each
class and results in clearer code.

R=tkent, adamk

Review URL: https://codereview.chromium.org/202893002

git-svn-id: svn://svn.chromium.org/blink/trunk@169412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now slightly fewer files are recompiled when touching the header.

BUG=none

Review URL: https://codereview.chromium.org/196353003

git-svn-id: svn://svn.chromium.org/blink/trunk@169411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink is calling new API createAudioDevice().
It needs to remove.

TODO(crogers): remove deprecated API as soon as WebKit calls new API.

This patch is related with https://codereview.chromium.org/201303006/

BUG=353110

Review URL: https://codereview.chromium.org/201723003

git-svn-id: svn://svn.chromium.org/blink/trunk@169410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1.6% of the overall profile, and 2% of the recalcStyle, in the PeaceKeeper
benchmark is spent inside cacheUserAgentBorderAndBackground() because even
though there is an appearance guard on the constructor, we still run
constructors and destructors for all the members which aren't free since lots
of them have a lot of fields to initialize (ex. FillLayers and BorderData).

This patch moves the check from the constructor of CachedUAStyle into
cacheUserAgentBorderAndBackground() so that we can skip all the
initialization for the common case where the element has no appearance.

Review URL: https://codereview.chromium.org/202223002

git-svn-id: svn://svn.chromium.org/blink/trunk@169408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

One type testing mechanism to rule them all.

BUG=none

Review URL: https://codereview.chromium.org/200713004

git-svn-id: svn://svn.chromium.org/blink/trunk@169407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

adjustRenderStyle is 2% of the recalcStyle cost and 1.5% of the time
in the peacekeeper benchmark. This patch adds an early out when adjusting
the element's style based on the tagName since after one match on the
tagName no other cases can match. It also adds a check for <div> and <span>
which are the most common elements and never need adjustment to skip
all the rest of the tagName checks.

Review URL: https://codereview.chromium.org/202343003

git-svn-id: svn://svn.chromium.org/blink/trunk@169406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Involving the media controller plainly does not make sense.

There was no test coverage for the CC button with a media controller
present, and adding a negative test for it does not seem useful.

Note that what remains is still not great since it doesn't allow you to
pick between multiple tracks, but that will be fixed at a later time.

BUG=341813
TEST=LayoutTests/media/audio-controls-captions.html
     LayoutTests/media/video-controls-captions.html

Review URL: https://codereview.chromium.org/201123004

git-svn-id: svn://svn.chromium.org/blink/trunk@169405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch parse the sizes attribute into vector of IntSize, also added sizes in WebIconURL, so it could be used by chromium 

BUG=349039

Review URL: https://codereview.chromium.org/196743002

git-svn-id: svn://svn.chromium.org/blink/trunk@169404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Causing virtual/softwarecompositing/squashing/squashed-layer-loses-graphicslayer.html to fail.

> Set geometry dirty bits on composited layer mappings when updating squashed layers.
> 
> The lack of setting geometry dirty bits in these cases is wrong. However, at the moment it is masked by setting needs geometry dirty bits more globally upwards in the system. When that is cleaned up these targeted ones will be in place.
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/200623006

TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/201153013

git-svn-id: svn://svn.chromium.org/blink/trunk@169402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Might have broken countless layout tests (ok I am exaggerating) on almost all platforms

> Node::setTextContent should avoid work when nothing changes
> 
> We already had code to handle this case, which is shared
> by editing as well as HTMLElement::setInnerText.
> 
> replaceChildrenWithText does the right thing to avoid
> doing work when the text content hasn't changed, etc.
> 
> BUG=352836
> R=jchaffraix@chromium.org
> 
> Review URL: https://codereview.chromium.org/200763006

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/202883002

git-svn-id: svn://svn.chromium.org/blink/trunk@169401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cause browser test HTTPRedirectDisallowed to timeout on chromeos - 100% reproducible.

One example: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22389

> id of iframe incorrectly sets window name
> 
> As per the specification, the iframe's name should be an empty string if unset:
> http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name
> 
> Instead, Chromium was using the iframe's id as window name if the name was
> unset. This change makes us behave like Firefox 27 and IE 11, verified using:
> http://jsfiddle.net/xf5H7/9/
> 
> This CL sets the name attribute iframe in a lot of layout tests so that
> testRunner.dumpChildFramesAsText() keeps printing the same result.
> 
> R=arv@chromium.org, tkent@chromium.org, abarth, arv, tkent
> BUG=347169
> TEST=fast/frames/iframe-no-name.html
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168553
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168801
> 
> Review URL: https://codereview.chromium.org/187103002

TBR=ch.dumez@samsung.com

Review URL: https://codereview.chromium.org/202823002

git-svn-id: svn://svn.chromium.org/blink/trunk@169398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This makes it easier to read, and also prevents pointless conversions
back and forth between a 32-bit integer and four floats.

This resolves a FIXME which asked why this was the case.

BUG=

Review URL: https://codereview.chromium.org/201503002

git-svn-id: svn://svn.chromium.org/blink/trunk@169396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The lack of setting geometry dirty bits in these cases is wrong. However, at the moment it is masked by setting needs geometry dirty bits more globally upwards in the system. When that is cleaned up these targeted ones will be in place.

BUG=

Review URL: https://codereview.chromium.org/200623006

git-svn-id: svn://svn.chromium.org/blink/trunk@169395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We already had code to handle this case, which is shared
by editing as well as HTMLElement::setInnerText.

replaceChildrenWithText does the right thing to avoid
doing work when the text content hasn't changed, etc.

BUG=352836
R=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/200763006

git-svn-id: svn://svn.chromium.org/blink/trunk@169394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169378

BUG=345027
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/197213021

git-svn-id: svn://svn.chromium.org/blink/trunk@169393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a cached resource needs to be revalidated, then supply the referrer
of the document making the request.

R=japhet@chromium.org
BUG=344335

Review URL: https://codereview.chromium.org/201973002

git-svn-id: svn://svn.chromium.org/blink/trunk@169392 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CORS-with-credentials are only defined for http(s) resources.

Chromium uses Access-Control-Allow-Origin: * with the intention of
whitelisting resources at certain origins for use in XMLHttpRequest and
images with canvas.
When the includeCredentials flag is set, these requests are blocked, even
though the term "credentials" makes no sense for data:/chrome-extension:-URLs.

This CL relaxes the wildcard check for non-http(s) resources, so that implementors
can choose to use CORS regardless of whether credentials were requested.

BUG=315152
TEST=Layout tests are already in CL https://codereview.chromium.org/54173002/

Review URL: https://codereview.chromium.org/192573011

git-svn-id: svn://svn.chromium.org/blink/trunk@169391 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353301
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/197063008

git-svn-id: svn://svn.chromium.org/blink/trunk@169390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Caused a crash on linux asan bot, see crbug.com/353257

> DevTools: track stylesheets by document, not local frame.
> 
> R=lushnikov@chromium.org, vsevik@chromium.org
> 
> Review URL: https://codereview.chromium.org/201683002

TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/202443003

git-svn-id: svn://svn.chromium.org/blink/trunk@169389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is in order to revert 169354, which caused a crash on ASAN bot.

See crbug.com/353257

> DevTools: defer styles delta calculation to until the end of the task.
> 
> BUG=289708
> R=vsevik@chromium.org
> 
> Review URL: https://codereview.chromium.org/201363002

TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/196743008

git-svn-id: svn://svn.chromium.org/blink/trunk@169388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch copies TextAutosizer's functions into FastTextAutosizer.cpp
so that we can refactor this code for understandability. This is the
first patch of a few and just moves the code. A followup will actually
refactor the functions.

BUG=302005

Review URL: https://codereview.chromium.org/200603002

git-svn-id: svn://svn.chromium.org/blink/trunk@169387 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353217
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/197233006

git-svn-id: svn://svn.chromium.org/blink/trunk@169386 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use new is*Element() helpers more in rendering code. This makes the code clearer
and simpler.

R=esprehn, adamk
BUG=346095

Review URL: https://codereview.chromium.org/197283025

git-svn-id: svn://svn.chromium.org/blink/trunk@169385 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use new is*Element() helpers more in core/ code. This makes the code clearer
and simpler.

R=adamk, eseidel
BUG=346095

Review URL: https://codereview.chromium.org/201403002

git-svn-id: svn://svn.chromium.org/blink/trunk@169384 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This applies to both importKey() and unwrapKey().

This matches the intended change in the spec, of dropping self-identifying JWK keys:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=25036

BUG=245025

Review URL: https://codereview.chromium.org/198513002

git-svn-id: svn://svn.chromium.org/blink/trunk@169383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec tells us that setting the crossorigin attribute on an img
element should cause the "update the image data" steps to be invoked,

 http://www.whatwg.org/specs/web-apps/current-work/#update-the-image-data

Do so here, along with updating the underlying test's expectation.

R=
BUG=341047

Review URL: https://codereview.chromium.org/201143002

git-svn-id: svn://svn.chromium.org/blink/trunk@169382 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is following the latest changes from the specification.

BUG=162827

Review URL: https://codereview.chromium.org/200893004

git-svn-id: svn://svn.chromium.org/blink/trunk@169381 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add PerfTestRunner.logFatalError(text) to stop a test if the test can not run.
For example, WebGL is not supported on some platforms, so a WebGL perf test on
the platform should stop.

BUG=242244

Review URL: https://codereview.chromium.org/198873004

git-svn-id: svn://svn.chromium.org/blink/trunk@169380 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The below one is flaky on linux/mac,fail on win
fast/dom/Window/open-window-min-size.html

The below three are passing
fast/events/scroll-event-during-modal-dialog.html
fast/events/show-modal-dialog-onblur-onfocus.html
fast/harness/show-modal-dialog.html

BUG=345831
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/198503006

git-svn-id: svn://svn.chromium.org/blink/trunk@169379 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Tables cache data related to border collapsing to optimize paint calls
as the border collapsing logic can be slow. These layout tests make
sure that we correctly invalidate and recompute this cache in response
to various style/DOM changes, so they need to run some code to set up
the scene, go through the paint path to set up the cache, then
invalidate the cache by causing further mutations.  This uses the
runAfterDisplay harness to run the second part of the test after
painting instead of invoking testRunner.display() directly.

Since the table border collapsing logic doesn't directly involve
repaint invalidations, this doesn't attempt to preserve the
invalidation data. Invalidations on table changes should be covered by
other tests.

BUG=345027

Review URL: https://codereview.chromium.org/196573021

git-svn-id: svn://svn.chromium.org/blink/trunk@169378 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353208
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/202243004

git-svn-id: svn://svn.chromium.org/blink/trunk@169377 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These numbers are: NaN, Infinity, -Infinity, -0.

R=pfeldman
TEST=various existing tests

Review URL: https://codereview.chromium.org/200423008

git-svn-id: svn://svn.chromium.org/blink/trunk@169376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169130

BUG=351807
TBR=sugoi@chromium.org

Review URL: https://codereview.chromium.org/202233003

git-svn-id: svn://svn.chromium.org/blink/trunk@169375 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168774

BUG=345452
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/202023003

git-svn-id: svn://svn.chromium.org/blink/trunk@169374 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168743

BUG=348518
TBR=andersr@opera.com

Review URL: https://codereview.chromium.org/202143003

git-svn-id: svn://svn.chromium.org/blink/trunk@169373 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168968

BUG=320139
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/202263002

git-svn-id: svn://svn.chromium.org/blink/trunk@169372 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=289708
R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/201363002

git-svn-id: svn://svn.chromium.org/blink/trunk@169371 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=169197

BUG=302005
TBR=skobes@chromium.org

Review URL: https://codereview.chromium.org/202243002

git-svn-id: svn://svn.chromium.org/blink/trunk@169370 bbb929c8-8fbe-4397-9dbb-9b2b20218538