1. 01 May, 2017 40 commits
    • ajuma's avatar
      cc: Rename LayerImpl::is_drawn_render_surface_layer_list_member · 651848a5
      ajuma authored
      Since there's no longer a render surface layer list, this renames
      LayerImpl::is_drawn_render_surface_layer_list_member to
      contributes_to_drawn_render_surface.
      
      BUG=611883
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      
      Review-Url: https://codereview.chromium.org/2851193002
      Cr-Commit-Position: refs/heads/master@{#468413}
      651848a5
    • dougt's avatar
      Drop the retargeting of accNavigate in BrowserAccessibilityWin · 851c752c
      dougt authored
      AXPlatformNode already retargets based on the start variant, so we can drop
      the GetTargetFromChildID call for GetPlatformNodeWin()->accNavigate.
      
      BUG=703369
      
      Review-Url: https://codereview.chromium.org/2851093002
      Cr-Commit-Position: refs/heads/master@{#468412}
      851c752c
    • fsamuel's avatar
      Aura-Mus: Avoid creating StubSurfaceReferenceFactory's on every surface ID change · 77654fd1
      fsamuel authored
      BUG=none
      
      Review-Url: https://codereview.chromium.org/2848273002
      Cr-Commit-Position: refs/heads/master@{#468411}
      77654fd1
    • twellington's avatar
      [Android] Add android:roundIcon for adaptive icon support · fab67980
      twellington authored
      BUG=707449
      
      Review-Url: https://codereview.chromium.org/2850253003
      Cr-Commit-Position: refs/heads/master@{#468410}
      fab67980
    • spqchan's avatar
      [Mac] Fix for Page Info Bubble · 222d387e
      spqchan authored
      Same issue with https://codereview.chromium.org/2752623003/
      There's a potential with a race condition with the Page Info icon where
      it might switch between LocationIconDecoration and
      SecurityStateBubbleDecoration.
      
      BUG=675854
      
      Review-Url: https://codereview.chromium.org/2851663002
      Cr-Commit-Position: refs/heads/master@{#468409}
      222d387e
    • mfomitchev's avatar
      Adding static asserts to LatencyInfo struct traits. · 648dc8df
      mfomitchev authored
      Asserts ensure that the number of items in corresponding ui and mojom enums matches each other.
      
      BUG=NONE
      
      Review-Url: https://codereview.chromium.org/2856623002
      Cr-Commit-Position: refs/heads/master@{#468408}
      648dc8df
    • kbr's avatar
      Deploy "Mac Experimental Release (Intel)". · 4540a3e7
      kbr authored
      BUG=716670
      TBR=zmo@chromium.org
      NOTRY=true
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/2849163004
      Cr-Commit-Position: refs/heads/master@{#468407}
      4540a3e7
    • sky's avatar
      Revert of Fix an interactive ui test (patchset #7 id:120001 of... · d1483ffa
      sky authored
      Revert of Fix an interactive ui test (patchset #7 id:120001 of https://codereview.chromium.org/2836073003/ )
      
      Reason for revert:
      Reverting as this seems to be causing flake on the msan bot. See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F260%2F%2B%2Frecipes%2Fsteps%2Finteractive_ui_tests%2F0%2Flogs%2FTabDragging__x2f_DetachToBrowserInSeparateDisplayTabDragControllerTest.DragSingleTabToSeparateWindowInSecondDisplay__x2f_0%2F0 for example:
      
      [ RUN      ] TabDragging/DetachToBrowserInSeparateDisplayTabDragControllerTest.DragSingleTabToSeparateWindowInSecondDisplay/0
      [9966:9966:0428/135949.114391:WARNING:chrome_browser_main_chromeos.cc(408)] Running as stub user with profile dir: test-user
      [9966:9966:0428/135949.955645:WARNING:audio_manager.cc(293)] Multiple instances of AudioManager detected
      [9966:9966:0428/135949.955736:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected
      Xlib:  extension "RANDR" missing on display ":99".
      Xlib:  extension "RANDR" missing on display ":99".
      libva info: VA-API version 0.35.0
      libva info: va_getDriverName() returns -1
      libva error: va_getDriverName() failed with unknown libva error,driver_name=(null)
      [9997:9997:0428/135950.268268:WARNING:vaapi_wrapper.cc(1220)] vaInitialize failed: unknown libva error
      [9966:9987:0428/135950.394495:WARNING:freezer_cgroup_process_manager.cc(61)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
      ==9966==WARNING: MemorySanitizer: use-of-uninitialized-value
          #0 0xb8902c5 in SkPaint::nothingToDraw() const third_party/skia/src/core/SkPaint.cpp:2328:17
          #1 0x1e298854 in skia::AnalysisCanvas::onDrawRect(SkRect const&, SkPaint const&) skia/ext/analysis_canvas.cc:121:13
          #2 0xc152180 in operator()<SkRecords::DrawRect> third_party/skia/src/core/SkRecordDraw.h:62:15
          #3 0xc152180 in SkMiniPicture<SkRecords::DrawRect>::playback(SkCanvas*, SkPicture::AbortCallback*) const third_party/skia/src/core/SkMiniRecorder.cpp:55:0
          #4 0xe99b5ad in cc::(anonymous namespace)::RasterItem(cc::DisplayItem const&, SkCanvas*, SkPicture::AbortCallback*) cc/paint/display_item_list.cc:105:21
          #5 0xe99a627 in cc::DisplayItemList::Raster(SkCanvas*, SkPicture::AbortCallback*) const cc/paint/display_item_list.cc:188:5
          #6 0xe99a025 in cc::DisplayItemList::Raster(SkCanvas*, SkPicture::AbortCallback*, gfx::Rect const&, float) const cc/paint/display_item_list.cc:175:3
          #7 0x1044dd06 in cc::RecordingSource::DetermineIfSolidColor() cc/layers/recording_source.cc:152:18
          #8 0x1044d4bb in cc::RecordingSource::FinishDisplayItemListUpdate() cc/layers/recording_source.cc:56:3
          #9 0x1ee06f0f in cc::PictureLayer::Update() cc/layers/picture_layer.cc:130:24
          #10 0x102e1014 in PaintContent cc/trees/layer_tree_host.cc:1066:33
          #11 0x102e1014 in cc::LayerTreeHost::DoUpdateLayers(cc::Layer*) cc/trees/layer_tree_host.cc:716:0
          #12 0x102df467 in cc::LayerTreeHost::UpdateLayers() cc/trees/layer_tree_host.cc:591:17
          #13 0x103e12c9 in DoPainting cc/trees/single_thread_proxy.cc:705:21
          #14 0x103e12c9 in cc::SingleThreadProxy::BeginMainFrame(cc::BeginFrameArgs const&) cc/trees/single_thread_proxy.cc:685:0
          #15 0xd4f1335 in Run base/callback.h:91:12
          #16 0xd4f1335 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0
          #17 0xd25eb93 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19
          #18 0xd260561 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5
          #19 0xd26210e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13
          #20 0xd271a59 in HandleDispatch base/message_loop/message_pump_glib.cc:267:25
          #21 0xd271a59 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109:0
          #22 0x7f475b7653ce in g_main_dispatch /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3064:27
          #23 0x7f475b7653ce in g_main_context_dispatch /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3663:0
          #24 0x7f475b766686 in g_main_context_iterate /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3734:5
          #25 0x7f475b766a1d in g_main_context_iteration /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3795:12
          #26 0xd270fb3 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:309:30
          #27 0xd25dc2b in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10
          #28 0xd31d81c in base::RunLoop::Run() base/run_loop.cc:37:10
          #29 0x1479f62d in ash::ToplevelWindowEventHandler::RunMoveLoop(aura::Window*, gfx::Vector2d const&, aura::client::WindowMoveSource) ash/wm/toplevel_window_event_handler.cc:99:12
          #30 0xcaa4ced in views::NativeWidgetAura::RunMoveLoop(gfx::Vector2d const&, views::Widget::MoveLoopSource, views::Widget::MoveLoopEscapeBehavior) ui/views/widget/native_widget_aura.cc:707:20
          #31 0x15221a1d in TabDragController::RunMoveLoop(gfx::Vector2d const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:1076:26
          #32 0x1522a3f5 in TabDragController::DetachIntoNewBrowserAndRunMoveLoop(gfx::Point const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:1045:3
          #33 0x1522693c in TabDragController::DragBrowserToNewTabStrip(TabStrip*, gfx::Point const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:565:5
          #34 0x1522279d in TabDragController::ContinueDragging(gfx::Point const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:530:9
          #35 0x1521a39f in TabDragController::Drag(gfx::Point const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:387:7
          #36 0x15253741 in ContinueDrag chrome/browser/ui/views/tabs/tab_strip.cc:1221:23
          #37 0x15253741 in non-virtual thunk to TabStrip::ContinueDrag(views::View*, ui::LocatedEvent const&) chrome/browser/ui/views/tabs/tab_strip.cc:0:0
          #38 0x1520bb4b in OnMouseDragged chrome/browser/ui/views/tabs/tab.cc:893:16
          #39 0x1520bb4b in non-virtual thunk to Tab::OnMouseDragged(ui::MouseEvent const&) chrome/browser/ui/views/tabs/tab.cc:0:0
          #40 0xca25f95 in views::View::ProcessMouseDragged(ui::MouseEvent const&) ui/views/view.cc:2463:9
          #41 0xca247a4 in views::View::OnMouseEvent(ui::MouseEvent*) ui/views/view.cc:1076:11
          #42 0xebbd783 in DispatchEvent ui/events/event_dispatcher.cc:191:12
          #43 0xebbd783 in ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:139:0
          #44 0xebbcbf8 in DispatchEventToTarget ui/events/event_dispatcher.cc:86:14
          #45 0xebbcbf8 in ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:58:0
          #46 0xca4021f in views::internal::RootView::OnMouseDragged(ui::MouseEvent const&) ui/views/widget/root_view.cc:422:9
          #47 0xca5e71b in views::Widget::OnMouseEvent(ui::MouseEvent*) ui/views/widget/widget.cc:1239:22
          #48 0xebbd783 in DispatchEvent ui/events/event_dispatcher.cc:191:12
          #49 0xebbd783 in ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:139:0
          #50 0xebbcbf8 in DispatchEventToTarget ui/events/event_dispatcher.cc:86:14
          #51 0xebbcbf8 in ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:58:0
          #52 0xebc594f in ui::EventProcessor::OnEventFromSource(ui::Event*) ui/events/event_processor.cc:46:15
          #53 0xebc6f28 in DeliverEventToSink ui/events/event_source.cc:73:16
          #54 0xebc6f28 in ui::EventSource::SendEventToSink(ui::Event*) ui/events/event_source.cc:51:0
          #55 0x1ef37da4 in aura::WindowTreeHostX11::DispatchEvent(_XEvent* const&) ui/aura/window_tree_host_x11.cc:274:9
          #56 0xeb9250c in ui::PlatformEventSource::DispatchEvent(_XEvent*) ui/events/platform/platform_event_source.cc:81:29
          #57 0xed247b6 in ui::X11EventSource::ExtractCookieDataDispatchEvent(_XEvent*) ui/events/platform/x11/x11_event_source.cc:240:14
          #58 0xed24471 in ui::X11EventSource::DispatchXEvents() ui/events/platform/x11/x11_event_source.cc:140:5
          #59 0xed23c59 in ui::(anonymous namespace)::XSourceDispatch(_GSource*, int (*)(void*), void*) ui/events/platform/x11/x11_event_source_glib.cc:41:15
          #60 0x7f475b7653ce in g_main_dispatch /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3064:27
          #61 0x7f475b7653ce in g_main_context_dispatch /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3663:0
          #62 0x7f475b766686 in g_main_context_iterate /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3734:5
          #63 0x7f475b766a1d in g_main_context_iteration /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3795:12
          #64 0xd270fb3 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:309:30
          #65 0xd25dc2b in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10
          #66 0xd31d81c in base::RunLoop::Run() base/run_loop.cc:37:10
          #67 0xd1464d in DetachToBrowserTabDragControllerTest::QuitWhenNotDragging() chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:527:23
          #68 0xd7288e in DetachToBrowserInSeparateDisplayTabDragControllerTest_DragSingleTabToSeparateWindowInSecondDisplay_Test::RunTestOnMainThread() chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:1812:3
          #69 0xa860dfb in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:309:5
          #70 0x94cd165 in Run base/callback.h:80:12
          #71 0x94cd165 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1916:0
          #72 0x94c8e14 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1257:18
          #73 0x4c94b49 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() chrome/browser/chromeos/chrome_browser_main_chromeos.cc:506:32
          #74 0x2771066 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:1161:13
          #75 0x381ec1a in Run base/callback.h:80:12
          #76 0x381ec1a in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45:0
          #77 0x2768b24 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:956:25
          #78 0x277f340 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:125:17
          #79 0x275c35fe in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:42:32
          #80 0x934aeba in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:411:14
          #81 0x934dadb in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:703:12
          #82 0x10e02e92 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:450:29
          #83 0x9347727 in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10
          #84 0xa85fea0 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:265:3
          #85 0x9479b7a in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:266:20
          #86 0xc6c1a97 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
          #87 0xc6c1a97 in testing::Test::Run() testing/gtest/src/gtest.cc:2470:0
          #88 0xc6c4a8b in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
          #89 0xc6c6029 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
          #90 0xc6e59cd in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
          #91 0xc6e485e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
          #92 0xc6e485e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0
          #93 0xd169eb0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
          #94 0xd169eb0 in base::TestSuite::Run() base/test/test_suite.cc:271:0
          #95 0xab1007 in InteractiveUITestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/interactive_ui_tests_main.cc:85:47
          #96 0xa87dcab in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:520:31
          #97 0xab0e43 in main chrome/test/base/interactive_ui_tests_main.cc:109:22
          #98 0x7f4755681f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0
          #99 0x4a0435 in _start ??:0:0
      
      Original issue's description:
      > Fix an interactive ui test
      >
      > * Remove touch drag for a series of tests about tab dragging to the second display as, up to now, there's no use case.
      >
      > * Each display has its own UI controller in the test, but, in ozone build, they do not share the state of mouse (down, up). When the mouse is moved to the second display, the UI controller for it does know that the mouse is down in first display. That's why the tab cannot be dragged to the second display only in ozone build. Simple solution is to move the mouse state variable outside of UI controller class.
      >
      > BUG=626769
      >
      > Review-Url: https://codereview.chromium.org/2836073003
      > Cr-Commit-Position: refs/heads/master@{#468048}
      > Committed: https://chromium.googlesource.com/chromium/src/+/171e2ebecd1cda288825631299b898d65b80f52e
      
      TBR=pkasting@chromium.org,sadrul@chromium.org,weidongg@chromium.org
      # Not skipping CQ checks because original CL landed more than 1 days ago.
      BUG=626769
      
      Review-Url: https://codereview.chromium.org/2851333002
      Cr-Commit-Position: refs/heads/master@{#468406}
      d1483ffa
    • Ken Rockot's avatar
      Fix thread DCHECK in child process ServiceManagerConnection · 8dea4773
      Ken Rockot authored
      |child_binding_| was introduced by r461826 to be bound on the IO
      thread. This CL ensures that it's also unbound on the same thread
      during shutdown; otherwise there's a race and it might get
      incorrectly unbound on the main thread, leading to a DCHECK in
      developer builds.
      
      BUG=716416
      TBR=ben@chromium.org
      
      Change-Id: I194d1446753d3fb976b21bb191e7a407e7f8c6e7
      Reviewed-on: https://chromium-review.googlesource.com/491886Reviewed-by: default avatarKen Rockot <rockot@chromium.org>
      Commit-Queue: Ken Rockot <rockot@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#468405}
      8dea4773
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ 489530e06..d170c0fb4 (3 commits) · 2472d2fe
      skia-deps-roller@chromium.org authored
      https://skia.googlesource.com/skia.git/+log/489530e06cb7..d170c0fb48aa
      
      $ git log 489530e06..d170c0fb4 --date=short --no-merges --format='%ad %ae %s'
      2017-05-01 msarett Only store width and height on SkPixelRef (last part)
      2017-05-01 msarett Blacklist testimgari.jpg on CG
      2017-05-01 fmalita Restore legacy SaveLayerRec ctor
      
      Created with:
        roll-dep src/third_party/skia
      
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, see:
      http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
      
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
      TBR=scroggo@chromium.org
      
      Change-Id: I4032fc211df6523e4a410f5c947af654083cb45c
      Reviewed-on: https://chromium-review.googlesource.com/491248Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
      Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#468404}
      2472d2fe
    • jaydasika's avatar
      cc : Replace unordered_maps with flat_map in property trees · dfcb08fa
      jaydasika authored
      Because these maps should be small.
      
      BUG=678397
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
      
      Review-Url: https://codereview.chromium.org/2848243003
      Cr-Commit-Position: refs/heads/master@{#468403}
      dfcb08fa
    • Yipeng Wang's avatar
      Reland: [about:credits] Improve compression by sorting licenses · 0534ad76
      Yipeng Wang authored
      Reverted in: ba3fb344.
      
      Reason for reland: Fixed sort order when two licenses of same length exist.
      
      Restore the alphabetical order in javascript.
      
      Saves around 100k when gzip is used, but only 2k for brotli.
      Intention is to have android_webview to use the same copy
      of about:credits in a follow-up, in which case this optimization
      becomes relevant.
      
      TBR=dbeam@chromium.org
      BUG=688077
      Change-Id: I085626bc2c81933ae973fb9762b6c3694318855b
      
      Change-Id: I085626bc2c81933ae973fb9762b6c3694318855b
      Reviewed-on: https://chromium-review.googlesource.com/490718
      Commit-Queue: Andrew Grieve <agrieve@chromium.org>
      Reviewed-by: default avatarRichard Coles <torne@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#468402}
      0534ad76
    • kouhei's avatar
      [ES6 modules] Enable moduleScripts under experimental-web-platform-features · 29950db4
      kouhei authored
      BUG=594639
      
      Review-Url: https://codereview.chromium.org/2848193002
      Cr-Commit-Position: refs/heads/master@{#468401}
      29950db4
    • catapult-deps-roller@chromium.org's avatar
      Roll src/third_party/catapult/ 1c3f4b921..2b7090e93 (1 commit) · de4c4327
      catapult-deps-roller@chromium.org authored
      https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1c3f4b921788..2b7090e93566
      
      $ git log 1c3f4b921..2b7090e93 --date=short --no-merges --format='%ad %ae %s'
      2017-05-01 aschulman [Devil] Added Cherry Mobile One USB charging control commands.
      
      Created with:
        roll-dep src/third_party/catapult
      
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, see:
      http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
      
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
      TBR=sullivan@chromium.org
      
      Change-Id: Ie1ee49db40e87f1ff157a8dd2c55322ab1f9c63c
      Reviewed-on: https://chromium-review.googlesource.com/491526
      Reviewed-by: <catapult-deps-roller@chromium.org>
      Commit-Queue: <catapult-deps-roller@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#468400}
      de4c4327
    • bshaya's avatar
      [Chromecast] Complete PostProcessingPipeline changes · 4d46c8d9
      bshaya authored
      - Add mix & linearize AudioPostProcessor hooks.
      - Use delay from AudioPostProcessor::ProcessFrames to update timing estimates.
      - Allow configuring mixing multiple device_id's in a single AudioPostProcessor.
      - Pass Cast Volume to PostProcessors (rather than raw multiplier).
      - Add unittest for assignment of PostProcessors + delay accounting.
      
      BUG=internal/36299959
      TEST=cast_alsa_cma_backend_unittests
      
      Change-Id: I5503f7de39d0ac502b8e861322162fee9aade8dd
      Review-Url: https://codereview.chromium.org/2847673002
      Cr-Commit-Position: refs/heads/master@{#468399}
      4d46c8d9
    • sky's avatar
      Revert of [Mac] Refactor bookmark bar controller (patchset #10 id:180001 of... · 27ed7650
      sky authored
      Revert of [Mac] Refactor bookmark bar controller (patchset #10 id:180001 of https://codereview.chromium.org/2751573002/ )
      
      Reason for revert:
      Reverting as likely caused msan failurs. See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F29660%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FBookmarkFolderAppleScriptTest.DeleteBookmarkItems%2F0 for example:
      
      ==77706==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000445b40 at pc 0x0001156ab4fe bp 0x7fff5c399fd0 sp 0x7fff5c399fc8
      READ of size 8 at 0x603000445b40 thread T0
          #0 0x1156ab4fd in -[BookmarkBarController applyLayout:animated:] ??:0:0
          #1 0x1156a9db1 in -[BookmarkBarController rebuildLayoutWithAnimated:] ??:0:0
          #2 0x1156acf25 in -[BookmarkBarController nodeRemoved:parent:index:] ??:0:0
          #3 0x1127774c7 in bookmarks::BookmarkModel::RemoveAndDeleteNode(bookmarks::BookmarkNode*) ??:0:0
          #4 0x112776d40 in bookmarks::BookmarkModel::Remove(bookmarks::BookmarkNode const*) ??:0:0
          #5 0x10607a64c in (anonymous namespace)::BookmarkFolderAppleScriptTest_DeleteBookmarkItems_Test::RunTestOnMainThread() ??:0:0
          #6 0x10d1f6ac3 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ??:0:0
          #7 0x10bb87dc3 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ??:0:0
          #8 0x10bb851e6 in ChromeBrowserMainParts::PreMainMessageLoopRun() ??:0:0
          #9 0x1077b02dd in content::BrowserMainLoop::PreMainMessageLoopRun() ??:0:0
          #10 0x1084ba8a3 in content::StartupTaskRunner::RunAllTasksNow() ??:0:0
          #11 0x1077abc3a in content::BrowserMainLoop::CreateStartupTasks() ??:0:0
          #12 0x1077b94ec in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ??:0:0
          #13 0x1077a40b5 in content::BrowserMain(content::MainFunctionParams const&) ??:0:0
          #14 0x10b6a9604 in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) ??:0:0
          #15 0x10b6ab3c7 in content::ContentMainRunnerImpl::Run() ??:0:0
          #16 0x111afc88b in service_manager::Main(service_manager::MainParams const&) ??:0:0
          #17 0x10b6a8ff4 in content::ContentMain(content::ContentMainParams const&) ??:0:0
          #18 0x10d1f5c4f in content::BrowserTestBase::SetUp() ??:0:0
          #19 0x10ba09201 in InProcessBrowserTest::SetUp() ??:0:0
          #20 0x10ed76b2f in testing::Test::Run() ??:0:0
          #21 0x10ed78b43 in testing::TestInfo::Run() ??:0:0
          #22 0x10ed79e86 in testing::TestCase::Run() ??:0:0
          #23 0x10ed8cfb6 in testing::internal::UnitTestImpl::RunAllTests() ??:0:0
          #24 0x10ed8c588 in testing::UnitTest::Run() ??:0:0
          #25 0x10ba51d3e in base::TestSuite::Run() ??:0:0
          #26 0x10b6fc3ac in ChromeTestSuiteRunner::RunTestSuite(int, char**) ??:0:0
          #27 0x10d2c7991 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) ??:0:0
          #28 0x10b6fc203 in main ??:0:0
          #29 0x7fff8a0125fc in start ??:0:0
      
      Original issue's description:
      > Yes, with RTL thrown in, since this is specifically designed to make it almost free.
      >
      > Two major things here:
      > - The bar is no longer relaid-out directly in response to changes in view size, bookmark model etc. Instead, a new UI-direction-agnostic view model (BookmarkBarLayout) is created from the current state, and if it's different from before, it's applied to the view.
      > - Removed a bunch of layout-related code that's no longer necessary
      >
      > BUG=648560
      >
      > Review-Url: https://codereview.chromium.org/2751573002
      > Cr-Commit-Position: refs/heads/master@{#468364}
      > Committed: https://chromium.googlesource.com/chromium/src/+/2644729cb7722a702a76cc2758d0ce372e1e6f92
      
      TBR=ellyjones@chromium.org,avi@chromium.org,lgrey@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=648560
      
      Review-Url: https://codereview.chromium.org/2853123002
      Cr-Commit-Position: refs/heads/master@{#468398}
      27ed7650
    • brucedawson's avatar
      Improve error message when debuggers not installed · 6c3d410e
      brucedawson authored
      When building Chrome we require that you have the "Debugging tools for
      Windows" feature of the Windows 10 SDK installed. The error messages
      when this non-default component is not installed are a bit cryptic. This
      adds a more explicit error message.
      
      The new error message looks like this:
      
      >gn gen out\debug
      Traceback (most recent call last):
        File "c:/src/chromium4/src/build/vs_toolchain.py", line 448, in <module>
          sys.exit(main())
        File "c:/src/chromium4/src/build/vs_toolchain.py", line 444, in main
          return commands[sys.argv[1]](*sys.argv[2:])
        File "c:/src/chromium4/src/build/vs_toolchain.py", line 309, in CopyDlls
          _CopyDebugger(target_dir, target_cpu)
        File "c:/src/chromium4/src/build/vs_toolchain.py", line 331, in _CopyDebugger
          '10 SDK.' % full_path)
      Exception: dbghelp.dll not found in "C:\Program Files (x86)\Windows Kits\10\Debuggers\x86\dbghelp.dll"
      You must install the "Debugging Tools for Windows" feature from the Windows 10 SDK.
      ERROR at //build/toolchain/win/BUILD.gn:39:3: Script returned non-zero exit code.
        exec_script("../../vs_toolchain.py",
        ^----------
      Current dir: c:/src/chromium4/src/out/debug/
      Command: C:/src/depot_tools/python276_bin/python.exe -- c:/src/chromium4/src/build/vs_toolchain.py copy_dlls c:/src/chromium4/src/out/debug Debug x86
      Returned 1.
      See //BUILD.gn:65:1: which caused the file to be included.
      group("gn_all") {
      ^----------------
      
      R=wkorman@chromium.org
      BUG=702697
      
      Review-Url: https://codereview.chromium.org/2853083002
      Cr-Commit-Position: refs/heads/master@{#468397}
      6c3d410e
    • bcwhite's avatar
      Restore tests for single-sample storage in histograms. · da4b9983
      bcwhite authored
      These tests were removed from the main CL because they were
      believed to be the cause of some instability in other tests.
      Without the tests, everything seems fine so now it's time to
      restore these.
      
      Main CL: https://codereview.chromium.org/2811713003/
      
      BUG=705342
      
      Review-Url: https://codereview.chromium.org/2850233002
      Cr-Commit-Position: refs/heads/master@{#468396}
      da4b9983
    • bnc's avatar
      Remove unused LifoWriteScheduler class. · ba7a5305
      bnc authored
      Review-Url: https://codereview.chromium.org/2852993002
      Cr-Commit-Position: refs/heads/master@{#468395}
      ba7a5305
    • sky's avatar
      Revert of CrOS: Fix appearance of notification toasts when sliding out via... · ba5c53c9
      sky authored
      Revert of CrOS: Fix appearance of notification toasts when sliding out via gesture (patchset #4 id:60001 of https://codereview.chromium.org/2849523005/ )
      
      Reason for revert:
      This appears to have broken message_center_unittests on chromium.win/Win10 Tests x64. See https://uberchromegw.corp.google.com/i/chromium.win/builders/Win10%20Tests%20x64/builds/11112/steps/message_center_unittests%20on%20Windows-10-10586 for one example.
      
      Original issue's description:
      > CrOS: Fix appearance of notification toasts when sliding out via gesture
      >
      > This converts SlideOutView to SlideOutController, which provides all the
      > same functionality but can be added to any view rather than just those
      > that extend it.
      >
      > It allows the target view to control the layer that's sliding out. For
      > toasts, that is the widget's layer. For notifications inside the message
      > center, that will continue to be the NotificationView itself.
      >
      > BUG=716429
      >
      > Review-Url: https://codereview.chromium.org/2849523005
      > Cr-Commit-Position: refs/heads/master@{#468339}
      > Committed: https://chromium.googlesource.com/chromium/src/+/3d7851ff607c370234e4f93ecf66727a8f8498d9
      
      TBR=yoshiki@chromium.org,estade@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=716429
      
      Review-Url: https://codereview.chromium.org/2850153003
      Cr-Commit-Position: refs/heads/master@{#468394}
      ba5c53c9
    • paulmiller's avatar
      A11y: Don't accounce password keystrokes twice · b042a7e5
      paulmiller authored
      When typing passwords on Android, TalkBack first announces the letter
      from the keyboard. When the letter is inserted into the password field,
      there is an AX_EVENT_TEXT_CHANGED, and TalkBack annaunces the inserted
      letter as "dot". Then after a delay, SecureTextTimer replaces the letter
      with a dot, causing a second AX_EVENT_TEXT_CHANGED, and TalkBack
      announces "dot" again. This suppresses the second AX_EVENT_TEXT_CHANGED.
      
      BUG=716212
      
      Review-Url: https://codereview.chromium.org/2846133002
      Cr-Commit-Position: refs/heads/master@{#468393}
      b042a7e5
    • rogerta's avatar
      Mark "external/wpt/fetch/api/basic/integrity-sharedworker.html" as crash. · 2b18a942
      rogerta authored
      BUG=717157
      TBR=qyearsley@chromium.org
      
      Review-Url: https://codereview.chromium.org/2849203002
      Cr-Commit-Position: refs/heads/master@{#468392}
      2b18a942
    • caseq's avatar
      Timeline: fix frame offsets in Timeline details · 55acd794
      caseq authored
      Review-Url: https://codereview.chromium.org/2850193002
      Cr-Commit-Position: refs/heads/master@{#468391}
      55acd794
    • khorimoto's avatar
      [CrOS Tether] Add the HasConnectedToHost network field to NetworkStateHandler. · 92916a4d
      khorimoto authored
      Currently, "false" is always passed as this parameter, but the parameter is properly utilized as part of a follow-up CL: https://codereview.chromium.org/2852693004/.
      
      BUG=672263
      
      Review-Url: https://codereview.chromium.org/2850993002
      Cr-Commit-Position: refs/heads/master@{#468390}
      92916a4d
    • robertshield's avatar
      Use new SafeBrowsing redirect tracking code in CWS pings. · 39d1ffe7
      robertshield authored
      The SafeBrowsing code tracks more types of redirects than the /net code which strictly adheres to spec and so can drop various types of redirects which can obscure the referrer chain.
      
      BUG=685905
      
      Review-Url: https://codereview.chromium.org/2779643002
      Cr-Commit-Position: refs/heads/master@{#468389}
      39d1ffe7
    • rogerta's avatar
      Disable ExtensionApiTest.Messaging for OS_WIN as it is timeout/flaky. · 6e2f717c
      rogerta authored
      BUG=681705
      
      Review-Url: https://codereview.chromium.org/2856613002
      Cr-Commit-Position: refs/heads/master@{#468388}
      6e2f717c
    • fmalita's avatar
      Add some missing Skia includes · 97c251f3
      fmalita authored
      SkCanvas.h will no longer pull SkBitmap.h and SkImage.h:
      https://skia-review.googlesource.com/c/14904.
      
      Include these explicitly, where needed.
      
      TBR=
      
      Review-Url: https://codereview.chromium.org/2853833002
      Cr-Commit-Position: refs/heads/master@{#468387}
      97c251f3
    • pfeldman's avatar
      DevTools: remove continue to location from behind experiment. · 191c1eb6
      pfeldman authored
      BUG=
      
      Review-Url: https://codereview.chromium.org/2849973003
      Cr-Commit-Position: refs/heads/master@{#468386}
      191c1eb6
    • sky's avatar
      Revert "Revert "Do not abort redirect responses with unadvertised encoding."" · 50576f3c
      sky authored
      This reverts commit da1b049f.
      
      The original patch landed before the first flake, so I don't think
      this is it. Reverting revert.
      
      OPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      R=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org
      TBR=eustas@chromium.org,holte@chromium.org,rdsmith@chromium.org,holte@chromium.org,mmenke@chromium.org
      BUG=716594
      
      Review-Url: https://codereview.chromium.org/2852123002
      Cr-Commit-Position: refs/heads/master@{#468385}
      50576f3c
    • sky's avatar
      chromeos: Disables a couple of tests for mus_browser_tests · 5ae1fa28
      sky authored
      These seem to be consistently failing on the bots.
      
      BUG=none
      TEST=none
      R=jonross@chromium.org
      
      Review-Url: https://codereview.chromium.org/2853733005
      Cr-Commit-Position: refs/heads/master@{#468384}
      5ae1fa28
    • sky's avatar
      Make tracing an embedded service · ad45c465
      sky authored
      This way we don't try to find tracing on disk, which as there is no
      data_dep is out of date.
      
      BUG=none
      TEST=none
      R=rockot@chromium.org
      
      Review-Url: https://codereview.chromium.org/2854633002
      Cr-Commit-Position: refs/heads/master@{#468383}
      ad45c465
    • yusukes's avatar
      Add arc_process_unittest.cc · 29581348
      yusukes authored
      arc::ArcProcess has a relatively complex operator<() which should be
      paired with a test. I'd add this before adding more changes for
      crbug.com/706048.
      
      BUG=None
      TEST=try
      
      Review-Url: https://codereview.chromium.org/2853633002
      Cr-Commit-Position: refs/heads/master@{#468382}
      29581348
    • fdoray's avatar
      Use TaskScheduler instead of blocking pool in chrome_screenshot_grabber.cc. · e6af56f1
      fdoray authored
      The blocking pool is being deprecated in favor of TaskScheduler.
      
      BUG=667892
      R=jamescook@chromium.org
      
      Review-Url: https://codereview.chromium.org/2841723002
      Cr-Commit-Position: refs/heads/master@{#468381}
      e6af56f1
    • jamiewalch's avatar
      Fix XMPP late response. · 38b76371
      jamiewalch authored
      BUG=
      
      Review-Url: https://codereview.chromium.org/2838993002
      Cr-Commit-Position: refs/heads/master@{#468380}
      38b76371
    • rbpotter's avatar
      Fix Print Preview failure state and add test · a7b31e1f
      rbpotter authored
      Prevent print preview error state from being unrecoverable by resetting
      the state when the user selects a new printer. Add test to check that
      the state resets and to check that the response to the INVALID_SETTINGS
      event is correct.
      
      BUG=708834
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
      
      Review-Url: https://codereview.chromium.org/2849733002
      Cr-Commit-Position: refs/heads/master@{#468379}
      a7b31e1f
    • yuweih's avatar
      [Remoting Client] DesktopViewport Implementation · 10b769e9
      yuweih authored
      This CL implements a class and some geometry tools to manipulate the viewport
      on a mobile client. For now this is only for iOS only. Later we should try to
      also use this on Android to reduce platform-specific codepaths.
      
      Review-Url: https://codereview.chromium.org/2843373005
      Cr-Commit-Position: refs/heads/master@{#468378}
      10b769e9
    • creis's avatar
      Disable failing sharedarraybuffer tests on Site Isolation FYI bots. · 978ff041
      creis authored
      BUG=717092
      TEST=Bot goes green.
      
      Review-Url: https://codereview.chromium.org/2852923003
      Cr-Commit-Position: refs/heads/master@{#468377}
      978ff041
    • robliao's avatar
      Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk · 3e27cb6e
      robliao authored
      This reverts commit f07732ec
      (https://codereview.chromium.org/2791933004)
      and reapplies b6d0c9a0
      (https://codereview.chromium.org/2690183002/).
      
      BUG=653916, 707986
      TBR=jam@chromium.org, rkaplow@chromium.org
      Previously reviewed at https://codereview.chromium.org/2690183002/
      
      Review-Url: https://codereview.chromium.org/2856583002
      Cr-Commit-Position: refs/heads/master@{#468376}
      3e27cb6e
    • acondor's avatar
      Fix controller positioning in VrShell when gyro reads are small · f00f17c2
      acondor authored
      BUG=716201
      
      Review-Url: https://codereview.chromium.org/2853843002
      Cr-Commit-Position: refs/heads/master@{#468375}
      f00f17c2
    • pkl's avatar
      Removes Native App Launcher functionality. · b9c3c20b
      pkl authored
      This is the first step of deprecating Native App Launcher. This step
      removes the functionality from Chrome so testing can start.
      
      There will be lots of dead code and unused classes/methods left after
      this step and they will be pruned in subsequent CLs.
      
      BUG=711511
      TEST=Tools > Settings > Google Apps should not be there. Visits to Maps or YouTube sites will not show infobar. Tapping on Maps or YouTube links may still launch Maps and YouTube app because of Universal Links.
      
      Review-Url: https://codereview.chromium.org/2821453003
      Cr-Commit-Position: refs/heads/master@{#468374}
      b9c3c20b