GitLab

This reverts commit 5b3ef591.

Reason for revert: causing failures on android-asan since commit, first failure:
https://ci.chromium.org/p/chromium/builders/ci/android-asan/6907

Original change's description:
> [COOP] Test allow-popup vs virtual-BCG.
> 
> Add a few more tests when navigating with one document using
> COOP:same-origin-allow-popup or COOP-Report-Only:same-origin-allow-popup
> (or both)
> 
> Bug: chromium:1090273
> Change-Id: I95bf3c4aaf2f2db5e8f0076c495f5c1872d77431
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279767
> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
> Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786221}

TBR=arthursonzogni@chromium.org,pmeuleman@chromium.org

Change-Id: I7d5dc3f4df187d232006caafb5820d8ef9527e2b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1090273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288430Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786372}

This significantly reduces the binary size of ANGLE and improves its
startup time.

Bug: angleproject:4763
Bug: angleproject:4814
Bug: chromium:1084580
Bug: chromium:1091440
Change-Id: I2345c6eee663e131a5141f2edada7ac95a6ee9ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281665Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786371}

1. Refactor SharedImageRepresentationSkiaVkAndroid to make it more generic
and usable.
2. Add its implementation to be used by SharedImageBackingAHB.

Bug: 1091945
Change-Id: I42e87978168925915f08e47876c56aac05e0b5f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287371Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786370}

PaintController::FinishCycle needs to be called after committing
display items and is used to free state such as raster invalidations.
The call to FinishCycle from GraphicsLayer::PaintRecursively has been
moved to LocalFrameView::RunPaintLifecyclePhase. This makes the
CompositeAfterPaint (CAP) and pre-CAP code more similar, as FinishCycle
is always called at the end of RunPaintLifecyclePhase. This approach is
needed for CompositeSVG (see: https://crrev.com/c/2250514) which needs
to delay raster invalidation until after PaintArtifactCompositor
updates (like CAP).

Bug: 1101002
Change-Id: I41fc782a0f9f2ca5e3fcd0fe55d9e12bcc643528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287813Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786369}

TBR=bling-team@google.com

Change-Id: I740b503f9c2585b07a53e8937130b4c44fc6d9a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287217Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786368}

Roll Chrome Win32 PGO profile from chrome-win32-master-1594205767-6ce6d14294fc2a08f2b1164184f19ff8db079629.profdata to chrome-win32-master-1594216727-af10bce0f9b1296f4a0f692869feeccf20c7185e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I1e7c26efd888a0cfcfce9ad512a8c8c2b5f900ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287783Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786367}

- Remove deprecated DISALLOW_COPY_AND_ASSIGN() usage, and private
  sections from structs as a result.
- Fix typos and lint errors.

Change-Id: I7a75f051bb8d8f21ed34589662e0f44a9abd1cee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285750Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786366}

I2S thread:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Ay1bG_e9m00/kpJVUINhBQAJ

Bug: 1076087
Change-Id: I0958427c73f5e7e9e3ba2f46ed4d0f7ee6edcb7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285249Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786365}

This reverts commit 47a0e3e7.

Reason for revert: broke WebKit Linux MSAN bot, see https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/6617

Original change's description:
> [WebCodecs] Add P3/Rec2020 uint8 support
> 
> This takes into account the color spaces of pixel data from
> ImageBitmap being encoded into VideoFrame.
> 
> Bug: 897297
> Change-Id: I5ee5b77eb067ce8f5cec91dbd584a1553f6e91f0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272134
> Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786156}

TBR=jie.a.chen@intel.com,sandersd@chromium.org

Change-Id: I11ed4108913b5935af2715184f5ac1cf153c09ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 897297
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288352Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786364}

On Linux, skia rendering is the default. Views examples application has
to override that to use GL for rendering instead. This override was
missed in the previous change @0678d778.

Bug: none
Change-Id: I102370418af4d8b761a61d039322fff12947ff54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286479Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786363}

https://skia.googlesource.com/skia.git/+log/cfbb56c6e180..f0288101b5fc

2020-07-08 robertphillips@google.com Remove SkCanvas::getGrContext calls from benches
2020-07-08 johnstiles@google.com Remove deprecated form of `asFragmentProcessor` method.
2020-07-08 johnstiles@google.com Add support for an inputFP in SkRuntimeColorFilter::asFragmentProcessor.
2020-07-08 nifong@google.com [canvaskit] Fix first frame measurement
2020-07-08 johnstiles@google.com Add support for an inputFP in SkHighContrast_Filter::asFragmentProcessor
2020-07-08 herb@google.com loop over SubRuns in GrRenderTargetContext

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: mtklein@google.com
Change-Id: I5adb7d015dbfe30267cff6d7a8976087170d9bab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287780Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786362}

Bug: 1103267
Change-Id: I6d05e1fba9a74c998146cc5d34219e3c8db6964b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287385
Commit-Queue: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786361}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I2cf28b3e448f70ac7bb8afa6d4690cfaa3f0e4f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287213Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786360}

When a RenderWidgetHostViewChildFrame is created, any calls to
GetScreenInfo() will default to getting the default ScreenInfo if the
view's FrameDelegate hasn't been attached yet. This can lead to
incorrect sizing if the view is on a secondary monitor with a different
device scale factor.

But at time of the view's creation we do know the parent view, so we
can give the child view a copy of it on creation. This CL allows an
initial ScreenInfo to be set on the RenderWidgetHostViewChildFrame at
creation time.

Bug: 966852
Change-Id: Ie80c617d8c6c741c33cfbddfdd63282ff28b1e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283404Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786359}

This change adds Chrome flags for the LiteVideo optimization and to
force override the decision logic. This also adds a switch to ignore
just the network settings to make the testing now and in the future
easier.

Bug: 1102904
Change-Id: I47e6c005e434e729652998804fcb6233d42c370f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284978
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786358}

This reverts commit e0f5a1c0.

Reason for revert: Breaking downstream builder:
https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8875332406729172240/+/steps/compile/0/logs/raw_io.output_failure_summary_/0

Original change's description:
> Reland "Android: Bump default target_sdk_version 24 -> SDK used to compile"
> 
> This reverts commit fb07fcff.
> 
> Reason for reland: Not changing target_sdk_version for angle tests
> 
> Original change's description:
> > Revert "Android: Bump default target_sdk_version 24 -> SDK used to compile"
> >
> > This reverts commit b7fb15b1.
> >
> > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1099849
> >
> > Original change's description:
> > > Android: Bump default target_sdk_version 24 -> SDK used to compile
> > >
> > > Why do this?
> > > * It's best practice to target the latest sdk, so this makes for a
> > >   better default.
> > > * Many targets were neglecting to ever update this value
> 
> TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,behdadb@chromium.org
> 
> Bug: 1099849
> Change-Id: I95f36a2b88d2e7ad1d90222f25192c9a915550ab
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280981
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786275}

TBR=boliu@chromium.org,agrieve@chromium.org,behdadb@chromium.org

Change-Id: If60966b54d37bfa2c5326bcad0f36819f1c47023
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1099849
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288092Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786357}

This change updates SetCanonicalCookie to return CookieAccessResult
instead of CookieInclusionStatus. This is one of many steps to
consistently use CookieAccessResult so CookieStore will eventually
be able to return EffectiveSameSite for SameSite across all its
endpoints.

Bug: 1092695
Change-Id: I38ae51fee78ba6a88c05447ec7516ff20e4bfe97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264511Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786356}

When the System-proxy service in CrOS sends an AuthenticationRequired
signal for a specific protection space (proxy url, scheme, realm), the
SystemProxyManager inside the Browser looks for the credentials added by
the user.

If found, it will send the credentials and protection space to
System-proxy via dbus. If no credentials are found or no user has
signed in yet, it will send the protection space with empty credentials
to signal that the request was processed.

BUG=1042642
TEST=unittest, tested on DUT

Change-Id: Id427d962d22171a41586f51d2936a73bfe8694e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246163Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Omar Morsi <omorsi@google.com>
Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
Cr-Commit-Position: refs/heads/master@{#786355}

Bug: 1071603
Change-Id: If1dd2c1cd005aebcd27cac1a3c80d43f7586d473
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287382Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786354}

BUG=1102412

Change-Id: I558cbc1b94791354d1b133bf59f5fcb57722387c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286471Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786353}

This is a reland of aafd725a

Original change's description:
> [ios] Add --landmines-path to build/landmines.py script
> 
> Chrome on iOS has some internal landmines and uses a forked version
> of build/landmines.py for that to allow using a separate landmines
> file.
> 
> Add a --landmines-path parameter to build/landmines.py script in
> order to remove the forked version and instead use the shared one.
> 
> Bug: 1033067
> Change-Id: Iac668c5877ae181442078cda7ce8e727f91104b4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283582
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786218}

Bug: 1033067
Change-Id: Ice49ba16caf21045e0b513fb4b55cf198d3f0d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287477Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#786352}

https://android.googlesource.com/platform/external/perfetto.git/+log/c103a111af91..9ea6876dcac5

2020-07-08 treehugger-gerrit@google.com Merge "Port the scroll flow breakdown into a trace processor metric."
2020-07-08 lalitm@google.com tp: hook up /query http method to new query serialization logic

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I83e5aba6ea2e4fae47ad27ed87cc4eefe92eacaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287786Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786351}

Trying to assign a string literal to a |char*| pointer results in the
following compilation error:

    error: ISO C++11 does not allow conversion from string literal to
    'char *' [-Werror,-Wwritable-strings]

This CL:
*) Avoids (char*)"string literal" casts
*) Changes the type of corresponding fields from |char*| to |const char*|

Bug: 1080832
Change-Id: Ie92eed766acec232a9e6b971f5f5d5569914dba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287911
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786350}

We wish to know whether a request to which variations headers will be
appended is from a frame whose top-level domain is a Google-owned web
property, e.g. YouTube, DoubleClick, etc.

In order to determine this context for a subframe-initiated subresource
request on the renderer side (e.g. a request to DoubleClick from an ad
on foo.com), we cannot use ResourceRequest::TrustedParams because they
are not populated. It is, however, possible to determine the context in
the renderer and to pass it along to the code that appends headers.

Bug: 1094303
Change-Id: I6d62b1ba52425a9b0d80d56b20326e23b6949263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276231
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786349}

This cannot be done in a single CL, so adding the new API to AppHooks
and deprecating the old.  After a chrome-internal roll we can remove
the deprecated one.

Change-Id: Ie848c5cb3066b531e02fe57c1824030981b907c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285471Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786348}

R=raleksandrov@google.com

Bug: 1097010
Change-Id: If875d3432637a6aba452039d0374467276705381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266612Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Danila Kuzmin <dkuzmin@google.com>
Cr-Commit-Position: refs/heads/master@{#786347}

We should contain Referrer header when a download is triggered
via anchor tag with download attribute.

Bug: 455987
Change-Id: I599abab8192095c7d4e6703807fa936b6c8e2024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262023
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786346}

Describes both building for and on arm macs.

Bug: 1098899,1103236
Change-Id: Iac5becb22ba07453765b10c854b47182d96c98e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287899
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786345}

If user data needs to be saved after shut down, call Chrome DevTools Protocol
browser.close. If browser.close failed, call KillProcess.
Do not call closeWebview when only one window left.

Bug: chromedriver:3370
Change-Id: I9022500332e0f971d9535ae2117c88f577144c5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283057Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Shengfa Lin <shengfa@google.com>
Cr-Commit-Position: refs/heads/master@{#786344}

For simple boolean equality checks, this converts those to
the Callable<Boolean> syntax, for all other checks, these are
converted to Criteria.checkThat(...)

BUG=1071247

Change-Id: I4f63fed847337867bb161b8b93bcd3e5a4e781ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286151
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786343}

Close() is confusing as people might relate to MediaKeySession::close().
Also, the current names are not consistent with what we use in other
parts of the stack, making code search harder.

This CL renames the methods to make it consistent with what use
everywhere else.

Tbr: dcheng@chromium.org
Change-Id: Ia9dd8c17ac11b9276efc0f4133f6002dea2a524c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277339Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786342}

BUG=1101315

Change-Id: I650582530cb48a209b489777325f672714bec041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284149Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786341}

Also changed to check the threshold with character size instead of byte
size.

Bug: b/160639930
Test: unit tests
Change-Id: I0cefba23ef46ce7bda7ccb57adf3c46481f0d389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285509Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786340}

Regressed in 7bb74836 due to an inverted
condition.

Bug: 1098217
Change-Id: I7e5cc46994e7df4ac66a1bbc2681af679d1ce736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283938Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786339}

This is split off from https://crrev.com/c/2286475 to facilitate
reviewing and any follow-up debugging.

Change-Id: Ie2a3a9fdd8f7e1d714c3e642ee18cb3fe5e53ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285926
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786338}

This change automatically grants location permissions to the default
search engine in WebLayer. For now, the DSE is hardcoded to
https://www.google.com and cannot be changed. If more complex logic is
needed in the future, it should be possible to share Chrome's DSE
permission logic. See go/weblayer-search-permissions for more
background.

The permission in site settings will link to the client app's settings,
similar to how notification permissions work for TWAs. The code to set
up the preferences was refactored so it can be shared.

Bug: 1063433
Change-Id: I1933e0b788d981d0aa0535ece9b4386afc37b619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283058
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786337}

Bug: 1071603
Change-Id: Id09d23f85aa3cca1dc7b42b49cf01995ce3cd2e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287950Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786336}

Fix and re-enable a couple tests for ink drop ripple. Add unit tests for
ink drop mask.

Bug: none
Change-Id: Ifa9f350f73fed05016982f7de03db5b8e3632361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272132
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786335}

The issue is suspected to be fixed: http://anglebug.com/3935#c33

Bug: angleproject:3935
Tbr: kbr@chromium.org
Change-Id: I0d7fd0e51070d45b77b1577c62b479f62e8a0b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283327Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786334}

The Mobile.Splash.HideSplashWhenFinishing UMA histogram is hit
thus the cause for the
https://bugs.chromium.org/p/chromium/issues/detail?id=1096171
NullPointerException is likely solely SplashController#hideSplash()
being called while the activity is finishing.

This CL:
- Removes Mobile.Splash.HideSplashWhenFinishing histogram
- Reverts code added in
  https://chromium-review.googlesource.com/c/chromium/src/+/2259483
  which handles a different theory of how
  ChromeActivity#getCompositorViewHolder() can be null

BUG=1101637

Change-Id: I598d0145ce1e456d35884ea7eb1eb18cef914a6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283247Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786333}