GitLab

It takes 30+ seconds to finish each of them with Release build.

BUG=490939
TBR=kojii@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2483783002
Cr-Commit-Position: refs/heads/master@{#430221}

BUG=none
R=chrishtr@chromium.org, wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2449183006
Cr-Commit-Position: refs/heads/master@{#430220}

These fail as well as timeout on Debug bots.

BUG=626703, 662765
TBR=qyearsley@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2480153002
Cr-Commit-Position: refs/heads/master@{#430219}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ae24592f..771b75bc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2479063002
Cr-Commit-Position: refs/heads/master@{#430218}

Just adding interfaces in blink side and implementing them in follow-up CL.
The interfaces are behind a new runtime flag.

Intent to implement:
  https://groups.google.com/a/chromium.org/forum/m/#!topic/blink-dev/2ojnMk_T9_c

BUG=661608

Review-Url: https://codereview.chromium.org/2472723003
Cr-Commit-Position: refs/heads/master@{#430217}

This CL makes URLLoader and URLLoaderClient associated for mojo-loading in
order to deal with the IPC ordering issue with the exising IPC messages.

BUG=603396

Review-Url: https://codereview.chromium.org/2449933003
Cr-Commit-Position: refs/heads/master@{#430216}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/63d17e18381b..d564ff3bb656

$ git log 63d17e183..d564ff3bb --date=short --no-merges --format='%ad %ae %s'
2016-11-06 petarj PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS

BUG=pnacl-llc aborts on run_vector_extension_test for MIPS

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review-Url: https://codereview.chromium.org/2481073002
Cr-Commit-Position: refs/heads/master@{#430215}

Adds support for sticky header rows to tray icon scroll views. When
marked as sticky the headers will not scroll above the top of the
visible viewport unless there is another sticky header row just below.
Multiple rows can be indicated as header rows by setting View::id_.

BUG=631831

Review-Url: https://codereview.chromium.org/2453133002
Cr-Commit-Position: refs/heads/master@{#430214}

Cr-Commit-Position: refs/heads/master@{#430213}

TBR=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2483763002
Cr-Commit-Position: refs/heads/master@{#430212}

This patch converts the layout test with spellcheck_test as a
preparation for implementing idle time spellchecker.

This patch also contains a performance optimization to spellcheck_test
in handling CharacterData nodes with long text.

BUG=517298

Review-Url: https://codereview.chromium.org/2455883003
Cr-Commit-Position: refs/heads/master@{#430211}

BUG=662693
TBR=bartfab@chromium.org, kainino@chromium.org

Review-Url: https://codereview.chromium.org/2477233002
Cr-Commit-Position: refs/heads/master@{#430210}

Native Mac NSAlert dialogs show the dialog buttons on the TouchBar, we
want similar behaviour for Chrome dialogs.

If a Widget's delegate implements views::DialogDelegate, add buttons to
the touchbar for the "OK" and "Cancel" buttons. Note the labels might
not necessarily be labeled "OK" and "Cancel".

Nearly all dialogs and bubbles work correctly with the TouchBar this
way. One exception is the Add Bookmark bubble -
LocationBarBubbleDelegateView::GetDialogButtons() returns
ui::DIALOG_BUTTON_NONE. That makes sense for the ZoomBubble.
SaveCardBubbleViews overrides again to return both buttons and works.
The translate bubble has "TODO: This should be using GetDialogButtons."

Screenshot: http://crbug.com/660126#c13

BUG=661581

Review-Url: https://codereview.chromium.org/2469213002
Cr-Commit-Position: refs/heads/master@{#430209}

As observation in https://crbug.com/658702, I found the mojo error handler
(EWInstance::Detach in this case) is called on the UI thread when the message
loop on the UI thread gets destructed though EWInstance is on the IO
thread. This patch is to check the running thread before the error handling to
avoid unexpected threading issues.

BUG=658702,604762

Review-Url: https://codereview.chromium.org/2467223002
Cr-Commit-Position: refs/heads/master@{#430208}

Results in multiple calls to getCharacteristic(s) to return the same object.

BUG=495270

Review-Url: https://codereview.chromium.org/2474863004
Cr-Commit-Position: refs/heads/master@{#430207}

Remove services from attribute instance map when a device disconnects or when disconnect is called.
Check that the service is in the attribute instance map and reject if it isn't.

Small refactor of disconnect() and dispatchGattServerDisconnected() to more closely
match the spec.

BUG=654950

Review-Url: https://codereview.chromium.org/2478013002
Cr-Commit-Position: refs/heads/master@{#430206}

BUG=626703,662765
TBR=qyearsley@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2483753002
Cr-Commit-Position: refs/heads/master@{#430205}

effect-reference-tile.html flaky on Win
Passed: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/47565
Failed: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/47566

margin_left.html NeedsManualRebaseline (missed in the batch added in r430198)

BUG=662722
NOTRY=true
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2479053002
Cr-Commit-Position: refs/heads/master@{#430204}

These failed in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/19591
but not in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/19590
after being rebaselined in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/19588

They seem to rely on hover effects and have a history of flakiness in TestExpectations.

BUG=662722
NOTRY=true
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2483743002
Cr-Commit-Position: refs/heads/master@{#430203}

Failing since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/16850 (initial landing)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/16855 (autorebaseline)

BUG=662722
NOTRY=true
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2481673002
Cr-Commit-Position: refs/heads/master@{#430202}

Crashes flakily. Couldn't find a culprit.

BUG=662688
TBR=tzik@chromium.org,boliu@chromium.org

Review-Url: https://codereview.chromium.org/2484543002
Cr-Commit-Position: refs/heads/master@{#430201}

- Add imported/wpt/dom/nodes/Document-createElement*.html which are currently
  failing on the bots.

- Merge tests with crbug.com/619746 into the section of crbug.com/508730.

- Triage some tests associated to crbug.com/508734

BUG=619746, 508730, 508734
TBR=qyearsley@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2476173003
Cr-Commit-Position: refs/heads/master@{#430200}

Blink has some loose heuristics to ignore images, even ones that are important for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2479593007
Cr-Commit-Position: refs/heads/master@{#430199}

Since:
Win - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/47558
Mac - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/39067
    - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/5749
HiDpi - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20%28dbg%29/builds/914

BUG=662722
NOTRY=true
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2481063002
Cr-Commit-Position: refs/heads/master@{#430198}

http://crrev.com/2369673003 introduced code to close the chooser when the
window looses focus. This works great for when the user switches apps but
it sadly causes the chooser to get closed when the permission prompt opens
up. Then when the user accepts the permission request chrome crashes
because the chooser was closed.

Checks if the chooser is still opened before restarting the scan.

Changes the testing framework to simulate a focus change when requesting
permission and adds asserts to make sure native functions are not being
called after the native object has been destroyed.

BUG=661770

Review-Url: https://codereview.chromium.org/2476563002
Cr-Commit-Position: refs/heads/master@{#430197}

BUG=

Review-Url: https://codereview.chromium.org/2387943002
Cr-Commit-Position: refs/heads/master@{#430196}

BUG=662495

Review-Url: https://codereview.chromium.org/2477173002
Cr-Commit-Position: refs/heads/master@{#430195}

https://chromium.googlesource.com/chromium/src/+/96c45c379

BUG=662722
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/2483723002 .

Cr-Commit-Position: refs/heads/master@{#430194}

Fallout from https://codereview.chromium.org/2457393004/

BUG=662722
TBR=liyuqian@chormium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2479023002
Cr-Commit-Position: refs/heads/master@{#430193}

https://skia.googlesource.com/skia.git/+log/9c46b68d5340..f98b730af08d

$ git log 9c46b68d5..f98b730af --date=short --no-merges --format='%ad %ae %s'
2016-11-06 mtklein Call ~SkRasterPipelineBlitter() on early out.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=scroggo@google.com

Review-Url: https://codereview.chromium.org/2484533002
Cr-Commit-Position: refs/heads/master@{#430192}

Fallout from https://codereview.chromium.org/2457393004/

BUG=662722
TBR=liyuqian@chromium.org,ajuma@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2481663002
Cr-Commit-Position: refs/heads/master@{#430191}

https://skia.googlesource.com/skia.git/+log/301dfc0bba37..9c46b68d5340

$ git log 301dfc0bb..9c46b68d5 --date=short --no-merges --format='%ad %ae %s'
2016-11-06 benjaminwagner Revert "Further centralize computation of GrSurface VRAM consumption"
2016-11-06 benjaminwagner Revert "Limit GL_TEXTURE_RECTANGLE filtering to bilinear."

BUG=662630,662630

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=scroggo@google.com

Review-Url: https://codereview.chromium.org/2480113002
Cr-Commit-Position: refs/heads/master@{#430190}

(This is our third attempt, which has the same diff as our attemp 2 https://codereview.chromium.org/2459433003/)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

R=fmalita@chromium.org
TBR=ajuma

patch from issue 2407393003 at patchset 20001 (http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review URL: https://codereview.chromium.org/2457393004 .

Cr-Commit-Position: refs/heads/master@{#430189}

https://skia.googlesource.com/skia.git/+log/db64acacf9c4..301dfc0bba37

$ git log db64acacf..301dfc0bb --date=short --no-merges --format='%ad %ae %s'
2016-11-06 update-skps Update SKP version

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=scroggo@google.com

Review-Url: https://codereview.chromium.org/2481013002
Cr-Commit-Position: refs/heads/master@{#430188}

* wptserve:
  Map imported/wpt_automation/ to //web-platform.test:*/wpt_automation/

* testharnessreport.js:
  Use /wpt_automation/ instead of LayoutTests/imported/wpt_automation/ if we run
  tests on WPTServe.

* update-the-source-set-expected.txt
  Rebaseline because it contains line numbers of testharnessreport.js.

BUG=627008

Review-Url: https://codereview.chromium.org/2468283004
Cr-Commit-Position: refs/heads/master@{#430187}

1. Add vector icons ime_menu_on_screen_keyboard.*.icon for on-screen keyboard.
2. Add new class MaterialKeyboardStatusRowView in ImeListView to show the keyboard row: a on-screen keyboard, a label and a toggle button.
3. Makes s shown only for MD and sticky when scrolling.
4. Updates the ImeInfoView as simple Label+Label+Image with TriView. And updates the id size.

* Still needs follow-up CL to make MaterialKeyboardStatusRowView has shadow and shown in opt-in IME menu.

BUG=657146, 642385, 652677
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2469663002
Cr-Commit-Position: refs/heads/master@{#430186}

BUG=654684

Review-Url: https://codereview.chromium.org/2469963003
Cr-Commit-Position: refs/heads/master@{#430185}

Use std::unique_ptr instead of deprecated linked_ptr.

BUG=556939

Review-Url: https://codereview.chromium.org/2466523002
Cr-Commit-Position: refs/heads/master@{#430184}

This change implements GetSourceList() and SelectSource() function in all
DesktopCapturer derived classes.

After this change, and https://codereview.chromium.org/2479553006/,
GetSourceList() and SelectSource() can be changed to pure virtual functions in
WebRTC.

BUG=webrtc:6513

Review-Url: https://codereview.chromium.org/2483483004
Cr-Commit-Position: refs/heads/master@{#430183}

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Review-Url: https://codereview.chromium.org/2480713003
Cr-Commit-Position: refs/heads/master@{#430182}