GitLab

 - Nested controls are removed:
 The aria attributes of buttons inside <a> links are removed,
 so they won't be read twice by a screen reader.

 - Missing aria labels are added to radio buttons.

Bug: 853996
Change-Id: I9e009425c4d6cc0c03135856135fb830d96cf989
Reviewed-on: https://chromium-review.googlesource.com/1206810
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589371}

Background fetch wasn't unregistering the provider on destruction which
is why there was a crash when trying to open download home.

Bug: 877670
Change-Id: I955a65694fb67aa8d4285a8e18ff2a37f2b220cc
Reviewed-on: https://chromium-review.googlesource.com/1211623Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589370}

Offline Pages namespaces can be configured to only allow its pages to be
presented in their original tabs. This is enforced using an undeclared
convention that pages for these namespaces will store the tab id value
in the ClientId::id field for their pages. This change makes this
convention more explicit.

Bug: 879801
Change-Id: I3ab3d871abb41d6de9112c55d8b3d8b6491c7386
Reviewed-on: https://chromium-review.googlesource.com/1200389
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589369}

DirectoryLoader contains a feature where it can fast fetch a directory based on
the start page token for the parent and the start page token that represents the
last time the directory was fetched.

Each team drive has it's own start page token, and in this case we were not
passing the team_drive_id when fetching the start page token, which means we
were getting the start page token for the users default corpus, which
effectively broke fast fetching for team drives.

The fix is to pass the team drive id to directory loader so it can then
retrieve the right start page token from resource metadata.

Patch comes with a test \o/.

Bug: 783184
Change-Id: Ic8c19efe8ea9bbffa4c97ba0a0d49f5debe2c97b
Reviewed-on: https://chromium-review.googlesource.com/1207779
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589368}

Since desktop capture has moved to using its own buffer pool implementation,
method ResurrectLastForProducer() in media::VideoCaptureBufferPool is no
longer used. This CL removes the method.

Bug: 879264
Change-Id: Ia24c683c8e63bc5b0d1bdc800e8c7d491f7c7c89
Reviewed-on: https://chromium-review.googlesource.com/1208952Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589367}

This patch allows updateWith() take shippingAddressErrors parameter.

Test: chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

Bug: 861704
Change-Id: I6c67e0c6c8fbd56d389ab279a1bc7816983a6b65
Reviewed-on: https://chromium-review.googlesource.com/1201625Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#589366}

In AppCacheStorageImpl::StoreGroupAndCacheTask::Run(), it has not checked
whether new appcache usage exceeds the maximium cache size. This CL adds
the check condition to AppCacheStorageImpl::StoreGroupAndCacheTask::Run().

Bug: 824619
Change-Id: Ic289f69cebcc60f06fc852072e9c50af831b8737
Reviewed-on: https://chromium-review.googlesource.com/1203752Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#589365}

This CL adds detection of cached DRP responses for the purpose of making
different previews types (with different cache affinities) easier to
compare.

A follow-up will add whether the main frame response was cached or not
to the PLM pingback proto.

Bug: 880655
Change-Id: I1591d2f10823514648bb05bd0d26cb7ae97a7244
Reviewed-on: https://chromium-review.googlesource.com/1208938
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589364}

Bug: 879020
Change-Id: I17b124d79daf101778395b235ec503fcb9179ea5
Reviewed-on: https://chromium-review.googlesource.com/1211738Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589363}

Adds 5 new histograms:
* Previews.ServerLitePage.BlacklistReason - tracks blacklist usage
* Previews.ServerLitePage.FallbackPenalty - the amount of time spent on
  loading a fallback
* Previews.ServerLitePage.IneligibleReason - the reason a preview wasn't
  triggered
* Previews.ServerLitePage.ServerResponse - the response type of the
  previews server
* Previews.ServerLitePage.Triggered - whether or not the preview was
  triggered

Also fixes the subframe test case which was broken.

Bug: 864635
Change-Id: If61cbc65a272091172937dfa0d4833bf9ccb1f47
Reviewed-on: https://chromium-review.googlesource.com/1200074
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589362}

DataReductionProxyIOData historically added previews_decider_ member to
support AMP redirection, but this is not longer used.

Bug: 842233
Change-Id: If4b5a9a9a7c259fc0552de20a15e4d723a52e773
Reviewed-on: https://chromium-review.googlesource.com/1211842Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589361}

R=cmasso@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2f51a21a62b3de4a12b8a0af0f5d7bac44d71046
Reviewed-on: https://chromium-review.googlesource.com/1211914Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589360}

On Mac, tab fullscreen mode doesn't show top UI while browser fullscreen
mode may show top UI depending on user's preference. When Chrome exits
from tab fullscreen, it needs to reset the top UI style to the one
corresponding to browser fullscreen. In addition, if it exits from tab
fullscreen to browser fullscreen, a re-layout may be triggered if top
UI needs to be shown.

This CL fixes the problem by calling UpdateUIForTabFullscreen() when
Chrome exits tab fullscreen, no matter it is going back to browser
fullscreen mode or normal state. So it can update the top UI status
correctly.

This CL also adds reading initial toolbar style value from user
preference.

BUG=879158

Change-Id: I3f2742cad2107667c562701a981f3240f29538bf
Reviewed-on: https://chromium-review.googlesource.com/1208721Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589359}

This makes sure that if the user types in a property exactly, it will
always be the default selected suggested item.

Bug: 879351
Change-Id: I4425e105ff9381e164b3455f5e727c28e3b2d931
Reviewed-on: https://chromium-review.googlesource.com/1211862
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589358}

This CL updates the behavior of fullscreen such that the toolbars will
be re-shown when the user starts a scroll past the bottom of a page
when the toolbars are completely collapsed.

Bug: 841094
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9e2cb3a59e931f83bb43e8a68df48a80bb6d0c3b
Reviewed-on: https://chromium-review.googlesource.com/1200563
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589357}

Previously, if we save a card twice in a row, the second time the animation needs to be shown, it would just show static text. The animation continues to glitch for each subsequent use.
Now the animation works properly each time it is invoked.

This also applies to the pop-up blocker's "Pop-up blocked" text animation.

Bug: 855186,881324,881320
Change-Id: Ie6f8a53a24d5ec4dd06b9ead27b784fc46a26310
Reviewed-on: https://chromium-review.googlesource.com/1208140Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#589356}

Register and download the demo mode resources CrOS component during
online demo mode setup. This happens before online enrollment starts.

Also updates offline-enrolled Demo Mode to always use the offline
resources image instead of attempting to download the CrOS component.

Bug: 869455
Change-Id: I6a947eab916f68bba4730a9ab611136be7fe1bc1
Reviewed-on: https://chromium-review.googlesource.com/1198018
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589355}

Using wpt-import in Chromium a3895348.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24196

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Ib75a8ff8ee0a7f3bf3011ab31088fddcb4d37144
Reviewed-on: https://chromium-review.googlesource.com/1211843
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589354}

Clear the |*base|-address out-parameter to null in case of blocking, to
ensure that calling-code won't get confused by seeing a failure NTSTATUS
with a non-null base-address.  e.g. Win32's MapViewOfFile() returns the
base-pointer as its result, using null to indicate failure, and leaves
the Win32 GetLastError() set based on the NTSTATUS.

Bug: 864351, 870663
Change-Id: I0aa2aacd1075224100d10d6291a416849f6d227b
Reviewed-on: https://chromium-review.googlesource.com/1211322Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589353}

This reverts commit 0c9c754f.

Reason for revert: Underlying issue (crbug.com/880203) is fixed.

Original change's description:
> Mark InterstitialPageTest#testCloseInterstitial as flaky
> 
> Bug: 879757
> 
> Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24
> 
> TBR=boliu@chromium.org
> 
> Change-Id: Ib8fbd95f086d95fc0f1ac00526059a7383e2ca24
> Reviewed-on: https://chromium-review.googlesource.com/1200165
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588214}

TBR=boliu@chromium.org,oksamyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 879757
Change-Id: I6c31bda83ad0a72c76fcb4054b14343478f7683f
Reviewed-on: https://chromium-review.googlesource.com/1211960Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589352}

Bug: 870903, 866839
Change-Id: I9747dfdb7c682c86c3aae201db7e74faa126aaf8
Reviewed-on: https://chromium-review.googlesource.com/1184314Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589351}

This CL fixed the CastRemotingConnector to support OffscreenTab
mirroring/remoting using Mirroring Service. However, when Mirroring
service is not used, remoting an OffscreenTab is still not supported.

Bug: 734672
Change-Id: I09aab2d76be9d1b466d5c54a3d5eb66c7a6ff83f
Reviewed-on: https://chromium-review.googlesource.com/1200321
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589350}

Add comments explaining different results for NetworkContextTest.ProxyErrorClientNotifiedOfPacError on iOS.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iee8707645813ad7af92f7a4e84403ccacc22abd0
Reviewed-on: https://chromium-review.googlesource.com/1208932
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589349}

Adds screen brightness mojo methods to assistant device API.  Generalizes
volume action methods to handle slider actions.

BUG:b/78189672
BUG:b/111130167

Change-Id: I5a8759478ec6ecef5b950839d644bca11cd88bbc
Reviewed-on: https://chromium-review.googlesource.com/1194984
Commit-Queue: Ryan Cui <rcui@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589348}

BUG=chromium:879737
TEST=This is a test case.

Change-Id: I57c11e9ad663081ec6ee56b5dd4afa58db470384
Reviewed-on: https://chromium-review.googlesource.com/1211113Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589347}

https://pdfium.googlesource.com/pdfium.git/+log/59d21660a3d9..aaff8f8b902a


git log 59d21660a3d9..aaff8f8b902a --date=short --no-merges --format='%ad %ae %s'
2018-09-06 hnakashima@chromium.org Discard deps that are not sync'ed anymore in safetynet_compare.py.


Created with:
  gclient setdep -r src/third_party/pdfium@aaff8f8b902a

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id9422dca4b077437ff7f7672fa01d7f3ab401435
Reviewed-on: https://chromium-review.googlesource.com/1211865Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589346}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/41db1841..e1220339

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I26eb6a975247973694e3d72c7a6bffd99c9420a3
Reviewed-on: https://chromium-review.googlesource.com/1211903Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589345}

The following parameters are added:
1) Select either top or bottom snackbar
2) Set stable offline wait time
3) Allow to bypass getting connectivity info from system and run our
own http probes

Bug: 881064
Change-Id: I72bbb82f2deb9f6222d25191380c048a53a4c815
Reviewed-on: https://chromium-review.googlesource.com/1208445Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589344}

Send the encryption key to network service so that the process
does not request the item from the keychain directly, which would
cause macOS to show a confirmation prompt.

Bug: 880522
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia1067bf809472653d843b9007a45574bfe10ed2c
Reviewed-on: https://chromium-review.googlesource.com/1208457
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589343}

The delegates communicate through 2 channels in the android
implementation:
1. WebXrPresentationState, owned by the scheduler.
2. The public interface of VrShellGl. Ideally, this interface should
remain very small to ensure the task separation.

VrShellGl now only implements the CompositorDelegate, and it's soon to
be renamed. RenderLoop now owns the delegates.

Bug: 875291
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia30e62ed249b5fc0682b8f2b943eef615408daa3
Reviewed-on: https://chromium-review.googlesource.com/1191864
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589342}

This is necessary so the initial bounds can be calculated correctly.
The app window requests a size for the content bounds and
ClientSideNonClientFrameView tacks on kTopViewInset.

Bug: 880584
Change-Id: I0584e6aef313cde4e17bcf7c58a59830815ff831
Reviewed-on: https://chromium-review.googlesource.com/1208937Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589341}

Bug: 854101
Change-Id: Id53834ff2b3e596e22b22b6e8878247fd904abe2
Reviewed-on: https://chromium-review.googlesource.com/1209707Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589340}

Removes client_created_windows_ and folds into known_windows_map_.

This also ensures embedded clients can't intercept events.

BUG=none
TEST=covered by tests

Change-Id: I529d553c0079287b18c7feaab67b81fda65d412f
Reviewed-on: https://chromium-review.googlesource.com/1211952Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589339}

Tbr: kojii@chromium.org
Bug: 881110
Change-Id: Ib1007641d09eec0ad372f2641bec77bc1c8643c8
Reviewed-on: https://chromium-review.googlesource.com/1211709Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589338}

Bug: 875088
Change-Id: Ied195d731d991553fc3df4243c131a633111e38d
Reviewed-on: https://chromium-review.googlesource.com/1204722Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589337}

This script that runs in the VM only runs after all the test binaries &
deps have been pushed. Consequently if a test generates crash dumps, it
won't get cleaned up until the next test pushes all its deps (which
might not fit in the VM since there's left-over crash dumps.)

This fixes that by ensuring that the test that generates the dumps also
cleans them up.

Bug: 880878
Change-Id: Icfe1559d244053998cace31bfc19f5c1606770b9
Reviewed-on: https://chromium-review.googlesource.com/1211706Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589336}

This CL changes the creation of anonymous shared memory on Windows to
remove name generation on versions < 8.1. This was originally added as
Windows would ignore the security of an unnamed object on XP -> 7, however
from at least Windows 8.1 this is no longer the case as we can create
unnamed shared memory (which will reduce memory usage slightly as well as
clutter in the user's named objects directory) while still enforcing the
security requirements. While this is likely to work on Windows 8 it'll
only be enforced for 8.1 and above due to a lack of testing for 8.

This CL applies the same changes in shared_memory_win to the platform
shared memory APIs which just copied the original implementation.

Bug: 880064
Change-Id: I3c61c01823a78d09ac6d220b647b26a07821ab39
Reviewed-on: https://chromium-review.googlesource.com/1209603Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589335}

As part of the MultiDevice Unified Setup project, the Chromebook is
supposed to notify the user for each of the following situations:
(1) A user who has not been through the Unified Setup Flow has a phone
    capable of hosting some MultiDevice features (a.k.a. 'new host'),
(2) A user who has already been through the Unified Setup Flow has a
    new host phone on their accounts (a.k.a. 'host switched'), or
(3) The currently logged in account went through the Unified Setup Flow
    on a different Chromebook (a.k.a. 'Chromebook added').

In the original design, implemented in
https://chromium-review.googlesource.com/c/chromium/src/+/1081287 and
https://chromium-review.googlesource.com/c/chromium/src/+/1089828

the Chromebook would have a bit in its preferences to indicate that it
had been enabled as a MultiDevice client. However we no longer perform
the verification necessary for to turn this on as part of the Unified
Setup flow so the bit is longer a valid basis for determining whether/
when to fire the notifications listed above.

This CL refactors the class responsible for this determination
(formerly ObserverNotifier, now
AccountStatusChangeDelegateNotifierImpl) so that it uses the status of
an already set MultiDevice host (or the lack thereof) to decide whether/
when to fire the notifications. In particular, the HostStatusProvider
class makes the raw data required readily available.

-----

A minor functionality change was implemented in the 'Chromebook added'
event. Prior to this CL, the check for that event, i.e.
AccountStatusChangeDelegateNotifierImpl::
CheckForExistingUserChromebookAddedEvent, would not fire a notification
if the SetupFlowCompletionRecorder says that the Chromebook was
previously used for Unified Setup. We decided this is not ideal
behavior because of the following case:

A user goes through Unified Setup on Chromebook A, forgets the host on
Chromebook A, and then go through Unified Setup on Chromebook B. This
automatically enabled the MultiDevice features on Chromebook A.

In the intended behavior before this CL (I say 'intended' because the
implementation was incomplete) this would not trigger a notification
and a user could be in a state in which they do not realize that
Chromebook A is connecting to their host phone. Removing the check for
whether Chromebook A has gone through Unified Setup prevents this from
happening. It has a side effect that the user will see the 'Chromebook
added' notification on Chromebook A immediately following following a
successful setup on Chromebook A but this is a much smaller concern
than the potential privacy issue described above.

I filed a bug
https://bugs.chromium.org/p/chromium/issues/detail?id=881549 to
either use or get rid of the SetupFlowCompletionRecorder pointer in
AccountStatusChangeDelegateNotifierImpl.

-----

Note that most of the unit tests from the aforementioned CLs 1081287
and 1089828 remained relevant modulo some adaptations. A small number
were dropped altogether as they were inextricably tied to the
implementation.


Bug: 856848
Change-Id: I49d884847f7e21516ea8af1a7264843386103c70
Reviewed-on: https://chromium-review.googlesource.com/1205495Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589334}

This is motivated by HTTPS Server Previews wanting to pass a large
blacklist to the client to avoid unnecessary roundtrips to the
litepages server. We also may want to pass a LoFi blacklist in the
future and perhaps a Hint API whitelist so the proto definition
should allow such additions.

Bug: 864640
Change-Id: I6c74483e22dac7e5b9c4705057728ddfb1d60ea2
Reviewed-on: https://chromium-review.googlesource.com/1208951
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589333}

isUVPAA is only available on Android N+

TBR=wychen@google.com

Bug: 880885
Change-Id: Ic768ae32cc09013f1e7197fbbb605948e9040f5e
Reviewed-on: https://chromium-review.googlesource.com/1211732Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589332}