GitLab

Revert of add remaining unittests to new android bots (patchset #2 id:20001 of https://codereview.chromium.org/1633713002/ )

Reason for revert:
isolate paths aren't quite right, e.g.

https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/2236/steps/base_unittests/logs/stdio

Original issue's description:
> add remaining unittests to new android bots
>
> BUG=514857
>
> Committed: https://crrev.com/3476f7c84c16ed45a8404f491fab9fb4691bda5f
> Cr-Commit-Position: refs/heads/master@{#371331}

TBR=martiniss@chromium.org,bpastene@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=514857

Review URL: https://codereview.chromium.org/1639603002

Cr-Commit-Position: refs/heads/master@{#371346}

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
R=fs@opera.com,caryclark@google.com

Review URL: https://codereview.chromium.org/1623073003

Cr-Commit-Position: refs/heads/master@{#371345}

It seems the issue is caused by the button being drawn into
a layer early on and being cached. Adding a -setNeedsDisplay:
when we actually determine whether it should be visible fixes
the problem - so that the first actual paint to the screen
has the correct appearance.

I'm not sure why Cocoa draws it to a layer earlier than this
(this doesn't happen for other buttons), nor why it's background
color is black when that happens. However, this change does fix
the bad appearance.

BUG=563395

Review URL: https://codereview.chromium.org/1630453002

Cr-Commit-Position: refs/heads/master@{#371344}

Currently, shownComponentsChanged_() assumes the first run flow has been stamped before getting the offsetHeight. This is not always the case if the first run flow has already been acknowledged but the current view of the media-router-container is modified.

Review URL: https://codereview.chromium.org/1615633002

Cr-Commit-Position: refs/heads/master@{#371343}

BUG=533750
TEST=build passes

Review URL: https://codereview.chromium.org/1606013005

Cr-Commit-Position: refs/heads/master@{#371342}

Until Oilpan is firmly enabled, always use GeolocationControllerPrivate
to wrap up the non-owned GeolocationController* object. The previous
implementation was performing an untidy downcast with undefined behavior;
no need for such shortcuts here.

R=
BUG=581112

Review URL: https://codereview.chromium.org/1638573002

Cr-Commit-Position: refs/heads/master@{#371341}

Now that we have 3 LGTMs for ImageBitmap and createImageBitmap to ship:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/jRzvehX9U1U/discussion,
let's ship it and expose it to larger audience!

This CL removes the Runtime flag in ImageBitmapFactories.idl and updates
some global interface layout tests results.

BUG=249384

Review URL: https://codereview.chromium.org/1636633002

Cr-Commit-Position: refs/heads/master@{#371340}

BUG=493167,504885,581105

TBR=dpranke@chromium.org, georgesak@chromium.org

Review URL: https://codereview.chromium.org/1635673002

Cr-Commit-Position: refs/heads/master@{#371339}

content/ incorrectly depends on components/arc. Revert first before work
out how to fix it properly.

This reverts commit daa96926.

BUG=b/25057601
TBR=holte

Review URL: https://codereview.chromium.org/1634443002

Cr-Commit-Position: refs/heads/master@{#371338}

Review URL: https://codereview.chromium.org/1577153002

Cr-Commit-Position: refs/heads/master@{#371337}

This will log a crash dump without crashing the browser process, letting
us see how a params object is unexpectedly created with both a main
frame routing ID and a proxy routing ID.

BUG=575245
TEST=Crash dumps in RenderViewHostImpl::CreateRenderView.

Review URL: https://codereview.chromium.org/1624413002

Cr-Commit-Position: refs/heads/master@{#371336}

After crrev.com/1584893002 base/ can use directly allocator.
The grand plan is to dismantle all the indirection layer such that:
 - base is the only thing that knows about allocator-specific details.
 - non-base code uses only base abstractions and stops looking
   at USE_TCMALLOC build flags.

This CL, specifically, addresses the profiling-related methods moving
the tcmalloc-specific dependencies to base and base only.
Other parts of the codebase will be cleaned up in separate CLs.

Also this CL removes a stale base/debug/OWNERS. That file makes
no sense these days as tracing has been moved to base/trace_event/.

BUG=564618

Review URL: https://codereview.chromium.org/1607303002

Cr-Commit-Position: refs/heads/master@{#371335}

Revert "Revert of CT Verify test utilities change - Moved the following common functions (patchset #1 id:1 of https://codereview.chromium.org/1498983004/ )"

This reverts commit 13cb74df.

BUG=568282

Review URL: https://codereview.chromium.org/1639483002

Cr-Commit-Position: refs/heads/master@{#371334}

Revert of Remove Metro mode avatar/profile switcher assets (patchset #2 id:20001 of https://codereview.chromium.org/1605243002/ )

Reason for revert:
Broke Win10

BUG=581097

Original issue's description:
> Remove Metro mode avatar/profile switcher assets
>
> BUG=558054
>
> Committed: https://crrev.com/327f4816de86c9408c8638e9c91add65424affd3
> Cr-Commit-Position: refs/heads/master@{#370906}

TBR=msw@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=558054

Review URL: https://codereview.chromium.org/1631973002

Cr-Commit-Position: refs/heads/master@{#371333}

Follow up to r369480. Use the main frame routing number for setting
background color IPC.

BUG=580765

Review URL: https://codereview.chromium.org/1622913002

Cr-Commit-Position: refs/heads/master@{#371332}

BUG=514857

Review URL: https://codereview.chromium.org/1633713002

Cr-Commit-Position: refs/heads/master@{#371331}

Revert of Enable handle verifier for tests and add some tests. (patchset #7 id:120001 of https://codereview.chromium.org/1580873003/ )

Reason for revert:
A lot of test are crashing on DrMemory x64 bot, so I'm reverting this speculatively. I'll reland this if it didn't help.

Original issue's description:
> Enable handle verifier for tests and add some tests.
>
> BUG=571304
>
> Committed: https://crrev.com/ff6cc3d794e1285c68f74ec9ae6d59dc3e523d5b
> Cr-Commit-Position: refs/heads/master@{#371075}

TBR=cpu@chromium.org,wfh@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=571304,580795

Review URL: https://codereview.chromium.org/1633623003

Cr-Commit-Position: refs/heads/master@{#371330}

We can assume the system verifier handles both SHA-256 and ECDSA now.
No need to inject SHA-256 support or disable ECDSA ciphers.

BUG=554410

Review URL: https://codereview.chromium.org/1610833004

Cr-Commit-Position: refs/heads/master@{#371329}

When there is no logo, the server sends out a json with an empty update
field. This is not the same as what we conjectured when the UMA for logo
was recorded. This CL fixes it.

BUG=543308

Review URL: https://codereview.chromium.org/1618043002

Cr-Commit-Position: refs/heads/master@{#371328}

There can be race cases where a deleted bookmark is opened in edit
activity. This CL prevents such crashes from happening.

This CL also shortens an unnecessarily long variable name.

BUG=574680

Review URL: https://codereview.chromium.org/1630893002

Cr-Commit-Position: refs/heads/master@{#371327}

BUG=

Review URL: https://codereview.chromium.org/1630953002

Cr-Commit-Position: refs/heads/master@{#371326}

When the OverlayPanel is only using two states, the amount of swipe
it takes to move from one panel state to another is excessive. This
change allows adjustment of how sensitive the panels are to a swipe.

BUG=565585

Review URL: https://codereview.chromium.org/1614953004

Cr-Commit-Position: refs/heads/master@{#371325}

If the GVD tears down AVDA before Initialize is called on the
strategy, usually due to an unsupported format, then the deferred
rendering backing strategy would access |shared_state_| before it
was initialized.

It now detects this, and skips all cleanup if Initialize wasn't
ever called.

BUG=580335

Review URL: https://codereview.chromium.org/1632793002

Cr-Commit-Position: refs/heads/master@{#371324}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/72f5bd6b1981..de5b559df615

$ git log 72f5bd6b1..de5b559df --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1632843002

Cr-Commit-Position: refs/heads/master@{#371323}

- add libFuzzer builds on Windows for use_drfuzz
- make libexif_parser_fuzzer build on Linux only

R=aizatsky@chromium.org, dpranke@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1628663002

Cr-Commit-Position: refs/heads/master@{#371322}

crrev.com/370480 added a CHECK() in DesktopSessionAgent. It was
added there in last minute during review and it wasn't properly
validated.

It's supposed to verify that the screen capturer actually uses
the shared memory given to it by verifying that frame->data() and
shared_memory->data() return the same address. On windows the capturer
maps uses shared_memory->handle() to allocate bitmap, so the same
file mapping ends up mapped in two different addresses. So
frame->data() and shared_memory->data() are different addresses, but
the data they contain is always the same.

BUG=575427

Review URL: https://codereview.chromium.org/1630953003

Cr-Commit-Position: refs/heads/master@{#371321}

- fix zlib_uncompress_fuzzer build failure on Windows:
  change buffer_length from size_t to uLongf
- fix zlib_uncompress_fuzzer run failure on Windows:
  use buffer from heap instead of stack to avoid _chkstk failure

R=aizatsky@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/1635703002

Cr-Commit-Position: refs/heads/master@{#371320}

Loading the native library can cause a crash on some older versions of
Android. This CL provides a way for embedders to implement custom library
loading logic that works around the issue.

BUG=550584
R=xunjieli@chromium.org

Review URL: https://codereview.chromium.org/1619673004

Cr-Commit-Position: refs/heads/master@{#371319}

When running md_browser.py, display an example URL that works.

Also, for any directory URL, implicitly try /README.md for
convenience of URLS such as http://localhost:8080/docs.

Review URL: https://codereview.chromium.org/1615733003

Cr-Commit-Position: refs/heads/master@{#371318}

The previous implementation obscured the fact that 'callback' and
'on_start_tracing_done_' were actually the same function.

Review URL: https://codereview.chromium.org/1638443003

Cr-Commit-Position: refs/heads/master@{#371317}

Revert of Exclude all ash test on DrMemory (patchset #1 id:1 of https://codereview.chromium.org/1627893004/ )

Reason for revert:
This didn't help. reverting

Original issue's description:
> Exclude all ash test on DrMemory
>
> BUG=558054
> TBR=scottmg@chromium.org
>
> Committed: https://crrev.com/144307209c8d8615bb29d8fb613367a155907c0f
> Cr-Commit-Position: refs/heads/master@{#371210}

TBR=scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=558054

Review URL: https://codereview.chromium.org/1631003002

Cr-Commit-Position: refs/heads/master@{#371316}

OTR theming is only supposed to apply to browser window windows (and the
find in page bar), not bubbles or dialogs. The bug only applies to Linux
because of the unique way Linux decides which native theme to use.

BUG=580387

Review URL: https://codereview.chromium.org/1626733002

Cr-Commit-Position: refs/heads/master@{#371315}

Cr-Commit-Position: refs/heads/master@{#371314}

Removes CertCacheTrial related code that was added in:
https://codereview.chromium.org/329733002
https://codereview.chromium.org/356953003

BUG=522312

Review URL: https://codereview.chromium.org/1599143002

Cr-Commit-Position: refs/heads/master@{#371313}

BUG=576313
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1637543002

Cr-Commit-Position: refs/heads/master@{#371312}

both product and browser action icons are affected by this check

BUG=none

Review URL: https://codereview.chromium.org/1618073002

Cr-Commit-Position: refs/heads/master@{#371311}

We should not include scroll offset of the scroller itself with the
fixed background in http://crrev.com/cc8fa7dd73e.

BUG=568625
TEST=paint/overflow/fixed-background-on-scroller-scroll.html

Review URL: https://codereview.chromium.org/1630693003

Cr-Commit-Position: refs/heads/master@{#371310}

Given a focusable node |iframe| with role iframe and a focusable child |webarea| with role webArea,

iframe.focus()

results in a focus event being fired on |webarea|.

When navigating backwards, since ChromeVox visits every node in depth-first ordering (reversed in this case), the following occurs
- ChromeVox range is on |webarea|
- ChromeVox walks and matches on |iframe|
- Chromevox calls iframe.focus().
- focus event fires on |webarea|

result:
ChromeVox range goes to |webarea| again and gets read aloud/brailled.

expected:
ChromeVox range should be on the |iframe|.

We can achieve this by not calling focus on the iframe node itself.

Additionally, consider nodes that already have the focused state set as being really focused (i.e. do not call focus() again).

Review URL: https://codereview.chromium.org/1621823003

Cr-Commit-Position: refs/heads/master@{#371309}

https://chromium.googlesource.com/skia.git/+log/a273c0f6676b..02cb4d469a2a

$ git log a273c0f66..02cb4d469 --date=short --no-merges --format='%ad %ae %s'
2016-01-25 msarett Disable RAW test on Chrome OS, Windows
2016-01-25 msarett Fix leak of SkImageGenerator
2016-01-25 joshualitt Build and link microhttpd from gyp
2016-01-25 benjaminwagner Remove RAW Codec from Google3 build.
2016-01-25 mtklein spin off some safe parts from AVX2 CL
2016-01-25 msarett Revert of AVX 2 SrcOver blits: color32, blitmask. (patchset #24 id:450001 of https://codereview.chromium.org/1532613002/ )
2016-01-25 robertphillips Add GM for SkPixelXorXfermode
2016-01-25 mtklein AVX 2 SrcOver blits: color32, blitmask.
2016-01-25 yujieqin Add RAW decoding into Skia.
2016-01-25 msarett Do not test images with alpha to 565
2016-01-25 cjacek Fixed compilation on mingw.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1634813002

Cr-Commit-Position: refs/heads/master@{#371308}

Remove periodic information from structs, protobufs, methods, and histograms. There are still functions with names like "FireOneShot" as opposed to just "Fire." If those are renamed, it will be in a followup.

* Remove power monitor: https://codereview.chromium.org/1617063002/
* Remove periodic code: https://codereview.chromium.org/1614063002/
* Remove mention of one-shot: https://codereview.chromium.org/1613053004/

BUG=552031

Review URL: https://codereview.chromium.org/1614063002

Cr-Commit-Position: refs/heads/master@{#371307}