- 29 May, 2018 40 commits
-
-
Javier Fernandez authored
We have identified several cases where the Baseline Alignment accounts for the grid's intrinsic size. Since we depend on the track sizing algorithm to compute the grid's intrinsic size, the only way to handle all these cases is to integrate the baseline alignment logic in the algorithm. Additionally, the CSSWG has identified several cases that can't be solved properly; such cases have in common that they imply cyclic dependencies between the item's and grid area's size. The CSSWG has resolved that these items don't participate in baseline alignment: https://github.com/w3c/csswg-drafts/issues/1365 There are also other related issues with some examples and relevant discussions about this topic: https://github.com/w3c/csswg-drafts/issues/1039 https://github.com/w3c/csswg-drafts/issues/1409 Bug: 704713 Change-Id: I817b16eb43aa76f4827deb8f1f20efb7fde3dc22 Reviewed-on: https://chromium-review.googlesource.com/923261 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#562406}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bcf467f..1e91374 git log bcf467f..1e91374 --date=short --no-merges --format='%ad %ae %s' 2018-05-25 lucferron@chromium.org Vulkan: Enable every dEQP tests that are passing Created with: gclient setdep -r src/third_party/angle@1e91374 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I1032b8c0b3d3c13c7e00e4b9f939d10d1b1a1c6f Reviewed-on: https://chromium-review.googlesource.com/1075825Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562405}
-
Hiroki Nakagawa authored
Bug: 680046 Change-Id: Ice3a4adcac4be7b255e263a57aa65609f45f30dd Reviewed-on: https://chromium-review.googlesource.com/1072225 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#562404}
-
Greg Thompson authored
It times out flakily. BUG=835774 TBR=clamy@chromium.org Change-Id: Ifef4b56eb858a2a928159bf14670871436fc41d7 Reviewed-on: https://chromium-review.googlesource.com/1076287Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#562403}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2e5c6916..cd4e3063 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I56153902a2076cdfc5f35edc96b87419f5c94a24 Reviewed-on: https://chromium-review.googlesource.com/1075475Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#562402}
-
Jan Krcal authored
This CL changes the test fixture of autocomplete_sync_bridge_unittest.cc to use mock processor instead of recording fake processor. The mock processor allows the same counting as the recording processor and is backed up by real processor that allows more realistic tests. Bug: 836718 Change-Id: I570d2091e6a93194ae37394bd00780ff466d2455 Reviewed-on: https://chromium-review.googlesource.com/1066061Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#562401}
-
Jeremy Roman authored
The test already ensures mutual exclusion using a pair of mutexes and condition variables. Change-Id: I496805ae8d5382a0da8f6e76a1c843303446e16d Reviewed-on: https://chromium-review.googlesource.com/1075716Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#562400}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b3085b288b17..2aae2733a70c $ git log b3085b288..2aae2733a --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:844647,chromium:845158,chromium:794608,chromium:None,chromium:None,chromium:None,chromium:845158 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8a13060bf81727a06eb046ff9c6ef9b18b4a9876 Reviewed-on: https://chromium-review.googlesource.com/1075864 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562399}
-
Fredrik Söderquist authored
Once upon a time, GetRoundedBorderFor(...) did accept a LayoutView* argument, but it no longer does. Luckily this would've yielded true anyway - matching the default argument - so no functional change is to be expected. Change-Id: Ief012e7a37efc9e9293f10bc2c67172ab088200d Reviewed-on: https://chromium-review.googlesource.com/1076231 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#562398}
-
Noel Gordon authored
Add a helper to convert a file name to a file system URL and use it to do that conversion in all test cases. No change in test speed here, it is just easier to read. Minor: update comments for some test steps. Test: browser_test --gtest_filter="OpenAudioFiles/FilesApp*" Bug: 847172 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I089f07a230f4a9817016b834d067fa07b0b1bc3b Reviewed-on: https://chromium-review.googlesource.com/1075959Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#562397}
-
Friedrich Horschig authored
This CL adds the capability to add/remove tabs dynamically. It also ensures that unused tabs are properly cleaned up. Also added some tests that ensure that activeIndex works as intended. Bug: 811747 Change-Id: Ie9602d23e4058885605a78e9a0ff403af2adc75b Reviewed-on: https://chromium-review.googlesource.com/1070152 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#562396}
-
Marcin Wiacek authored
Patch is moving "Open in other window" in the context menu below "Open in (incognito) tab" options. BUG=845335 Change-Id: I6c4a9453d45d68d97cdbfdf023840a527ae30cc8 Reviewed-on: https://chromium-review.googlesource.com/1076129Reviewed-by:
-
Marina Ciocea authored
Bug: 845105 Change-Id: I190ca21069e82322e8d1f6ddd189c15371395973 Reviewed-on: https://chromium-review.googlesource.com/1076207Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#562394}
-
Vasilii Sukhanov authored
Bug: 847102 Change-Id: I05e3e0088ec20b0f23eff408055ecda3bb6f92a0 Reviewed-on: https://chromium-review.googlesource.com/1076232Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#562393}
-
Stuart Langley authored
This change was not propagated when changing in the original change list to convert from largest change id to start page token. Bug: 833690 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifbedaac2523469d6e2ad41ac08da600860464c2b Reviewed-on: https://chromium-review.googlesource.com/1075830Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#562392}
-
Yutaka Hirano authored
ResourceSchedulerParamsManager is currently immutable, which results in an unnecessary std::unique_ptr indirection in ResourceScheduler. This CL fixes that. Bug: 754918 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I292e5078d55c700e69847e0d180ea751b319905d Reviewed-on: https://chromium-review.googlesource.com/1075846Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#562391}
-
Mikhail Atuchin authored
This CL fix an undefined behavior in BackgroundSyncManager::DispatchSyncEvent(). TEST=browser_test.BackgroundSyncBrowserTest.* Change-Id: I263f8d272ff2a1bf3e4cca3ef51df6f59fa3c04b Reviewed-on: https://chromium-review.googlesource.com/1076167Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Mikhail Atuchin <atuchin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#562390}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 61040709. With Chromium commits locally applied on WPT: d78c1e54 "[Resource-Timing] Fix `initiatorType` values" 61040709 "Worker: Clean up tests for module imports on dedicated workers using "export"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18901 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2720f7ce4516f040cff8e85fee11db4b74aa9abd Reviewed-on: https://chromium-review.googlesource.com/1075863 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#562389}
-
Michael Lippautz authored
Bug: chromium:841830, chromium:847284 Change-Id: I6d10de185826f6147a4477ac95891e0ae62315dd Reviewed-on: https://chromium-review.googlesource.com/1075954Reviewed-by:
-
Thiemo Nagel authored
For example: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16345 BUG=774873 TBR=paint-dev Change-Id: I02760f33d391a8d25c3ca4bf6b7e7112552e2c84 Reviewed-on: https://chromium-review.googlesource.com/1076152Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#562387}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14c83202..2e5c6916 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7d065b7b098732ada8ea6ce4f89c4cf8d9cc1e84 Reviewed-on: https://chromium-review.googlesource.com/1075575Reviewed-by:
-
Raphael Kubo da Costa authored
Mikhail is no longer at Intel, so the email is just bouncing. Change-Id: I562ad71299627b43ff9487e4de7c5afb2b0bc503 Reviewed-on: https://chromium-review.googlesource.com/1076150Reviewed-by:
Alexander Shalamov <alexander.shalamov@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#562385}
-
Fergal Daly authored
This adds a part_invalidation_set_ to RuleFeatureSet which is used to tell if any part selectors are in play in the document and if they are, part and partmap changes may trigger invalidation. Bug: 805271 Change-Id: If6f75693a63f6e1f590ed51a19ea02c57fb3e426 Reviewed-on: https://chromium-review.googlesource.com/1032450Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#562384}
-
Oskar Sundbom authored
If there are no available inputs, PulseAudio will, for some reason, select the monitor of the current default sink as the default source. Chrome will only add a Default input to the device enumeration if there is at least one valid input found. Currently, we also include unavailable inputs in the device enumeration, which means Chrome will show a Default device, which in that case would likely be a monitor device, rather than a proper input. This CL stops this happening by not enumerating inputs that don't have an available, active port. In case PulseAudio would _still_ pick a monitor device as the default device, this CL also explicitly returns invalid AudioParameters for monitor devices, and explicitly fails to open them as inputs - to be on the safe side. Bug: b/79580580 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I25bd96e98a48bcdf6e993759e97bf713855d4ad0 Reviewed-on: https://chromium-review.googlesource.com/1064373 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Adding feature to add a new account from the Unity user consent. This is done using delegate protocol from IdentityChooserViewController down to ChromeSigninViewController. ChromeSigninViewController is in charge to open ChromeIdentityInteractionManager to add a new account (which is already implemented). Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7578c33cf2ad7aa7bf4b6ca150d0a708a28baebf Reviewed-on: https://chromium-review.googlesource.com/1065456 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#562382}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/62113cb42963..8e200f3940ff $ git log 62113cb42..8e200f394 --date=short --no-merges --format='%ad %ae %s' 2018-05-29 angle-skia-autoroll Roll third_party/externals/angle2/ 29523298f..bcf467f24 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Iabfb6459ffa1bf93e2505bdb01347c9e02689f9c Reviewed-on: https://chromium-review.googlesource.com/1075822 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#562381}
-
Hiroki Nakagawa authored
This is a clean-up CL for existing tests, and doesn't add new tests. Before this CL, the tests work as follows: the top-level script imports modules, each module postMessage('LOADED') to the page on load, and the page waits for them all. This pattern is easy to write but not easy to read because it's not clear which modules are expected to be imported. Also, this pattern checks only the number of imported modules, so a broken test, for example, importing a wrong module can unexpectedly pass. To improve the situation, this CL stops using the pattern and instead make tests propagate the list of imported modules from child scripts to the top-level script. The top-level script sends the list to the page as a representative. This is less error-prone and clarifies which modules are expected to be imported. Change-Id: I08c4569b6dc69a1ecff6701df932e28dda6dc42a Bug: 680046 Reviewed-on: https://chromium-review.googlesource.com/1075843 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: -
Yoichi Osato authored
This patch enables to paint selection vertically on writing-mode:vertical-lr/rl style. Since paint_fragment.ComputeLocalSelectionRect() returns physical coordinate rect rather than logical, this patch delays GraphicsContext flip after selection painting. This patch fixes following tests leaving line gap paint: fast/writing-mode/japanese-lr-selection.html fast/writing-mode/japanese-rl-selection.html Bug: 708452 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I626e3e532a49928065de1bc2ea5478a72c867638 Reviewed-on: https://chromium-review.googlesource.com/1071497Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#562379}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf178510. With Chromium commits locally applied on WPT: d78c1e54 "[Resource-Timing] Fix `initiatorType` values" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18900 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor chongz@chromium.org: external/wpt/pointerlock dcheng@chromium.org, scottmg@chromium.org: external/wpt/domparsing domenic@chromium.org, ricea@chromium.org: external/wpt/streams hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/resources external/wpt/service-workers/cache-storage kojii@chromium.org: external/wpt/css/css-writing-modes mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mlamouri@chromium.org: external/wpt/remote-playback nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents pwnall@chromium.org, jsbell@chromium.org: external/wpt/cookie-store rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card external/wpt/payment-request worker-dev@chromium.org: external/wpt/workers yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I9f157d312d625b8fa12c63200b839abd0f2c22f0 Reviewed-on: https://chromium-review.googlesource.com/1075862 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Binary size improvement: -4KiB Bug: chromium:841830, chromium:847284 Change-Id: Ic0b4e1ddd8e4104973c45d634b6c37a2db880bcc Reviewed-on: https://chromium-review.googlesource.com/1075911 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
UnifiedSystemTray's back button in a detailed view was broken, because the detailed view container wasn't set to invisible after it's back. TEST=manual BUG=835733 Change-Id: I365033af19f745826ad4d7462734eb208be82407 Reviewed-on: https://chromium-review.googlesource.com/1075881Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#562376}
-
Mirko Bonadei authored
This will prevent errors like this: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-xcode-clang/49956. Bug: None Change-Id: Ic82fa04182bde0185d20026c977147ef697faf7a Reviewed-on: https://chromium-review.googlesource.com/1075889Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#562375}
-
Kent Tamura authored
Introduce NameStyleConveter.to_function_name(), and replace usage of method_name() with to_function_name(). * join_names() is also removed. This CL makes join_names() unnecessary. * method_name() converted 'domContentLoadedEventFired' in CoreProbes.pidl to 'DomContentLoadedEventFired,' however NameStyleConverter converts it to 'DOMContentLoadedEventFired'. This CL updates C++ code for it. Bug: 843927 Change-Id: I90a59111824ea76c690c2f809f1acb4bdbac6efd Reviewed-on: https://chromium-review.googlesource.com/1075913Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#562374}
-
Gauthier Ambard authored
This CL removes the relayout of the top toolbar on rotation as it is creating an issue with the stack views. It was added to fix an issue where the incognito NTP was flickering during the open animation. However, this is issue is fixed in UI Refresh. Bug: 846220 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic9b4d2eae03c63d84f204ccf799f755367378f7d Reviewed-on: https://chromium-review.googlesource.com/1075790Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#562373}
-
Max Morin authored
audio::OutputController started creating fake audio streams through the audio output proxy code with the audio service. This is not how it was done before, causing the output proxy UMA stats to change. This CL switches to creating fake streams without using the output stream proxy code, which avoids logging UMA stats. Bug: 847208 Change-Id: If143e92088d6997b4cf0399b4ff6ee767cb12af1 Reviewed-on: https://chromium-review.googlesource.com/1075310 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#562372}
-
chcunningham authored
See Intent to Deprecate https://groups.google.com/a/chromium.org/d/msg/blink-dev/x54XtrTyOP8/4-5QZlZzDAAJ MSE's resource is considered 'local' (we don't manage the donwload - the app does), so the HTML5 spec text around firing 'stalled' does not apply. See discussion in https://crbug.com/517240 No change to 'stalled' event for 'remote' (src="somefile.webm") resources. This CL also stops delaying the 'load' event for deferred media player Load() execution. Load() may be deferred for an arbitrary number of seconds, so we should not hold up the window's 'load' event. Prior to this change, 'stalled' was serving the unintended roll of unblocking the the 'load' event for deferred load()s that took > 3 seconds. With stall now removed for MSE, this weird behavior was uncovered and remedied. Bug: 517240, 836951 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I97f2bf972c79582d038e1215f5d630042656bd1c Reviewed-on: https://chromium-review.googlesource.com/982564 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#562371}
-
Tetsui Ohkubo authored
As TrayCast will be removed in UnifiedSystemTray, Stop Casting message row should be shown as a pinned notification. As the the icon is still not given by UX, it's temporary. Screenshot: http://screen/0uec3cFoVJS TEST=manual BUG=824631 Change-Id: I5c2bb8cc777a00c6a01549be814e54595882d6f2 Reviewed-on: https://chromium-review.googlesource.com/1063690 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6016f7759418..62113cb42963 $ git log 6016f7759..62113cb42 --date=short --no-merges --format='%ad %ae %s' 2018-05-29 skia-bookmaker Update markdown files Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Iea6c7a95d5bf85b100dbb7bcb8509d69d862b847 Reviewed-on: https://chromium-review.googlesource.com/1075819Reviewed-by:
-
Makoto Shimazu authored
When ServiceWorkerServicification is on and NetworkService is off, the request will be intercepted by both of request interceptors living in NavigationURLLoaderImpl and URLRequestInterceptors created in ResourceDispatcherHostImpl. However, in the current implementation, the network request intercepted by a request intercepter could be intercepted in the ResourceDispatcherHostImpl again when a service worker intercepted the request skips handling the request. This CL is to avoid the double interception. Bug: 846232 Change-Id: Iec6e770a9ba620a9592cd41872d1d8572b9e8bf4 Reviewed-on: https://chromium-review.googlesource.com/1074782Reviewed-by:
-
Tetsui Ohkubo authored
This CL removes overflow indicator in ScrollView in UnifiedSystemTray's detailed views. As the corners are rounded, overflow indicator is not shown properly. TEST=manual BUG=835733 Change-Id: I89e7e25a2529a354de9b258ba80697961e1c0745 Reviewed-on: https://chromium-review.googlesource.com/1075912 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
