- 01 Oct, 2019 40 commits
-
-
Finnur Thorarinsson authored
When an onSelectionStateChange comes in, it is not safe to call super while mBitmapDetails is null, because it may in some cases call back into us (like the crash dumps are showing). Bug: 1006823, 656015 Change-Id: Ia487d8e304d940ab7d681b39189c72d30c12ac8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829707 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#701485}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0335627777d66303090e6299b87798577ac40159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701484}
-
Evan Stade authored
This allows it to be forward declared and is necessary to avoid circular dependencies that arise when browser_non_client_frame_view.h includes tab_strip.h. It is motivated by the linked bug. Some IWYU changes were necessary due to removal of transitive includes. Bug: 998625 Change-Id: Id2c0b82b6fdaf4af686751405a710282ad1d58b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829746 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#701483}
-
Austin Tankiang authored
This code was used to deal with mounting rar files located in the legacy drive file system. Now that DriveFS is default, this is no longer needed. Bug: 1003238 Test: manually mounted/unmounted zip and rar files on DUT Change-Id: I75ab0da2ba26f8f004f1b48ac5bb9f2d2158c6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826752 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#701482}
-
Askar Aitzhan authored
Currently UMA metric called Enterprise.PolicyRefresh and Enterprise.DevicePolicyRefresh record state "Invalidated; Changed" if policy_changed and invalid_ are true, and record state "Invalidated; Unchanged" if policy_changed is false and invalid_ is true. The problem here is in variable called invalid_, it is true whenever there is a unacknowledged invalidation. So every call to OnStoreLoaded will cause a record of "Invalidated" whenever there is a unacknowledged invalidation, even if "Policy Fetch Job" is caused by scheduled job. The case when there is an unacknowledged invalidation cap happen when "Policy Fetch Job" caused by invalidation fails, this invalidation will not be acknowledged so all the intermediate scheduled jobs will be recorded as "Invalidated" which is not true. Bug: 1000974 Change-Id: I613802148295b2db699a16493d08ec14185cb688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787377 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701481}
-
Thomas Tangl authored
This was caused by using an unscaled bitmap for the circle in the image manipulations. Bug: 995720 Change-Id: I2a2cc58ee2abea6d90a1fdeee048169d1ec7a967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831759Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#701480}
-
Hiroshi Ichikawa authored
This change involves: - Use net::CookieStoreIOS instead of using WKHTTPCookieStore directly. -[WKHTTPCookieStore getAllCookies] has a bug that it sometimes doesn't call its completion handler immediately (https://openradar.appspot.com/39470983). net::CookieStoreIOS implements a workaround of the bug. Bug: 938123 Change-Id: Ica8f3855d3f7355a3903f56e7744abd9f5edb024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511094 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#701479}
-
Alex Danilo authored
Bug: 1009318 Change-Id: Ib894dd7b3930006211c13e89f26bd5617b4df97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833030Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701478}
-
François Beaufort authored
This CLs adds the lost attribute to GPUDevice. It is used to track fatal errors in WebGPU. See https://gpuweb.github.io/gpuweb/#fatal-errors Bug: 877147 Change-Id: I81fea6cdc300a577825d098f3c040e4969dcb0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827562Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#701477}
-
Morten Stenshorne authored
Even when there's a forced break deep inside a break-inside:avoid subtree, we should allow the break. https://www.w3.org/TR/css-break-3/#breaking-controls Bug: 829028 Change-Id: I2e098113d3bd73b506cffa22aa87c90e1f7186e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829348 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#701476}
-
Dominik Röttsches authored
Windows DWrite based fallback API may return a fallback font that differs from the regular style, for example Segoe UI Semilight with Georgian character coverage over a version of Segoe UI regular that would not have Georgian coverage. Keep weight, style, slant information to pass to the renderer, update the FontDescription object there to instantiate the font that's closest to the fallback information we have reiceved from DWrite. This applies to Windows 8.0 and below, as otherwise, a different fallback code path is taken. Bug: 1008901 Change-Id: Ib46a3cdbe164b69768780b798200bc5bbb8a5b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829378 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701475}
-
Tsuyoshi Horo authored
TBR=csharrison@chromium.org Bug: 1009885 Change-Id: Iddfb99a599c5337b650a6766935e79bbb9580f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833011Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701474}
-
Jeremie Boulic authored
When creating new folders from the directory tree, the new entry was sometimes added in the wrong spot due to the way labels were compared. The folders were then immediately reordered, causing the new folder to lose its renaming state with the corresponding input box. Issue fixed using the util.compareName function. Test: browser_tests --gtest_filter="*FilesApp*dirCreateMultipleFolders" Bug: 1004717 Change-Id: If2bc4d559a7a74811204d198a2aa8579ee3a6889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827110 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#701473}
-
Darren Shen authored
These aren't actually used in rule-based engine. No point sending them. Bug: 1009903 Change-Id: Ic0add4ecba3d4341c2976f6abce8e9c86465d116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833032Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#701472}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/839a023619b5..c912690d22ab git log 839a023619b5..c912690d22ab --date=short --no-merges --format='%ad %ae %s' 2019-10-01 apodtele@gmail.com * src/base/ftstroke.c (ft_stroker_inside): Speed up. 2019-09-30 wl@gnu.org * src/sfnt/sfwoff2 (woff2_open_font): Initialize `woff2.ttc_fonts'. Created with: gclient setdep -r src/third_party/freetype/src@c912690d22ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I27a51d179205fb38034959648f91910990916e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833105Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e06f01be719a..deb28ea45d0d git log e06f01be719a..deb28ea45d0d --date=short --no-merges --format='%ad %ae %s' 2019-10-01 jiawei.shao@intel.com D3D12: Implement ASSERT_SUCCESS as macro instead of function 2019-10-01 bryan.bernhart@intel.com D3D12: Use ringbuffer allocator for descriptor heaps. Created with: gclient setdep -r src/third_party/dawn@deb28ea45d0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I6d9e0cd64a2af9db3bf4172a45a331acfe8a4091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832985Reviewed-by:
-
Marc Treib authored
Bug: 1007942 Change-Id: Ibf1dd753fbd6a8922b0c909a8657728eab6af2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831901Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#701469}
-
Piotr Bialecki authored
Bug: 1009129 Change-Id: Iea0ee4259c894db49a76f8f4e1ca9b53f95f69ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829296 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#701468}
-
Hwanseung Lee authored
Use enum class instead of enum for PaintButtonMode enum class is more type safety. Bug: 940736 Change-Id: If4135af54748a1f9383aba3605916a593aaba0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824052 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#701467}
-
Ricky Liang authored
When we use VideoFrame::WrapVideoFrame to soft-apply a different set of format, visible rectangle, and natural size on a source VideoFrame, we have to make sure the source VideoFrame outlives the wrapping frame in most if not all the scenarios. This CL explicitly retains a reference to the wrapped frame inside the wrapping frame when WrapVideoFrame is called. Along with the change, we can remove several empty destruction callbacks that are only used for retaining a reference to the wrapped frame. Bug: 982201 Change-Id: Id81ad65c500fe4f0b47a60d98819408522314129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830241 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#701466}
-
Benedikt Meurer authored
When hovering an expression within the Sources panel (during debugging), we try to evaluate it's value and show a popover with the result of that. However this is all best effort and might fail for various reasons. If it fails because we guessed the wrong substring (for an expression), we currently display a popover with a SyntaxError or a ReferenceError in that. But this popover is confusing and doesn't serve a purpose. Instead we should just not display anything in this case as well. Bug: chromium:995036 Change-Id: Id70e2212fe0af58078b2a33731688ec1c5507434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831814 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#701465}
-
Fredrik Söderquist authored
While flag-waving may be considered somewhat ugly, it's quicker (no hash lookups) and slightly more flexible (then providing access to the tracking set) if you want check for reentrance earlier (which is what we want to do). Bug: 998526 Change-Id: I91f9df93879e4446bd5908513cd8a4226c657bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831906Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#701464}
-
Rune Lillesveen authored
When the runtime flag for flat tree style recalc is enabled, traverse children of slots and v0 insertion points directly. Also, skip traversing light tree children of shadow hosts. Bug: 972752 Change-Id: I7585bbbe9b880913887da48ea59fadfb5b4083b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829704Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#701463}
-
Fredrik Söderquist authored
We check this member field, but we never set it, so it's of no use anymore. Bug: 998526 Change-Id: I6de7399574828fe26f413d0dfcd2a0556540f4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831767Reviewed-by:
-
Benedikt Meurer authored
Remove the `ACORN_ECMA_VERSION` constant, and instead rely on the official `ecmaVersion` default in acorn, which is now 10 (corresponding to ES2019). Bug: chromium:995036, chromium:1009927 Change-Id: Ie6b4c5e2839012f498c2c561c33d811b37749eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829713 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
For subtree recalc when scheduling sibling invalidations as descendant invalidations on the ancestor, mark the shadow host instead of the shadow root for style recalc. In preparation for flat tree style recalc where we only want to consider elements and text nodes for style recalc. Bug: 972752, 990743 Change-Id: I00921e298d50be2667e7b26b3149f4f1b72a2d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831761Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a305a6276dfe..1ffc2e453b00 git log a305a6276dfe..1ffc2e453b00 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 71c1138d6739..087f1384f233 (3 commits) 2019-10-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 26279492..b26cb15a (404 commits) Created with: gclient setdep -r src/third_party/skia@1ffc2e453b00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None,chromium:None Change-Id: Iee6403217fc1c68cf5a2060c1115a824fd3b34eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832986Reviewed-by:
-
Benedikt Meurer authored
Bug: chromium:1009876 Change-Id: Id4983d9b7be445fd4d935b27195f1b53bb1cb263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832265Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: I471bc6109877cebbbbdb2467ceb0197b9d2906ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824647Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#701457}
-
Morten Stenshorne authored
This was just meant to be a preparatory CL for adding support for avoiding breaks using the break-before and break-after properties, but ended up fixing bugs as well. :) This makes 3 web tests pass, because we now have more control over break avoidance, so that we can keep last resort breaks inside a child if breaking before would be just as bad. When two breakpoints are equally bad, prefer the one that takes us the furthest in the content. Rename BreakBeforeChild() to BreakBeforeChildIfNeeded(), and introduce BreakBeforeChild(), which actually always breaks before a child. BreakTypeBeforeChild() only partially contained the logic to determine whether and how to break, and has now been swallowed by BreakBeforeChildIfNeeded(). Bug: 829028 Change-Id: Ia620c19e1dfd31e88cf76eb7cea150a9e1152865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829101Reviewed-by:
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 1008029 Change-Id: Ife5414a0331ab74fd0c2f1102de86a77f72f43fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832845Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c2a6ac81ca46..94a459c0b4c7 git log c2a6ac81ca46..94a459c0b4c7 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 vapier@chromium.org cros_build_lib: run: drop unused error_message setting 2019-10-01 vapier@chromium.org unittests: handle some renamed assert methods 2019-10-01 vapier@chromium.org cros_test_lib: deprecate some more unittest aliases Created with: gclient setdep -r src/third_party/chromite@94a459c0b4c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ieba503f928e77cd65551bbaa59d53c11705a98d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833109Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86a375c756f2..35e16bac7b41 Created with: gclient setdep -r src-internal@35e16bac7b41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia1d5e1d4371c941f4fb9cb508e104edb77e0893f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833110Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701453}
-
Jay Harris authored
Previously, the flag was only shown on ChromeOS, however there is currently implementation work on Linux and Windows (and soon, on MacOS), so it makes sense to show it on other platforms. Bug: 829689 Change-Id: I91e0e37828bea9ebd3888d18def5ace42a475e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833019 Commit-Queue: Jay Harris <harrisjay@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#701452}
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 248894, 1008848 Change-Id: Iac61f0d1e8b1046c05f2b9c8c4b0efdb8a717abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833342Reviewed-by:
-
Alex Danilo authored
When the connectedCallback is called on the panel item custom element, set any button onclick handlers since they could have been null'ed out if the panel item was removed from the DOM. Bug: 1009318 Change-Id: I621bf1bcda85c877c1c52a182474e6ec294c63ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832188 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Jay Harris authored
This is the result of some discussion at TPAC. Previously the BadgeManager applied badges to scopes. This CL changes the BadgeManager to work with AppIds instead (as the web facing API has been changed). Previous CLs have changed the API exposed to the Web, so this change only affects how Chromium stores/applies the badges. TPAC Discussion Summary: https://github.com/WICG/badging/issues/55 Related CLs: https://crrev.com/c/1817999 https://crrev.com/c/1818892 https://crrev.com/c/1816002 Bug: 1006665 Change-Id: I24d18bdad5a8a0a92b0d1b5ac14052b9de8913dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830485 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701449}
-
Patrick Monette authored
When ServiceWorkerContextCore::DeleteAndStartOver() is used, the existing service workers still exist for a short time but new instances are created and they will reuse existing version_id because the count is reset to kInvalidServiceWorkerVersionId. This leads to multiple running notifications for indifferentiable service workers. To fix this, the ServiceWorkerContextWrapper is notified when DeleteAndStartOver() is called and prematurely sends a stopped notification for all currently running service worker versions. Then, to prevent future notifications from all the old versions, the ServiceWorkerContextCore silently drops notifications if the core associated with the version is no longer alive. Bug: 993029 Change-Id: I27b192141265828139416abb37d8e0c762308679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829865 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701448}
-
Koji Ishii authored
TBR=eae@chromium.org NOTRY=true Bug: 1008790 Change-Id: I4e927365689ff14ecf87df4e3b180492f10645e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833341Reviewed-by:
-
Thanh Nguyen authored
This CL: 1. Adds prefix matching to the class. 2. Uses normalized text rather than raw text of TokenizedString. 3. Combines scores from all sources to give a final score. Bug: 990684 Change-Id: I200986fc38366be117c7c4b8849d4510b4f830bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826745 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#701446}
-
