- 19 Feb, 2020 29 commits
-
-
Meilin Wang authored
Part of our Assistant integration tests keep failing because of a crash happened during Assistant response processing. Previously it was possible that the |OnFinishedProcessing| callback gets fired after the response and its processor has been destroyed. To fix this, we use the WeakPtr in the callback because a specified destruction order is needed to indicate the failure of completion when the response processing can possibly get interrupted under some cases. Misc: fix linter warnings. Bug: b/148677894 Test: local compile and run tast tests. Change-Id: I87049a1d324a78c8bdc8b1487ea8dd5ce289b7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040734 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#742419}
-
bttk authored
Bug: 1046181 Change-Id: Ia7c2b1f98569c95d8ded7ec030d7936eddbd8f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024413 Auto-Submit: bttk <bttk@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#742418}
-
Robert Sesek authored
This also converts some of the receivers to use base::SyncSocket::ScopedHandle, which is what is the type that is extracted from the mojo::PlatformHandle. Bug: 710376 Change-Id: Ie8f3c05851fcd2514ed140886d61746129f43b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055844Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742417}
-
Anupam Snigdha authored
In some interactive_ui_tests, upon exit the TextInputClient object becomes null. This happens mostly in release builds where the GetScreenExt call from TSF happens after the test has exited which results in an AV in TSFTextStore::GetScreenExt. Bug: 1053769 Change-Id: I759eac57ddf0c08988dbb88f02dc796ede92a060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063673Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#742416}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 388f1d99. With Chromium commits locally applied on WPT: ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I0409352f88d4addb4036ddb18bd177b44dd8064c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063468Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742415}
-
Xianzhu Wang authored
Transforms don't apply to non-replaced inline boxes [1]. Previously when a LayoutInline had transform animation style, the transform node of the LayoutInline had HasActiveTransformAnimation(), while the transform was a zero translation 2d, which passed wrong information to PaintArtifactCompositor, and broke the expectation that an animating transform node should not have 2d translation optimization. This is one of the preparation CLs for considering animations in overlap testing for CompositeAfterPaint layerization (crrev.com/c/2057868). [1] https://drafts.csswg.org/css-transforms-1/#transformable-element Change-Id: Ia68a87d93f7fbd90b70009fe3fae61e2958bc2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058997 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742414}
-
Haiyang Pan authored
Android 10 has introduced scoped storage and this causes the smoke tests for trichrome_chrome_bundle failing due to no permission to read sdcard. See https://developer.android.com/training/data-storage#scoped-storage for more detail. Also fix typoes in OWNER file. Bug: 1044330 Change-Id: I8f290243896cfa721b479aa887e27e98b5e5d79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056749Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#742413}
-
Li Lin authored
Bug: b/149596491 Test: unit tests Change-Id: I31518f8e4cdc5656d4cea429824a3469e0e9693a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057537 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742412}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4b7bac78a9ea..123fd97000bb git log 4b7bac78a9ea..123fd97000bb --date=short --first-parent --format='%ad %ae %s' 2020-02-18 julien.isorce@chromium.org Provide default implementation of rx::DisplayEGL Created with: gclient setdep -r src/third_party/angle@123fd97000bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ib2835dfbc52baadb1f50eb7539b33d4f44adc529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063355Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742411}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibdc7b7d16eb4b472a2d571b5e2b697008a6fcdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742410}
-
David Van Cleve authored
The histograms measuring ESNI DNS records' fetch times, which had been implemented with the intention of being used for initial experimentation, are expiring; this CL obsoletes/removes them since the intended experimentation has been superseded by the plan to fetch HTTPSSVC records rather than ESNI. The CL leaves the actual ESNI record fetching implementation because Dan says he might repurpose at some of it for fetching HTTPSSVC records. R=ericorth Fixed: 1053065, 1053066 Change-Id: I371ff5fd36cc334a711b92b82e31d8862359ed05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062292Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742409}
-
Victor Costan authored
When kAppCacheUpdateResourceOn304Feature is enabled, AppCache correctly updates corrupted cache entries when receiving 304 responses. So, we don't need the probabilistic refresh approach anymore. Bug: 989611 Change-Id: I2974ab15db991bffb144553b21174f537a05d2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052804 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#742408}
-
Alex Cooper authored
Remove flags for shipped/shipping features: * WebXr Sandbox * WebXr Device API * WebXr AR Module * WebXr AR Hit Test Remove webxr-runtime choices for runtimes that we do not intend to support natively given that OpenXr will allow for support: * OpenVr * Oculus Removes "Orientation Sensors" choice from webxr-runtime as it is inline only and doesn't really make sense in the list for android, and will not be supported on Desktop. webxr-runtime is kept to ensure that tests can be run on both Windows Mixed Reality (WMR) and OpenXr. As usage of WMR is expected to decline in favor of OpenXr, this flag will be removed when WMR can be removed. Bump expiry of webxr-incubations flag to M85 to reflect ongoing usage. Note that this does not remove any features, so --enable-features, --disable-features, and --force-webxr-runtime= flags will still allow these features/options to be set. Fixed: 1049797 Change-Id: I54eaff1cfcf6ecebc574113759dc06c806bcd0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063535 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#742407}
-
Rachel Carpenter authored
This happens if the feature is enabled, else fall back to opening the genius app. Also record the app launch for new Help app. Bug: b/138970611 Change-Id: I50f2dba79f62d979c43ab6d9d3e8382d8892b9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054476 Commit-Queue: Rachel Carpenter <carpenterr@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#742406}
-
Bo Liu authored
Repeat scroll in the poll callback to keep scrolling until the top controls are hidden / releaved. This is a blind attempt at deflaking this test on L bots. Bug: 1035894 Change-Id: I66d02aaebb1dbb0ad0f3d36a027e449ac4005365 Tbr: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063539Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742405}
-
shrekshao authored
Counterpart CL of https://chromium-review.googlesource.com/c/angle/angle/+/2045512 Bug: 1051908 Change-Id: Ibe7f8b8af2dc1b048d1581bb06e2a5e59e7058d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057491Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#742404}
-
Callistus authored
Changed app name to Discover instead of Help App. Changed help icon to discover icon, added 512px icon. Set title bar to white. Bug: b/149429818 Change-Id: I0ac455c8e651708da9cc92ff9bef02d11dedc073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051878Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#742403}
-
bttk authored
Bug: 1046181 Change-Id: I17ab3859fdd006fffed453c2fac3ba0389ae04b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024079 Auto-Submit: bttk <bttk@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#742402}
-
David Manouchehri authored
Bug: 1051748 Change-Id: I6bbef3ef50930048984593270fbe39a59a6d61f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053167Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: David Manouchehri <david@davidmanouchehri.com> Cr-Commit-Position: refs/heads/master@{#742401}
-
Simeon Anfinrud authored
Bug: 1026378 Test: gn check android build Change-Id: Ibfe5dde9bba59e4219d244c780130f873336c713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063210 Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742400}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I96865f0c093432cad4171be8f485cc06de5740d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058926Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#742399}
-
Tomasz Wiszkowski authored
This CL is part of the post-launch cleanup. The purpose is to remove all the code that was necessary to conditionally enable/disable favicons and other decorations for Omnibox suggestions. Bug: 1051551 Change-Id: I2ef67c8e6fdd8be0aa7f6256e20d84763c6ba4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049834Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#742398}
-
Avi Drissman authored
BUG=1023913 Change-Id: Ibfcc2411221e05e0318c4924173792df0b41d72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031761 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#742397}
-
Tomasz Wiszkowski authored
This CL introduces a new Chrome feature and flag to control the number of presented Omnibox suggestions to show as many suggestions as the list can contain without making the list scrollable. The adaptive suggestion count will still honor the platform limit offering no fewer suggestions that were offered before. Bug: 1050813 Change-Id: Icc139adea0885499f07524b3641c37f759718cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048411 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#742396}
-
chrome://media-appTrent Apted authored
We couldn't do this initially due to https://crbug.com/1005726, which is now resolved. Currently, we bounce the CIPD package through a git repo which is tedious and error-prone. src-internal/DEPS was updated in crrev.com/i/2543523 to add the CIPD checkout at components/media_app_ui/resources/pkg (previously this was the "app" subfolder of the "app" checkout location of the git repo). This is "Step 3" of the migration in the linked bug. Step 4 is remove the git repo (../resources/app) from src-internal/DEPS. Bug: 1051776 Change-Id: I9608ea7e40b9601ca8919689efad6bf6eb6dce30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061568Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#742395}
-
bttk authored
Bug: 1046181 Change-Id: Ib732d475ecb33830a9e0be81a3b65b1d4e344a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019479 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#742394}
-
Donn Denman authored
Changes the text used to describe Contextual Search when the longpress activation experiment is in force. In this experiment we use longpress instead of Tap. This CL changes the term from "longpress" to the correct term to use externally: "Press & hold". Also update the legacy description of how to use the feature that shows in the Settings preferences on how to refine the search to use the new and improved wording. Followed https://g.co/chrome/translation to add screenshot sha1 hashes. BUG=957451 Change-Id: I6e98965b55a936107b9fffefebaad3bef5ed86c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058007Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#742393}
-
nancy authored
BUG=1016159 Change-Id: I7470f9fc89c1ff16eeb1f360b5ce4e1b631f0c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060355Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742392}
-
Ahmed Mehfooz authored
UX requirement to have theming enabled irrespective of blur enable / disable. Bug: 1049199 Change-Id: I6b7af77d12e75ed252d9c644577b9f4316eca76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062680Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742391}
-
- 18 Feb, 2020 11 commits
-
-
bttk authored
Bug: 1046181 Change-Id: I5f25fbc03a8f7feab5c76ac85b748bf04669f7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018253 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#742390}
-
Ayu Ishii authored
This change fixes origin parsing when there are dashes in the domain. I've also verified that there are no other characters that are expected in domains that should have been allowed. Bug: 1053351 Change-Id: I00fdb54cecd9719295fb195a36121ddaa1dea528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062871 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#742389}
-
Joel Hockey authored
TerminalSource which extends URLDataSource but not WebUIDataSource can benefit from using i18n substitutions via GetReplacements. Substitute $i18n{themeColor} into terminal *.html Currently we set page theme after a page loads after we fetch prefs. This causes flickering of the frame and page bg since the page is first set to the default theme from app manifest. In order to render correctly from the start, we will fetch the theme from prefs and substitute it into terminal.html for meta theme and css background. Bug: 1033339 Change-Id: I1820e1f271f1a51a7b8aafb6e6de65d4bd3d153b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059352Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#742388}
-
bttk authored
Bug: 1046181 Change-Id: I58390007cfdc98199a21e2e07df31d7c575b8185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019477 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#742387}
-
bttk authored
Bug: 1046181 Change-Id: Id7fc35bcf0891380e1ed3851cfb88791d213f679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024080 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#742386}
-
Robert Sesek authored
Bug: 710376 Change-Id: Ie3a7daded109f1f943b20b5f92c1eb07ca9ca6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057823Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742385}
-
Jamie Walch authored
DesktopCapturer is not a pure virtual interface, meaning that wrapping implementations such as DesktopAndCursorConditionalComposer need to be updated whenever a new method is added--the compiler will not give an error in this case. This was the cause of the multi-monitor breakage for relative pointer mode. Change-Id: I5a37a0e1fc47bf72cf9ccc7810c9e17d0a418237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063412 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#742384}
-
Mitsuru Oshima authored
Bug: None Change-Id: I5cb0478252d0cd52c23c9e10274f72dae5b48474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059050Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#742383}
-
nancy authored
Also modify ChromeLauncherController::LaunchApp to use AppService to launch apps, and remove LaunchApp function from LauncherControllerHelper. BUG=1016159 Change-Id: Idf863b32fa703c2f03e79042525bec14cc15fec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056892Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742382}
-
Hesen Zhang authored
- Add a debug option flag to show update notification right away. - Also enable helpful/unhelpful buttons. Change-Id: I878e337e9a2bf8aed1859553ab9a2fc29ec4de2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049044Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#742381}
-
Kurt Horimoto authored
Bug: 1030357 Change-Id: I1debca25f15b7b3ee4e8f8e51da7c4f43a949006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040920 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#742380}
-