GitLab

Please undo this change when the test has been fixed.

Bug: 1082820
Change-Id: I42f33fe05905d917bf83c09c9c2c4c7b205f922a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202341
Commit-Queue: Dana Fried <dfried@google.com>
Auto-Submit: Dana Fried <dfried@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768871}

BUG=1082705

Change-Id: I8d26b2b81b4d5e50f7f7d5504ae978997d68a3c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202144Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768870}

It turns out that Unicorn users can't view HaTS surveys anywhere due
to legal and privacy restrictions. Since that defeats most of the
purpose of enabling HaTS for supervised users on ChromeOS, this CL
reverts the code related to HaTS for supervised users on ChromeOS.

Bug: 1078513
Change-Id: I6c490bcea8f16705f4aa29779a1a3334dc9a926b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188925Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768869}

Tests are consistently (but not always) failing on Win7 builder.

Bug: 1082804
Change-Id: I92628ee5f12e4ae574291a3f225803fab5b699bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202318
Commit-Queue: Dana Fried <dfried@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768868}

This CL replaces the static class SigninTestUtil with
AccountManagerTestRule to mock the AccountManagerFacade in
background_sync tests. The latter is simpler and less flaky.

Bug: 1078342
Change-Id: I4754df741cf27b92b0c99fa19f7377d762050396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185009Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768867}

Bug: 1066016, 1066017
Change-Id: I2dc5929fc97b54d503d4290fd204d7413bf0cd59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201400Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768866}

https://chromium.googlesource.com/catapult.git/+log/fc43dd4cbbcb..db592f10d318

git log fc43dd4cbbcb..db592f10d318 --date=short --first-parent --format='%ad %ae %s'
2020-05-14 dberris@chromium.org auto-triage: Reopen issues with new regressions
2020-05-14 dberris@chromium.org refactoring: Preserve p-values in comparison result

Created with:
  gclient setdep -r src/third_party/catapult@db592f10d318

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC nuskos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1051710,chromium:1081607
Tbr: nuskos@google.com
Change-Id: Ie5628c40af267e72f73a5927739c62c6df0876d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201747Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768865}

Following <crrev.com/c/2198867>, there are more
|MarkDirtyLine*| tests in |NGInlineNodeTest|. This patch
ports them to |NGFragmentItem|-based line caching.

Bug: 982194
Change-Id: Icf1841d83d2a63893b33a240382c299c427ce5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198704
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768864}

For the GPU hang and crashes, I found all those boxes have two GPUs.
One is discrete NVIDIA GPU and one is integrated INTEL GPU. Chrome uses
the discrete NVIDIA GPU for GL, but chooses INTEL GPU for vulkan. Since
all hangs and crashes have the same configuration. So I think the hang
and crash could be related. Try to fix the hang by using the same GPU
for both GL and Vulkan.

Bug: 1082095,1072413
Change-Id: I20a191b03c23e10d1617098c305e0ccf9c9142c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200153Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768863}

In these unit tests, the reason to not letting the views hierarchy to
own the view was due to the controller and delegate's shorter lifetime.
We changed to let the test class own the controller and delegate so that
their lifetime are guaranteed. Thus we can remove the use of
set_owned_by_client().

BUG=1044687

Change-Id: Id95274422abcbae29107ac2cfdc69adec4ba2d67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196929
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768862}

Users have requested a way to darken all of the screen except what
is being read by Select to Speak, in order to improve focus. This
draws a semi-transparent black color over the rest of the screen
except for where the focus ring and its contents are drawn.

Plumbs the focus ring background alpha to Select to Speak, although
it is not used yet. Setting the alpha in prefs will be a separate
change.

Ax-Relnotes: N/A
Bug: 1079424
Change-Id: I5c0355fd33b8f595c0e761a46871405a0437ec22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188532
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768861}

https://chromium.googlesource.com/angle/angle.git/+log/c9ed32549988..ce925b4cbe60

git log c9ed32549988..ce925b4cbe60 --date=short --first-parent --format='%ad %ae %s'
2020-05-14 cnorthrop@google.com Perf: Add Temple Run trace

Created with:
  gclient setdep -r src/third_party/angle@ce925b4cbe60

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: geofflang@chromium.org
Change-Id: I8afcc9ff3baeb91ab95cd48d5c2172f2ec99525e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201746Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768860}

Current flow relies on the page loaded event. SAML page might contain
embedded pages which are hosted on separate domains (e.g. Google
captcha). That might lead to wrong SAML notice "This sign-in service is
hosted by ...".

This CL extracts domain from the top level url on each loadcommit

Fixed: 1055791
Change-Id: I882a62dc29200c6eb6a569defb89f25c7db2de91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201761Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768859}

Bug: 1066623
Change-Id: I3925e1d9e394983f6d6ecb8dc97b31222a333ca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182567Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768858}

Currently, we use a static unified clock to be able to compute the
'time at which the global monotonic clock is zero'. This means that this
values survives even if a page is reloaded after going to sleep for a
while. This is a problem because the time relies on a delta between the
unix time and the monotonic time, which may change after going to sleep.
Hence this means that values after reload cannot be compared with the
value returned by performance.timeOrigin. This CL fixes this by removing
the class and computing this value separately upon instantiating each
Performance object. In particular this ensures that
performance.timeOrigin and performance.timing.navigationStart don't
become extremely different after going to sleep and then reloading a
page.

Bug: 955532
Change-Id: Iaed7e127cd1224a4d3f053225635f2947e074bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182670Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768857}

WebLayer's use case is different enough to Clank's around launching
site settings activity, that WebLayer code can make do without
implementing this interface.

chouinard@ tells me there's no planned work to use this interface in
components anytime soon, so this CL reverts it.

This reverts commit 33f6fb0a.

Bug: None
Change-Id: Idc4b1fbabad8c2702e56a3226bb65f7766c88abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198968Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768856}

We don't care about thumbnails in this test, so use
TabUiTestHelper#createTabs instead.

Bug: 1079460
Change-Id: I7a6c4053fd5e56201aa0bccb76414d160ca4c458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199916Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768855}

We used to create an EventMetrics for each event and then ignore it if
the event type is not whitelisted. With this CL, EventMetrics' are only
created for whitelisted event types. This simplifies EventMetrics code a
bit and allows for further improvements.

Bug: None
Change-Id: I19d815a2f8679d4e9345670d23fec007f076585a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191332Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768854}

Bug: b/156611135
Change-Id: I3e96178ed97345d8ff99bc7ce291c0ef743dd708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202256
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768853}

This wrapper wraps a AnimationSet and keeps track of the cancelable
animators, and it provides the ability to cancel those animation with
one function call. So we don't need to keep a list of FloatProperty and
iterate through the list to locate the cancelable animators.

Change-Id: I43956e790636365f791c8aea305678dfc8216e1a
Bug: 1070284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183483Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768852}

phone code.

Certain forms can have the phone country code as a selection box field.
This CL adds the selection boxes to the list of the fields that are
considered for matching of the phone code when parsing for the
phone number.

Bug: 1081191
Change-Id: Ic8ec2e98c73b76f0478ad8db7603ceb821a42cc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193581
Commit-Queue: Vidhan Jain <vidhanj@google.com>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#768851}

- Injects TileServiceScheduler which wraps native scheduler.
- Call Handler functions on event happen.
- Baked instant fetch logic into new scheduler.
- Cancel task if feature disabled.

Bug: 1073550
Change-Id: I32947455dd048f7f65d8d47ddeff6c60600aafd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195004
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768850}

AllSections() was already used in a unit test, and the other two will be
used in follow-up CLs.

Bug: 1080892
Change-Id: Ia0d7f25ad8eb90705491b5460b2de119af248de5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199183
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768849}

Restricts the source of media files and styles that can be loaded
preventing external network requests. chrome://media-app requires
- media & images to load from blob urls from disk
- data urls for the transparent background and in tests

In doing so, this patch:
* adds GetContentSecurityPolicyDefaultSrc() to url_data_source.cc and
up the stack
* adds implementations for GetContentSecurityPolicyStyleSrc(),
GetContentSecurityPolicyImgSrc()
* sorts CSP methods/variables in alphabetical order
* adds a test to web_ui_data_source_unittest.cc

Bug: b/154181066, 996088, 1078672
Change-Id: I296bcc340389a05ee91cbf3c5dd2283b1abe5430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178632
Auto-Submit: David Lei <dlei@google.com>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768848}

Once SafeBrowsing has shipped, it should be possible to remove the
transient items.

Bug: 1028755
Change-Id: Ibc6dcf2750b421b58a279f99041e6f43796fbd81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201768
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768847}

A special case is needed for timeline current time and phase calculation
when endScrollOffset is greater than or equal to the max offset. This
special case was removed when adding timeline phase, and is now being
added back in.

The special case makes it so that when no endScrollOffset is provided
(which is the default behavior) the max scroll offset is inclusive.
This means that it is not necessary to specify "fill: forwards" on an
effect to make sure it remains at the end of the effect when the scroll
has reached its maximum.

https://github.com/w3c/csswg-drafts/issues/4325#issuecomment-606723725

Bug: 1046833
Change-Id: I6184f9c6059e1a091b54d86f37e4ba4b63c6bd13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195085
Commit-Queue: Jordan Taylor <jortaylo@microsoft.com>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768846}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c7172a2a6808..90c7477737b9

git log c7172a2a6808..90c7477737b9 --date=short --first-parent --format='%ad %ae %s'
2020-05-14 juxiao@microsoft.com Devtools: remove tabIndex when JS VM instance list is empty
2020-05-14 wolfi@chromium.org Port PerformanceMetricsModel.js to TypeScript
2020-05-14 pfaffe@chromium.org Fix Wasm debugging based on the DWARF SourceMap approach
2020-05-14 yangguo@chromium.org Assign owners to hidden files in root
2020-05-14 morlovich@chromium.org Add test for _generateBrandVersionList
2020-05-14 wolfi@chromium.org Fix return type after porting to TypeScript
2020-05-14 leese@chromium.org Keep editing enabled for filesystem scripts
2020-05-14 pfaffe@chromium.org Reenable tests
2020-05-14 mathias@chromium.org Enable no-global-assign lint rule
2020-05-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@90c7477737b9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811,chromium:1057042,chromium:1073909,chromium:1078243,chromium:1079233,chromium:1079328,chromium:1081865,chromium:1082687,chromium:1082720
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I205b5d3d8314b7698fbb7a01aa0c4af5edf99ae9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202001Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#768845}

Previously we were forcibly terminating the GPU process.

Now, we CHECK(SUCCEEDED(hr)) so we can gather telemetry on process
state and affected drivers.

Bug: 1054217
Change-Id: I6a8752e0c185ef9bdc49edd01e9c2b3b1208e0c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200095Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#768844}

This reverts commit b7c7185e.

Reason for revert: Change to test_runner.cc breaks several builds on compile.

Original change's description:
> Move InsertStyleSheet out of TestRunnerForSpecificView
> 
> R=​avi@chromium.org
> 
> Bug: 866140
> Change-Id: I4684093db40f628b273c343352a74118830df824
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202157
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#768829}

TBR=avi@chromium.org,danakj@chromium.org

Change-Id: I7f666d54521d0868e659eb1d11d1636ba4ea8ec7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202377Reviewed-by: Dana Fried <dfried@google.com>
Commit-Queue: Dana Fried <dfried@google.com>
Cr-Commit-Position: refs/heads/master@{#768843}

This CL fixes a bug that the account picker dialog is still shown after
the user selects an account.

Bug: 1082109
Change-Id: Ic1f1f96031aa91dcf69d73376f2e1891284039f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199261
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768842}

Eventually we'll add similar DCHECKs in net, at the URLRequest layer,
but it's better to DCHECK sooner, with more relevant data on the stack,
and this also protects against regressions until we can DCHECK that all
URLRequests have an IsolationInfo.

Also fix a bug in DedicatedWorkerHost that the DCHECK caught.
There was an assumption that StartScriptLoad was called before other
methods that need an IsolationInfo, but this is not true.

Bug: 1082280
Change-Id: I14878ffa0e8e1fe4e7d2a6d4dba537acebd8c71c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196721
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768841}

This may start up the sync datatype faster in certain cases like First
Run Experience (with lots of data to download from non-priority
datatypes) in addition to more advanced cases like pending NIGORI
commits.

Change-Id: I9a95769277135601b9aa698fbefdaef4fd0164e9
Bug: 1056206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201357
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#768840}

This fixes the initialization and tear down code paths for the
TabLoadingFrameNavigationScheduler mechanism, which was previously
being racily torn down from the PM sequence rather than the UI
thread.

BUG=1064763

Change-Id: Ic1185fc8a9ab6328f4eb4fbaf9d0a73bc0d2f972
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202137
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768839}

Default interval on iOS was set to 30 minutes, but it's unclear if
the value is ideal for iOS. Too frequent sampling will put unnecessary
load on the server, while to rare sampling will not allow us to
collect enough data.

Default interval on Android was set to 24 hours, which seems to be
too rare, so we don't collect enough data.

Configurable sampling interval will allow us to find the best sampling
rate for iOS and Android.

Bug: 1075702
TBR: rockot@chromium.org
Change-Id: I6e820486240e2b3552146d0b066d411b79a12a6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194593
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768838}

Enabling the test on Android will be done in the next CL. This will be a
separate CL in case there are any flakiness issues.

Bug: 1080661, 1047474
Change-Id: I0d02b46f7c39e2d83040a64f3b5190d4c660b7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194945
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768837}

Bug: 928595
Change-Id: I045f64c5c20ee29a59295c0f2467d2290a87e0ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201579
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#768836}

This introduces BrowserControlsNavigationStateHandler, which is responsible
for determining the state of the controls as related to navigation state. It
has the logic of Clank and chromeos. The interesting changes are:
. the control state is specific to a navigation, and needs to be
  sent in DidFinishNavigation(). This is why prior to this patch the
  controls snapped back on every navigation (I'm not positive if the
  state is specific to a renderer process, or per-navigation,
  clank code says process, but I'm not sure that is right).
. The controls are forced visible until 3 seconds after loading.
. Lots of other logic around forcing shown around various error states.

I've put the logic in the C++ side for two reasons:
. We are striving to have C++ the source of truth.
. Tests are easier.

I would like to make this compile on all platforms, but for now it's
just android.

There are also some TODOs for parts we don't have wired up yet, but they
shouldn't stop this from landing.

I plan to write tests, but am trying to get this in before the branch.

I'm also disabling the bottom-tests, they are just too flaky. I know
the source of that flake and will have a patch to straighten them out
soon (it's not pretty).

BUG=1081231
TEST=forthcoming

Change-Id: Id1d7c36ed473b3df665e615372d2548d8e2bbcb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200318Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768835}

This aligns tests with a new document split.

Bug: https://github.com/w3c/webrtc-priority/issues/8
Change-Id: Idb512da6c34c866552f1155dd0ee4df6754dee6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201757Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768834}

Add methods in TestRunnerBindings to wrap a V8 function into a
base::Callback, making the function and any bound V8 arguments into
v8::Persistent objects.

The resulting callback, when Run(), can receive further V8 arguments,
which will appended to the bound v8::Persistent objects (converted back
to v8::Local objects). Then the v8 function will be invoked. This is
effectively currying for the v8 function arguments. Sorry, not sorry.

Also add a helper to PostTask a V8 function. It will be used as more
code migrates from TestRunnerForSpecificView.

We replace all calls that were being made to TestRunnerForSpecificView
from TestRunnerBindings in order to post/invoke V8 functions, and use
the new methods instead.

Notably, CreateClosureThatPostsV8Callback() was being used to wrap
everything into a base::Callback, but it introduced an extra PostTask()
in the process. We do not need that, so we use our new Callback-wrapper
methods directly instead of binding a PostTask in as well.

R=avi@chromium.org

Bug: 866140, 1069111
Change-Id: I09aaef11032c0a90162a3ad4b6800c958ce5f102
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199726Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768833}

Add error callback reporting error by connecting through message port,
call callback from error metrics function in testing mode.

Bug: 1072700
Test: tast run <DUT> "camera.CCAUI*"

Change-Id: Ifb2824b9ce2689909dc4730e145cd831d41eb0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169448
Auto-Submit: Kuo Jen Wei <inker@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768832}