- 13 Aug, 2018 40 commits
-
-
Donna Wu authored
This CL moves the permission checking in UsbDevice implementation to WebUsbService by adjusting some mojo interfaces. BUG=699790 Change-Id: Ie5842f1a433a8b05275b06f31f25320bcc10a4d7 Reviewed-on: https://chromium-review.googlesource.com/1166592 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582538}
-
Vasilii Sukhanov authored
Bug: 791389 Change-Id: Iea3b6e0f2ec7899e099bd9d7e23017ac4c83e459 Reviewed-on: https://chromium-review.googlesource.com/1170908Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582537}
-
Gauthier Ambard authored
This CL adds the animations for the presentation of the IdentityChooser. Bug: 873065 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id64905a5e11fcf64ed65860aabf988a01e17d837 Reviewed-on: https://chromium-review.googlesource.com/1170774 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582536}
-
Marc Treib authored
Sync would like to use one AccessTokenFetcher instance to fetch access tokens both for the primary account and for secondary accounts. For the primary account, they would like to wait for the refresh token to be available. In order to support this use case, AccessTokenFetcher needs a Mode parameter. This CL adds that Mode parameter. Note that this Mode parameter is *not identical* semantically to the Mode parameter of PrimaryAccountAccessTokenFetcher: the former's |kWaitUntilAvailable| mode makes an access token request once there is an account that is both (a) primary and (b) has a refresh token available, while the latter's new |kWaitUntilRefreshTokenAvailable| mode simply waits until there is a refresh token available for the given account (which may no longer be primary at that point, even if it was at the time of creating the AccessTokenFetcher). This semantic distinction is called out explicitly in the comments on PrimaryAccountAccessTokenFetcher::Mode. Sync has indicated that the AccessTokenFetcher semantics suffice for their use case. Bug: 840703, 729547 Change-Id: Iff39a24ef74945b3e9fa22ad961c3cd73a401e51 Reviewed-on: https://chromium-review.googlesource.com/1158831 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#582535}
-
Victor Costan authored
Switch from counting usage of the indexedDB property on the global object to counting indexedDB.open(). The former can get triggered by code that walks all global properties, while the latter is real IndexedDB usage. Change-Id: I36d003321ea0ca24a07034cbce89c33c39c67959 Reviewed-on: https://chromium-review.googlesource.com/1170392Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
Verifiy that all 'required' properties in a policy schema are actually existing in 'properties' as well. Bug: 856903 Test: components_unittests --gtest_filter=JSONSchemaValidator.* Change-Id: Ie8c3ff8ac82bcb3c436cfb580721070050b66b22 Reviewed-on: https://chromium-review.googlesource.com/1165361Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#582533}
-
Dominik Röttsches authored
Bug: 870379 Tbr: eae, behdad Change-Id: I89c78c4b5253706b5c8075576a53dd3791fcd4cf Reviewed-on: https://chromium-review.googlesource.com/1162229 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#582532}
-
Marcin Wiacek authored
Compilation settings: target_os="android" target_cpu="arm" enable_nacl=false symbol_level=0 remove_webcore_debug_symbols=true is_debug=false dcheck_always_on=false is_component_build=false use_jumbo_build=true Compilation error without patch: ./../../content/browser/font_unique_name_lookup/icu_fold_case_util.cc:7:19: error: using namespace directive in global context in header [-Werror,-Wheader-hygiene] using namespace ::icu_62; ^ Change-Id: Idd624fd0d5a14e49070c958a18a7e7136a14a659 Reviewed-on: https://chromium-review.googlesource.com/1172125 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#582531}
-
Gauthier Ambard authored
The Identity Chooser popup was using the MDC presentation style. It is not in line with the current style applied with UI Refresh. This CL creates the classes to be user to present the popup according to the new styling. For now, no animation or styling is done. Bug: 873065 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I73b93e0d47c7ebe2e2b5756faaf6fea32be63b3e Reviewed-on: https://chromium-review.googlesource.com/1169815Reviewed-by:
-
Gauthier Ambard authored
The ConsentBump should be displayed modally on iPhone+ landscape and iPad. Bug: 873128 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I96482c930ef1b6b94509e8aafd7b1691b76b2e28 Reviewed-on: https://chromium-review.googlesource.com/1170823Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582529}
-
Makoto Shimazu authored
TBR=vitaliii@chromium.org NOTRY=true Bug: 873494 Change-Id: I1395c30a000ac7033b1e8711caac1132add2ad94 Reviewed-on: https://chromium-review.googlesource.com/1172265Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582528}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1a25c06cd15..87a737292804 git log f1a25c06cd15..87a737292804 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 7ae70d8fb360..a43d7306d87a (1 commits) Created with: gclient setdep -r src/third_party/skia@87a737292804 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I4e8aa819ddbb79f6ebecc336f11ceb6bdfee53f3 Reviewed-on: https://chromium-review.googlesource.com/1172107Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582527}
-
Ramin Halavati authored
A deprecated entry in annotations.xml is corrected. Change-Id: I8d77e73602c4050fbfdf3defd9a4b72f5fc705fa TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1172130Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582526}
-
Lutz Justen authored
During signin, the cryptohome migration flag is automatically set for Active Directory user accounts, which makes their cryptohome id switch from email to account id key. This is problematic for tests that populate policy before signin by sending policy to Session Manager since the policy is 'addressed' using the cryptohome id, see e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1145319/2/chrome/browser/chromeos/policy/affiliation_test_helper.cc#122 In a nutshell, policy is stored using the email address, but later loaded using the account id key. To resolve this, ACTIVE_DIRECTORY now always uses the account id key as cryptohome id. This fixes the issue and should make the code more robust. BUG=chromium:839352 TEST=Verified that the hack in the CL above isn't necessary anymore. Change-Id: I3ecb378aac08fc8dc5374e7bc170a9eb2c96741d Reviewed-on: https://chromium-review.googlesource.com/1055509Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#582525}
-
Kyoko Muto authored
As the first step of implementing "Imperative Shadow DOM Distribution API", this CL makes element.attachShadow take an optional parameter, |slotting|, which should be 'manual' or 'auto'. This CL also introduces new Runtime flag, ManualSlotting, to guard the new feature. BUG=869308 Change-Id: I71b115886c07c0090bef16b66da48c88e723a622 Reviewed-on: https://chromium-review.googlesource.com/1166767 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#582524}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62dc9deeea75..8d8a9d7701bd git log 62dc9deeea75..8d8a9d7701bd --date=short --no-merges --format='%ad %ae %s' 2018-08-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8d8a9d7701bd The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I886dcabc2d0d391328bd566aa68c2f50615e1a24 Reviewed-on: https://chromium-review.googlesource.com/1172105Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582523}
-
Makoto Shimazu authored
This reverts commit fe36308d. Reason for revert: OfflinePageBridgeTest.testGetLoadUrlParamsForOpeningMhtmlFileUrl seems failing. This is the only CL relevant to offline pages, so let me revert this speculatively. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.offlinepages.OfflinePageBridgeTest%23testGetLoadUrlParamsForOpeningMhtmlFileUrl Original change's description: > Report different UMA enums when clicking async download notification > > Currently it is reported as "Download Home". We now add the logic > to separate it out, together with the case that clicking from progress > bar. > > Bug: 869692 > Change-Id: I9f2fcbbac20da9cf23176a00505fe10d04136b2f > Tbr: dgn@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/1157644 > Commit-Queue: Jian Li <jianli@chromium.org> > Reviewed-by: Dmitry Titov <dimich@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581930} TBR=peter@chromium.org,dimich@chromium.org,jianli@chromium.org,qinmin@chromium.org,dgn@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869692 Change-Id: Ifaee7de7a978f3795a6cf701d4420aa04736b169 Reviewed-on: https://chromium-review.googlesource.com/1172182Reviewed-by:
-
Koji Ishii authored
This patch rebaselines 2 text failures that look good from a manual review of build 8803, and 5 removal that match to their base expectations. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0efe930ada47e46163be831d7814c50a132ba195 Reviewed-on: https://chromium-review.googlesource.com/1172231 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582521}
-
Alexey Baskakov authored
No behavior change. Bug: 860581 Change-Id: I808616a351c2f7912ebab1e6f052e00c10e4107a Reviewed-on: https://chromium-review.googlesource.com/1172171Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#582520}
-
Makoto Shimazu authored
TBR=robertma@chromium.org NOTRY=true Bug: 856601 Change-Id: I8527c9d7c1df382f08620378ac9931634cfdd5aa Reviewed-on: https://chromium-review.googlesource.com/1172226Reviewed-by:
-
Makoto Shimazu authored
TBR=jsbell@chromium.org NOTRY=true Bug: 873570 Change-Id: I1cf6d4ca729e7fdb7c14bf5b5288dc84de408f3c Reviewed-on: https://chromium-review.googlesource.com/1172228Reviewed-by:
-
Ramin Halavati authored
Preferences related to Rapor are moved to the incognito persistent storage list. This CL does not change the current behavior. Bug: 861722 Change-Id: Ie2212b845d2ce9a73d60a7fc24ae480b29b56420 Reviewed-on: https://chromium-review.googlesource.com/1166829 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#582517}
-
Makoto Shimazu authored
Tbr: andruud@chromium.org No-Try: true Bug: 873454 Change-Id: I713c5266cd9eb12cf49cfe8b952e709f47070ca9 Reviewed-on: https://chromium-review.googlesource.com/1172181Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582516}
-
Yoichi Osato authored
This patch makes the function to only receive |const Text&| rather than |Text*| as other MarkersXXX functions. Bug: 868229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I547e35fe6f95d959759b7042cebf81e27aad9d96 Reviewed-on: https://chromium-review.googlesource.com/1168948Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582515}
-
Ramin Halavati authored
Tests are added to Extensions Tabs API to ensure extensions cannot create or query the tabs in incognito mode when they are not enabled to run there. Bug: 862075 Change-Id: I6081b4cc432c82d147a65f30311af0708efe03f9 Reviewed-on: https://chromium-review.googlesource.com/1158368 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582514}
-
Giovanni Ortuño Urquidi authored
Changes BookmarkAppHelper, CrxInstaller, and ConvertWebAppToExtension so that clients can set the manifest location and extra install flags that will be used when creating the extension. Bug: 852244 Change-Id: I59077e015dc80d9461218f3722942e58e9bc5281 Reviewed-on: https://chromium-review.googlesource.com/1170152Reviewed-by:
-
Adam Rice authored
Design doc https://docs.google.com/document/d/17goe4jacAYjHHtprfVPSrqDvF_J58u2qirz0HQ58sQ4/edit Implement the C++ classes TransformStream and TransformStreamDefaultController. These provide thin wrappers for the equivalent JavaScript classes. Modify the JavaScript TransformStream implementation to pass the |controller| argument to the algorithms. This is a departure from the standard, but the difference is not observable to user code. It makes the memory management considerably simpler as no C++ reference to the TransformStreamDefaultController needs to be retained between calls. Define the interface TransformStreamTransformer. Also create unit tests for these new classes. Bug: 845427 Change-Id: I067a8ff15daaa4912760fbdb9ca4697705f2e3f8 Reviewed-on: https://chromium-review.googlesource.com/1156324Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#582512}
-
Ryan Sleevi authored
MCSProbe was refactored in r567674 to use Mojo, rather than interacting directly with //net APIs. However, as part of the refactor, many of the objects used to initialize the HttpNetworkSession became unused in the Mojo URLRequestContext. This restores the intended behaviour - namely, that the command-line can control whether a NetLog is generated, as well as whether certificate errors are ignored. In the process of cleaning up this code, it was the last remaining caller of ProxyResolutionService::CreateDirectWithNetLog(). However, because it was always using DIRECT, supplying the NetLog was unnecessary, and CreateDirect() works just as well. Fix the call site and remove the (now dead) ProxyResolutionService API. Bug: none Change-Id: I126b60db94c4f486eed9bfd2af3ba2971e34a4fd Reviewed-on: https://chromium-review.googlesource.com/1169826 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#582511}
-
Pin-chih Lin authored
Currently on VideoEncodeAccelerator::Initialize() deafult framerate is always used to initialize encoder. As we have profile and level of H.264 encoding in initial Config, framerate should be also adjustable on initialization for the client to configure a supportable parameter set under the limit of of profile/level. BUG=871154 TEST=build and deploy chrome on eve TEST=build and run video_encoder_accelerator_unittest on eve Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifd6e33ada82d44c0e1b46f56856caeec9600e139 Reviewed-on: https://chromium-review.googlesource.com/1163592Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582510}
-
Kouhei Ueno authored
This is a speculative fix for crash reported on crbug.com/872672 . There is no guarantee that the DocumentLoader is always attached [1], so let's introduce a null check. [1] The DocumentLoader may be detached while FrameLoader::PrepareForCommit. Bug: 872672 Change-Id: I015651506a891c3344f1bdbf40ea013ce988a95f Reviewed-on: https://chromium-review.googlesource.com/1171972Reviewed-by:
-
Ramin Halavati authored
Preferences related to UKM are moved to the persistent storage list for incognito mode. This CL does not change any current behaviore. Bug: 861722 Change-Id: I80e3ab0ef4326e7e6105649c3fe376be1755c755 Reviewed-on: https://chromium-review.googlesource.com/1166826Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I098426b763ce553d7a23e4665951dcbb709ef760 Reviewed-on: https://chromium-review.googlesource.com/1172153Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582507}
-
Ryo Hashimoto authored
Removing the timeout to have one less sources of flakiness. BUG=872732 TEST=dbus_unittests Change-Id: I7ca390a19a77686df268332850e3951e6d13d3d1 Reviewed-on: https://chromium-review.googlesource.com/1170719 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#582506}
-
Matt Falkenhagen authored
The test no longer flakes since the bug was fixed. Bug: 862294 Change-Id: I4802c3a5d09ea487459a93726a841ae4dd7c437a Reviewed-on: https://chromium-review.googlesource.com/1172168Reviewed-by:
-
Ehsan Karamad authored
MimeHandlerViewContainer implements the renderer side of logic for embedding the MimeHandlerView extension. The logic is currently based on a GuestViewContainer which internally uses a WebPlugin (BrowserPlugin). MimeHandlerView will eventually get implemented on top of cross-process frames architecture; requiring its owner container class on the embedder side. This CL will extract the common code between the current BrowserPlugin version and the forthcoming frame-based version into a base class so that the similar code between the two containers is not duplicated. The common code includes a) logic in creating MimeHandlerViewGuest, b) support for network service and c) support for post message. Bug: 659750 Change-Id: Iabe44b1438fc22aa052b1ebf6d8696bdca00d0c9 Reviewed-on: https://chromium-review.googlesource.com/1170564Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#582504}
-
Koji Ishii authored
Following bot results are included. 8762 8763 8764 8766 8775 8780 8783 8784 8785 8786 8787 8791 8792 8793 8794 8796 0 lines were removed and 7 lines were deflaked by consecutive results since 8775. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iacb8621bd123235f6347897915d2317093d10c06 Reviewed-on: https://chromium-review.googlesource.com/1170444 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Bug: 819663 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5a79280401e460954a53de4db529061c3f9bae49 Reviewed-on: https://chromium-review.googlesource.com/1171257 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Emil A Eklund authored
Computing whether an inline block spans multiple lines is more expensive than expected thus causing a small paint performance regression for both legacy layout and LayoutNG. This patch moves the computation to use-time thereby avoiding it when cached drawings are used or paint isn't needed. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I97380b2e304c3c3293514ecf118fffdf6f9b9292 Reviewed-on: https://chromium-review.googlesource.com/1170310Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#582501}
-
Makoto Shimazu authored
TBR=yosin@chromium.org NOTRY=true Bug: 873547 Change-Id: Ife2840825a7e24a6757da817806d35bd80cbd95c Reviewed-on: https://chromium-review.googlesource.com/1172166Reviewed-by:
-
James Cook authored
There's no separate "classic" mode in ash anymore. Collapse the superclass with its only subclass. Just cleanup, no functional changes. Bug: 873266 Test: ash_unittests Change-Id: I70cdf56a8cb534cc5f5f1385ef5d702d3694b5a5 Reviewed-on: https://chromium-review.googlesource.com/1171821Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#582499}
-
