GitLab

Also fix favicons in task manager.

BUG=32148
TEST=Have a few tabs that share a process. Sort of various columns in the task manager, the process group should stay one block.

Review URL: http://codereview.chromium.org/3029041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54206 0039d316-1c4b-4281-b951-d872f2087c98

Separate all interactions with HistoryService out of DownloadManager
to new class DownloadHistory owned by the DownloadManager.

The goal is to create more smaller classes with clearly defined
responsibilities.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3071005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Test passes
Review URL: http://codereview.chromium.org/3029038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54204 0039d316-1c4b-4281-b951-d872f2087c98

the private font interface.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3044029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54203 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54202 0039d316-1c4b-4281-b951-d872f2087c98

to net/test/test_server.h

No code changes, just a move.

TEST=none
BUG=49680

Review URL: http://codereview.chromium.org/3034038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98

    BUG=chromium-os:4485
    TEST=unit tests

Review URL: http://codereview.chromium.org/3058021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54199 0039d316-1c4b-4281-b951-d872f2087c98

empty strings.

BUG=50674
TEST=none

Review URL: http://codereview.chromium.org/3069012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54196 0039d316-1c4b-4281-b951-d872f2087c98

Revert 54168 - Remove PulseAudio 48553 suppression.  The memory leaks do not happen if connecting to PulseAudio on the calling (UI) thread at browser init time. Since this change is checked in (r53992), this suppression can be removed.

BUG=3013042,48553
TEST=none

Review URL: http://codereview.chromium.org/2868081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54192 0039d316-1c4b-4281-b951-d872f2087c98

Also update the DCHECK to use an absolute
value of the skew for comparison. It could
be negative.

TEST=base_unittests
BUG=none

Review URL: http://codereview.chromium.org/3083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54191 0039d316-1c4b-4281-b951-d872f2087c98

TEST=it still compiles
BUG=none
Review URL: http://codereview.chromium.org/3020027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54190 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3056032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54189 0039d316-1c4b-4281-b951-d872f2087c98

Toolbar.xib changes:
 - buttons from 31x27 to 29x29 so that the visual is 27x27.
 - shift things left to take up opened space.
 - omnibox to 29 pixels tall.
 - wrench also to 29x29.
 - all of that raised a single pixel to recenter.
 - swap positions of home and reload.

Modify home-button-adjustment code to reflect rearranged
home/reload positions.

Increase Omnibox font size by one point to match increased field
height (and Windows Omnibox).  Revise various font clients to
recognize this.  Shift Omnibox baseline and other measurements to
account for increased height.

Shift globe/search icon in by one pixel so icons on both sides of
Omnibox are 4px from border.  Matching shift in popup.

Fix EV-bubble to use appropriate green for text, rather than black.

Push out bubble to have a single-pixel space WRT Omnibox border.
Tighten corners to tuck into Omnibox corners.  Handle different
lhs padding versus location icon (image should end up in same
spot, even though the bubble draws outside the image).

BUG=50575
TEST=none

Review URL: http://codereview.chromium.org/3046029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54188 0039d316-1c4b-4281-b951-d872f2087c98

Rework somewhat how the folder menu window and main view sizes and positions are calculated. Handle edge case where the top scroll arrow is not showing. Proposed window height was not taking into account the one additional vertical separation.

BUG=46101
TEST=Setup: Create a bookmark folder on the bookmark bar with plenty of bookmarks, more than enough to fill the screen, and so that it is scrollable. 1) Bring up the bookmark folder menu but do not cause it to scroll. 2) Using the contextual menu delete a bookmark midway in the menu. 3) Verify that the top of the menu window and contents do not move relative to the bookmark bar folder button. 4) Bring up the bookmark folder menu again. 5) Cause the menu to scroll up to fill the screen and then scroll it down so that the top scroll arrow is not showing. 6) Using the contextual menu delete a bookmark midway in the menu. 7) Verify that the top of the menu window and contents have not moved in relation to the screen top. 8) Bring up the bookmark folder menu and cause it to scroll such that both the top and bottom scroll arrows are showing. 9) Using the contextual menu, delete a bookmark midway in the menu. 10) Verify that the top scroll arrow, the top-most item showing in the menu, and the menu window have not changed position relative to the top of the window. Note that the contents of the folder menu below the bookmark item being delete should adjust upward to fill the slot originally occupied by the deleted bookmark.

Review URL: http://codereview.chromium.org/3050021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54187 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2819071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54186 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50573
TEST=none

Review URL: http://codereview.chromium.org/2868082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54185 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2884048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50378
TEST=none

Review URL: http://codereview.chromium.org/3018026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50583
TEST=Saw bug in heapcheck, made change, saw bug dissapear.

Review URL: http://codereview.chromium.org/2856069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54181 0039d316-1c4b-4281-b951-d872f2087c98

When I was running ui_tests on Linux at the end there were to xmessage windows
on the screen. They shouldn't be there, and they might gum up the bots,
especially if it happens on Windows.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2847085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54180 0039d316-1c4b-4281-b951-d872f2087c98

the private font interface.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3044029

TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/3052024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=DOMUI Under the Hood options still display correctly.

Review URL: http://codereview.chromium.org/3017039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50669
TEST=none

Review URL: http://codereview.chromium.org/3013043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54176 0039d316-1c4b-4281-b951-d872f2087c98

Also fix a leak in test Init reported by valgrind. The problem was that the test called a rogue init, which didn't cause the window to be shown, and hence -close didn't send a -windowWillClose: notification. Also restore -windowWillClose:, it accidentally got deleted in http://codereview.chromium.org/536086

BUG=32148,30398
TEST=Click a column in the task manager. Should sort.

Review URL: http://codereview.chromium.org/2873075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54175 0039d316-1c4b-4281-b951-d872f2087c98

In short, this:
* Eliminates the divider on the right (the new chevron has a built-in divider)
* Changes the padding between items (see updated comments in header for precise layout details)
* Updates the imagery for the new theme
* Makes the chevron respond to theme changes

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3057016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54174 0039d316-1c4b-4281-b951-d872f2087c98

the private font interface.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3044029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54173 0039d316-1c4b-4281-b951-d872f2087c98

TBR=glider,thestig
Review URL: http://codereview.chromium.org/3069011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54171 0039d316-1c4b-4281-b951-d872f2087c98

Revert 53992 - An earlier check-in (r51786, Issue 2769008) caused a memory leak on the build bots when PulseAudio was initialized on a separate worker thread.  This change calls PulseAudioMixer::InitSync() so the init happens on the calling thread.  For some reason, the init finishes cleanly on one thread, but not the other.

BUG=48553 (and http://code.google.com/p/chromium-os/issues/detail?id=5141)
TEST=Valgrind should not have PulseAudio related memory leaks, suppression 48553, or assertion failures.

Review URL: http://codereview.chromium.org/3026028

TBR=davej@chromium.org
Review URL: http://codereview.chromium.org/3013042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54170 0039d316-1c4b-4281-b951-d872f2087c98

The memory leaks do not happen if connecting to PulseAudio on the calling (UI) thread at browser init time.
Since this change is checked in (r53992), this suppression can be removed.
BUG=48553
TEST=There should be no more PulseAudio related memory leaks or assertion failures.

Review URL: http://codereview.chromium.org/3066012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54168 0039d316-1c4b-4281-b951-d872f2087c98

Pepper3D test passes on trybots but fails on buildbots. I am guessing osmesa is not being built on the buildbots. Adding osmesa target dependency may fix it.
BUG=46662
Review URL: http://codereview.chromium.org/3031028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54167 0039d316-1c4b-4281-b951-d872f2087c98

TEST=this is it
BUG=none
Review URL: http://codereview.chromium.org/3079006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54166 0039d316-1c4b-4281-b951-d872f2087c98

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3020041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54165 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54164 0039d316-1c4b-4281-b951-d872f2087c98

Verifies the multiple downloads infobar.

Implemented by Venkat, who figured out how to reliably trigger the multiple
downloads infobar.

Review URL: http://codereview.chromium.org/3066017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54163 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Verify that wrench menu zoom controls are disabled when showing PDF using the Chrome PDF plugin anf enabled otherwise.

Review URL: http://codereview.chromium.org/3032038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54162 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50471
TEST=PreferencesWindowController.SwitchToPage should not crash in official builds.
Review URL: http://codereview.chromium.org/2836073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54160 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/2873074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50565
Review URL: http://codereview.chromium.org/3028034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54155 0039d316-1c4b-4281-b951-d872f2087c98

SpdyHttpStream now implements (a slightly wider) HttpStream interface.

BUG=50268
TEST=none

Review URL: http://codereview.chromium.org/3079002


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54154 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54150 0039d316-1c4b-4281-b951-d872f2087c98