- 14 Jan, 2021 40 commits
-
-
Cammie Smith Barnes authored
Removes '^chrome/test/chromedriver/server/http_handler.cc' from the _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK list in src/PRESUBMIT.py, as the chrome/test directory has now been fully converted. Bug: 1007643 Change-Id: Ib57bcb674ac8c26c7ad5553267194cecd590591d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626176Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#843312}
-
Yao Xiao authored
Explainer: https://github.com/WICG/floc#opting-out-of-computation This feature controls the access to the interest cohort (https://github.com/WICG/floc) as well as the eligibility for the navigation history entry to be included in the interest cohort computation. Let the feature availability be controlled by a chrome feature to allow some flexibility while finalizing on the decision. In reality, we will probably want to enable the chrome feature before it goes to OT. Use browsertest for testing as opposed to using webtest, as the functions rely on the chrome layer. Bug: 1158851 Change-Id: I2a81f9547c9180bf3c6ac65974eb0b1666a41812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593688 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#843311}
-
Michael Montvelishsky authored
Bug: none Test: none Change-Id: I19e2731087799e7f58dfd43c66d65d0ff5e5cfb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627873 Auto-Submit: Michael Montvelishsky <mont@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#843310}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9b5dd7ab8a98..64d94deaa6a4 2021-01-14 ehmaldonado@google.com presubmit: Use new API to check for owners approval If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Id46502da345918835c0e3df5ee1643a7f5156cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843309}
-
Trevor Perrier authored
This CL moves the expiry on the detailed-language-settings flag from M89 to M91. Bug: 1127531 Change-Id: I23d2df7e3a2b87a45bc8c87baafb45589dee4b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626977Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#843308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/20d3823787dd..3f6d4980860b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com,mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1164243 Tbr: yutak@google.com,mpearson@google.com Change-Id: I98b55b506d69b9fe546f2a6ee06c706bec917775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628342Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843307}
-
Austin Sullivan authored
Refactor content/public/browser and chrome/browser All changes are find-and-replace unless called out in a comment. Bug: 1110509 Change-Id: Ib46ed353865321413e49a56477a4a07b47034e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602222 Commit-Queue: Austin Sullivan <asully@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#843306}
-
Yuta Hijikata authored
The patch removes is_lacros, is_ash, IS_LACROS and IS_ASH which were aliases for is_chromeos_lacros, is_chromeos_ash, IS_CHROMEOS_ASH and IS_CHROMEOS_LACROS. The names were changed to make it clearer that the variables are related to CrOS. Bug: 1052397 Change-Id: Id5b9b1b2ca3d34a9773ae73e4cc9408b9633e0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627529Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#843305}
-
Xianzhu Wang authored
It will be called to map a cull rect from parent space to local space in cull rect update during PrePaint. The purpose is to mark PaintLayers needing repaint on cull rect changes before paint, instead of checking interest rect / cull rect changes during paint, to avoid setting PaintLayer needing repaint unnecessarily, especially for CAP during composited scrolling. Besides the original features of CullRect::ApplyTransforms() which is used in cull rect mapping for CompositeAfterPaint, it also implements the following features to be on par with CompositedLayerMapping:: ReComputeInterestRect(): - Considering clips in additional to scroll clips, - Clipping expanded cull rect by scrolling contents rect for composited scroll translations, - Clamping extreme geometry values, - Adaptive expansion distance for composited transforms. The next steps are: 1. Add CullRectUpdater which updates cull rects during PrePaint when runtime feature CullRectUpdate is enabled. 2. Use the updated cull rect to replace interest rect in pre-CAP and cull rect in CAP and pre-CAP, still behind the runtime feature. 3. Enable CullRectUpdate for CAP 4. Enable CullRectUpdate for pre-CAP. 5. Remove old interest rect / cull rect code. Bug: 1046544 Change-Id: I6e7e9f85bc0b4640e67de1732744e647b6f7e230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620090Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843304}
-
Max Curran authored
Initial implementation of the background task to measure how often user are offline and what they do while offline. Full Design Doc: https://docs.google.com/document/d/1Vv6fdaRWjLpxeuVR89C6y5cGcAiCu6f4YBRwMjpN_T0/edit?usp=sharing Bug: 1131600 Change-Id: I89f67a6bbdaf71b550518b40c06788e3dfaccf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459946 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#843303}
-
Azeem Arshad authored
This CL changes eid_popup component so that it fetches eid qr code image data from mojo service and renders it on a canvas. Screenshot: http://screen/bVoRYtfvfMMyMb4.png Bug: 1093185 Change-Id: Iae2f248c5524495aa13e85b25ea6add02c382d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613945 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843302}
-
Joel Riley authored
When navigation controls are not present, STS was not going into inactive state after TTS completed. This CL fixes this issue, as calling updatePauseStatusFromTtsEvent_ was setting STS back into SPEAKING state. Also, if STS is activated without nodes, do not show panel. AX-Relnotes: Bug fix when activating STS without navigation controls, STS did not go back into inactive state. Bug: 1165847 Change-Id: I88b44e84de525d2dbc190b97fa02b691394cb294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625268 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#843301}
-
John Delaney authored
What: Replace usage of ShellAddedObserver + TestNavigationObserver with TestNavigationObserver::StartWatchingNewWebContents(). Why: Tests are flaking from calls to TestNavigationObserver::Wait() hanging. The existing solution assumes that the test will setup the TestNavigationObserver before the newly opened WebContents starts the navigation. However this isn't necessarily true, as we aren't registering the TestNavigationObserver in the same callstack in which the web contents is created. Bug: 1166341 Change-Id: Id2b5f36158f86377b3881e54d793c27af718cb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627757Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ic81197c9b576e8f6045365196ec0f3637509c0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628109Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843299}
-
Eric Willigers authored
In guest mode, shared files in the .WebShare/ directory are deleted when the user logs off (if they are not deleted earlier). In incognito mode, we continue to prevent file sharing. Bug: 1161373 Change-Id: I0542d4ba92381c7ab2f07bbab896242bcc643057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626991 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#843298}
-
Roman Arora authored
Relevant pinpoint benchmark results: https://pinpoint-dot-chromeperf.appspot.com/job/12d352aad20000 https://pinpoint-dot-chromeperf.appspot.com/job/1011ee42d20000 https://pinpoint-dot-chromeperf.appspot.com/job/11aa1592d20000 Bug: 1149400 Change-Id: Ibe3afd85eaeaa8b6f13902c282cc3f5bb45ca3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623159Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#843297}
-
Nancy Wang authored
UI review deck: go/cros-full-restore PRD: go/cros-full-restore-prd Design doc: go/chrome-os-full-restore-dd When the full restore feature is enabled, whether to launch the browser is controlled by the full restore process: 1. If the full restore setting is not restore, don't launch the browser. 2. If the user selects restore or set always restore, launch the browser. This CL modified the current launching browser process during the startup phase. 1. If the full restore feature is disabled, the current process is not changed. 2. If the full restore feature is enabled, postpone the browser launching. Only when the restore data has been fetched, and the user selects restore or set always restore, launch the browser by the full restore process. BUG=1146900 Change-Id: I9f03e7039761f4d2956b7d4c2bdeecf99ef2d955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603759Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843296}
-
Ted Meyer authored
It's no longer used, so get rid of it. Change-Id: I2e9b98b3719a71645f8148dcc1acaae804559be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623155 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#843295}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fccd82e4e02..59abfbcd2b03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I58cc47d2c3a3107a3ccf93bdb2e3b33e2600db60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627986Reviewed-by:
-
Regan Hsu authored
Fixed: 1164582 Bug: 1106937 Change-Id: Iac5a7f61cd0f3b3354c4e9281342b07edb18b26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627145Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Philip Rogers authored
Transform nodes store a changed field that is used to cause damage in the compositor (see: PaintArtifactCompositor::PropertyTreeStateChanged). We need to ensure changed state is not lost when decompositing (see: PaintArtifactCompositor::DecompositeTransforms). This patch takes a simple approach of recording the changes of decomposited transform nodes on PendingLayers, and using that to cause damage. This fixes a bug where a change on a decomposited transform node failed to cause damage. http://crrev.com/c/2626192 explored an approach of not decompositing nodes with changes but that leads to unnecessary additional layers. Bug: 1164513 Change-Id: I9c6d68f748772e9c2a86158e62bc0c7db3e8733f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627943 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843292}
-
Kunihiko Sakamoto authored
Now it has the same expiration date as the other WebFont.DownloadTime.* histograms. Bug: 1156194 Change-Id: Ie2e9ec544359dc9498a96064964a173b901f7d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622688Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843291}
-
Sinan Sahin authored
This CL adds support for horizontal swipe-to-dismiss gestures, adds fling support and updates the existing motion specs. It also adds unit tests for the mediator. Flings currently don't affect the speed of the resulting animations as it turned out to be complicated to implement. There are several cases that are handled in this CL: - No fling: - If the message is within the dismiss threshold, vertical or horizontal, the message is animated back to the idle position, i.e. center. - If it's outside the threshold, the message is dismissed by being animated to out of screen. - Fling: - If the message is flung toward the center from outside the dismiss threshold, it is animated to the idle position. - If it's flung from within the threshold to the outside, the message is dismissed with animation. - If it's flung toward out of screen from outside the dismiss threshold, the message is dismissed with animation. Bug: 1157213 Change-Id: I82cfac7111e5ada8687be74a90162784a1e7c992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602706 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#843290}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/47e9aed2af83..6c79df687e09 2021-01-13 m.maiya@samsung.com Allow attributes and uniforms to have the same name 2021-01-13 jmadill@chromium.org infra: Fix win-trace-rel bot typo. 2021-01-13 jmadill@chromium.org Program: Support multiple varying packings. 2021-01-13 cnorthrop@google.com Capture/Replay: Add DrawBuffer state to MEC 2021-01-13 jmadill@chromium.org Test Runner: Add a slow tests list. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: Aztec Ruins MEC Change-Id: I0eea686ff6ca592f67f32d87b7ada4f6ea2d6481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628050Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a1598e58..8b42c4e7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id40defc26f7eead5a9b7c77045b5ffa98538cc6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628072Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843288}
-
Theo Johnson-kanu authored
Bug: 1093185 Change-Id: Ibf6267c9a41bb0800848980dc203e7c43f1e23fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628039 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#843287}
-
Ahmed Mehfooz authored
Bug: 1137533 Change-Id: Iafdae4693b0fa67a7e187692ca566e1b832fd688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626967Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
Pulled out from CL:2528573. This change makes sense on its own, but is required for tests in the child CL to pass. Bug: None Change-Id: I5392c62dee345b0fa422c08f07029b325ced440a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627997Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#843285}
-
Leonid Baraz authored
Bug was detected while working on stress test: When part of the data is available and we want to read more, we need to start not from initial 'pos' but shift to the position after the available data! The original code always started to read from the initial position - thus reading some data twice. Also some cleanup done. BUG: b:177439641 Change-Id: I59c9d36f97d2a7193ff0d211c61f5afb7cf2d60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626102Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843284}
-
Nancy Wang authored
This reverts commit f112bfc2. Reason for revert: <INSERT REASONING HERE> Fix the browser tests issue. Original change's description: > Revert "Create standard icons on shelf for non-app icons." > > This reverts commit 201f15f1. > > Reason for revert: Suspicious about causing a test breakage of WindowOpenApiTest.PopupBlockingExtension. > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview > > Original change's description: > > Create standard icons on shelf for non-app icons. > > > > AppService creates standard circle icons for all apps. However, there > > are a few cases that icons on shelf are not app icons, e.g.: > > 1. Task manager > > 2. A few extensions show icons when open a new window, e.g. google > > hangouts. > > > > This CL create standard circle icons for them when they are shown on > > shelf. > > > > Modify TaskManagerView to create standard icon when running in Chrome > > OS. > > > > Modify ChromeLauncherController::OnAppImageUpdated. If the icon is not > > loaded by AppServiceAppIconLoader (which loads the standard circle > > icons), create standard icons. > > > > BUG=1162514 > > BUG=1142373 > > > > Change-Id: Ibfe40c33944a1120ca9c991c4953d0da906ee2e2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624273 > > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#842874} > > TBR=xiyuan@chromium.org,sky@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org > > Change-Id: I6e0dbef6a173a179d79e39cebbd4a4f78f15bcfb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1162514 > Bug: 1142373 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626821 > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842947} TBR=xiyuan@chromium.org,sky@chromium.org,yukishiino@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org Bug: 1162514 Bug: 1142373 Change-Id: If55904732c4fd468db2a5f56cece04fc8a937a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626943Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843283}
-
Jarryd authored
* Refactor LaunchInternal to handle both tabbed and windowed display modes. * Implement set_open_in_tab_internal and assert_tab_created. * Refactor ExecuteAction() to use LaunchInternal() for all launch actions. * Refactor ExecuteAction() to use SetOpenInTabInternal() for both the internal and non-internal versions of the action. * Add a test case for journey 151 from the spreadsheet. Journeys spreadsheet: https://docs.google.com/spreadsheets/d/1d3iAOAnojp4_WrPky9exz1-mjkeulOJVUav5QYG99MQ/edit#gid=1894585254 Bug: 1156730, 1156375 Change-Id: I92d34a595ffe5caf4651a37577fa715c3a789710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601318 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I4bd4366c70dcf70f8e54be407b37b7be7e811b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626522Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843281}
-
Takuto Ikuta authored
This is fix for https://ci.chromium.org/p/chrome/builders/ci/linux-perf-fyi/47656 due to incompatible format of json from swarming client. Bug: 1127205 Change-Id: I8ff3b050f1d999d19218ad85a96b56e637c8e80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626686 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843280}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d8e9436a78bf..77ba8103d34f 2021-01-13 brianosman@google.com In runtime effects, verify that loops conform to ES2 rules 2021-01-13 mtklein@google.com make SkShaderBase::onProgram pure virtual 2021-01-13 csmartdalton@google.com Use tolerance==0 to flatten curves in GrTriangulator 2021-01-13 kjlubick@google.com [canvaskit] Expose getShadowLocalBounds 2021-01-13 bsalomon@google.com Revert "Push SkYUVAInfo into GrYUVToRGBEffect." 2021-01-13 johnstiles@google.com Update tests which mix int and float types without casts. 2021-01-13 johnstiles@google.com Allow type-fluid GLSL-style vec2(int, bool) ctors in SkSL. 2021-01-13 reed@google.com Begin to hide drawBitmap 2021-01-13 bsalomon@google.com Push SkYUVAInfo into GrYUVToRGBEffect. 2021-01-13 johnstiles@google.com Update VectorConstructor unit test with mixed-type ctors. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I95d4b474169c6c445b0e2a3f1c67c980f61da5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627295Reviewed-by:
-
Mohsen Izadi authored
This CL adds renderer-side event dispatch breakdowns to EventLatency UKM. These include breakdowns of both main and compositor threads. These changes to EventLatency UKM has been approved in: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit?usp=sharing Bug: 1054009 Change-Id: Ic5a4f6b06a2e2c29165fd38ee95c0320877608dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612931Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843278}
-
Hiroshige Hayashizaki authored
Previously, second successful import map was rejected during registration. It didn't trigger error events, and the second import map wasn't rejected if the first import map had errors. This CL follows https://github.com/WICG/import-maps/pull/242 and changes these behavior (the second import map is rejected with an error event no matter whether the first import map has errors). This CL also introduces Modulator::AcquiringImportMapsState, just for better error messaging. Bug: 848607 Change-Id: Iadfc59dc0ae9b64262908dbf27d44a4c24a74c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618838Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#843277}
-
Francois Doray authored
[sheriff] Disable core.benchmark_runner_test.BenchmarkRunnerIntegrationTest.testTimelineBasedEndToEnd on ChromeOS. R=achuith@chromium.org Bug: 1098412 Change-Id: Ib19a9a0e93339c2a5e3aff75897cff8a2ebbe9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626410 Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#843276}
-
Jeffrey Kardatzke authored
This feature is launching with M89, so we need to enable it by default now. The code that uses this feature check has other build flags around it to limit it to the platforms that actually support it. BUG=1146646,b:153111783 TEST=HWDRM is used by default w/out setting flag Change-Id: I836c71ec2ba5752b737d6aef76c825f0dcf5fc17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627168Reviewed-by:
-
David Bokan authored
This Blink RuntimeEnabledFeature was previously used to enable this opt-out for the TextFragment (and other kinds of load-time scrolls) feature using an Origin-Trial. The feature shipped for real as part of Document-Policy and the Origin-Trial has been wound-down. This CL removes the no longer needed RuntimeEnabledFeature. Bug: 1047900 Change-Id: Ie8e8180aae6a9d76e4626eb2d5c8e4b3a9fb582c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622240 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4e0ef215f6da..9b5dd7ab8a98 2021-01-13 vapier@chromium.org repo: upgrade to v2.11 2021-01-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib83a0812a752852364928a9ac9beec1bc43a379a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628367Reviewed-by:
-
