- 25 Oct, 2019 19 commits
-
-
Manu Cornet authored
* Make the app list controller the only class that observes home launcher changes. * Move "home launcher animation state" cached field to the app list controller. * Rejiggle a bit the flow of information between our various observers (overview, app list visibility, home launcher gesture, etc.) so that more classes are generally aware of the final state of a transition sooner than previously. * Add a "will start" API to the overview observer. * Add a couple of "const" where appropriate. Bug: 1012760,1013737,1012353,1016012,1012767,1009550,1006013,1016511 Change-Id: I15bc0fb519713145beffb9933295564b0d8a5f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872102 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#709301}
-
Carlos Knippschild authored
Change-Id: I3d10b7e233015b291681200cda2e42c7706571d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880276 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#709300}
-
Xiaoqian Dai authored
If the shelf is hidden or auto-hide hidden shelf, the user needs to swipe up the shelf and then second swipe to do the window dragging. Bug: 997885 Change-Id: I765cf813943d4bc209b4e1c9a023586a12c69145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877257 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709299}
-
tby authored
The framework implementation will involve some breaking changes to the code. I'm disabling collection for now, with plans to re-enable it once the new API is done. Bug: 1016655 Change-Id: I862294a4020c3d6f25c726c4799cd4ffa4dc4e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872081Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#709298}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cb771c6c486e..25df51372600 git log cb771c6c486e..25df51372600 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 chrome-bot@chromium.org Update config settings by config-updater. 2019-10-24 vapier@chromium.org gn_helpers: pull python 3 updates from upstream Created with: gclient setdep -r src/third_party/chromite@25df51372600 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1754d308c1ab627b416878ca1fbd87072dd90351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709297}
-
Yulun Wu authored
Bug: 1016946 Change-Id: Ia4b3a2a5f10bcac12c21f040cde81f7710be9b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879652Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709296}
-
minch authored
scroll_x() of gesture event is not reliable after checked on physical device. Get the x drag amount from touch events as y drag amount. Fling event is supported, which means the |drag_progress_| might hasn't reached full progress while COMPLETING the drag. Bug: 1002733 Change-Id: I66dfb4110e2e8f34445d67a5e5cc25681b3f8708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879821 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Meredith Lane authored
This reverts commit bbe3cdf3. Reason for revert: AXPlatformNodeAuraLinuxTest.TestAtkValueChangedSignal has been failing consistently. https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/15401?blamelist=1#blamelist-tab Original change's description: > Reland "Fix emission of AtkValue property change signal" > > This version checks at runtime for atk_value_set_value during testing. > This should allow the change to work on bots running trusty. > > Original commit message: > > > The introduction of text-change signals for the omnibox included a > > regression that prevented the emission of AtkValue property change > > signals. Fix this error and also add an implementation of > > atk_value_set_value. The implementation is used in a test to verify the > > correct behavior. > > > > The fix is that we correct the misuse of a logical operator and now > > always try to emit AtkValue property change events when receiving the > > kValueChanged event in AXPlatformNodeAuraLinux. > > Bug: 1015387 > Change-Id: I486b44f9d0f212d951487bdc9f953401a94f9dff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876850 > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com> > Cr-Commit-Position: refs/heads/master@{#709023} TBR=mrobinson@igalia.com,jdiggs@igalia.com Change-Id: I319a1d3b6d73c313d47fe92952ddbabe021e7407 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880487Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709294}
-
Jordy Greenblatt authored
This is step one of the two part task of ensuring that settings subpage buttons in cr-link-rows announce that they are subpage buttons. As is, they are called 'link's [1], which almost always implies opening a new tab in both browser and OS settings. This change allows elements containing a cr-link-row to provide a string to be passed down to the link row's nested cr-icon-button as the button's role description. As a practical test, this change also migrates the OS settings' main page's 'Languages and input' row [2] to use a cr-link-row [3] with the new role description "subpage button" injected [4]. ---- Note: I initially missed an error resulting in a regression that caused the act of routing to and then back from the Languages and input subpage via this row to send DOM and a11y focus to the full page instead of back the its previous location on the subpage button. This was fixed in Patchset 7 by updating line 33 of os_languages_section to reflect the change to the DOM caused by this CL. See [5] for a demonstration of the correct routing behavior once Patchset 7 was implemented. [1] https://drive.google.com/file/d/1tBGDSoeaRBRO3nJ4h7IMPtiiGMDGB10L/view?usp=sharing [2] https://screenshot.googleplex.com/dsGjkF0e93c [3] The migration to cr-link-row was planned anyway as part of crbug.com/1012565 so it was a good trial case for the task of using the "subpage button" language on all settings 'cr-link-row's, i.e. crbug.com/1012104. [4] https://drive.google.com/file/d/1Lsil-tybwB_cwSLN0TyabfCq_DFNpUSo/view?usp=sharing [5] https://drive.google.com/file/d/13VYF-XPAryQYfI1paU8vi9KBC3J5fvhM/view?usp=sharing Bug: 1012103, 1012104, 1012565 Change-Id: I7ac02205bbdd8a352fdbc7e920c1729acf634ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846397 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#709293}
-
Peng Huang authored
When Vulkan and GL interop is not supported, we are using separate gl texture and vk image in ExternalVkImage. We need sync content between gl and vulkan textures. Without this change, we only sync content to gl or vulkan texture which decided by the first begin read access. However, with recent change promise image caching in viz, concurrent read may happen, If the second access is for a different texture, the content could be out of sync. This change fixes the problem by always sync the content to both gl and vulkan texture with the first begin read access. Bug: 1014236 Change-Id: I00ad75f0ffe5f87f98d2e298a687743e2e8e1947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879556 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#709292}
-
Xiaoqian Dai authored
Remove kDragWindowToHomeOrOverview mode from HomeLauncherGestureHandler and migrate tests. No functional change. Bug: 997885 Change-Id: I727e1c6bbc11d88416eb3e92a8f113c7d4c8e4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879818 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Carlos Knippschild authored
Bug: 999454 Change-Id: Ic64485af9f8989980282a87d86e3a2b63cdb3684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879657 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
-
Tobias Sargeant authored
This enables us to set the browser package info during intialization without having to reflect to look up the object again. Change-Id: I2a66494dde72a1d6c64140e9ac68b310f970be50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879887Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#709289}
-
RJ Ascani authored
This is the first change in a soft transition change in the fuchsia.media.drm APIs. The LicenseSession OnKeysChanged event is being renamed to OnKeyStatesChanged. This adds an identical handler to the FuchsiaCdm::CdmSession. Implementations will send one or the other, but not both events. Bug: fxb/38522 Change-Id: I07b370f18f38b223c11a89bdc68fddc6955a2b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879521Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: RJ Ascani <rjascani@google.com> Cr-Commit-Position: refs/heads/master@{#709288}
-
Ryan Hansberry authored
Alert the user when the Bluetooth device is being connected to, requires passkey entry or confirmation, or fails to connect (an existing notification already alerts the user when the device successfully connects). Bug: 1007364 Change-Id: Icbca5b4ff3c5c645c4e21f17ef040acb107e9352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876470Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#709287}
-
Tim Song authored
As part of the new UI redesign fo the system tray, we no longer render shadows around the tray bubbles. This includes the quick settings, sliders, and autoclick bubbles. Legacy bubbles (e.g. palette) are not affected. Note that we need to add a new border to the message center bubble, which will be done in a follow-up CL. TEST=manually verified all bubbles BUG=976952 Change-Id: I5e52b272262064044f52c79ababd14725111a735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877137 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#709286}
-
Rakib M. Hasan authored
Blinkpy originally checked for leaks in the actual driver output twice, and therefore returned two FailureLeak instances. This caused typ to raise an exception when writing the leak log twice. Bug: chromium:1017068 Change-Id: I345fc0151e2130fcd7d38ea63a1423f1fc1f939c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879768Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#709285}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1a96724321f..de9e3cabe60e git log b1a96724321f..de9e3cabe60e --date=short --no-merges --format='%ad %ae %s' 2019-10-24 ehmaldonado@chromium.org presubmit: Make ThreadPool surface exceptions on CallCommand. Created with: gclient setdep -r src/third_party/depot_tools@de9e3cabe60e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I363ac38edcb0b9332e8349b0f517f42b7c10db37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879571Reviewed-by:
-
khmel@chromium.org authored
This is required to identify the reason of the main account resolution failures. BUG=b:143167303 TEST=Locally, status is reported in histograms. Change-Id: I57540c82606eb7f86b00bdae69b7b753afe7cf15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874589 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#709283}
-
- 24 Oct, 2019 21 commits
-
-
Darren Shen authored
Doing an experiment with some handwriting features, so we added some UMA metrics in cl/272533804 and cl/270199050. This is the corresponding Chromium change that adds these metrics to the dashboard. Change-Id: I4caacebb32815991ea792759f3e21ef992ae27e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877327 Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#709282}
-
Clark DuVall authored
Both main resource and subresource appcache requests were not being intercepted by WebRequest. We now proxy main resource requests in AppCacheRequestHandler, and subresource requests in RenderFrameHostImpl where the other subresource factories are proxied. The main changes needed for this were: - NavigationLoaderInterceptor::LoaderCallback now takes a SharedURLLoaderFactory instead of a SingleRequestURLLoaderFactory::RequestHandler. This allows the appcache interceptor to pass a proxied factory. Many of the changes in content/ are to support this interface change. - AppCacheURLLoaderJob was expecting the callback passed to NavigationLoaderInterceptor::LoaderCallback to be run immediately (which was probably a bad assumption anyway). This is no longer the case if the factory is proxied, so some changes had to be made there to handle async execution of the callback. - ContentBrowserClient::WillCreateURLLoaderFactoryForAppCacheSubresource is no longer needed, since it was added as a bandaid for not calling ContentBrowserClient::WillCreateURLLoaderFactory. Bug: 983139 Change-Id: I5e5642c922ccd18b5d085ebf4d261f1539fdb06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875268 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Simon Que authored
This builder has a low QPS and should not cause any capacity issues on the server: https://docs.google.com/spreadsheets/d/1EUbPo8FQx-zpkuj_Srq8iHFe11sNngzTf7u-ZQSftMw/edit Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413, 1015983 Change-Id: I771437a9665e0e889fa89906893ff1fe24d598a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877870Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#709280}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/740f85949db2..b653813d5814 git log 740f85949db2..b653813d5814 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 ethannicholas@google.com Vulkan SkSL code now works in locales which use ',' as the decimal separator. 2019-10-24 rmistry@google.com Make NUC7i5BNK SkottieWASM/Lottie_Web bots ON_DEMAND 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 bsalomon@google.com Reland "Allow direct readback for formats in non-ES OpenGL" 2019-10-24 halcanary@google.com [minor] nanobench: use default member initializer 2019-10-24 mtklein@google.com remove NEON matrix procs 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 herb@google.com Change code() to glyphID() on SkGlyph. 2019-10-24 csmartdalton@google.com Reland "ccpr: Unblacklist Qualcomm with msaa" 2019-10-24 bsalomon@google.com Make GrSurfaceProxy ref counts thread safe. 2019-10-24 mtklein@google.com did you mean to leave this in? 2019-10-24 jvanverth@google.com Reland "Enable Programs (formerly GLPrograms) test for other APIs" 2019-10-24 bsalomon@google.com GrResourceProvider::MakeApprox() fix after SkISizification 2019-10-24 robertphillips@google.com Pull tessellation forward into GrTextureOp::onPrePrepareDraws Created with: gclient setdep -r src/third_party/skia@b653813d5814 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:10083125,chromium:1017229,chromium:1017242 Change-Id: I0ffc36d6cf826c992419dd7ee8d190fc02706924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879623Reviewed-by:
-
Anton Bikineev authored
Bug: 1002998 Change-Id: Ic2acd0c15501a3cbe3c361f7003c7b8736893558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878830Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#709278}
-
Tibor Goldschwendt authored
This gets rid of the whitelist in Module.java. Going forward DFM authors simply have to specify native_deps in the module_desc and the native library will be automatically loaded when first accessing the module (when using the autogenerated module class). See go/native-dfm-load-v2 for more context and details. Change-Id: I5bd30c2e8a6cfa3afeb4b69c348cdab0e304d597 Bug: 870055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877250Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#709277}
-
Clark DuVall authored
This causes issues when trying to install multiple apps that are using WebLayer. Bug: 1017938 Change-Id: Iac2a12d42b565c043e68b56aac8f7d58fb109bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880048 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#709276}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/154145a8f4cf..a38631cd7417 git log 154145a8f4cf..a38631cd7417 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 dproy@chromium.org Log JS errors on the server Created with: gclient setdep -r src/third_party/catapult@a38631cd7417 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1015942 Change-Id: Ifd699e7621e2d84074a2c93ef077e80079bd5e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879614Reviewed-by:
-
Meredith Lane authored
TBR=benwells@chromium.org Bug: 1017305 Change-Id: I8c8129ea2728ab2750a8528b98385255763baa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880230Reviewed-by:
-
Yue Zhang authored
This reverts commit 079d6cd8. Reason for revert: Land the test class but disable the test for now. Original change's description: > Revert "Add multi-window behavior test for GTS" > > This reverts commit ef605722. > > Reason for revert: the test consistently fails on Android N > > Original change's description: > > Add multi-window behavior test for GTS > > > > This CL adds a class for testing mult-window related operations in GTS. > > It only contains one test case so far for GTS without group enabled. > > Will add group related tests in a later patch. > > > > Bug: 983170 > > Change-Id: I36761705effba417abbcb715c8e4bbb6c2b266dc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857604 > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#707949} > > TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 983170, 1017141 > Change-Id: I736a4e0649f462a6f3325c16209242cd31525067 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876388 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708614} TBR=yusufo@chromium.org,wychen@chromium.org,alexilin@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 983170, 1017141 Change-Id: I051805a99a20ebc1a508e2d98b46711f02ef8d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879468Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#709273}
-
Caleb Rouleau authored
For other stories (namely the MSE ones), we should not enable the metric since it cannot produce good data but instead produces a few measurements with 0 values that just confuse people. For example see crbug.com/982383. This changelist also fixes the issue with the measure_memory member variable of the media story set. That attribute was true for everything since it was shared within the story set, so it would have turned on memory metrics for MSE Pages. For system_health benchmarks, we have have some benchmarks that produce cpu usage metrics and some that produce memory metrics. This is done purposefully since producing memory dumps is cpu-intensive which skews the cpu usage results. In the future, media benchmark could adopt a similar approach. However, using the GetExtraTracingMetrics() function, media benchmark could have some stories produce memory measurements and some produce cpu usage measurements within the same benchmark. This changelist happens to provide the structure that would allow that. I tested this by running ./run_benchmark media.desktop --browser=system --story='video.html?src=tulip2.vp9.webm&background' --output-format=html --output-dir=/usr/local/google/home/crouleau/output and checking that memory metrics were produced in the html output. and then running ./run_benchmark media.desktop --browser=system --story=mse.html?media=aac_audio.mp4 --output-format=html --output-dir=/usr/local/google/home/crouleau/output and checking that no memory metrics were produced in the html output. Bug: 982383 Change-Id: I02a6171e240a426521c7516cb1bdf489072cebd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879779 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#709272}
-
Yulun Wu authored
This reverts commit a57dd0eb. Reason for revert: Moving release notes notification behind a feature flag instead Original change's description: > CrOS: disable release notes for M78. > > Bug: 1016946 > Change-Id: Ib9bb97271e18eb1428eded141068a4c0526a8096 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872481 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Yulun Wu <yulunwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708776} TBR=alemate@chromium.org,yulunwu@chromium.org Change-Id: Ib0edac6352a69fa3a4b012055c431b37445f0f92 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1016946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879695Reviewed-by:
-
Hans Wennborg authored
Bug: 1016945 Change-Id: Ide11a3e8f26ed447668f1497daf4392d0ba0d605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879889 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#709270}
-
Henrique Nakashima authored
It is scheduled with a random delay between 0ms and 59999ms. When it is exactly 0, the delayed task is actually executed as a regular task, and since it is scheduled just before the task that starts native, it runs without native, causing a crash. Moving recordMetrics() to after native is initialized fixes the issue. Bug: 1017130 Change-Id: Ica5d0a125b93433bd2291a6c73ac30d3fd890aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880172 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#709269}
-
Andrew Xu authored
When the scrollable shelf is enabled, use ScrollableShelfView as the shelf button delegate for the shelf app buttons. It helps to build the connection between the app button and the topmost view in hotseat widget. This CL should not bring any noticeable change. Bug: 1010219 Change-Id: I0e4e3a810a72094a108af459561ebb306808c2f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869554 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Mostyn Bramley-Moore authored
We no longer use any LGPL code from Mesa, so let's remove that license from the corresponsing README.chromium file. Also, GLES/glext.h, GLES/gl.h and GLES/glplatform.h are made available under another license that is not already mentioned- "SGI Free Software B License Version 2.0". Let's add this license text. Note that the reference URL for this license is now a broken link, and these header files do not include the actual license themselves. The license text added by this patch was taken from this (reputable) source: https://spdx.org/licenses/SGI-B-2.0.html BUG=873321 Change-Id: I324fe79c070a996bcab9ff78021f45572d6bbf39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813353 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709267}
-
Ahmed Mehfooz authored
This change fixes a number of crashes caused by the message center widget being destroyed without it's animations being cleaned up properly. Change-Id: If70b46d530867721785cd208db937207c6dcc865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877256 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#709266}
-
Daniel Murphy authored
This CL take the LevelDBFactory in leveldb_env.h, and split it up into: * leveldb_factory.h, which contains the part of the previous LevelDBFactory that deals only with LevelDB and LevelDBState. This is cleaned up a bit to hold the options and other configuration that doesn't change. * transactional_leveldb_factory.h, which contains the Transactional LevelDB factory parts. The rest of the CL is refactoring the code to use these two new factories. Some tests are updated to be a little cleaner. Bug: 1015212 Change-Id: I8d70958e1c5892cd908792db8eab45e584ece97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865038 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#709265}
-
Tatiana Buldina authored
Change-Id: Iec38375f55151e73cc3bb72683d1b4ee3cb2b01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721852Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#709264}
-
Hiroki Nakagawa authored
This is a follow-up for: https://chromium-review.googlesource.com/c/chromium/src/+/1772933/3/third_party/blink/renderer/platform/weborigin/url_security_origin_map.h#42 For code simplification, this CL moves BlobURLNullOriginMap from core/fileapi/public_url_manager.cc to its own file in platform/blob/. This enables to remove platform/weborigin/url_security_origin_map.h that was used for exposing BlobURLNullOriginMap from PublicURLManager in core/ to SecurityOrigin in platform/ (see SecurityOrigin::SetBlobURLNullOriginMap() in the original code). Also, this CL simplifies class instance relationship. Before this CL, BlobURLNullOriginMap was a process global object, and BlobURLOriginMap that actually managed pairs of blob URL and "null" security origin was a thread specific object. BlobURLNullOriginMap served as the interface of the thread specific object. (process global) BlobURLNullOriginMap == accesses ==> (thread specific) BlobURLOriginMap == manages ==> pairs of blob URL and "null" origin After this CL, BlobURLNullOriginMap is a thread specific object and contains pairs of blob URL and "null" security origin. An instance of BlobURLNullOriginMap is accessed via BlobURLNullOriginMap::GetInstance(). (thread specific) BlobURLNullOriginMap == manages ==> pairs of blob URL and "null" origin. Change-Id: I17c76c41d6a2bfddc66049a53268bba955808c5f Bug: 987130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864497 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#709263}
-
Bailey Berro authored
This change introduces a fuzzer for the PpdLineReader class that calls NextLine on random buffers with randon max_line_lengths. Change-Id: I5aa22e1dbe4fd88a2dee1fed6bd740e3c0fdfad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874593Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#709262}
-
