GitLab

TBR=kmilka@chromium.org

Bug: 1060667
Change-Id: I40290bd8030770f04258072de9e062813dd663a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097826Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749255}

Switch the additional_data_vector_ field to WTF::Vector for better
compliance with Blink practices.
While this implies a copy of the data, this vector is normally small
and we plan to change it to a structured format in the near future.

Bug: 1059912
Change-Id: I0fdeb5fefd4aac9c85712bf246866e5826b5f2c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094311
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749254}

Shows the current progress while downloading an image received via
remote copy. The notification will be updated during the download and
at the end to show the image.
Implemented behind the #remote-copy-progress-notification flag.

Bug: 1059290
Change-Id: Iee18f7d1781eaa4d15f21f78453f706d2b897dc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089685
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749253}

The test was testing UnsizedMedia feature working properly when images
got resized on screen after they initially got loaded.

Initially the test worked fine, but after certain optimization made by
rendering team, window.onload no longer guarantees that images are
painted on the screen. This CL introduces a timeout to force the script
to execute after initial images are painted on screen first.

Bug: 591099
Change-Id: I1a11e1b5b8c87ba2bd3d5c64c9d5477a73ee0d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090457
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749252}

This CL is doing the following:
- Rename DeviceLoginScreenChromeVariations into DeviceChromeVariations
and that'll be fine, as that hasn't been done yet from server side
- Setting ChromeVariations only for any platform other than ChromeOS
and Android
- Adding a new pref kDeviceVariationsRestrictionsByPolicy which is
writing its state in local state, and controlling the variations in
ChromeOS
-- That workaround is being used in order to retrieve the device policy
value, on ChromeOS, and to update the actual value of
kVariationsRestrictionsByPolicy. In order to be able to reflect that
in the variations service according to the pref value.


Bug: 1047683
Change-Id: I3a835ef4098ca26dfc791a3c66206afb2b63e1cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089737
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749251}

As requested in [1]. Idea is make it less needed to code-search for
examples.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2068305/10/ui/compositor/animation_metrics_recorder.h#16

Test: none
Bug: 1051490
Change-Id: I4a8bb4bc04e8f745913f215952daab90a54deafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097236
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749250}

Seems that some emulators require this even when just on
Android P.

Bug: 946194
Change-Id: Iad5811a54404bfcf46267d5c3f3a5f565f399ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098236
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749249}

This is a reland of d828e2eb

* I added the BUILD dependency to the wrong target in the
  previous reland. It needed to be on generate_schema_org_code.
  https://crrev.com/c/2097359

Original change's description:
> Reland: "Add validator for schema org entities and types in doc metadata mojo."
>
> "
> * Add a validator that removes properties that are not the right type.
> * Add double, time, and timedelta types in the document metadata mojo
>   structure.
> * Use the new mojo types in document metadata extractor.
> "
>
> This is a reland of https://crrev.com/c/2062907 which was reverted in
> https://crrev.com/c/2095670.
>
> The substantial changes are two-fold:
> (1) add build dep on base in schema_org_properties. This should fix the
>     try bot issue which was somehow skipped.
> (2) Rebase on top of https://crrev.com/c/2073337 which was submitted and
>     contains some changes to the mojo structure.
>
> Change-Id: I7f47d74e8833f76d4077028eac0dcb43790a1d26
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097059
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Commit-Queue: Sam Bowen <sgbowen@google.com>
> Cr-Commit-Position: refs/heads/master@{#748945}

Change-Id: Ibc7124d5a779d663048315a2697c9c050c1c00c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097452Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Sam Bowen <sgbowen@google.com>
Cr-Commit-Position: refs/heads/master@{#749248}

Bug: 1056327
Change-Id: I490f176ae56d5fc08b76df0777e0d5af1529b0f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082317Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749247}

Like getCoercedText and getHTMLText in Clipboard.java, if another app
did something incorrectly when they put content into the clipboard,
getPrimaryClip may crash. For example, if the another app didn't set
permissions correctly this may crash. There are also some devices where
hasPrimaryClip returns true but calling getPrimaryClip causes an NPE.

Bug: 1059946
Change-Id: Idf5d64f86f7d85cd2723aeac3a1d4868fb579317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097019
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749246}

Change-Id: I007c0d8224522346d252f7703e78b6487a679d6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096961Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#749245}

Given that individual navigations to various routes with settings are
already logged via UMA, the additional UMA logging provided by the
SettingsPageInteractions enum/histogram was of little value.

Additionally supporting this logging required restrictive code on the
site_settings_page.

This CL deprecates the existing enum/historgram and replaces it with
one focusing on interactions with elements that do not trigger a route
change.

Bug: 1059098
Change-Id: I9130836da821eae1aa0ac40ae0e96dcb4f398054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090795
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749244}

Bug: None
Change-Id: I1bbe76e767d532ceeb6b94d0dc1608a63fcbe618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098176Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749243}

These tests are failing when features::kOutOfBlinkCors is not
turned on, but the feature is turned on by default, so we just
early-out of these tests on bots that have the feature turned off.

Bug: 1060046
Change-Id: I1ef843d1b0cde163cf38b7e704a78c308251470d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098105Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749242}

Change-Id: I7b9300b0260cc734d955a59c11df8551fbfb1d04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080865
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749241}

ChromeOS devices currently do not have styluses with buttons,
and there is no support for handling stylus button events.

In the long term, we will want to make stylus button clicks act
as a right mouse click button (open context menu).  In the short
term, we want to use the stylus button to accelerate the long press
gesture.

If the user has the stylus button pressed when touching the screen,
or presses it before the long press timeout, generate a long press
gesture.

Bug: b:139781900
Change-Id: I3869989f3f731de18ecec480577eb209c08b9c6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076663Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749240}

This is a reland of 9fcd7541

Original change's description:
> Revert "Cros: Report metrics for the animation of traslucent background"
>
> This reverts commit 64465df5.
>
> Reason for revert: Speculative revert to fix use-of-uninitialized member flake / crash; see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886180914914709040/+/steps/browser_tests/0/logs/Deterministic_failure:_PublicSessionOobeTestImpl__x2f_PublicSessionOobeTest.NoTermsOfService__x2f_4__status_CRASH_/0
>
> ==18002==WARNING: MemorySanitizer: use-of-uninitialized-value
>     #0 0x5640af44e1e6 in ui::AnimationMetricsRecorder::OnAnimationEnd(base::Optional<int>, float) ./../../ui/compositor/animation_metrics_recorder.cc:64:14
>     #1 0x5640af4e4b37 in ui::LayerAnimationElement::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_element.cc:669:34
>     #2 0x5640af4fbb95 in ui::LayerAnimationSequence::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_sequence.cc:147:35
>     #3 0x5640af513c54 in ProgressAnimationToEnd ./../../ui/compositor/layer_animator.cc:476:13
>     #4 0x5640af513c54 in ui::LayerAnimator::FinishAnimation(ui::LayerAnimationSequence*, bool) ./../../ui/compositor/layer_animator.cc:622:5
>     #5 0x5640af519c6d in ui::LayerAnimator::StopAnimatingInternal(bool) ./../../ui/compositor/layer_animator.cc:533:5
>     #6 0x5640af489c93 in StopAnimating ./../../ui/compositor/layer_animator.h:198:26
>     #7 0x5640af489c93 in ui::Layer::CompleteAllAnimations() ./../../ui/compositor/layer.cc:1128:12
>     #8 0x5640af3c6ff1 in aura::Window::~Window() ./../../ui/aura/window.cc:124:14
>     #9 0x5640af3ca7ac in aura::Window::~Window() ./../../ui/aura/window.cc:119:19
>     #10 0x5640a9a51655 in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:0:0
>     #11 0x5640a9a51b9c in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:1054:39
>     #12 0x5640a99ba714 in views::Widget::~Widget() ./../../ui/views/widget/widget.cc:185:5
>     #13 0x5640b72c7e39 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1
>     #14 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33
>     #15 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5
>     #16 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7
>     #17 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19
>     #18 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11
>     #19 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19
>     #20 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3
>     #21 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17
>     #22 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5
>     #23 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7
>     #24 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19
>     #25 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29
>     #26 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32
>     #27 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13
>     #28 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17
>     #29 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16
>     #30 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10
>     #31 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10
>     #32 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12
>     #33 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29
>     #34 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
>     #35 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3
>     #36 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20
>     #37 0x5640960c6b50 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
>     #38 0x5640960c6b50 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3
>     #39 0x5640960cb24d in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11
>     #40 0x5640960cd5f9 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28
>     #41 0x564096106f6e in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44
>     #42 0x5640961053fd in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10
>     #43 0x5640961053fd in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10
>     #44 0x5640a5902835 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46
>     #45 0x5640a5902835 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16
>     #46 0x5640a5393dd1 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23
>     #47 0x5640a773a27e in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31
>     #48 0x5640a5394f45 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:246:10
>     #49 0x5640a5393bb8 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10
>     #50 0x7f194b36282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0
>     #51 0x56408b4293c9 in _start ??:0:0
>
>   Uninitialized value was created by a heap deallocation
>     #0 0x56408b497790 in operator delete(void*) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:74:44
>     #1 0x5640b72c7d74 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5
>     #2 0x5640b72c7d74 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7
>     #3 0x5640b72c7d74 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19
>     #4 0x5640b72c7d74 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1
>     #5 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33
>     #6 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5
>     #7 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7
>     #8 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19
>     #9 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11
>     #10 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19
>     #11 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3
>     #12 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17
>     #13 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5
>     #14 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7
>     #15 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19
>     #16 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29
>     #17 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32
>     #18 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13
>     #19 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17
>     #20 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16
>     #21 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10
>     #22 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10
>     #23 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12
>     #24 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29
>     #25 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
>     #26 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3
>     #27 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20
>
> Original change's description:
> > Cros: Report metrics for the animation of traslucent background
> >
> > This animation happens during transition between hotseat states.
> >
> > Bug: 1058609
> > Change-Id: Iff1f81625e6de2bf6dc6dcfee09225c4d16cc53e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088641
> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > Reviewed-by: Manu Cornet <manucornet@chromium.org>
> > Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> > Commit-Queue: Ana Salazar <anasalazar@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#748806}
>
> TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org
>
> Change-Id: I28dfaa49cae6e27801975a2863c013b9f9a5edca
> Bug: 1058609
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097507
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749146}

TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org

Bug: 1058609
Change-Id: Id247b5b669d149031543336702585c6e2bbccd50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097509
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749239}

The linker tests don't run on bots (and likely not locally either) and
do not support the latest library loading patterns. This is the first
step to remove them, as they add non-trivial complexity in the codebase.

More specifically, this removes the build rules and the test APK.

Bug: 1059707
Change-Id: I12102d59116ad1f0a152d3110cf3346471c8f390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093606Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749238}

Fixed: 1060581
Change-Id: Iba1504630546197dbcd4228a4155feb6f496b3e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096686
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749237}

Bug: 890029
Change-Id: I380cddc0165b24d18fc91a8aef48778b4c65ccbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097129Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749236}

TBR=sadrul@chromium.org

Bug: 1060648
Change-Id: I3eca3395d3fbe089a6944498879b625c52ceba37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098485Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749235}

https://skia.googlesource.com/skia.git/+log/fdf94044ffea..6dc0f63a509c

git log fdf94044ffea..6dc0f63a509c --date=short --first-parent --format='%ad %ae %s'
2020-03-11 robertphillips@google.com Make DrawAtlasOp surface its programInfo at record time
2020-03-11 robertphillips@google.com Make DefaultPathOp surface its programInfo at record time

Created with:
  gclient setdep -r src/third_party/skia@6dc0f63a509c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: brianosman@google.com
Change-Id: I8790e27532a2f5eb32f094a656806850ce10e98e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098238Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749234}

This patch enables multi-threaded LevelDBScopes usage by IndexedDB. It
does this by:
* Changing the mode during scopes initialization,
* Changing the RequestDestruction parameters to accept a WaitableEvent
* Modifies the destructor of IDBOriginState to request this destruction
  & then wait on the event.
* Modifies all unittests to match the new API pattern.

This allows cleanup & revert tasks to now take place off of the main
IndexedDB sequence, ensuring that cleanup & deferred range deletion do
not block IndexedDB operations.

See doc for more reasoning & alternatives:
https://docs.google.com/document/d/1xlSye5iCVU2kRsdzpue3-OE-BIBhmhTfMWss4XYxygI/edit#

Bug: 1058977
Change-Id: I679990a8ef057531a9ad3f710c9411377881eb11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090630Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749233}

This coordinator presents a UIViewController over the context of the
OverlayContainerViewController.  This is necessary because custom
UIViewController presentation with a UIPresentationController whose
|shouldPresentInFullscreen| is NO results in the presented container
view to be added to the presentation container view of the nearest
presented UIViewController.

Although OverlayContainerViewController's |definesPresentationContext|
returns YES, the container view is added as a child UIViewController
in the view hierarchy.  This means that custom UIViewController
presentation cannot use its presentation context.  To fix this,
OverlayPresentationContextViewController is presented using
UIModalPresentationOverCurrentContext so that a UIKit-provided
presentation context is inserted into the view hierarchy over the
container view's modality.

This CL updates the OverlayPresentationContextImpl to be based on
the container and presentation context view controllers to update
its presentation capabilities so that overlay UI presented with
UIModalPresentationCustom can be correctly scoped to the appropriate
context.

Since the UIKit-provided presentation context intercepts touches by
default, the OverlayPresentationContextViewController's view is
resized to CGRectZero when there is no visible overlay UI.  This
allows touches that hit the container view when there are no overlays
displayed to be forwarded to the underlying browser UI.  The hit test
and touch forwarding code used in OverlayContainerView cannot be used
here since the touch handling for the UIKit-provided presentation
container view cannot be customized.

This CL also creates OverlayPresentationController, which can be used
to communicate presented UIViewController presentation information to
the presentation context.  This is used to resize the presentation
context's container view such that it exactly matches the presented
overlay UI.  This will be used by infobar banner overlays so that
touches that lie outside of the banner can pass through to the browser
UI.

Additionally, this CL removes the DCHECK for BVC's snapshot overlay
calculation since it is no longer appropriate.  Previously, overlays
could only be displayed as a child of the container or as presented
upon it.  After this CL, the container has the presentation context
permanently presented upon it and this presented view controller is
used as the base for any overlay UI implemented using presented
UIViewControllers.

Bug: 1030357, 1054344
Change-Id: I170add2bfc1bc37a9c211f422ab4c494f47b67ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038252
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749232}

Implemented Phase for ScrollTimelines. Also updated Phase to match
current time model for internal and external behavior which will allow
phase to be accessed as an enum in animation.cc where it will be used
in different calculations.

Added unit test as well as a WPT test for ScrollTimeline Phases.

Bug: 1046833
Change-Id: Ib86f68b34ef91f4e70fdefd55bdb2629dc415a72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084777Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Jordan Taylor <jortaylo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#749231}

Related VirtualTestSuites were adjusted to test NG fieldset
fragmentation using existing web tests.

Bug: 875235
Change-Id: Iaa568ec9738db8b08f0ece9451822484929f882f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097181
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749230}

This patch fixes the "double render" problem that occurs when we have
auto locks inside a container that becomes hidden.

Previously:
- When outer element becomes hidden, intersection observer tells inner
  locks that they are not visible, causing them to lock and invalidate
  their own layout (which propagates up to the outer element).
- When outer element becomes visible, we process the dirty tree
  (render 1)
- If inner elements are visible:
  - Then we run intersection observer which notifies the auto locks that
    they are visible, causing them to unlock and invalidate their own
    layout
  - Next lifecycle, we clean the layout state (render 2)
- If not:
  - Nothing happens since intersection observer does not run on already
    hidden elements.

Overall, we have at least 1 render. In the worst case, 2 renders.

Now:
- When outer element becomes hidden, intersection observer tells inner
  locks that they are not visible. The inner locks discover they are
  nested, and register themselves for lifecycle notifications but don't
  invalidate layout.
- When outer element becomes visible, we don't do anything (I'm not
  counting the element itself updating its layout; since the important
  thing is the subtree)
- If inner elements are visible:
  - Nothing happens; the next intersection observer that lets them know
    they are visible will be ignored since they are unlocked.
- If inner elements are not visible:
  - At the start of the next lifecycle, the element determines that it
    should be not visible and that its not nested; it locks itself
    causing layout invalidations. This same lifecycle is render 1.

Overall, we can have no renders. In the worst case, 1 render.

R=chrishtr@chromium.org, flackr@chromium.org

Change-Id: Id9a75a7a68d5208c49839f9f2adb9ee8ae6734e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092196Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749229}

These histograms will be useful in our upcoming projects.

Bug: 1043730, 1053112
Change-Id: Ia7e6e602ec61d593587e8e6f3e557fd00ed7cda2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096684
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749228}

If this size inversion happened in a flex layout with a flex rule that
causes drop-out below minimum size and the view reported a minimum size
larger than its preferred size it would never display.

This CL fixes both the general case and the specific inversion in
ExtensionsToolbarButton.

It was manifesting as the PWA window not having an extensions menu icon
icon in very specific cases.

I just want to say how DEEPLY FRUSTRATING this one was to track down :/

Will follow up by attempting to make code in flex_layout_types.cc a
DCHECK instead of set-to-min after branch (want to be safe now, will
actually try to find inversions later).

Bug: 1059677, 1057901
Change-Id: Icea2fd739260c91f7d390ec15b890257d9715ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097134
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749227}

BUG=1060626
TBR=waffles@chromium.org

Change-Id: I3b5f57767fbd1b15c3508baacf7709f8e0386292
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098323Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749226}

This commit updates WPT located in blinkpy to use pywebsocket3. Since
the current blinkpy does not support version 8 of MANIFEST.json, we
cherry-pick the corresponding patch in the upstream WPT, and apply it
locally.

Change-Id: I78125f49974c6cbc03160e6efa42ebc0d7bf6a43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094906Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749225}

This adds an additional check to prevent non-DataSaver users from
registering optimization types with the the Optimziation Guide
even though they would not be used within Previews code.


Bug: 1042429
Change-Id: Ibf6073aafcdde35939122f0b043b0c5b53b573bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097558
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749224}

This is a reland of 8a27ec89

The original CL was reverted as a suspect for breaking the build,
but wasn't actually responsible.

TBR-ing the original reviewers since the patch hasn't changed.

TBR=isherman@chromium.org,kkhorimoto@chromium.org,vakh@chromium.org

Original change's description:
> Safe Browsing: Add UMA to measure time since last database update
>
> This adds UMA to record whether the Safe Browsing local database has
> received an update, and if so, how much time elapsed since the last update
> was received. These metrics are recorded whenever the local database is
> queried.
>
> While these metrics do not distinguish between a successful update and
> an unsuccessful update, an existing metric (SafeBrowsing.V4Update.Result)
> already records whether updates are successful or not.
>
> These metrics will allow us to compare database freshness on iOS to freshness
> on desktop, to evaluate changes we can make to update the database more
> frequently on iOS.
>
> Bug: 1055863
> Change-Id: I12d6b672e3d274b40fa71fc99d44419380d340a0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087415
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Commit-Queue: Ali Juma <ajuma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749150}

Bug: 1055863
Change-Id: Ied21194dec2e855e6c3bce874c52d8dd9f3aed84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098108Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749223}

This patch makes Webanimation to support getAnimations() whose target
element is a shadow root on which this method is called.

Spec: https://drafts.csswg.org/web-animations/#extensions-to-the-documentorshadowroot-interface-mixin

Bug: 1046916
Change-Id: Ibb201fe3a8a21f3852d4f5135ce344238b1476c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051768
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749222}

Change-Id: I0d2e3211720c255647db43ec9bed24f17cf6c5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096793
Commit-Queue: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Auto-Submit: Joe Downing <joedow@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749221}

The test sets up Sync-the-transport, has the user opt-in to the account
password storage, and makes sure that saves go to the correct store.

This requires a few changes to password_manager_test_base.h/cc:
- Most notably: The password manager tests used to set up a
  MockPasswordFeatureManager (in order to make IsGenerationEnabled()
  return true), but the new combined tests require a real
  PasswordFeatureManager. So this CL removes the mock (which also lets
  us remove CustomPasswordManagerClient), and instead sets up a
  TestSyncService which claims "everything is active" and so also makes
  IsGenerationEnabled() true.
- Some simple refactorings to avoid duplicating test setup code:
  - Split the "GetNewTab" part out of SetUpOnMainThreadAndGetNewTab(),
    into a new static helper.
  - Exposed PasswordStoreResultsObserver (it used to be fully defined
    in the .cc).
  - Exposed a version of CheckThatCredentialsStored() that takes a
    PasswordStore parameter.

Bug: 1058339
Change-Id: If9b040cbd56ee10ba6b6badd1b4b4d772603f13a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089825
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749220}

Using wpt-import in Chromium b255692f.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
acf33020 "Add testing for the scrolling attribute"
2594f643 "Fix timeout in update-and-send-events-replacment.html"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ifdeb54f516c165074ea1d83c75aff41eea56c2f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095266Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749219}

Bug: 1060374
Change-Id: I75f2df23ef35ff16e912fd0c037333a329bdd459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097333
Commit-Queue: Ali Juma <ajuma@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749218}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8cf4a76817cb..c7796cf40d5e

git log 8cf4a76817cb..c7796cf40d5e --date=short --first-parent --format='%ad %ae %s'
2020-03-11 vapier@chromium.org gerrit: rewrite helpers to use classes
2020-03-11 saklein@chromium.org build_target_util: Rename to build_target_lib.
2020-03-11 vapier@chromium.org git_metrics: have git commands return strings
2020-03-10 tbegin@google.com packages: add termina VMs to versioned package uprev
2020-03-10 saklein@chromium.org commandline: Add build_target argument type support.
2020-03-10 vapier@chromium.org export_to_gcloud: fix some python3 unittest logic
2020-03-10 kcwu@chromium.org cros_chrome_sdk: fix goma install using python3

Created with:
  gclient setdep -r src/third_party/chromite@c7796cf40d5e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I51e30138a7d72c632be9937e8aab2c80a5e3e975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098237Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749217}

Bug: 1059046
Change-Id: I3663b4e7d9c84e7f7d7a90652995d7addb0a4088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097935Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#749216}