- 27 Nov, 2019 40 commits
-
-
Toby Huang authored
As a compound mixin, LoggedInUserMixin should inherit from InProcessBrowserTestMixin, just like all of the other browser test mixins. Doing so enables automatic calling of setup functions such as SetUpOnMainThread(), instead of requiring the test developer to remember to call these setup functions manually. Bug: 1028190 Change-Id: I3d36ddff1060ef7ff254b34d3c76ce069b5f49ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934507Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719747}
-
Devlin Cronin authored
ExtensionView::GetBrowser() is used by the ExtensionViewHost and ExtensionPopup to retrieve the Browser object the ExtensionView is hosted in (if any). However, the Browser is a platform-agnostic concept, and is passed through the ExtensionViewHost when creating the view. Instead, have ExtensionViewHost hold the reference to the browser when the view is created. This cuts down on virtual methods and redirection, and allows the ExtensionViewHost (which was 3/4 of the callers) to use the Browser directly, eliminating it from the ExtensionView (which never actually needed it) API surface. Also a smattering of drive-by cleanups: NULL->nullptr, make_unique, etc Bug: None Change-Id: Ibef4d5c9685f026c44640d01cb948b16405c0e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938030Reviewed-by:
-
John Chen authored
Modified three tests in run_py_tests.py: * testSendCommand: Too similar to testSendCommandAndGetResult, deleted. * testSendCommandNoParams: Replaced with unit test. * testSendCommandAndGetResult: Enabled on CQ. This used to be run exclusively on ChromeDriver waterfall, which no longer exists. Change-Id: I465fd6ccd5949f3b46eabacb951071d4ecbd0e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940488 Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#719745}
-
Jonathan Backer authored
SkiaOutputSurfaceImpl owns the SkiaOutputSurfaceDependency. After Impl goes out of scope, there is no more Dependency. We reference the Dependency when we call CreateSafe{Once,Repeating}Callback for things like presentation feedback callbacks. It is possible for presentation feedback to occur after Impl is gone, in which case we can no longer use Dependency. Bug: 1020699 Change-Id: Iedb37a444358e4c543afbb8d8da5907d6b290b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936889 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#719744}
-
Andrew Luo authored
Bug: 1016864 Change-Id: Id260f981248d815fe4eceb59c79c58ea7c054b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937786Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719743}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8861d02f89f7..79685304182c git log 8861d02f89f7..79685304182c --date=short --first-parent --format='%ad %ae %s' 2019-11-27 sprang@webrtc.org Removes caching SimulcastEncoderAdapter::GetEncoderInfo() 2019-11-27 ilnik@webrtc.org Fix bw_limited_resolution in SendStatisticsProxy GetStats 2019-11-27 danilchap@webrtc.org Add string<->VideoCodecType conversion for all codec types. 2019-11-27 orphis@webrtc.org Revert "Add support for RtpEncodingParameters::max_framerate" Created with: gclient setdep -r src/third_party/webrtc@79685304182c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I06886f4fc323913e6f3a8413978d5d935c2ce2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719742}
-
Chris Hall authored
R=dmazzoni Change-Id: I464920afa12ab30208ebf490936ce55d36cf12bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938868 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719741}
-
Jonathan Freed authored
Change-Id: I0adf2512553c7cfb7b9018b65a8d207f252edafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940548 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#719740}
-
Steve Kobes authored
The original tests are left intact, as they also verify the value of LayoutShiftTracker::Score() which is not directly available to WPT. Bug: 984109 Change-Id: I25d8fd48ac86ebbfc742d6dfe10e7097497b31d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937579 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#719739}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use DynamicTo<SVGTitleElement> as new downcast helper 2. Use IsA<SVGTitleElement>(element) in place of IsSVGTitleElement(element) Bug: 891908 Change-Id: I1001e154870ab13f84d53e25361e9107cad4c4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936687Reviewed-by:Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#719738}
-
Vitaly Buka authored
With crrev.com/c/1914359 merged so we can enable the flag on Windows. Patch is similar to crrev.com/c/1795632 and crrev.com/c/1838383. Bug: 977230 Change-Id: I166392ee0f65ed7fd7f68cbdd5b7a3b7d589539b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854805 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#719737}
-
Carlos Caballero authored
This reverts commit de47eedd. Reason for revert: This is firing for all navigations Original change's description: > [bfcache] Disabling bfcache for PermissionManager. > > Some background on why we sometimes need to disable bfcache: > https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 > > Bug: 1001087 > Change-Id: If3a7b14a0cb6630c8d5754726bf3a10e6b84eeab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852289 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Auto-Submit: Karolina Soltys <ksolt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713803} TBR=mlamouri@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1001087 Change-Id: I34da66bcf77ee5d561abea303f8c2a0d210f283d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940176Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#719736}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4cd5a5469ffe..29815810c944 Created with: gclient setdep -r src-internal@29815810c944 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Iaadf0fb8a79c275487e0ae804d6429f762c391d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940809Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719735}
-
Aga Wronska authored
Wrapper creates an abstraction layer and takes care of types conversion and data filtering, so it is not spread around per-app time limits code. Bug: 1015658 Test: AppServiceWrapperTest Change-Id: Iae04ea99e05f9495b70117e425374223e8583919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938567 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Move all classes under org.chromium.chrome.browser.preferences which are related to Android settings screens (rather than the underlying preferences persistence layers) to org.chromium.chrome.browser.settings instead. This disambiguation was decided in go/clank-preferences-refactor. Dependent downstream change: https://crrev.com/i/2222930 TBR=tedchoc@chromium.org NOPRESUBMIT=true Binary-Size: Keeping existing method name, see crrev.com/c/1935716 Bug: 1027271 Change-Id: I961a7b13ab0911503ee0e9a59fc267436bebbe90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938467Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#719733}
-
chrome://flagsDemetrios Papadopoulos authored
Bug: 720034 Change-Id: I5042226a6269b3d60884cdc92ba554c2aaacaf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940555 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#719732}
-
Joe DeBlasio authored
This CL updates the cases in which mixed content download blocking will dump without crashing by excluding now-known cases where initiators are missing. These include downloads from webview/cct, internally-initiated downloads and user-initiated downloads of offline pages. It also silences dumps from a not-yet-understood situation where seemingly-normal downloads don't have initiators. The stack trace isn't helping in this case, so crash dumps aren't useful. Bug: 1029003 Change-Id: I77102e361d334e847331f5e0bc1b9ce5321ab4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940723 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719731}
-
Livvie Lin authored
Bug: 1027626 Change-Id: I70ddfb8cb18b7e045e8c6f30ce7d398d0c2f1c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929862Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719730}
-
Carlos Knippschild authored
TBR=fgorski@chromium.org Bug: 1025251 Change-Id: I9034302de26f8be776045fdb3714da29fed5da74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940867Reviewed-by:
-
Devlin Cronin authored
The only remaining method of DeferredStartRenderHostObserver, OnDeferredStartRenderHostDidStopFirstLoad(), is only used in tests by a class that monitors ExtensionHost loads. Move this method to ExtensionHostObserver (and rename it OnExtensionHostDidStopFirstLoad()), and fully remove DeferredStartRenderFrameHostObserver. Bug: 1028334 Change-Id: I33afa64dd95ccc54903e99dc68c903818e6ef82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937357 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#719728}
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/7e8ae0dee24d..f54082a0145f $ git log 7e8ae0dee..f54082a01 --date=short --no-merges --format='%ad %ae %s' 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in quic/core (but not subdirectories). 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in quic/core/http. 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in a few tests. 2019-11-27 bnc Use IsStreamError() and friends gMock matchers in quic/quartc. 2019-11-26 dschinazi Deprecate quic_version_negotiation_grease 2019-11-26 dschinazi Deprecate quic_enable_version_49 Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: Ib9a68a549f96a69c07686a06ef23dd6ec6928c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940753 Commit-Queue: Bin Wu <wub@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#719727}
-
danakj authored
These Closures are all called more than once when WebContentsObserver events occur, so they are made to be RepeatingClosures. TBR=clamy@chromium.org Bug: 953861, 1007763 Change-Id: Idc328b2091b839151d0503ca518e50be50d71203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940357Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719726}
-
Andrew Luo authored
Bug: 1019521 Change-Id: I2074e8178214487c7677b45bd647ffc0191e1a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938450Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#719725}
-
Ender authored
This reverts commit a59a4ff3. Reason for revert: Code crashes with following assertion: java.lang.AssertionError: Paint should be initialized when the search engine is Google. at org.chromium.chrome.browser.omnibox.status.StatusView.setStatusIcon(StatusView.java:343) Consulted Brandon and reverting this change as we agreed. We'll reland it when he's back. Original change's description: > Visually scale down the size of the Google G logo in the omnibox > > Bug: 1020774 > Change-Id: I48b32fdfbcf4dc2a20ba047ee3f93783f4fa2a38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918047 > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718931} TBR=twellington@chromium.org,wylieb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1020774 Change-Id: I858a8f362898af35de2b255af960029f64894373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940720Reviewed-by:
Ender <ender@google.com> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#719724}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/126d7a263625..4d6c84bf8985 git log 126d7a263625..4d6c84bf8985 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@4d6c84bf8985 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I574439fbada47c3cdc499465e1d26b6b2768db09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940542Reviewed-by:
-
Liquan (Max) Gu authored
Currently, the layout of Payment Handler toolbar has a layout issue. The title and the security icon has no padding between them and their container. As sheet_tab_toolbar is shared between Payment Handler toolbar and Ephemeral Tab toolbar, the Ephemeral Tab toolbar has been test-run to ensure looking normal. Bug: 1027713 Change-Id: I624ab42a0494b715ac2d5789704e95548d2eda9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940558Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#719722}
-
Kelvin Jiang authored
Bug: 1017934 Change-Id: If9fe54ca0ca7b137c6a51187d9b81a7f37387d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937780 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719721}
-
Asanka Herath authored
Removes some no-op code. Bug: 927182 Change-Id: I295a0e9f3b166a1c204d053af9f86acb3917a5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938710Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#719720}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2613cb5e3a21..8a6dcf76315c git log 2613cb5e3a21..8a6dcf76315c --date=short --first-parent --format='%ad %ae %s' 2019-11-27 sugoi@google.com Support sample image instruction operand Created with: gclient setdep -r src/third_party/swiftshader@8a6dcf76315c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/135265531 Tbr: swiftshader-team+autoroll@google.com Change-Id: I2c2110445a3f4c4f01828322cca979f1b09aec8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940544Reviewed-by:
-
weiliangc authored
For builder Linux FYI Release (AMD R7 240). BUG=1028639 TBR=cwallez@chromium.org Change-Id: Ib2113fc2825cd683d31ebd909316b90fa7bbfa3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940808Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Auto-Submit: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719718}
-
Matt Mueller authored
This allows NetLog to safely be used from worker threads that are not joined on shutdown. It already was a leaked object in Chromium and in Cronet on Android (but not on Cronet iOS). Moves ownership of the global object into net_log.cc and adds NetLog::Get() to access it, and makes ~NetLog destructor private so that code can't accidentally create local NetLog objects. Tests can create a local NetLog with the TestNetLog class. Tests that only needed an NetLog incidentally but don't actually observe/test it are changed to use the global NetLog::Get(). Bug: 177538 Change-Id: I12a832801c108483db5b1a577c1094e7d2ceb3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912696Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#719717}
-
David Benjamin authored
There were also two places where custom HttpResponses could just use one of the built-in ones. Bug: 1007815 Change-Id: I97dad08849c1ca0db04b200c2168ba4ff5939e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880529 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#719716}
-
Bo Liu authored
The expected though surprising behavior is that history API does not trigger onPageStarted or onPageFinished. Bug: 1027165 Change-Id: I26163f98fe87184719d5ca4e195d5577496c5b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940747 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719715}
-
Toby Huang authored
When the "Permissions for sites and apps" toggle in Chrome family dashboard is disabled, we should prevent child users from installing new extensions and approving additional permissions for existing extensions. This CL focuses on preventing child users from granting approval for additional permissions. When the toggle is disabled, pref kSupervisedUserExtensionsMayRequestPermissions becomes false, and this is used to implement the desired effects in this CL. Bug: 1018956 Change-Id: I492e9ffa2b5b4c923160c54aebbbc8a5622849a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929032Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719714}
-
Peter Kasting authored
For X11 this likely doesn't matter, as in practice NativeThemeGtk::GetColor() will probably override everything. For the increased contrast theme supplier, someday we probably want to replace this with better platform-native high contrast support on the platforms that use it, but for now, it doesn't make sense to disable incognito default colors in most cases; the code in question was only intended to apply to custom themes. This _does_ still apply "force non-incognito" to autogenerated themes, since these should basically work "like custom themes" as much as possible. If we wanted, we could likely change this by ensuring the autogenerator overrides everything necessary. I don't have a strong opinion. This is primarily a set-up change for fixing bug 621004, by exposing a method that we'll also use to control "disable dark mode". Bug: 621004 Change-Id: I6375cea9ae88d56a02c212258caf3b647af30585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938569 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#719713}
-
Asanka Herath authored
Renames auth_sspi to mechanism_. Separating this out before some more refactors come down the pipe. Bug: 927182 Change-Id: I8f4a5133ae296db742460b97a1dc5aa88221ef6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938709Reviewed-by:
-
John Abd-El-Malek authored
This only seemed to come up on Windows debug and not other desktop platforms, possibly related to timing. The user-data-dir override wasn't set on desktop and so tests in parallel shared a data directory. Bug: 1026523 Change-Id: Ifddf92266e63a2742c8806aabbf9c0dbdb94d42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940718 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719711}
-
Daniel Murphy authored
R=enne@chromium.org Bug: 1024966 Change-Id: I8f7f1f31434668c1cdaadb07d0ee7ec3606b2b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924920 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#719710}
-
Kevin McNee authored
In NavigationControllerImpl::NavigateFromFrameProxy, there is a check that prevents replacement if there are no existing entries. However, this is only done for the browser's NavigationEntry. The original value provided by the caller is used for the navigation request. The renderer sees the initial navigation being done with replacement which causes it to DCHECK in RenderFrameImpl::UpdateNavigationHistory. We now prevent replacement for the navigation request to be consistent with the navigation entry. Bug: 1029036 Change-Id: I34ee5bc0b4b9c44c531f2b70fba24133eba23064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877129 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719709}
-
Peter Kasting authored
Mostly gives clearer names to autogenerated theme functions. Some small comment tweak, ordering changes, and code shortening. Bug: none Change-Id: Id4237b208cbd07e2a61b2cb419102b5a7b241908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938461Reviewed-by:
-
