- 13 Jul, 2018 40 commits
-
-
Katie D authored
Fixes a bug by using a "while" rather than an "if" when stepping to the next node in word boundary events. This allows STS to skip nodes if they are not spoken, which may occur if there are nodes that are punctuation only in the list, like ")" or "-". For example, on the English alphabet Wikipedia page, A a * B b * C c * etc, the * node is not spoken, which causes highlight to get delayed because those nodes could not be skipped. Changing the "if" to a "while" fixes that. Bug: 830116,830116 Change-Id: Ic40aa7c32ab10db3a084e94f1d4db49f096abd9c Reviewed-on: https://chromium-review.googlesource.com/1136524Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#575113}
-
Taylor Bergquist authored
The various content setting bubbles were listening to their radio buttons and maintaining a separate copy of the buttons' checkedness state. However, radio buttons didn't notify their listeners when the arrow keys were used to change checkedness; they only notified on mouse events. This CL makes the bubbles refer to the actual radio button state when closing instead of listening to the buttons. It also gets rid of radio button listening as a thing, since it didn't work anyways and nobody else was using it. Other yaks shaved by this change: - Remove Checkbox::set_listener so that it can't be called on radio buttons. Listeners must be added at construction time now. - Move the business logic out of destructors in the content setting bubbles so that the bubble models can reference their views without worrying about them having been already cleaned up. It's now in an explicitly invoked separate method 'CommitChanges'. - The RPH (register protocol handler) content setting bubble was the only one that applied settings changes as users clicked on radio buttons, rather than when the dialog was closed. It's now consistent with the other bubbles. Bug: 841202 Change-Id: I16761571fd03bb1925d95995d8b7e6f0e03aa02a Reviewed-on: https://chromium-review.googlesource.com/1128377Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#575112}
-
Kim Paulhamus authored
-virtual/gpu/fast/canvas/canvas-blend-image.html -external/wpt/requestidlecallback/callback-iframe.html TBR: tkent@chromium.org Bug: 863350, 863599 Change-Id: I56246e6b83ecad9365a2974f82e17f5d8e7de65a Reviewed-on: https://chromium-review.googlesource.com/1137234Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#575111}
-
liberato@chromium.org authored
This CL adds a cleanup CB to AbstractTexture, so that it can notify the client that it is no longer keeping a reference to the underlying TextureBase. This lets the client perform any cleanup tasks that are associated with either (a) the client dropping the AbstractTexture or (b) the decoder stub being destroyed. This CL also modifies TexturePool to use it, rather than sending a callback to be run when the sync token clears. This has the advantage of freeing codec resources immediately upon context loss, rather relying on VideoFrame cleanup to happen properly when the renderer is being torn down. Bug: 863012 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I672ae8831c1e5a8d92aa3812fa938901d2a171fd Reviewed-on: https://chromium-review.googlesource.com/1135757Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#575110}
-
Reilly Grant authored
This is a follow-up to r564119 where it was suggested that by always returning true from ShouldShowIconBeforeText() the "no devices found" message would be offset to the right. To fix this, when there are no options to display this change hides the table view entirely and displays the message using the same style of overlayed label as the "adapter off" message. Bug: 654137 Change-Id: I7544698425e94fb3d1666ba9c70063091f85f438 Reviewed-on: https://chromium-review.googlesource.com/1117873 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#575109}
-
erikchen authored
There appears to be a bug in Launch Services that causes MallocNanoZone=1 to always be set by default for all applications [this affects applications launched by Finder, and on restart, but not applications launched from the Terminal]. I filed https://bugreport.apple.com/web/?problemID=42181038 to track this. MallocNanoZone causes libMalloc to use the nano malloc zone by default [affects allocations <= 256 bytes]. The implementation of nano malloc never frees memory. See https://bugs.chromium.org/p/chromium/issues/detail?id=861939#c6 for more details. This has been observed to cause > 1GB of wasted memory in the browser process. Possibly a lot more when added up across all processes. To test this: 1) Build Chrome with patch. 2) Run /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister -f <path_to_chrome> 3) Launch Chrome from Finder 4) Use "vmmap <pid>" to observe whether there is a MALLOC_NANO summary. Bug: 861939 Change-Id: I740bcbb006e4ce641d0dde6f6e53dcf4f032ff0b Reviewed-on: https://chromium-review.googlesource.com/1137131Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575108}
-
Oksana Zhuravlova authored
Change-Id: I97dd67db41337f69cc9ed54eb743b7f1664301f3 Reviewed-on: https://chromium-review.googlesource.com/1137271Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#575107}
-
Toni Barzic authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/ec6d4902f36c..0eac64e18aba $ git log ec6d4902f..0eac64e18 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 phongo Un-deprecate supervision_transition field. 2018-07-10 dgreid vm_concierge: Add an export message 2018-07-09 baileyberro system_api: Add StartCopy and ContinueCopy to SmbProvider constants 2018-07-06 tbarzic Add is_demo_session to UpgradeArcContainerRequest 2018-06-26 hychao service_constants: Add GetSystemAecSupported method 2018-06-28 baileyberro system_api: Add Smb Copy Errors 2018-06-22 zachr vm_cicerone: add debug information constants 2018-05-22 xzhou cryptohome: add nvspace bootlockbox protos Created with: roll-dep src/third_party/cros_system_api Change-Id: I1d4d9f055c3fd9e4dbca69755fb3d40a162e0448 Reviewed-on: https://chromium-review.googlesource.com/1137056Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575106}
-
Dan Harrington authored
Bug: 860228 Change-Id: I8ea5f1f39b8d9a62b5f2a4c608e9a1054d0fb297 Reviewed-on: https://chromium-review.googlesource.com/1129466 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#575105}
-
Wez authored
Previously Fuchsia required IPv4 multicast binding to specify the desired interface by its IP address, requiring an extra step to look up the address based on the interface index. Fuchsia's netstack now supports binding using the interface Id directly, which is what we use on all other platforms than MacOS, so switch to using that version of the API. Bug: 862189 Change-Id: Idecc66cb1d6e7bbe0ab1061dbb96c12114cac9dc Reviewed-on: https://chromium-review.googlesource.com/1136390Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#575104}
-
Tom Anderson authored
BUG=863460 R=thakis Change-Id: I658c215071c5dfe9dcc2b7e7bc5a5d21ee57ac18 Reviewed-on: https://chromium-review.googlesource.com/1136495 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575103}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a80a012456a9..1128ebcb6dde git log a80a012456a9..1128ebcb6dde --date=short --no-merges --format='%ad %ae %s' 2018-07-13 reed@google.com make u32 check runtime Created with: gclient setdep -r src/third_party/skia@1128ebcb6dde The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:848521 TBR=robertphillips@chromium.org Change-Id: I7a78fd591eae7f4a7916fcce8e977fa1d8a8ed80 Reviewed-on: https://chromium-review.googlesource.com/1136772Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575102}
-
Kevin Strohbehn authored
Bug: 863479 Change-Id: Iad8c001d9ae2ce9606a31d98cc694f904b900b86 Reviewed-on: https://chromium-review.googlesource.com/1136974Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#575101}
-
Jordy Greenblatt authored
The main change in this CL is the addition of the Smart Lock icon, and with it the necessary infrastructure for adding the of the icons. There are also some alignment and naming cleanups. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I13b32e26228bbea02378ef03a74405be1b926c46 Reviewed-on: https://chromium-review.googlesource.com/1136896Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#575100}
-
Kenneth Russell authored
Since all of the 10.12.6 machines were upgraded to 10.13.5 this has been failing. Tbr: jmadill@chromium.org Bug: 856799 Change-Id: I7937b7b8a3d59b3d2e60db9665f3ffb89dd5b745 Reviewed-on: https://chromium-review.googlesource.com/1137254Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575099}
-
Patti authored
Show the number of cookies on a domain / eTLD+1 group of sites in All Sites. Since cookies at their widest scope can be set on eTLD+1s, this display will be restricted to sites that are grouped. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I66d2c36b2af1ad577d4d71512f3d22541e1c926f Reviewed-on: https://chromium-review.googlesource.com/1111770Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#575098}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3a83fe5cf6cf..cf403ba5720c git log 3a83fe5cf6cf..cf403ba5720c --date=short --no-merges --format='%ad %ae %s' 2018-07-13 hnakashima@chromium.org Create API to remove a parameter from a content mark. 2018-07-13 hnakashima@chromium.org Create API to remove a content mark from a page object. 2018-07-13 hnakashima@chromium.org Fix mark parameters not saved if nothing changed. 2018-07-13 thestig@chromium.org Validate out-parameters in FPDF_GetPageSizeByIndex(). Created with: gclient setdep -r src/third_party/pdfium@cf403ba5720c The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I95b79f108eaf746ab80a49bb122a5cd4410b8839 Reviewed-on: https://chromium-review.googlesource.com/1136494Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575097}
-
Guido Urdaneta authored
Some devices report zero frame rates in their supported video formats and this makes getUserMedia() fail if frame-rate constraints are used. This CL replaces zero frame rates with a fallback frame rate to work around this issue. Bug: 862325 Change-Id: If7e844856d9652480ed6bca607037dc0a4b9b7c4 Reviewed-on: https://chromium-review.googlesource.com/1136642Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#575096}
-
Malay Keshav authored
This patch achieves two goals. 1. Snaps the NativeHostView of the extension popup to the physical pixels. This is because NativeHostView's layer will have a render surface of its own which needs to be snapped to the physical pixels for all its content to be snapped as well. 2. Snaps the RenderWidgetHostView to the nearest ancestor instead of of the toplevel or root window. This ensures that it snaps to the render surface it belonds too, instead of snapping to some other render surface in the hierarchy. To achieve the two goals, this patch also moves the utility method that snaps windows to its nearest snapped ancestor window from src/ash to ui/wm/core. Bug: 843250 Change-Id: I9d9f0bdd2391b1d9904537ec8580de72d225fdf6 Component: Windows, Snap to physical pixel, HighDPI, extensions Reviewed-on: https://chromium-review.googlesource.com/1121330 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Yue Cen authored
There is an "App downloading" screen after user chooses to install the selected packages. The screen is added in this CL. Bug: 835029 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8412980e0e1bec0ff1d9257a509f3ccf6bf77c8f Reviewed-on: https://chromium-review.googlesource.com/1103665 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575094}
-
Kim Paulhamus authored
TBR: tkent@chromium.org Bug: 863544 Change-Id: Ie4f20bb619366eb7e9ac296ac4497ec27241a7b1 Reviewed-on: https://chromium-review.googlesource.com/1136971Reviewed-by:
-
Francois Doray authored
With this CL, frozen tabs can be unfrozen at configurable intervals for a configurable amount of time. The goal of unfreezing tabs is to let them update their state, so they are up to date when they are reactivated. The code enforces that a single tab is unfrozen at a time. Bug: 775644 Change-Id: Ifd57c4ef0aea866089a931020242bc60486f6edd Reviewed-on: https://chromium-review.googlesource.com/1135639 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#575092}
-
Nico Weber authored
- Run components_browsertests on 32-bit linux dbg main waterfall bot, and on the win7 and win10 dbg main waterfall bots. If the tests end up failing there, we can re-disable them with a link to a bug explaining what exactly fails. - Run mash_unittests on the fyi Mojo ChromiumOS bot (suite takes seconds to run). Bug: 843511 Change-Id: I6b529723300ade97712e5e360dfddff8d8d64c40 Reviewed-on: https://chromium-review.googlesource.com/1136464Reviewed-by:
-
yiyix authored
Since there is only active tree on browser side, metrics that measure the pending_tree related information does not report any data. Note that no change in the code is needed because the metric is initiated in CreatePendingTree, which is not called in the browser side. Bug:856860 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I40c36c62131e309fabaedab298b249307a9c1c29 Reviewed-on: https://chromium-review.googlesource.com/1133971Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#575090}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a738c2067f78..be45355b46d9 git log a738c2067f78..be45355b46d9 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 simonhatch@chromium.org Dashboard - Fix fast path in ReplaceSharedDiagnostic 2018-07-13 dtu@chromium.org [pinpoint] Pass in `--non-telemetry true` for non-Telemetry tests. Created with: gclient setdep -r src/third_party/catapult@be45355b46d9 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863527 TBR=sullivan@chromium.org Change-Id: I34a564feca7d7fbd65d88ffca3f9d238da94e70a Reviewed-on: https://chromium-review.googlesource.com/1136951Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575089}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/895617fa9bc3..b2ecc3dc49dc git log 895617fa9bc3..b2ecc3dc49dc --date=short --no-merges --format='%ad %ae %s' 2018-07-13 srte@webrtc.org Removes old probe controller. 2018-07-13 magjed@webrtc.org Android: Transform legacy codec factories into VideoCodecFactories 2018-07-13 philipel@webrtc.org Remove RTPVideoHeader::h264() accessors. 2018-07-13 srte@webrtc.org Replaces call config create in tests with modify. 2018-07-13 srte@webrtc.org Moving functionality from VideoQualityTest to CallTest 2018-07-13 srte@webrtc.org Makes some CallTest members private. 2018-07-13 andersc@webrtc.org Don't care about H264 profiles when creating Android decoder. 2018-07-13 magjed@webrtc.org Android: Pass VideoCodecInfo instead of String to createDecoder() 2018-07-13 srte@webrtc.org Using FunctionVideoEncoderFactory in VideoQualityTest. 2018-07-13 srte@webrtc.org Separates send and receive event log in CallTest. 2018-07-13 alexnarest@webrtc.org Better handle target audio bitrate allocation. 2018-07-13 sakal@webrtc.org Add support for RTX in external codecs. 2018-07-13 magjed@webrtc.org Android: Add software fallback wrapper in Default video codec factories 2018-07-13 saza@webrtc.org Fuzz more aec3 field trials 2018-07-13 srte@webrtc.org Makes srte owner in call/ and test/ 2018-07-12 peah@webrtc.org AEC3: Refactor the code for analyzing filter convergence 2018-07-12 qingsi@google.com Reland "Reland "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*."" 2018-07-12 buildbot@webrtc.org Roll chromium_revision f7c234b0..1447fae2 (574598:574709) Created with: gclient setdep -r src/third_party/webrtc@b2ecc3dc49dc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:b/111416606,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5f3f5002dd296fa13fa30ce4fcf4d80697adacbf Reviewed-on: https://chromium-review.googlesource.com/1136914Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575088}
-
Kurt Horimoto authored
This CL updates the reading list table view edit animations from using UITableViewRowAnimationFade to using UITableViewRowAnimationAutomatic. Bug: 862172 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia6cdb098dcf7f454a782adb820b9e0f665a54acb Reviewed-on: https://chromium-review.googlesource.com/1132420 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575087}
-
Eric Karl authored
This CL causes us to re-use computed cache keys in the GPU image decode cache rather than re-computing them each frame. Improves the speed of re-acquiring an already-decoded image by 10% in the included perf test. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idfe6b6bb96dded1903c24cc82da9243fe85f00dc Reviewed-on: https://chromium-review.googlesource.com/1135650 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#575086}
-
Eric Orth authored
Starting a TCP DNS attempt cancels and deletes any previous running attempts. Fix the filtering to skip retriable errors that will not retry because we have exhausted available attempts. Otherwise, if an attempt has already completed synchronously and posted to handle the result, it could try to handle the result of a deleted attempt. Also replace the raw Attempt pointer in AttemptResult with a WeakPtr, so any future similar bugs will safely DCHECK and crash instead of UAF. Bug: 860292 Change-Id: I4a012a078b9b35f87b95a9592f4e43573c6a0708 Reviewed-on: https://chromium-review.googlesource.com/1134028 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#575085}
-
Findit authored
This reverts commit fac52799. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 575065 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZhYzUyNzk5YjIzNGIxZDQ4MmEyZDljYjQwNjVhZjFmZDkxMGNkODIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/15781 Sample Failed Step: net_unittests Original change's description: > Add new ResolveHost API. > > Primarily an interface-only change. Only change past the interface level > of the stack was to internally pass rawer information rather than > use RequestInfo as that struct is specific to the old Resolve API. > > Only handles the basic case for now (HostPortPair input without any > significant options), but additional funtionality will be added in > subsequent changes. > > Copy and convert all the unittests that can be implemented using the new > method with its current basic functionality. If we ever convert all > usage to the new method and delete the old, we'll be able to cleanly > delete all the old tests. > > Design doc: > https://docs.google.com/document/d/1NmADJX00oRe9TxFCJTWl8ofdfyR22pbKT8-5Ad5lBsU > > Bug: 821021 > Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I4fe454761e2930d6f235e8e505b689f8917fdeed > Reviewed-on: https://chromium-review.googlesource.com/1099427 > Commit-Queue: Eric Orth <ericorth@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575065} Change-Id: Ifa50c76a409dde3580599275aade1686795d6c17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1137111 Cr-Commit-Position: refs/heads/master@{#575084}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/210610261006..ecbaf6663915 git log 210610261006..ecbaf6663915 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 jmadill@chromium.org dEQP: Fix non-GTest error logging. 2018-07-13 lucferron@chromium.org Vulkan: Implement gl_DepthRange support using driver uniform 2018-07-13 lucferron@chromium.org Vulkan: Enable viewport Y flipping Created with: gclient setdep -r src/third_party/angle@ecbaf6663915 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I79233d62143b89d8dd41df36c7e7229c882202a3 Reviewed-on: https://chromium-review.googlesource.com/1136912Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575083}
-
David Tseng authored
1. a few more places where we need to go from dip back to screen (e.g. when dispatching events as part of pass through). 2. InOneFingerPassThrough was taking the event location and subtracting a |passthrough_offset_|. However, it appears downstream there was a syntax or semantic error as the parens were off. We were subtracting the event location *after* being converted to screen with the pass through offset which is in dips. Bug: 862830 Change-Id: I2ca08e2e785e23aae980ea1138f8f57876808b34 Reviewed-on: https://chromium-review.googlesource.com/1135656Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575082}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie86c12f331845a732f8e01840e465a6389c9c01b Reviewed-on: https://chromium-review.googlesource.com/1136931Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#575081}
-
Charlie Harrison authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I0fd84010f51370df1b1537ee6eb415aeb363972a Reviewed-on: https://chromium-review.googlesource.com/1136645 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#575080}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8e093bc7. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21204 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I3b5057a625e08474add7f4ea48130310d40bdf9a Reviewed-on: https://chromium-review.googlesource.com/1136861 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575079}
-
edchin authored
The tab grid cell titles were previously being updated too late on "page loaded", rather than earlier on "title changed". This CL also sets a default icon for cells. This CL also removes an old snapshot in the tab grid once the title has changed, so that the title and snapshot are in sync. Video: https://drive.google.com/open?id=1NvSuQ039jsl0YTqO6ua_IREk7f2Z807C Bug: 860245, 853569 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic3317ddc50ceb16fe0d89b41e8b26fc2bac203e9 Reviewed-on: https://chromium-review.googlesource.com/1136836Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575078}
-
Scott Chen authored
<iron-list> introduced a bug that causes a focused item to lose focus when the user scrolls away then tab back. A fix was landed in the iron-list repository but a new version had not been released yet, so this CL patches the fix locally first. The local patch should be removed later once iron-list releases the new version and is patched into our code-base. Bug: 854571 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5b70ce4188b882839e7a322270847fde85690011 Reviewed-on: https://chromium-review.googlesource.com/1135652Reviewed-by:
-
Nektarios Paisios authored
Removes the word "accessibility" from many Views classes and deletes unused NativeViewAccessibility class There are still a few changes required in Views components that use accessibility classes. I'll ask for other owners to approve when accessibility people are fine. R=aleventhal@chromium.org, dmazzoni@chromium.org Change-Id: Ie86e2934fe58607a184af44b94ca6cd6ed50c56c Reviewed-on: https://chromium-review.googlesource.com/1123197 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
David Black authored
DeepLinkType enum is more easily consumed by event observers. DeepLinkType + params adequately represents the complete deep link. Bug: b:111437390 Change-Id: I62618b9ae84a1240232bd2f9e50f999cb2be9055 Reviewed-on: https://chromium-review.googlesource.com/1136855 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575075}
-
Dan Zhang authored
Existing crashes are not use-after-free. The CHECK's haven't been triggered so far. Merge internal changelist: 204339592 R=zhongyi@chromium.org Change-Id: I2b0549aafff5f639a3a86803aef364dc8c4e059c Bug: 664200 Change-Id: I2b0549aafff5f639a3a86803aef364dc8c4e059c Reviewed-on: https://chromium-review.googlesource.com/1135871 Commit-Queue: Dan Zhang <danzh@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575074}
-
