- 06 Aug, 2014 40 commits
-
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287749 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/448583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287748 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
This makes ui::Compositor no longer in charge of scheduling commits and draws, deferring it to cc::Scheduler. Other compositors that use SingleThreadProxy are left calling composite synchronously and now pass a flag to indicate that this is their intention. This patch doesn't remove synchronous composite, but now makes it mutually exclusive with scheduling. BUG=329552, 287250 Review URL: https://codereview.chromium.org/134623005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287747 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
The AutoSize test was failing on Mac: WebViewTest.AutoSize (run #1): [ RUN ] WebViewTest.AutoSize [9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType) [9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType) [9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType) [9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType) [9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors [9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors [9340:71171:0806/013455:INFO:CONSOLE(14)] "guest.loadstop", source: chrome-extension://blepeeghknicglkaidbjijdlejjompdl/main.js (14) ASSERTION FAILED: !enable || !minSize.isEmpty() (log: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/26134/steps/browser_tests/logs/AutoSize) > <webview>: Move autosize from content to chrome. > > BUG=330264 > TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json > > Review URL: https://codereview.chromium.org/427883002 TBR=fsamuel@chromium.org Review URL: https://codereview.chromium.org/446823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287746 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
These can now be intercepted within glibc so there is no need to implement them directly. mkdir/mkdir were also be intercepted at this level under newlib unnecessarily. It seems that truncate.c is still needed but I've got a fix for that in glibc: https://codereview.chromium.org/439003002/ BUG= https://code.google.com/p/nativeclient/issues/detail?id=3709 R=binji@chromium.org Review URL: https://codereview.chromium.org/433193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287745 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
TrackerIDSet class is expanded on disk DB, and needs a good simulation to work similarly with it. This CL fixes handling of active tracker ID which was not correct. BUG=347425 TEST=./unit_tests --gtest_filter="MetadataDatabaseIndexOn*" Review URL: https://codereview.chromium.org/441873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287744 0039d316-1c4b-4281-b951-d872f2087c98
-
tbutter@gmail.com authored
Playing a WebM File with opus audio via MediaSource currently uses kSampleFormatS16. In a video src it uses kSampleFormatF32. S16 does not work (just plays noise). BUG=400247 R=vigneshv@chromium.org Review URL: https://codereview.chromium.org/437813005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287743 0039d316-1c4b-4281-b951-d872f2087c98
-
byungwook.ahn@gmail.com authored
BUG=254066 TEST=NONE Review URL: https://codereview.chromium.org/423173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287742 0039d316-1c4b-4281-b951-d872f2087c98
-
dzhioev@chromium.org authored
BUG=401010 TBR=bartfab Review URL: https://codereview.chromium.org/442233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287741 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
The problem is that we were generating zero hashes when there were no input bytes, when we should have generated one. To make this fix a little easier to test, I moved the code for generating hashes of content into a utility funciton in computed_hashes.{h,cc}. Also, in order to fix things for any profiles that might have incorrect computed_hashes.json files, I changed the format of it to add the notion of a version. When the format or version isn't recognized, the code will return an error from the Init function, and then the code that uses it elsewhere in the content verification code will automatically try to recreate it. BUG=399251 Review URL: https://codereview.chromium.org/436563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287740 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
Previously, platform backends were singletons [per platform] but the platform object itself was created and destroyed by the browser. Moreover, the current OS backend was publicly accessible. This patch tightens up the lifecycle of platforms, making the host platform an explicit singleton, and target platforms singletons owned by their finder. And, the platform backend is no longer exposed. Sadly, three corner cases exist: a memory test case and the actual desktop-based browser finders. R=tonyg BUG=356763 Review URL: https://codereview.chromium.org/436873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287739 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
This was re-enabled recently but was still flaky. This CL removes another possible cause of flakiness and re-enables the test again. BUG=171450 Review URL: https://codereview.chromium.org/448473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287738 0039d316-1c4b-4281-b951-d872f2087c98
-
qyearsley@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/434043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287737 0039d316-1c4b-4281-b951-d872f2087c98
-
chhajer.m@samsung.com authored
corrected to "Microphone currently unavailable" BUG=396971 Review URL: https://codereview.chromium.org/434373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287735 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
BUG=346956 Review URL: https://codereview.chromium.org/436453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287734 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Print more information in cast_simulator: 1. Total video frames. 2. Dropped video frames. 3. Late video frames. 4. Avg. target bitrate. 5. Avg. encoded bitrate. Review URL: https://codereview.chromium.org/433363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287733 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
BUG=330264 TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json Review URL: https://codereview.chromium.org/427883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287732 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=None TEST=None TBR=sky Review URL: https://codereview.chromium.org/442893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287730 0039d316-1c4b-4281-b951-d872f2087c98
-
cjhopman@chromium.org authored
This is essentially three steps, packaging resources, packaging code, and then signing+zipaligning the apk. The apk does not currently contain the native libraries. Depends on http://crrev.com/386473002/ BUG=359249 Review URL: https://codereview.chromium.org/383613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287729 0039d316-1c4b-4281-b951-d872f2087c98
-
jzern@chromium.org authored
dsp: detect mips64 & disable mips32 code enc_mips32: workaround gcc-4.9 bug BUG=374343 Review URL: https://codereview.chromium.org/442853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287728 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalyp@chromium.org authored
BUG=393873 R=dbeam@chromium.org TEST=python2 third_party/closure_compiler/coding_conventions_test.py Review URL: https://codereview.chromium.org/421253006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287727 0039d316-1c4b-4281-b951-d872f2087c98
-
kkimlabs@chromium.org authored
BookmarksBridge#getAllBookmarkIDsOrderedByCreationDate() is used to show all bookmarks, which has to be ordered from most-recent to oldest. BUG=386785 Review URL: https://codereview.chromium.org/440183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287726 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
As of r286651, NativeThemeMac now provides user-configurable system colours for better OS integration. However, these are not needed for dialogs that aren't trying to look native. This change gets the button hover background used for the new avatar menu from CommonTheme instead, to get a cross-platform look. BUG=399820 TEST=On Mac, run Chrome with --new-avatar-menu and open the avatar drop-down; hovering over the "Not xxx?" item should switch to a gray background. Review URL: https://codereview.chromium.org/440633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287725 0039d316-1c4b-4281-b951-d872f2087c98
-
siva.gunturi@samsung.com authored
BUG= 399240 Review URL: https://codereview.chromium.org/424543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287724 0039d316-1c4b-4281-b951-d872f2087c98
-
bengr@chromium.org authored
Precache manifests and configuration details are fetched via https instead of http with this change. BUG=309216 Review URL: https://codereview.chromium.org/435303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287723 0039d316-1c4b-4281-b951-d872f2087c98
-
ricea@chromium.org authored
Added a memory leak: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4658 > Add a browser test for functions in notification provider API > > Add a basic browser test for functions in notification provider API. > This is mainly to test the connection and provide a skeleton for future > tests. The functions are not fully implemented yet, and more tests will > be added as the functions are implemented. > > BUG= > > Review URL: https://codereview.chromium.org/416423006 TBR=liyanhou@chromium.org Review URL: https://codereview.chromium.org/447543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287722 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
Some hardware encoder cannot handle bitrate changing too quickly. The solution is to have a fixed bitrate and only set it once. BUG=392086 Review URL: https://codereview.chromium.org/439863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287721 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
BUG=398888 NOTRY=true Review URL: https://codereview.chromium.org/443713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287720 0039d316-1c4b-4281-b951-d872f2087c98
-
jiayl@chromium.org authored
BUG=398827 Review URL: https://codereview.chromium.org/448503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287719 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287718 0039d316-1c4b-4281-b951-d872f2087c98
-
ricea@chromium.org authored
Broken official Windows builder: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/25818 > Add integration browser tests for settings hardening. > > This CL introduces the PrefHashBrowserTestBase fixture which these tests are based on. > > This fixture (in conjunction with the new PREF_HASH_BROWSER_TEST macro) provides an easy way to override 3 methods in order to: > 1) Setup Chrome as desired in a PRE_ test. > 2) Attack Preferences while Chrome isn't running. > 3) Relaunch Chrome and verify reaction to attacks. > > The fixture+macro also parametrizes every test such that they are ran in every SettingsEnforcement trial group. > > A few pieces were resurrected from the old PrefHashBrowserTest used to test unloaded profile seeding prior to http://crrev.com/277209 > > Review URL: https://codereview.chromium.org/431973002 TBR=gab@chromium.org,erikwright@chromium.org Review URL: https://codereview.chromium.org/448563002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287717 0039d316-1c4b-4281-b951-d872f2087c98
-
eakuefner@chromium.org authored
This CL adds a method FromDict for converting deserialized JSON dicts to values. Review URL: https://codereview.chromium.org/417193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287716 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
BUG=347425 TEST=./unit_tests --gtest_filter="Metadata*" Review URL: https://codereview.chromium.org/423433006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287715 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
For functions in BoringSSL where X() is guaranteed to return either 1 or 0. Review URL: https://codereview.chromium.org/444793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287714 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Track UI and other threads differently in requesting DrawGL. The request itself is posted through UI thread, so not tracking them separately can lead to deadlocks. See bug for more detail. BUG=399745 Review URL: https://codereview.chromium.org/431383003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287713 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=399030 Review URL: https://codereview.chromium.org/441133003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287712 0039d316-1c4b-4281-b951-d872f2087c98
-
kkimlabs@chromium.org authored
The newest Android SDK had start&end attributes in non -v17 resources. Temporarily change the checking script from error to warning so that people can continue to work before it is fixed. This should be reverted once the issue is addressed BUG=None Review URL: https://codereview.chromium.org/445753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287711 0039d316-1c4b-4281-b951-d872f2087c98
-
vmpstr@chromium.org authored
This patch ensures that we clear the existing tile priorities when the tiling is reset. R=reveman Review URL: https://codereview.chromium.org/441033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287710 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
This will fix log parsing error on bot. BUG=397746 Review URL: https://codereview.chromium.org/440243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287709 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
The ui_controls_aura implementations either dispatch events via aura::Window::GetHost() (which first does GetRootWindow()), find the root window independently, or else ignore the window argument. So the GetRootWindow call is not required here. BUG=399191 Review URL: https://codereview.chromium.org/442633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287708 0039d316-1c4b-4281-b951-d872f2087c98
-