GitLab

BUG=480352,454716,412045

Review URL: https://codereview.chromium.org/1083193007

Cr-Commit-Position: refs/heads/master@{#330603}

The SHOW_STATE_FULLSCREEN state has not been supported in Windows
so this CL implements it and allows browser_tests to pass the
test for creating a full screen extension window without manually
calling setFullscreenMode().

BUG=473228

Review URL: https://codereview.chromium.org/1138383008

Cr-Commit-Position: refs/heads/master@{#330602}

We default most tests to having the trial enabled because that is the expected way forward. Nevertheless we put the trial so we can control rollout or kill it after the fact.

BUG=488602
TBR=asvitkine
TEST=FormStructureTest*,AutofillServerTest*

Review URL: https://codereview.chromium.org/1141133003

Cr-Commit-Position: refs/heads/master@{#330601}

This patch ensures that the skewport contains the visible rect. This
is a required that could be violated by extreme visible rects that
would overflow integer math. The fix is to add an extra union.
Includes a test.

R=enne
BUG=487130

Review URL: https://codereview.chromium.org/1131383007

Cr-Commit-Position: refs/heads/master@{#330600}

BUG=none
TEST=compiles

Review URL: https://codereview.chromium.org/1130183009

Cr-Commit-Position: refs/heads/master@{#330599}

BUG=392620

Review URL: https://codereview.chromium.org/1138233003

Cr-Commit-Position: refs/heads/master@{#330598}

DeepCopy() is expensive and we're doing a lot of it, transferring ownership is
better. I also tidied up some code here and there, like C++11 niceties,
removing unnecessary linked_ptrs, and better commenting.

R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1141963002

Cr-Commit-Position: refs/heads/master@{#330597}

On Win10 the current approach of SHOpenWithDialog is suboptimal. See
the bug for more details.

BUG=488774,489803

Review URL: https://codereview.chromium.org/1140293002

Cr-Commit-Position: refs/heads/master@{#330596}

R=lcwu@chromium.org,halliwell@chromium.org

Review URL: https://codereview.chromium.org/1132663004

Cr-Commit-Position: refs/heads/master@{#330595}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/89aeb69..cbb44be

TBR=hiroshige@chromium.org,szager@chromium.org

Review URL: https://codereview.chromium.org/1146763002

Cr-Commit-Position: refs/heads/master@{#330594}

Previously, the configuration was done by having multiple methods which
returned a single server and relied on the caller to understand which
was desired (origin vs fallback vs alternative vs alternative fallback).

The configuration was also limited to 2 servers and relied on checking
the validity of each value of the std::pair to understand if a value was
actually set or not.

Using a std::vector permits more than 2 servers to be used, and
makes it clearer that any values inside are valid.

The IsDataReductionProxy method also moves into DataReductionProxyConfig
instead of being implemented in DataReductionProxyConfigValues.

BUG=470587

Review URL: https://codereview.chromium.org/1124073008

Cr-Commit-Position: refs/heads/master@{#330593}

Revert of [Sync] Remove periodic sync for Chrome for Android (patchset #2 id:20001 of https://codereview.chromium.org/1148613002/)

Reason for revert:
seems to break the build
https://build.chromium.org/p/chromium/builders/Android/builds/40042

Original issue's description:
> [Sync] Remove periodic sync for Chrome for Android
>
> updateAccount() is always called on startup with the signed in account,
> so the removePeriodicSync() call will be hit even for already signed in
> users when the app restarts.
>
> BUG=480688
>
> Committed: https://crrev.com/20989a55f294c1b1643cbc2b80bf083de1dd7e36
> Cr-Commit-Position: refs/heads/master@{#330588}

TBR=nyquist@chromium.org,maxbogue@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=480688

Review URL: https://codereview.chromium.org/1135113006

Cr-Commit-Position: refs/heads/master@{#330592}

Revert of [Android] Refactor the native test wrappers. (patchset #7 id:120001 of https://codereview.chromium.org/1126543009/)

Reason for revert:
broke http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android

e.g. http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/1922

Original issue's description:
> [Android] Refactor the native test wrappers.
>
> BUG=476410
>
> Committed: https://crrev.com/581d25e509e4a2b1e8927c6d8accc0c90ea86090
> Cr-Commit-Position: refs/heads/master@{#330531}

TBR=jochen@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,perezju@chromium.org,tedchoc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=476410

Review URL: https://codereview.chromium.org/1138993009

Cr-Commit-Position: refs/heads/master@{#330591}

and change the DeterministicSockets to not implement AsyncSocket.

This helps make clear using the type system that the Deterministic
classes are distinct from the non-Deterministic classes.

Review URL: https://codereview.chromium.org/1135553003

Cr-Commit-Position: refs/heads/master@{#330590}

Introduce QuicStreamFactoryTest::DefaultProofVerifyDetails(), a helper function
to set up a ProofVerifyDetailsChromium object with a default cert loaded.

BUG=474217

Review URL: https://codereview.chromium.org/1142953002

Cr-Commit-Position: refs/heads/master@{#330589}

updateAccount() is always called on startup with the signed in account,
so the removePeriodicSync() call will be hit even for already signed in
users when the app restarts.

BUG=480688

Review URL: https://codereview.chromium.org/1148613002

Cr-Commit-Position: refs/heads/master@{#330588}

Disabling ForceReclaimResource on BeginCommit when using ui impl side painting
had the unintended consequence of breaking Display::Draw's mechanism for
not drawing while an OutputSurface was between Commit/Swap. Re enabling
this for now. Tracking handling this in a more robust way in
crbug.com/489515.

BUG=481656,489515

Review URL: https://codereview.chromium.org/1139823008

Cr-Commit-Position: refs/heads/master@{#330587}

BUG=489446

Review URL: https://codereview.chromium.org/1147843003

Cr-Commit-Position: refs/heads/master@{#330586}

The tests were re-entrantly reusing a TestCompletionCallback subclass in
a weird manner, which has now been fixed.  Also fix a WebSocket test
modelled after them.

BUG=114130

Review URL: https://codereview.chromium.org/1132313004

Cr-Commit-Position: refs/heads/master@{#330585}

There's no reason that an interrupt to a dup() should cause a SharedMemory
operation to fail.

BUG=

Review URL: https://codereview.chromium.org/1138113006

Cr-Commit-Position: refs/heads/master@{#330584}

For both desktop Chrome and Android we need to support a mechanism for
synchronizing open notifications. For desktop the most important case
is where Chrome just started up, where there won't be any notifications
since the message center is owned by Chrome.

For Android, there are more cases, since the platform hosts displaying
the notifications and informs Chrome through Intents of mutations. This
patch leaves synchronization there mostly out of scope, while still
laying the early groundwork towards supporting this.

BUG=442143

Review URL: https://codereview.chromium.org/1127013008

Cr-Commit-Position: refs/heads/master@{#330583}

- NULL -> nullptr
- prepend g_ to global variables
- fix misc nits.

Review URL: https://codereview.chromium.org/1134153003

Cr-Commit-Position: refs/heads/master@{#330582}

Without above change it breaks the build for Crosswalk which is dependent on
content and components like devtools_http_handler. This is somehow not evident
on Chrome or Content Shell builds which might be including base/values.h through
some other includes.

R=pfeldman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1137243005

Cr-Commit-Position: refs/heads/master@{#330581}

BUG=455974

Review URL: https://codereview.chromium.org/1133353006

Cr-Commit-Position: refs/heads/master@{#330580}

Task posts in Data Saver logic were delaying initialization
unnecessarily in Cronet, and consequently, the first
request after initialization wasn't necessarily proxied.
This CL makes the initialization logic synchronous when
Data Saver's UI and IO task runners are on the same thread.

BUG=461910

Review URL: https://codereview.chromium.org/1143503005

Cr-Commit-Position: refs/heads/master@{#330579}

R=lcwu@chromium.org
BUG=391045

Review URL: https://codereview.chromium.org/1142513004

Cr-Commit-Position: refs/heads/master@{#330578}

The lookup table for sniffing text/plain messages for binary characters
was 256 bytes in size. The information it encoded could be stored in 32
bits.

Use a 32-bit lookup table instead of the 256-byte lookup table. This
reduces binary size.

This change is mostly performance neutral; micro-benchmarks show
no statistically significant change on Android. Micro-benchmarks on
high-performance Intel processors show an additional cost of around
400ns, apparently due to branch mis-prediction.

However, real-world performance is likely to be dominated by the time taken to
load the table into CPU cache, which the new implementation should win
easily.

Also add a micro-benchmark test.

BUG=
TEST=net_unittests

Review URL: https://codereview.chromium.org/1058003005

Cr-Commit-Position: refs/heads/master@{#330577}

This CL
- Adds an unregister method to the remoting.WindowShape so that clientUI can unhook itself.
  This is a preparation work for the in-DOM reconnect window.
- Adds an centerToDesktop() method to center a DOM element to the union of desktop rectangle.

BUG=486888

Review URL: https://codereview.chromium.org/1143453007

Cr-Commit-Position: refs/heads/master@{#330576}

BUG=473205

Review URL: https://codereview.chromium.org/1147783002

Cr-Commit-Position: refs/heads/master@{#330575}

Flaky failures on the ChromeOS/MSan bot.

BUG=475516
TBR=xiyuan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1142963002

Cr-Commit-Position: refs/heads/master@{#330574}

When compiling Objective C, warns if a method is used whose availability is
newer than the deployment target.

BUG=471823

Review URL: https://codereview.chromium.org/1140423002

Cr-Commit-Position: refs/heads/master@{#330573}

This is not longer needed since we only guard the API under
_api_features. This extra guard is causing the test failures in officla
builds since extensions::ScopedCurrentChannel does not affect the
regular chrome channel settings.

BUG=489368
TEST=existing tests

Review URL: https://codereview.chromium.org/1131793011

Cr-Commit-Position: refs/heads/master@{#330572}

Tests various behaviors for the passphrase creation UI; specifically
when error messages are displayed and when submission succeeds.

BUG=480604

Review URL: https://codereview.chromium.org/1133453010

Cr-Commit-Position: refs/heads/master@{#330571}

This change is motivated by some complex test flakiness issues that were
discovered in http://crrev.com/1118833002. Making it impossible to store
a reference means that if we overwrite it for tests, we know everyone is
then using the overwritten version.

The approach here is to make every public method static and take the
context as an argument, so it can initialize the inner object if
necessary.

This CL is part 1/3 and leaves in deprecated versions of all the methods.
In part 2/3 the downstream uses of AndroidSyncSettings will be changed,
and in part 3/3 the deprecated methods will be removed upstream.

BUG=480604

Review URL: https://codereview.chromium.org/1138013008

Cr-Commit-Position: refs/heads/master@{#330570}

Review URL: https://codereview.chromium.org/1096303003

Cr-Commit-Position: refs/heads/master@{#330569}

Exclude techcrunch.com from power.top_25 . It is not suitable for this
benchmark because it does not consistently become quiescent within
60 seconds.

BUG=489214
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1138243003

Cr-Commit-Position: refs/heads/master@{#330568}

BUG=489779
TBR=jam@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1142093003

Cr-Commit-Position: refs/heads/master@{#330567}

BUG=466799

Review URL: https://codereview.chromium.org/1091363002

Cr-Commit-Position: refs/heads/master@{#330566}

This design is based on this mock: https://drive.google.com/a/chromium.org/file/d/0B-DVbqI3huZGZGhIcTFtRWRTSTA/view?usp=sharing

BUG=458664

TEST=
1. Launch chrome and make sure there is more than one available profile.
2. Left-click on the Avatar Button.
3. A tutorial bubble should be displayed informing the user they can
   right-click the button to see other users.
4. Close the bubble without dismissing the tutorial, for example by
   clicking in the content area.
5. Reopening the Avatar Menu should still display the tutorial until it
   is explicitly dismissed (clicking the X or the "Ok, got it!" button)
   or until the user right clicks the button.
6. Once dismissed, the tutorial should never be shown again.

Review URL: https://codereview.chromium.org/1120013003

Cr-Commit-Position: refs/heads/master@{#330565}

Do not let the invalidations service to fall back to XMPP if GCM is disabled, since we already finished traansite from GCM to XMPP, and XMPP do not have prepare for such load spike.
Since Sync have backoff mechanism, so if GCM server some how disabled, sync will retry it later.

BUG=479300

Review URL: https://codereview.chromium.org/1127393005

Cr-Commit-Position: refs/heads/master@{#330564}