GitLab

BUG=372607

Review URL: https://codereview.chromium.org/504773004

Cr-Commit-Position: refs/heads/master@{#291966}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506903003

Cr-Commit-Position: refs/heads/master@{#291965}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/500383003

Cr-Commit-Position: refs/heads/master@{#291964}

The icon is changed so it's more distinguishable from the 'locked' icon

BUG=405770

Review URL: https://codereview.chromium.org/508703002

Cr-Commit-Position: refs/heads/master@{#291963}

It was only used for GPU rendering on Windows XP, which is now blacklisted.

BUG=407177

Review URL: https://codereview.chromium.org/506633002

Cr-Commit-Position: refs/heads/master@{#291962}

This also makes the opus_demo app in the GYP build compile and link (which I discovered when tracking down why the GN version of this gives warnings).

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/507753002

Cr-Commit-Position: refs/heads/master@{#291961}

BUG=407750
TBR=hashimoto@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/508713002

Cr-Commit-Position: refs/heads/master@{#291960}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/501993003

Cr-Commit-Position: refs/heads/master@{#291959}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/509563002

Cr-Commit-Position: refs/heads/master@{#291958}

BUG = N/A

Review URL: https://codereview.chromium.org/505743002

Cr-Commit-Position: refs/heads/master@{#291957}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503883005

Cr-Commit-Position: refs/heads/master@{#291956}

Using const scoped_refptr<T>& is more efficient when passing a
scoped_refptr<T> to a function or returning a scoped_refptr<T> from an
accessor. It avoids the creation of a temporary scoped_refptr and
reduces refcount churn.

BUG=none

Review URL: https://codereview.chromium.org/467183003

Cr-Commit-Position: refs/heads/master@{#291955}

The HidConnection knows the appropriate read buffer size and the
platform-specific implementation may already have a buffer that it is
waiting to return to the next caller. Passing a buffer in is therefore
unnecessary, one can be provided in the callback.

By standardizing on a buffer format which always includes the report ID
as the first byte (even when it is zero) most of the buffer copying can
be removed except in the case of OS X's persistent read buffer and
getting feature reports on Windows.

BUG=

Review URL: https://codereview.chromium.org/499713002

Cr-Commit-Position: refs/heads/master@{#291954}

i.e. "chrome-extension://<id>" instead of "Chrome Dev Editor"

BUG=407451

Review URL: https://codereview.chromium.org/505073002

Cr-Commit-Position: refs/heads/master@{#291953}

Fixes the rest of the non-rtc and non-vpx linker errors for the chrome target.

BUG=
R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/505853003

Cr-Commit-Position: refs/heads/master@{#291952}

BUG=

Review URL: https://codereview.chromium.org/506103002

Cr-Commit-Position: refs/heads/master@{#291951}

ImagePainter is in an unnamed namespace, exporting it makes no sense.

Fixes
..\..\ui\views\painter.cc(187,15) :  error(clang): 'views::(anonymous namespace)::ImagePainter::ImagePainter' must have external linkage when declared 'dllexport'
ImagePainter::ImagePainter(const int image_ids[])
              ^
on the clang/win components bot.

BUG=82385
R=msw@chromium.org

Review URL: https://codereview.chromium.org/496123003

Cr-Commit-Position: refs/heads/master@{#291950}

This patch removes tiles from the recycle tree that were deleted from
the active tree as a result of a shifting live tiles rect. It is
important to do this, since if the active tree then would recreate
the deleted tile (ie, live tiles rect shift back), we have to ensure
that this tile will be shared when the next pending tree is created.
If we don't do it, we can run into a situation in which we will
continuously raster the same tile.

The patch does the following:
- Adds a way to get a recycled tree twin tiling.
- During LiveTilesRect tile deletion, deletes tiles from the same
  location from the recycle twin (if one exists).

R=danakj, enne

Review URL: https://codereview.chromium.org/502453003

Cr-Commit-Position: refs/heads/master@{#291949}

The Reset Settings section in Advanced Settings used to be hidden by
default, and then enabled if the profile was OffTheRecord. CL
https://codereview.chromium.org/467363003 changed this setting to be
hidden if guest mode is set, but did not ever remove the hidden flag.
Thus, it was only ever hidden.

In this CL the Reset Settings section is now visible by default. It
still gets hidden by guest mode.

BUG=407493

Review URL: https://codereview.chromium.org/505143002

Cr-Commit-Position: refs/heads/master@{#291948}

BUG=352290

Committed: https://chromium.googlesource.com/chromium/src/+/1218a23163baab9f53d70e9a63030db13ef04d04

Review URL: https://codereview.chromium.org/496873006

Cr-Commit-Position: refs/heads/master@{#291947}

Previous revision is 333. Revision 334 fixes a clang warning about
writing timestamps into strings with "%ld" on systems that use 64-bit
time. The fix is a static cast of the timestamp into long. This will be
fine until 2037.

TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/503383003

Cr-Commit-Position: refs/heads/master@{#291946}

BUG=403813
R=sadrul@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/502583002

Cr-Commit-Position: refs/heads/master@{#291945}

Avoids unnecessarily downloading data which will be unused.

BUG=400788
TEST=none

Review URL: https://codereview.chromium.org/485023003

Cr-Commit-Position: refs/heads/master@{#291944}

* Prevent accessing more arguments than provided.
* Fix application of vertex divisor for non-instanced draws in D3D9
* Fix swizzle formats being assigned incorrectly.
* MANGLE refactorings.

BUG=390111, 398337, angle:721

Review URL: https://codereview.chromium.org/493053006

Cr-Commit-Position: refs/heads/master@{#291943}

BUG=

Review URL: https://codereview.chromium.org/474013006

Cr-Commit-Position: refs/heads/master@{#291942}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/508683002

Cr-Commit-Position: refs/heads/master@{#291941}

This CL repairs a linker error which prevented us from checking in the full copresence implementation under Windows.

BUG=407466

Review URL: https://codereview.chromium.org/503253002

Cr-Commit-Position: refs/heads/master@{#291940}

I can't determine why we are seeing crashes in 	AppListItemList::AddItem
from inspection, so I am adding some more rigorous CHECKs in Release to
help track down the root cause. This shouldn't make the code crash more
often, just sooner and hopefully someplace where we can identify the
problem.

BUG=402357

Review URL: https://codereview.chromium.org/487853003

Cr-Commit-Position: refs/heads/master@{#291939}

Imagine the following:
(1) A user types a username, which matches saved credentials, so the password is autofilled.
(2) The user overwrites the suggested password in the password field.
(3) The user enters the username field again, but leaves it without changes.

Currently, the autofilled password after step 3 replaces the user-typed password from step 2.

This CL makes sure, that the password from step 2 stays.

BUG=385619

Review URL: https://codereview.chromium.org/414013003

Cr-Commit-Position: refs/heads/master@{#291938}

R=tbreisacher@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/490773005

Cr-Commit-Position: refs/heads/master@{#291937}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/509553002

Cr-Commit-Position: refs/heads/master@{#291936}

 (there was no leak reported because they're deleted upon shutdown)

A few minor cleanup/improvements
* Added shortcut to close athena. This doesn't update overview/split view mode.
  I'll address it in separate CL.
* Delete unnecessary athena_content_support_lib target. (I somehow missed this in review)
* Separate app_shell specific impl in extensions_delegate  (this is prep for athena+chrome)
* Remove ActivityWidget wrapper and use views::Widget instead, as it seems to be unnecessary. This is also prep for athena+chrome, where AppActivity should use NativeAppWindowViews.

BUG=None
TEST=coverted by unittests.
TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/498023003

Cr-Commit-Position: refs/heads/master@{#291935}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/501413003

Cr-Commit-Position: refs/heads/master@{#291934}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/505213002

Cr-Commit-Position: refs/heads/master@{#291933}

It's flaking with the same error that causes it to be disabled on other platforms.

TBR=bajones@chromium.org
BUG=373812

Review URL: https://codereview.chromium.org/502133006

Cr-Commit-Position: refs/heads/master@{#291932}

BUG=407342

Review URL: https://codereview.chromium.org/471763009

Cr-Commit-Position: refs/heads/master@{#291931}

App Store rules require shipping armv7s with arm64, so this is required
for the "both" configuration.

Also adds it to the 32-bit configuration so that local testing will
better match actual builds, but we can revisit if that turns out to be
onerous in practice.

BUG=407295

Review URL: https://codereview.chromium.org/489713003

Cr-Commit-Position: refs/heads/master@{#291930}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/501033003

Cr-Commit-Position: refs/heads/master@{#291929}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506633004

Cr-Commit-Position: refs/heads/master@{#291928}

Previously it put all toolchains' main link output into the root build directory, which doesn't work when there are multiple toolchains generating the same targets.

BUG=405686
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/502163002

Cr-Commit-Position: refs/heads/master@{#291927}