- 12 Aug, 2020 40 commits
-
-
Yifan Luo authored
This CL adds everything in TrustedTypePolicyFactory that changes were made to the spec that weren't reflected in the IDL tests description in `trusted-types.tentative.idl` test file. Change-Id: Iac7c68439a449d5437783daa7640ffcb1d3694a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290090 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#797337}
-
Marc Treib authored
This reverts commit dfb96619. Reason for revert: Likely made some Android tests flaky, see crbug.com/1115258 Original change's description: > Sync: Clean up remaining site of unnecessary deferred startup > > Followup to https://crrev.com/c/1989533 > > Sync supports delaying the engine startup by 10 seconds. This is meant > for avoiding contention during browser startup. > Before this CL, the 10-second delay would also apply in one other > (rare) situation, for no good reason other than some tests depending on > this behavior. Two of these tests were recently fixed (in > crrev.com/c/2339986), and the one remaining one is fixed in this CL. > With that, the delayed startup can now go away! > > Bug: 1035874 > Change-Id: I865d0bc3caac4d8f0712489ccbad526f912ccdce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343036 > Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796819} TBR=treib@chromium.org,mmoskvitin@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1035874, 1115258 Change-Id: Idde272bf1bd4325160346bd5d74c49bdf3f384a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352909Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#797336}
-
Ting Shao authored
This change implements the FetchEvent.handled API which gives developers the ability to intercept when the event is handled. Chrome Status: https://chromestatus.com/features/5654467158474752 Bug: 1039558 Change-Id: I8033d85d57ea6c331401006789713c0cb899aeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114932 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#797335}
-
Jeffrey Young authored
Set height of radio button to 100% to capture click events. BUG=b:162456206 TEST=click on top pixels of ambient mode photo gallery radio button Change-Id: I5a536e903768e606e29fef6658c9733549f53bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351553Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#797334}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5697d3550bc8..09afd88dfed8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie415008a41412c66f09bd3eefc63c1b471d6869f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797333}
-
Nick Burris authored
To run an origin trial, we need a UseCounter metric that simply counts every time the API is used. This patch adds a use counter to count when the payment request API is used with the "secure-payment-confirmation" payment method. Bug: 1110320 Change-Id: Ie72a3fbd27c7928e858d8e7b8f059dd915af3bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350247 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797332}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/51d97b104f79..fc2bd2179672 2020-08-12 sigurds@chromium.org Offer to filter for offending request for error pages 2020-08-12 szuend@chromium.org [ts] Type-check ui/HistroyInput.js with TypeScript 2020-08-12 szuend@chromium.org [ts] Type-check ui/Glasspane.js with TypeScript 2020-08-12 jacktfranklin@chromium.org Rename newBreadcrumbs => breadcrumbs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093247 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I663e858feabb55290e2bfff17363c243abf8182d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352366Reviewed-by:
-
David Maunder authored
We should only acquire Title if the Tab is initialized. Now with some attributes such as Title being moved to UserData objects we enforce this. Bug: 1114564 Change-Id: I876603c4126a24a1e6e8579f90cf7beb32e9871b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352511Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#797330}
-
Elly Fong-Jones authored
These tests were asserting that, when Views damages a specific rect within the BridgedContentView, AppKit was propagating the damaged rect all the way back to [BridgedContentView drawRect:]. There are two issues with this: 1) BridgedContentView does not implement drawRect:, and 2) Since BridgedContentView is layer-hosted AppKit is not supposed to track damage to it and is *supposed* to always call drawRect: on the entire thing It appears that AppKit in <= 10.15 did bother to track the damage and invoke drawRect: only on the damaged area even for layer-hosted views, presumably as an optimization for misguided code that was improperly using layers. As of 11 AppKit does not do this, so the test (which was asserting behavior that was both incorrect and irrelevant to us) is broken. This change deletes these tests. Bug: 1114240 Change-Id: I22ede812cdf98707cc22bca1238f59856a371d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352431 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#797329}
-
Matthew Mourgos authored
This change ensures that circular icons are scaled down when needed so that they do not exceed a maximum size relative to the size of the bitmap. Before this change, when circular icons were standardized they are returned without any changes, even when the size of the icon is too big. Also in this change is an additional unittest, to ensure that a large circular icon is scaled down to the maximum size when standardized. Bug: 1110496 Change-Id: I032da9422d078db8ae8e5d1d1198c8e12f3dec76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347318Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797328}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e99b9be0afe..5192b234de64 2020-08-12 ddoman@chromium.org [resultdb] bump up the cipd pin of rdb in depot_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1113089 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I7f7aafc41c8dc20c3d55aac380a1ca892a0f2c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351750Reviewed-by:
-
Danil Chapovalov authored
it is ignored by webrtc Bug: webrtc:6471 Change-Id: Ia6a5b0b09b220e90c7481b3a67894e2fb85fde81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346327 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#797326}
-
Aya ElAttar authored
Bug: 1092469 Change-Id: I4a405c8642bbb78a59bd3681178e372cc2a56cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348772 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#797325}
-
Boris Sazonov authored
Even though ChromeBackupAgent no longer gets the sign-in account from ChromeSigninController, it still uses ChromeSigninController.SIGNED_IN_ACCOUNT_KEY as the key to store the email of the signed in account. This CL moves this key to ChromeBackupAgent. The value of the key is preserved for backward compatibility. Bug: 1046412 Change-Id: I4c49a406f474348471de2f27c67c6e4ac2c523f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339457Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#797324}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09afd88dfed8..dfa133b7b48c 2020-08-12 treehugger-gerrit@google.com Merge "Adds protos for memory dump." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7ed224c37a65e5a48601007143a37807e35ec33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352364Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4451adcce85..09afd88dfed8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie5797dff15ff24ee6094c14fe82bbb332243e2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351284Reviewed-by:
-
Himanshu Jaju authored
Marks the incoming transfer as started / complete depending upon the status of the transfer metadata. Bug: 1085068 Change-Id: Ie29a294d86b8bd9b05d63d8a11e713cac53f570a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350421 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797321}
-
Stephen McGruer authored
This reverts commit d43884e1. Reason for revert: Tentative revert for https://crbug.com/1115595 . I'm not very confident in this being the suspect - will be monitoring whether the revert works and will re-land (with my apologies) if it doesn't. Original change's description: > [SH-Blink] Create TextFragmentSelectorGenerator with page. > > Create TextFragmentSelectorGenerator with page and set selection > information when context menu is shown. > This is done so that Java code can just call the GenerateSelector > function without any arguments and generation can happen for the latest > selected text. > > Follow-up CL > https://chromium-review.googlesource.com/c/chromium/src/+/2341662 > will connect to browser-side component. > > Bug: 1102382 > Change-Id: I5574f5b40e5a74bef56698e2de5a9b1fea17e0d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340734 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797256} TBR=yosin@chromium.org,bokan@chromium.org,gayane@chromium.org Change-Id: Ifd4a62cf42088da87227611655e3620d1148022a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102382, 1115595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351963Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797320}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/780679454319..d7b09c4c3acf 2020-08-12 johnstiles@google.com Guard gencode dumpInfo() calls with GR_TEST_UTILS, instead of SK_DEBUG. 2020-08-12 jmbetancourt@google.com implement and test basic playback features for SkottieView 2020-08-12 johnstiles@google.com Remove dumpInfo() entirely when GR_TEST_UTILS is off. 2020-08-12 johnstiles@google.com Guard dumpInfo() calls with GR_TEST_UTILS, instead of SK_DEBUG. 2020-08-12 johnstiles@google.com Reland "Implement `dumpInfo` for .fp files." 2020-08-12 johnstiles@google.com Add AutoDisableInline helper class to SkSLIRGenerator. 2020-08-12 johnstiles@google.com Update the IRGenerator's referenced intrinsics to use unordered_set. 2020-08-12 robertphillips@google.com Make the GrSmallPathAtlasMgr a flush-time object 2020-08-12 brianosman@google.com Revert "Implement `dumpInfo` for .fp files." 2020-08-12 michaelludwig@google.com Apply correct matrix to correct points in GrDashOp 2020-08-12 johnstiles@google.com Implement `dumpInfo` for .fp files. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408,chromium:1113794 Tbr: fmalita@google.com Change-Id: I99e65eb427eb4fcd67d6525998aba79a69b2edc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352367Reviewed-by:
-
Wei Lee authored
Without this CL, when enabling #zero-copy-video-capture flag on devices such as Elm, the camera preview cannot show and an error message complaining that YUV_420_BIPLANAR format is not supported will appear in the logs. Bug: 982201 Test: Enable #zero-copy-video-capture and camera preview show normally Change-Id: I5e4b40cabcf5340097e22a8141053adad95a5645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338276 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#797318}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2d9546d5..75a11031 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6af1f50848f72799acc5f8392a08fea6f6aaab26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351551Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797317}
-
Charlene Yan authored
Bug: 1111874 Change-Id: I98b17f7240e6434697c9d697fadc89861d788d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347889Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797316}
-
Chris Sharp authored
Bug: 1115511 Change-Id: Idc0c4fef58ec3338157e11488cdba8d9ea87e434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351552 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#797315}
-
Kartik Hegde authored
Add a routine to test whether the active network is trapped in a captive portal. BUG=chromium:956783 TEST=unit_tests --gtest_filter=CaptivePortalRoutineTest.* Change-Id: I503920315f8f1ccd4e367373b0ac04f13f3b997e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236099 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797314}
-
Matt Jones authored
Bug: 1115568 Change-Id: I25754474e7a7600e15987c680880b3e752644218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351376 Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797313}
-
Mathias Bynens authored
As part of a DevTools CL [1], we expose decoded X-Client-Data HTTP header values as code in a format similar to the proto definition. Since we want to include comments in that user-visible output, there is a desire to match the comments in the source. This patch tweaks the comments in the source to align with the desired UI strings (slightly shorter, and using active voice). [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2351775 No-Presubmit: true Bug: chromium:1103854 Change-Id: Ic128e0289559ab95c6e293dbcd15aead7cebe6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351928Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#797312}
-
Guillaume Jenkins authored
The system's shared URL loader factory wasn't set as trusted, probably because no desktop shared code required it so far. With iOS CBCM, some network requests built by shared desktop code have TrustedParams set, and this requires the URL loader factory to be marked as trusted. Bug: 1066495 Change-Id: I20c557ddfc99c19ffb25931ebde557eb5125e33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346848Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#797311}
-
Joanmarie Diggs authored
* Fire "row-reordered" when the rows are reordered due to aria-sort changing on a column header. * Fire "column-reordered" when the columns are reordered due to aria-sort changing on a row header. Note that there is no AtkObject signal for object attributes changing. But the sort order can be obtained from the focused header in response to the reordered signals. Bug: 1074417, 1074380 Ax-Relnotes: Orca now announces when the sort order changes in a table. Change-Id: Ie5b168af9189d903569bb2db3eb9b4e9548765f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339749Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#797310}
-
Michael Giuffrida authored
Extends Demo Mode histograms to M92 since Demo Mode is still in use and under active development. Also replaces owners who have left the project, adding drcrash@ and cros-demo-mode-eng@google.com instead. Bug: 1104931, 1104932, 1104933 Change-Id: I13c8e43ae308bdbdf01b72ccbdccc4e09a624947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314879Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#797309}
-
Piotr Pawliczek authored
This patch removes an obsolete fuzzer that checks operations on URI set in PrinterConfiguration objects. Currently, these functionality is tested by a fuzzer created for Uri class. BUG=chromium:1106355 TEST=none Change-Id: I0dd973d8c9626026e52495e6435d0d16a1e701dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305215 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#797308}
-
Gauthier Ambard authored
This CL removes the content of the error pages to avoid flag when loading it. Bug: 991608 Change-Id: I7600d091705f930e6115246496f47e21a09e197b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352870 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#797307}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d56f379356d9..9f3ce85bab94 2020-08-12 omerkatz@chromium.org heap: Add ServiceWorker threads to gc metrics. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986235 Tbr: sadrul@google.com Change-Id: I31db620c74d602b653f96e808a32f2c45ab0211a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352360Reviewed-by:
-
Mark Yacoub authored
Use std::make_unique instead unique_ptr(new). Use '= default' to define a trivial default constructor. BUG=1082882 TEST=drm_overlay_validator_unittest,drm_window_unittest,screen_manager_unittest. Change-Id: I6ee0b6ff923d7134348d2a6d103c1acae48da9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352850 Auto-Submit: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mark Yacoub <markyacoub@google.com> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#797305}
-
Becca Hughes authored
Also fixes a bug in RelList::ValidateTokenValue where || was used instead of &&, causing <something that happened, presumably incorrectly>. BUG=1053599 Intent-to-Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/OXZLwImwdbc/m/ltULzqsAAgAJ Change-Id: I32efa63c43fdb5ca641e8afae3c49f42d9013f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341934 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Ali Juma authored
This extends the expiry of safe-browsing-available from M85 to M87. The feature has not yet been enabled at 100%, so having an about:flags entry is still useful for testing. Bug: 1028755 Change-Id: I9385c83af0f2b759f6bf89f96b062c11ab6fbe2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351958 Auto-Submit: Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797303}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5245bcfaf6a9..bca9dcdf05aa 2020-08-12 yupingso@chromium.org flash-ap: Create private key file with mode 0600 2020-08-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-12 allenwebb@google.com lib/portage_util: Improve GetPackageDependencies 2020-08-12 gbiv@google.com toolchain_util: make `_CollectFiles` respect subdirectories 2020-08-11 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I58b85338cb1e213c57837dd2c10701733ddb33d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352359Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebc115d9852c..f7f46a7432a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: smcgruer@google.com Change-Id: Icacc3464a79fd3aa2325507ca08a6c62c139c5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797301}
-
Alice Wang authored
This CL adds an empty WebSigninBridge.Listener implementation to AccountPickerDelegate and a WebSigninBridge field to the delegate class. Bug: 1102784 Change-Id: I66f135e2b61f949122ee30582548ce2dbf5fb29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346572Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797300}
-
Sammie Quon authored
We will be adding more to it soon, so move it out of DesksController. No functional change. Test: none Bug: 1111445 Change-Id: I1c557c687d8508c844c0fc50c038ebc9d3258ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347199Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#797299}
-
dizg authored
Bug: 1105865 Change-Id: Id95b06b84c36ba6824d83637a3c7b615bbed9f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341131 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797298}
-
