GitLab

This is intended as a temporary fix since the current commit
position for version 62 points to a revision that is actually
listed as 63.

Bug: 
Change-Id: I9aa73ac1e9f9712b84893c08e7d8c07d333df3ab
Reviewed-on: https://chromium-review.googlesource.com/806762Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521491}

It had a custom implementation to support use of RawResourceClientStateChecker.
Separate these.

The original version (https://chromium.googlesource.com/chromium/src/+/ae15c13530084329ac2509ccded45428d7d7d2c8)
failed to update DocumentThreadableLoader::Trace(). It introduced an intermediate
subclass, ResourceOwner<RawResource>, between DocumentThreadableLoader and RawResourceClient, but
because Trace() wasn't updated, ResourceOwner::resource_ was left untraced. The GC clang plugin
would normally catch a mistake like this, but the plugin ignores ResourceOwner due to
https://crbug.com/652966, so it wasn't detected at compile time.

Bug: 790778, 640291
Change-Id: I114df7eaa97139fbb6aa70b22b2f41019988631f
Reviewed-on: https://chromium-review.googlesource.com/806753
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521490}

These tests flake under Fuchsia, suggesting that the ordering of NetLog
events assumed by the tests may not always be valid, e.g. due to
concurrency in resource delivery over QUIC. The additional EXPECTations
will cause more detail to be reported about what was actually NetLog'd.

The tests are also renamed to better express their purpose.

Bug: 775122
Change-Id: Ia1c8aa898d27db2faafd2e79d705b724a7704843
Reviewed-on: https://chromium-review.googlesource.com/806760Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521489}

According to the mock, separators should go between sections, not items.
This CL fixes the style according to the mock.

Given that this changes the UI of the app, it might be better to check in
this after the M64 branch point.

Before: https://drive.google.com/a/google.com/file/d/1cosHV0dLNdIraqZCQhE0M0La9b6fDn6B/view?usp=sharing
After: https://drive.google.com/a/google.com/file/d/1s_ZtlUMztnkr-QdU1-04ssxw-m2iLXHH/view?usp=sharing

Bug: 786616
Change-Id: If4975398b7fd0da0a0884ee4b009c3098f05de42
Reviewed-on: https://chromium-review.googlesource.com/783817
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521488}

Currently at HEAD when I run test-webkitpy I get a couple of
extraneous debug logs which contain:

Generating grammar tables from /usr/lib/python2.7/lib2to3/Grammar.txt
Generating grammar tables from /usr/lib/python2.7/lib2to3/PatternGrammar.txt

The purpose of this CL is to prevent test-webkitpy from
logging this to stderr.

Change-Id: Ica515a4f03f184cc1c3f91b6179de9317591c0bc
Reviewed-on: https://chromium-review.googlesource.com/807165Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521487}

https://webrtc.googlesource.com/src.git/+log/83d27683a83d..31cee3a0d51e

$ git log 83d27683a..31cee3a0d --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None,None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idbcb75f5fe9f49ddb5b3f8718dbfe8b2dfb698a3
Reviewed-on: https://chromium-review.googlesource.com/806321Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521486}

https://chromium.googlesource.com/catapult.git/+log/a12fb2d1ad96..cb907fe1fd1b

$ git log a12fb2d1a..cb907fe1f --date=short --no-merges --format='%ad %ae %s'
2017-12-04 simonhatch Dashboard - Route bisects to Pinpoint for windows bots.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I102bb172b6dbee15b2a135a5ba561ba274db68d3
Reviewed-on: https://chromium-review.googlesource.com/806881
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521485}

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I96565fa693ae9598636927c953abfd68c57359d4
Reviewed-on: https://chromium-review.googlesource.com/801777Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521484}

This CL fixes an issue with the page history. If an extension is removed
and the user tries to navigate back to the details page for that
extension, they may get caught in a loop (unable to go back). This CL
will navigate back or replace the history element (there are two different
cases: removing an extension from the details page; or navigating to an
invalid extension ID).

FYI, the case where the extension is removed from the main list page is
not affected (it doesn't have the issue).

Bug: 789891
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I45eb0f2917452da55e0e07c67356e24ae5bd56bb
Reviewed-on: https://chromium-review.googlesource.com/801975
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521483}

Check if the histogram is null before adding an entry to it.

Bug: 776579
Change-Id: I77049905fa5953cdf52d5438fa7ea15385877898
Reviewed-on: https://chromium-review.googlesource.com/806879Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521482}

Note that the signature of InstallUpdate is changed to match with
CrxInstaller::InstallUnpackedCrx.

Bug: 722942
Change-Id: I789c6277458447976d24aa7ba5dcced670c8cc11
Reviewed-on: https://chromium-review.googlesource.com/765095
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521481}

Some tests fail because network service URLLoader currently doesn't support
download_to_file.

TBR=jam@chromium.org
BUG=791702

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I988be3a0416fa034d63bf55c47f71e8d20902c59
Reviewed-on: https://chromium-review.googlesource.com/806752Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521480}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ad64abd69aed..b278ddd93923

$ git log ad64abd69..b278ddd93 --date=short --no-merges --format='%ad %ae %s'
2017-12-04 myjang [presubmit] Remove line

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: Idca5d12e96bb4a3c156f449b7554439529337fc2
Reviewed-on: https://chromium-review.googlesource.com/806438Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521479}

This CL is preparation for onion souping of WebClipboard.

It moves public enum types from WebClipboard into a mojom file
defined in WebKit/common.

The clipboard mojo interface is then changed to use these enums
rather than the type defined in ui/base/clipboard.

Typemaps for clipboard_format and ui::ClipboardType have been
removed as we no longer use these types in the mojom, and
it will make it simpler to move the files around. We may
add type-mapping back in when we've removed WebClipboard.

Code that previously converted from WebClipboard::Buffer to
ui::Clipboard has been moved to the browser side, on the
renderer side we still check that the Buffer type is valid,
but we no longer do the conversion.

The ultimate goal is to replace WebClipboard with the mojo
interface.

Bug: 775830
Change-Id: I2cf4e7fc771dd66c4b6ec95abc7d131686683d52
Reviewed-on: https://chromium-review.googlesource.com/804774Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521478}

This reverts commit f7eb8650.

The msan build failure has been addressed:
https://chromium-review.googlesource.com/c/chromium/src/+/806634

Original change's description:
> Reason for revert: Broke linux msan builder:
> https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/7457

BUG=783519

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

R=tomfinegan@chromium.org,dalecurtis@chromium.org

Change-Id: I720447e099700e1bce0868590d31943beb370643
Reviewed-on: https://chromium-review.googlesource.com/806875Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#521477}

This change tries to address the perf regression reported for
createImageBitmapFromImageData canvas perf test. This change performs
the premul operation in ImageData in advance, instead of doing that after
creating the ImageBitmap. This has resulted in ~60% perf improvement
on the local Linux machine, so it hopefully must address the regressions.

Bug: 782813,787772,787811
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If0f02d99677348d49cc9d16e910113b4250afb69
Reviewed-on: https://chromium-review.googlesource.com/802855Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521476}

Allow mousedown to prevent default the back/forward actions. This feature
is controlled via the ExtendedMouseButtons feature flag which is by
default disabled. Since the button events aren't sent from the browser
when the feature is off the blink code doesn't require a feature flag
since it won't be executed.

Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/3DjSQKQzKz8/FI9qbxHhAwAJ

BUG=680741

Change-Id: If9a59fbb085104b26d25e050f1ca7349756b102b
Reviewed-on: https://chromium-review.googlesource.com/781999
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521475}

Bug: 789190
Change-Id: I1f1b2546d126ad35e27bd977e17b295477e10938
Reviewed-on: https://chromium-review.googlesource.com/795011
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521474}

Using the Length store directly should work fine most of the time, and
avoids the fairly bloaty Length copy constructor and destructor pair.

Some minor massaging of ValueForPositionOffset required, but otherwise
straightforward.

Change-Id: I1b1d0b14f3897fc4173eab123cc3b241b28c70d3
Reviewed-on: https://chromium-review.googlesource.com/806834Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#521473}

We have not supported valgrind for some time (it was never ported to
the GN build IIUC, and has been obsoleted by ASan/MSan/TSan).

Followup to https://chromium-review.googlesource.com/c/chromium/src/+/778881

BUG=791518

Change-Id: I3a03f033263e6477eddcc683b986635b6ff2c963
Reviewed-on: https://chromium-review.googlesource.com/805994
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521472}

Change-Id: I36b10c7b37e0340c02e9106aec0ae94eaec864a2
Reviewed-on: https://chromium-review.googlesource.com/804737Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521471}

It's an anti-pattern to have "using" for a namespace that contains
methods that the code depends on.

Bug: 678368
Change-Id: Icbfbceb35c2384fd6ae20c187d579f1df7913a90
Reviewed-on: https://chromium-review.googlesource.com/803619Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521470}

That callback is going away as it's not compatible with network service. Plumb information about subresource responses starting from the renderer to WebContents instead.

A followup will undo much of the code added in r519351 after this.

Bug: 783981
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id04381daa669cb2ac05dcf0f5d7d890960c6c06b
Reviewed-on: https://chromium-review.googlesource.com/804947Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521469}

This change moves the IDL tests that do not use bluetooth_test
into the wpt directory.

BUG=509038

Change-Id: I6bced22bf6b14dd2581977a73ce0220a31dd4fe6
Reviewed-on: https://chromium-review.googlesource.com/804817
Commit-Queue: Ovidio Henriquez <odejesush@google.com>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521468}

This CL is the fifth CL of implementing OfflinePageModelTaskified.
It contains:
- Hooking up consistency checks for temporary and persistent pages.
- Related tests.
- Updating temporary and persistent consistency check tasks to make
  them more similar in implementation.

Bug: 753595
Change-Id: I7200ea8fbdcfb3f6914c494d0bc060504774a67b
Reviewed-on: https://chromium-review.googlesource.com/786820Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521467}

This bug was unmasked by this CL that re-enabled overdraw
optimizations in GPU-accelerated 2D canvas:
https://chromium-review.googlesource.com/c/chromium/src/+/800750

Crash happens on configuration that do not support the sync query
extension.

BUG=791608

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0da7be2f305d61881ba57d999329de2864d68ca5
Reviewed-on: https://chromium-review.googlesource.com/806678Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521466}

The UI theme images will miss color conversion caching, resulting in
repeated conversions and poor performance.

Bug: 769677
Change-Id: Icfeafb9c9418cf03bfbfaae62cf98c5ad07e0f6d
Reviewed-on: https://chromium-review.googlesource.com/806641Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521465}

https://pdfium.googlesource.com/pdfium.git/+log/0ddd5dc79696..cef20d4b2ff1

$ git log 0ddd5dc79..cef20d4b2 --date=short --no-merges --format='%ad %ae %s'
2017-12-04 thestig Simplify code in CFX_ImageTransformer.
2017-12-04 thestig Refactor CFX_ImageTransformer down sample calculations.
2017-12-04 thestig Refactor CFX_ImageTransformer bicubic calculations.
2017-12-04 dsinclair Remove SetResultCreateNode
2017-12-04 thestig Refactor CFX_ImageTransformer bilinear calculations.
2017-12-04 dsinclair Remove CXFA_ValueArray
2017-12-04 dsinclair Cleanup ResolveObjects params and return
2017-12-04 dsinclair Cleanup CFXJSE engine and resolve processor

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I609f4022c510b4cd37641a3ec78d9a12a686e8c8
Reviewed-on: https://chromium-review.googlesource.com/806322
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521464}

It's not used.

Bug: 733662
Change-Id: I3b69a62a9a53a2a732bc0ed461d593ab119cdddd
Reviewed-on: https://chromium-review.googlesource.com/806747Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#521463}

Bug: 599906
Change-Id: I6fba5554875a98f8f4e5e531891be62a18fff4c9
Reviewed-on: https://chromium-review.googlesource.com/803664
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521462}

Bug: 773747
Change-Id: I01059b4f7e5b64821b2215136f217cf175d2160c
Reviewed-on: https://chromium-review.googlesource.com/804148Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521461}

After additional discussion, it was decided that the texture should
remain a private implementation detail rather than exposed class. This
keeps the UI on track to have element render themselves directly, rather
than through separate classes.

BUG=
R=vollick

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iee191543884cda51605356da7215ec3c036c5734
Reviewed-on: https://chromium-review.googlesource.com/806575Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521460}

Change-Id: I76cccbcbf245d7dddf586f03f99360004431e738
Reviewed-on: https://chromium-review.googlesource.com/806636
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521459}

Callbacks and mocks that are called on the media thread but act on the
Pipeline must post that work.

This CL fixes the cases where pipeline_integration_fuzzertest.cc calls
test->FailTest() from callbacks.

Bug: 790959
Change-Id: Iecfdb095dd9d213deffa24f44790b0617ace371a
Reviewed-on: https://chromium-review.googlesource.com/804494
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521458}

The passthrough command decoder has slightly different behavior than the
validating command decoder, as they go through different ANGLE functions
(glBlitFrameBuffer vs. glBlitFramebufferANGLE).  This means that
passthrough doesn't support GL_LINEAR interpolation mode, and is more
strict about color formats.

The immediate fix to unblock WebVR is to use compatible buffer format,
and use GL_NEAREST.  A subsequent change (crbug/790033) will reconcile
the two behaviors to ensure consistancy.

BUG=790785

Change-Id: I0ac98a923168823f9e6618fef9d6e6e0e974c777
Reviewed-on: https://chromium-review.googlesource.com/802244Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521457}

Using Length::IsAuto() is more efficient (and generates significantly
less code) than constructing a new Length and comparing with that.

Also replace some open-coded "is auto" checks with said method, and
simplify the surrounding code a bit.

Change-Id: I974a28a0eef969b56557428eb019f7cf1dac18c1
Reviewed-on: https://chromium-review.googlesource.com/806170Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#521456}

Adding GetLastFileError() allows a base::File user to know the reason
for an API failure. Previously the only error code that could be
retrieved was by calling error_details after a failed open attempt.

This method is similar to using errno or Win32's GetLastError(),
and must be called immediately after the failed function call.
Also, similar to the POSIX errno contract, base::File functions
do not set errno=0 (or call SetLastError(ERROR_SUCCESS)).

Bug: None
Change-Id: I659b6963277b2b999019ad791275bf4fb7807909
Reviewed-on: https://chromium-review.googlesource.com/803736Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521455}

Devtools was not correctly handling input that is not generated by itself
and invoking callbacks when the input wasn't actually processed.

Add a modifier indicating content was injected using the debugger so that
we can then query for that to determine if we should release the event.
This is a stop gap solution until we can actually bind callbacks into the
sending of events and devtools wouldn't need its own queues of callbacks.

BUG=789869

Change-Id: I2b56e8ebf4921b48bd4d35dee2226d7cb780cb94
Reviewed-on: https://chromium-review.googlesource.com/804357
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521454}

Continuation of http://crrev/c/802464 to test that Active, Inactive,
and Background application states are interpreted correctly.

Bug: 781361
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie86cfca571e8e0a4159a591d0d357a3458384483
Reviewed-on: https://chromium-review.googlesource.com/802618Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521453}

TBR=dcheng

Bug: 789374
Change-Id: I68d41425e0cf376d1346546268fac60bd9a6dc3c
Reviewed-on: https://chromium-review.googlesource.com/807184Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521452}