- 04 May, 2018 40 commits
- 
- 
jonross authoredForegroundedOrClosedTest.SingleTab has started to flake on ChromeOS. This disables the test until the cause can be found. TEST=ForegroundedOrClosedTest.SingleTab TBR=fdoray@chromium.org Bug: 839886 Change-Id: I650bc975a9e4795218eb205a628d3c604f7fcdcf Reviewed-on: https://chromium-review.googlesource.com/1044533Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#556112} 
- 
Khushal authoredWrap up the checkerimaging finch trial and make checkerimaging an opt-in only feature used if an image has async=true specified. R=chrishtr@chromium.org, piman@chromium.org Bug: 728273 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d452ddce51e063f8769523694236b9e20632b4b Reviewed-on: https://chromium-review.googlesource.com/1041147Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#556111} 
- 
Lindsay Pasricha authoredBug: 826341 Change-Id: Ifd2630580efceffab3b73e617e031c32a3a1be13 Reviewed-on: https://chromium-review.googlesource.com/1040947 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#556110} 
- 
Varun Mohan authoredThis refactor was done to allow for greater granularity for internal LifecycleUnit state representation. Change-Id: I27c20eec8e5fe7f1365b64fe87b32cfdf124fbb8 Reviewed-on: https://chromium-review.googlesource.com/1041010 Commit-Queue: Varun Mohan <varunmohan@google.com> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#556109} 
- 
Lei Zhang authoredChange-Id: I042880a6b33e52f88f31f2b4c1dce44ad71677f1 Reviewed-on: https://chromium-review.googlesource.com/1043653Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#556108} 
- 
Ethan Kuefner authoredThis is the One-BuildBot-Step version of this change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1038751 It will be safe to land once https://chromium-review.googlesource.com/c/catapult/+/1029170 rolls into Chromium. Bug: catapult:#4397 Change-Id: I2358970703782a2d09940e580d7e8b06ea910726 Reviewed-on: https://chromium-review.googlesource.com/1038783Reviewed-by: Simon Hatch <simonhatch@chromium.org> Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#556107} 
- 
Qiang Xu authoredChanges: Design doc: go/arc-app-shortcuts Launch app shortcut has to be called by Android's LauncherApps' startShortcut API. Thus provide a mojo API to do the work. Bug: 803291 Test: tested on device with ag/3997639 Change-Id: Idece1c44836a9e43932b700b81d128883c15666d Reviewed-on: https://chromium-review.googlesource.com/1041574 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556106} 
- 
Lei Zhang authoredIt always returns true. Change-Id: I25fee275c7c970dceb00dc13bd74abf1e72cea26 Reviewed-on: https://chromium-review.googlesource.com/1043053Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#556105} 
- 
Lei Zhang authoredSimplify some code too. Change-Id: I94dbf05f1090ee7d3ecd88e8e6ef7edd778494c2 Reviewed-on: https://chromium-review.googlesource.com/1043361Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#556104} 
- 
Gabriel Charette authoredFollow-up to v8 CLs: - https://chromium-review.googlesource.com/c/v8/v8/+/941946 - https://chromium-review.googlesource.com/c/v8/v8/+/941442 - https://chromium-review.googlesource.com/c/v8/v8/+/941944 - https://chromium-review.googlesource.com/c/v8/v8/+/1033584 - https://chromium-review.googlesource.com/c/v8/v8/+/978443 This will make Platform::CallBlockingTaskOnWorkerThread() actually result in a high-priority task which is expected to help blocking parallel GC tasks get ahead of other async work. And allow removal of deprecated "background threads" APIs in v8::Platform. Bug: 817421 Change-Id: Idb7f369538c23c9b065d90cc5ed48300a5c9724c Reviewed-on: https://chromium-review.googlesource.com/957761Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#556103} 
- 
Peng Huang authoredIn future, SkiaRenderer will only use SkDDL to draw frame, and the SkiaOutputSurfaceImpl will handle vulkan related stuff. So the SkiaRenderer doesn't need to know vulkan anymore. Bug: 838899 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id611e02b4e20c318e202927fa6de8f9e548f4b81 Reviewed-on: https://chromium-review.googlesource.com/1039685Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#556102} 
- 
Rohit Rao authoredIf the bookmarks UI was displayed before the BookmarkModel was done loading, we would incorrectly cache a pointer to a BookmarkNode that had been destroyed. Instead, do not set the root node of the BookmarkHomeViewController until after the model has finished loading. BUG=839883 TEST=See repro steps in bug. Displaying the Bookmarks UI immediately upon startup should not crash. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I062171c6d588da6be666b92e0c961abb90f1af17 Reviewed-on: https://chromium-review.googlesource.com/1044353Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556101} 
- 
Robert Phillips authoredThis will permit a later cl to remove this flag and update the cc_unittests LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets at the same time. Bug: skia:7765 Change-Id: Ibd631f0d2fa503f452d799a59d75bbcbb79268a4 Reviewed-on: https://chromium-review.googlesource.com/1044113Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#556100} 
- 
khmel@google.com authoredTest: Manually Bug: 836266 Change-Id: I90ffbc6222d0af85c307eda29974156e9ff314bd Reviewed-on: https://chromium-review.googlesource.com/1043485Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556099} 
- 
Eugene But authoredPreviously Download Manager used NamedGuide instead of ivar. Named guides suppose to be used to pass the guide across the different layers of UI. In this case storing UILayoutGuide in ivar is sufficient. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8937900fdfcbbbe906a586cf206fd2c42317c70e Reviewed-on: https://chromium-review.googlesource.com/1040266 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556098} 
- 
David Black authoredPreviously, rendered cards had margins so no padding needed to be applied by the embedding view. Internal margins have been removed from cards so it is now up to the embedding view to apply padding if needed. See before/after in bug. Bug: b:79214709 Change-Id: Ia173c97a955f7391d71e84fcd1859fea5d5f2cb1 Reviewed-on: https://chromium-review.googlesource.com/1043450Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#556097} 
- 
Jonathan Ross authoredhttps://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/49396 Revert "Add chrome enterprise logo in the theme_resources.grd" This reverts commit 86dafb90. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add chrome enterprise logo in the theme_resources.grd > > The logo is located in > default_100_percent/google_chrome > default_200_percent/google_chrome > > Bug: 838156 > Change-Id: Id300ef64e70cdc92bcdbad89b5aad00bc5bbd777 > Reviewed-on: https://chromium-review.googlesource.com/1042491 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556093} TBR=zmin@chromium.org,grt@chromium.org Change-Id: I70621ad525fd9a1c2ced334ba35ab4d48c731f1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838156 Reviewed-on: https://chromium-review.googlesource.com/1044685Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#556096} 
- 
sebsg authoredIt was a run-once routine and has landed around 10 months ago. Bug: 619589 Change-Id: I735c8ced77c610af6a0bfc890c0a85d540f06714 Reviewed-on: https://chromium-review.googlesource.com/1042928Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556095} 
- 
Scott Violet authoredThis patch makes Ash, when run with ash_shell_with_content, start the WindowService. It also forces quick_launch to start to make sure something can be displayed. Lastly, I moved what was EmbeddedAshService to ash. I would like to make ash create this as well. BUG=837689 TEST=most of this change doesn't effect production code Change-Id: Ia9f651b16a94d5db07dd5dc17e0619c442685597 Reviewed-on: https://chromium-review.googlesource.com/1043392Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#556094} 
- 
Owen Min authoredThe logo is located in default_100_percent/google_chrome default_200_percent/google_chrome Bug: 838156 Change-Id: Id300ef64e70cdc92bcdbad89b5aad00bc5bbd777 Reviewed-on: https://chromium-review.googlesource.com/1042491Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556093} 
- 
Xianzhu Wang authoredThe test flakily failed in the following ways: 1. Hover state was not applied and the background was still red. The test perhaps finished before the hover state was visualized. 2. The actual result showed net::ERR_FILE_NOT_FOUND. This was perhaps caused by the click. Now 1. Use runAfterLayoutAndPaint() before the test finishes; 2. Remove the click. Just hover. Also simplify the test and convert it into a ref test. Bug: 839734 Change-Id: I0c5e0a1b0ef2319c6c8d9809fac9cbd4bd0732d0 Reviewed-on: https://chromium-review.googlesource.com/1044489Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556092} 
- 
Sean Kau authoredMove some existing logging to device logs. Expand on existing logs to help with diagnostics. Bug: 836434 Change-Id: I8516930f36aeecffd33fe96b044650903536a9d2 Reviewed-on: https://chromium-review.googlesource.com/1036231Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#556091} 
- 
Ian Vollick authoredPer review comments on crrev.com/c/1005627, we should plumb a unique_ptr rather than raw pointers to make the transfer of ownership more explicit. Bug: None Change-Id: I8163362778e3e03287e6742dfc254fe38aec815f Reviewed-on: https://chromium-review.googlesource.com/1038061 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#556090} 
- 
edchin authoredA DCHECK was recently added that revealed that the tab grid cell is nil sometimes in |-cellForItemAtIndexPath:|. The cell should never be nil in this method. This is an issue that was previously went unnoticed, but adding a DCHECK unsurfaced this existing issue. This CL removes that DCHECK since it was recently added. It is replaced with a TODO so that the underlying issue can be fixed. Bug: 839892 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I85e486786978f992e2b67a7c67b626fbfe97d898 Reviewed-on: https://chromium-review.googlesource.com/1044506Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556089} 
- 
Andrey Kosyakov authoredBug: 721408 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I22204e52a27a1431907d284fd32993d727b1435d Reviewed-on: https://chromium-review.googlesource.com/1043528Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#556088} 
- 
Stephen McGruer authoredConceptually, this is somewhat close to what WorkletAnimation does; the KeyframeEffect skips (seeks) from point to point driven by the script-provided local time. More importantly, it means that WorkletAnimations do not terminate after the duration has expired (which they are not meant to do), and allows us to remove the ActiveTimeProvider hack (in favour of this one!). This CL also removes PushPropertiesTo from WorkletAnimation. This method used to push the local_time_ from cc-main to impl. Doing so was incorrect as cc-main never gets the output of the mutate call, so always has a zero local time, which then started to interfere with the other changes made in this CL. Bug: 779189 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibb0bdd60753bd24264112e10a1f829d394db27e2 Reviewed-on: https://chromium-review.googlesource.com/1037766 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#556087} 
- 
David Tseng authoredThis reverts commit 55b083a6. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=839683#c1 As a guess, key events used to go to SpokenFeedbackEventRewriter then KeyboardDrivenEventRewriter. Original change's description: > mash: Move SpokenFeedbackEventRewriter to ash; add mojo delegate > > Move the rewriter files to ash, keep the delegate impl in chrome. > Add a mojo interface for the delegate to receive and return events. > Ash's controller creates the rewriter, Chrome sets the delegate. > > Move, expand, and refine the existing unit tests. > > Add TODOs to refine the rewriter/delegate/ChromeVox pattern. > (the rewriter shouldn't pass events that will need to be reposted) > > This should allow Mash to support this rewriter in the future. > (for now, Ash doesn't get Window Service events sent to Chrome) > > Bug: 647781 > Test: No regressions with ChromeVox spoken feedback on Chrome OS. > Change-Id: I4f7805298156ab9463ca3110a1e957f922c6d82b > Reviewed-on: https://chromium-review.googlesource.com/1038819 > Commit-Queue: Michael Wasserman <msw@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555867} TBR=jamescook@chromium.org,dmazzoni@chromium.org,msw@chromium.org,dtseng@chromium.org,tsepez@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 647781, 839683 Change-Id: I8103916c1df3013d093cc6cdeac5745b6cd051d0 Reviewed-on: https://chromium-review.googlesource.com/1044492Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#556086} 
- 
Xi Cheng authoredThis reverts commit 44e2fc52. Reason for revert: <CL title/description is inaccurate> Original change's description: > Make sure kNotificationId and kAppId are mutual exclusive on Windows > > Bug: 734095 > Change-Id: I08275fff11aef97c3265a6832dc1485b4ef19b61 > Reviewed-on: https://chromium-review.googlesource.com/1038432 > Commit-Queue: Xi Cheng <chengx@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555986} TBR=tmartino@chromium.org,chengx@chromium.org Change-Id: I050712e720d65ab5b59ef67752c0c1bd3bbbbe02 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734095 Reviewed-on: https://chromium-review.googlesource.com/1044569Reviewed-by: Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#556085} 
- 
Fadi Meawad authoredIn this CL, each frame updates its FrameResourceCoordinator with any updates the lifecycle state. If the main frame lifecycle state is updated, then the page inherit the new state. The PageSignalGeneratorImpl then updates the state in TabLifecycleUnit which is used by the chrome:://discards UI. The CL also disables freezing a Tab that is already frozen. Bug: chromium:804976 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iba82286a06af17ccb74a7f6fac18cdb7914c003a Reviewed-on: https://chromium-review.googlesource.com/942022Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Shubhie Panicker <panicker@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556084} 
- 
CJ DiMeglio authoredThis reverts commit 6f0b5d97. Reason for revert: Causing Webkit Linux Trusty Leak to fail https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/ Original change's description: > [blinkpy] Find manifest items for tests by URL > > When running WPT in web_tests, test names are more like URLs instead of > file paths (to be precise, the part of a test name after external/wpt is > a WPT URL), because WPT can generate multiple tests (variations) for a > single test file (e.g. .any.js, ?run_type). > > Therefore, when asking questions like "is a test slow?", we need to find > the manifest item for that test by URL instead of by file path; whereas > if we want to know if a file in external/wpt is a test file, we find > the manifest item(s) for that file by file path. > > This CL separates the two types of manifest queries, and chooses the > correct one for each call site. Besides, unit tests are improved to > cover the WPT variations (.any.js & ?run_type). > > Bug: 831975, 800570 > Change-Id: I230d5ec7df06b7df1387da1b93788d6cae55d153 > Reviewed-on: https://chromium-review.googlesource.com/1043160 > Commit-Queue: Robert Ma <robertma@chromium.org> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556043} TBR=qyearsley@chromium.org,robertma@chromium.org Change-Id: I5fb2c257967e32d1e4fce4277c10d77635e303d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831975, 800570 Reviewed-on: https://chromium-review.googlesource.com/1044567Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#556083} 
- 
Eugene But authoredAdded the following test cases: - testReloadPageAfterServerIsDown - testGoForwardAfterServerIsDownAndReload - testGoBackFromErrorPage Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a872e6691c66ff6facd100cdb90607488738ff6 Reviewed-on: https://chromium-review.googlesource.com/1043074Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#556082} 
- 
Emily Hanley authoredNOTRY=true Bug: 817872 Change-Id: I4cacf33aa0411fb648e3396ca047aa0ed8773123 Reviewed-on: https://chromium-review.googlesource.com/1044284Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#556081} 
- 
v8-autoroll authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ac9b5ca0..e0f6ae79 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I28206da5525c697ceced2275b13895205a99946d Reviewed-on: https://chromium-review.googlesource.com/1044114Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556080} 
- 
Chromium WPT Sync authoredUsing wpt-import in Chromium 00eb06c3. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16860 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I9845c9f0a0456fbbdb114368aba93a3f41b2686c Reviewed-on: https://chromium-review.googlesource.com/1044346 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556079} 
- 
crystallambert@chromium.org authoredUpdated options page on get started tutorial and complete sample extension. Bug: 839545 Change-Id: I13cf017d1bf23e5a9eafe32cf8efe0eda214990f Reviewed-on: https://chromium-review.googlesource.com/1044274 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556078} 
- 
Yifei Yu authoredThe scheduler expects balanced callbacks of DidHandleInputEventOnMainThread() and DidHandleInputEventOnCompositorThread(EVENT_FORWARDED_TO_MAIN_THREAD). If the expectation is broken, the wrongly-maintained UserModel would produce an endless loop of UpdatePolicy(), which consumes device power. Also makes corresponding changes to unit test. Bug: 837105 Change-Id: Ib5193041728a97f055df757a33680e788dd4c876 Reviewed-on: https://chromium-review.googlesource.com/1032468Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#556077} 
- 
Samuel Huang authoredPreviously PatchElementHeader members were ordered by: [old_offset, new_offset, old_length, new_length]. This CL changes the order to [old_offset, old_length, new_offset, new_length] to be consistent with PatchHeader's grouping by "old" and "new". Also improve comments in patch_read_write_unittest.cc, and fix input value in PatchElementTest.WrongExtraData. Change-Id: I0dab56b7de1ba99f0a2f686dfebdf422a9d1c3b0 Reviewed-on: https://chromium-review.googlesource.com/1043073 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#556076} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/76c01c930ca4..4824ed05ac12 $ git log 76c01c930..4824ed05a --date=short --no-merges --format='%ad %ae %s' 2018-05-04 skcms-skia-autoroll Roll skia/third_party/skcms cc1799c..02fc32e (1 commits) 2018-05-03 benjaminwagner Remove fCacheKeys from SkImageFilter. 2018-05-03 jvanverth Use MaskFilter to create SDFs for text. 2018-05-03 kjlubick Add Skottie fuzzer (via json input) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I7aea5cccf09f486a8feb73a9cf6760fb58822c40 Reviewed-on: https://chromium-review.googlesource.com/1044266Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556075} 
- 
Dave Tapuska authoredI disabled the test because it was failing on one builder and blocking the fix from landing. The test is now adjusted so that the mocked InputMethod is assigned before Setup. BUG=839339 Change-Id: I8b6b75337f52eb46f6e57ef4d5133ed5afc444c7 Reviewed-on: https://chromium-review.googlesource.com/1044269Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#556074} 
- 
https://webrtc.googlesource.com/src.git/+log/9d96e923169d..e6256055e7db $ git log 9d96e9231..e6256055e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I06e993b5f5ff05e78d63dabbf803eef4630b42b1 Reviewed-on: https://chromium-review.googlesource.com/1044270 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556073} 
 
-