- 09 Jun, 2018 40 commits
-
-
Andres Calderon Jaramillo authored
This CL fixes media/gpu/jpeg_decode_accelerator_unittest.cc so that the strides and pointers for the VideoFrame that holds the decode result are computed correctly when the JPEG image has at least one odd dimension. The strategy is to keep track of a visible size and a coded size for each image. For odd-sized images, the visible size corresponds to the original dimensions whereas the coded size corresponds to the odd dimensions rounded up to the next even number. Thus, the stride computations will be correct when we call WrapExternalSharedMemory to build the VideoFrame. A test case is added for odd-sized images. To visualize the results, both the software and hardware decode outputs are saved as PNG when using the --save_to_file flag. Bug: 849776 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia80c038059949d873b59958afe1fad1533b32226 Reviewed-on: https://chromium-review.googlesource.com/1094037 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#565895}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc4634d..4bc53b0 git log dc4634d..4bc53b0 --date=short --no-merges --format='%ad %ae %s' 2018-06-09 benjhayden@chromium.org Replace the 23 Anomaly indexes with 11 joinable indexes. Created with: gclient setdep -r src/third_party/catapult@4bc53b0 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I55dd212cdf2e42dd309db7da3bb80c405adbae13 Reviewed-on: https://chromium-review.googlesource.com/1094494Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565894}
-
Peter Kasting authored
This also reorders the methods to match the order in the parent classes. BUG=none TEST=none TBR=bsep Change-Id: I7f4b543a80edf057b67754a324ce6923f8cf06a6 Reviewed-on: https://chromium-review.googlesource.com/1094265 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#565893}
-
Jeremy Klein authored
R=khorimoto@chromium.org Bug: 850823 Change-Id: I7a4b0bbfad4b553929aebd59a508ab11ce208ac1 Reviewed-on: https://chromium-review.googlesource.com/1092192Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#565892}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1182c84d. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests." c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order." 4049f639 "[LayoutNG] Orthogonal flows need available inline size for min/max calculation." 69af6f38 "webrtc wpt: add cleanup to close peerconnections" 03ef65db "Update existing WebUSB WPT to be multi-global" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19247 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I3fa3f0158178897af104b6bdfb4751a46aa8411e Reviewed-on: https://chromium-review.googlesource.com/1094479 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565891}
-
Sergey Ulanov authored
media FIDL library was moved to the fuchsia namespace. Updating BUILD.gn file accordingly. Change-Id: I760d8c91f94b5d5a2d0b249d1bdc62f49708063c Reviewed-on: https://chromium-review.googlesource.com/1094054Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565890}
-
Wez authored
- Update #include sites, and the paths in //third_party/fuchsia-sdk's build rules. - Add //third_party/fuchsia-sdk to the set of "gn check" directories. TBR: thakis, rockot Bug: 850757 Change-Id: I012d50f405ed93fa49ed4aaa0f25783d1e7e9e4b Reviewed-on: https://chromium-review.googlesource.com/1094145Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565889}
-
Mathieu Perreault authored
It's not recommended to draw outside the canvas factors (here canvas is 32), and this icon should be 16, as wanted by UX and demonstrated by PNG tooltips which are 16dp. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --draw-view-bounds-rects --test-launcher-interactive Change-Id: I8401c11c60f5926bec81baaf4cb079f93ce87f5c Reviewed-on: https://chromium-review.googlesource.com/1091130 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565888}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a45dd1..5ebb90d git log 7a45dd1..5ebb90d --date=short --no-merges --format='%ad %ae %s' 2018-06-09 senorblanco@chromium.org Revert "remove half float workaround in GrGLGpu::onReadPixels" 2018-06-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-08 mtklein@chromium.org remove unused parts of SkTypes.h 2018-06-08 egdaniel@google.com Fall back to bilerp if we are undable to do a copy for mips. 2018-06-08 egdaniel@google.com Reland "Reland "Require mips to be allocated at texture creation time and disable late allocations."" 2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c3907ef..f15f886 (6 commits) 2018-06-08 bsalomon@google.com Stop passing GrPrimitiveProcessor to GrMesh::sendToGpu. 2018-06-08 herb@google.com Glyph search of desperation 2018-06-08 egdaniel@google.com Revert "Reland "Require mips to be allocated at texture creation time and disable late allocations."" 2018-06-08 borenet@google.com [recipes] Make ct_skps use binaries from a build task 2018-06-08 brianosman@google.com Avoid degenerate matrices (that trigger asserts) in test code 2018-06-08 mtklein@chromium.org see if we can remove this hack 2018-06-08 caryclark@skia.org rebase 2018-06-08 khushalsagar@chromium.org fonts: Perform blob analysis at SkBaseDevice layer instead of canvas. 2018-06-08 mtklein@chromium.org remove unimportant bench 2018-06-08 csmartdalton@google.com Make the SkPathRef GenIDChangeListener ref counted 2018-06-08 bsalomon@google.com Remove include of GrGLProgramBuilder.h from GrGLProgram.h and GrVkPipelineState.h 2018-06-08 csmartdalton@google.com Add a front() accessor to GrAllocator 2018-06-08 herb@google.com New more efficient run builder 2018-06-08 brucewang@google.com Add SkTypeface::makeClone. 2018-06-08 bsalomon@google.com remove half float workaround in GrGLGpu::onReadPixels 2018-06-08 brianosman@google.com Fix A2B JPEG images on GPU backed xform or color-managed canvas 2018-06-08 bungeman@google.com Add text size override to Viewer. 2018-06-08 csmartdalton@google.com Implement Sk2f::floor 2018-06-08 mtklein@chromium.org remove linear blending from SkWebpCodec 2018-06-08 senorblanco@chromium.org GrTessellator: catch missing intersections. 2018-06-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-08 fmalita@chromium.org SkJson 2018-06-08 enne@chromium.org Fix SkImageInfo::computeByteSize underflow 2018-06-08 egdaniel@google.com Reland "Require mips to be allocated at texture creation time and disable late allocations." 2018-06-08 bsalomon@google.com Revert "Reland "Workaround constexpr bug in MSVC 2015 in GrTextureOp"" 2018-06-08 caryclark@skia.org update SkColor 2018-06-08 caryclark@skia.org fix define comments 2018-06-08 mtklein@chromium.org remove final SkTypes dependencies in SkArenaAlloc 2018-06-08 benjaminwagner@google.com Remove Win2k8 GPU jobs. 2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 81970bc..c3907ef (2 commits) 2018-06-08 timliang@google.com fixed vec3 size differences and mod calculation of skslc msl backend 2018-06-08 brianosman@google.com srgb config is gone. Stop testing it. 2018-06-08 borenet@google.com Update gen_tasks.go to use unforked glog 2018-06-08 robertphillips@google.com Add a factory to any GrOp-derived class that lacked one Created with: gclient setdep -r src/third_party/skia@5ebb90d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:830651,chromium:829622,chromium:843135,chromium: 819616 TBR=halcanary@chromium.org Change-Id: If58892b6b6b2061e1b52168911b4fb49a1b990e7 Reviewed-on: https://chromium-review.googlesource.com/1094454Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565887}
-
Peter Kasting authored
* Shorten/simplify * Move initializers to .h * Remove dead code * double -> float * Better comments/names * Helper functions * Use SK_AlphaXXX * Const correctness * Don't expose constants unnecessarily * Use CenterPoint() * Return by value * NULL -> nullptr * Declare variables in narrowest possible scope * Use static member functions * SCOPED_TRACE * Remove using directives * auto BUG=none TEST=none Change-Id: I80090de4b90c8547f17df93ad2b5b2921bcbbd3f Reviewed-on: https://chromium-review.googlesource.com/1083781 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#565886}
-
Sergey Ulanov authored
Add some helper code for Scenic: 1. ScenicSession is a wrapper around a scenic::Session, which is responsible for queuing Scenic messages and allocating resource IDs within the session. 2. scenic_helper.h/cc contain functions that simplify construction of scenic commands. Bug: 829980 Change-Id: Ib9d5a5f7d6b9e77c657d84f42f0a1f0e99652cb5 Reviewed-on: https://chromium-review.googlesource.com/1081244 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#565885}
-
Scott Violet authored
To make tracking easier this just renames the files. Class rename will be next. BUG=none TEST=none TBR=jamescook@chromium.org Change-Id: Ie5cfc06021c2aaf5f482151aa45e9e442842165e Reviewed-on: https://chromium-review.googlesource.com/1094418Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#565884}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 001406bc. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests." c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order." 4049f639 "[LayoutNG] Orthogonal flows need available inline size for min/max calculation." 69af6f38 "webrtc wpt: add cleanup to close peerconnections" 03ef65db "Update existing WebUSB WPT to be multi-global" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19239 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I1c0d6e8d2abaa7991e2ebf5949bbc1ff32365afd Reviewed-on: https://chromium-review.googlesource.com/1094417 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565883}
-
Andrey Kosyakov authored
Change-Id: I969626e1c5a7851d093365b98ad7fafebce92310 Reviewed-on: https://chromium-review.googlesource.com/1094314 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565882}
-
Emily Stark authored
Group non-overrides together and adjust definition order to match. Requested in https://chromium-review.googlesource.com/c/chromium/src/+/1087721/2/content/browser/loader/resource_request_info_impl.h#99. Change-Id: I2c07ec7b94894dfcd9d6dd521befcbb396a8007d Reviewed-on: https://chromium-review.googlesource.com/1089119 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#565881}
-
tzik authored
This migrates TaskTimeObserver and its implementations to base::TimeTicks from double-as-time for clearer time unit handling and rounding error free times. Change-Id: I1a1f011b227a0e160d466df822b6e651262839f7 Reviewed-on: https://chromium-review.googlesource.com/1090529Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#565880}
-
Dominik Röttsches authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/0589f6e6ee6e..8f1ed54877ff $ git log 0589f6e6e..8f1ed5487 --date=short --no-merges --format='%ad %ae %s' 2018-06-07 apodtele [base] API for Harmony LCD rendering. 2018-06-07 wl Minor. 2018-06-06 wl ftcolor.h: Redesign API. 2018-06-06 wl New `ftcolor.h' draft. 2018-06-06 wl Minor. 2018-06-06 parthwazurkar [bdf, pcf] Removed deprecated FT_FACE_FLAG_FAST_GLYPHS flag. 2018-06-06 wl [smooth, raster] Limit bitmap size (#54019). 2018-06-04 ramakrishnan.nikhil Restore missing comment lines and other minor fixes 2018-06-04 lightside Restore accidentally removed, commented-out configuration options. 2018-06-03 wl [GSoC] include/*.*, devel/*.*: Convert block comments to `light' style. 2018-06-03 wl Typos. 2018-06-03 prince.cherusker * src/smooth/ftgrays.c (gray_convert_glyph): Remove unused variables. 2018-06-03 wl Minor formatting. 2018-06-03 wl * src/tools/glnames.py (main): Emit header in `light' comment style. 2018-06-03 wl [GSoC] src/*.*: Convert block comments to `light' style. 2018-06-02 apodtele [smooth] Attempt to mitigate bug #54019. 2018-06-02 wl * src/truetype/ttinterp.c (Ins_MIRP): Use SUB_LONG; avoid FT_ABS. 2018-06-02 wl * src/autofit/afwarp.h: Use AF_CONFIG_OPTION_USE_WARPER (#54033). 2018-05-31 wl * src/raster/ftraster.c (black_TWorker_): Remove `gTarget' field. 2018-05-30 apodtele Shorten LCD filtering docs. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1110 Change-Id: Ib64d897487cb2c78cab3aa3b774fedaf2861d2d0 Reviewed-on: https://chromium-review.googlesource.com/1094174 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565879}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/683dd05..dc4634d git log 683dd05..dc4634d --date=short --no-merges --format='%ad %ae %s' 2018-06-09 dpranke@chromium.org Fix typ/run to work from any directory. Created with: gclient setdep -r src/third_party/catapult@dc4634d The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I6208dd5cbe0636c1bf5c01013a435ec3ee92c954 Reviewed-on: https://chromium-review.googlesource.com/1094338Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565878}
-
Chromium WPT Sync authored
Using wpt-import in Chromium be015f13. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests." c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order." 4049f639 "[LayoutNG] Orthogonal flows need available inline size for min/max calculation." 69af6f38 "webrtc wpt: add cleanup to close peerconnections" 03ef65db "Update existing WebUSB WPT to be multi-global" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19238 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: I020cc126b7b724a34a62b689d718724b178928ea Reviewed-on: https://chromium-review.googlesource.com/1094414 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565877}
-
Stephen White authored
Temporarily mark virtual/gpu/fast/canvas/canvas-arc-circumference-fill.html as flaky until the skia roll goes through. Bug: 843135 Change-Id: I5a730a7ac729f2eccaa4222730ecd098809aeb24 Reviewed-on: https://chromium-review.googlesource.com/1094302Reviewed-by:
Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#565876}
-
Stephen McGruer authored
This allows code in the browser process to directly record detected PageLoadFeatures, rather than unnecessarily round-trip to the renderer. This has been requested for cases such as browser-side interventions (e.g. pop-up blocker) as well as UseCounters coming from WebView. Change-Id: Ib3d24469e5e487e90098d11f73a84916bdb5bb5d Reviewed-on: https://chromium-review.googlesource.com/1079711Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#565875}
-
Xida Chen authored
Right now there is no such class, and that's why we added a ScrollingTouchActionForTesting function in the TouchActionFilter class. This CL creates a new TouchActionFilterTest class, and converts every test in the file from TEST to TEST_F. It also cleans up the TouchActionFilterPinchTest. This CL should not introduce any behavior change, which can be tested by bots. Bug: 850337 Change-Id: I355e43d3a6562efe779e8592aa95d1359f544443 Reviewed-on: https://chromium-review.googlesource.com/1091232Reviewed-by:
Xianda Sun <sunxd@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#565874}
-
Andrey Kosyakov authored
Change-Id: I26ec7afcb2f8b35970e4aadf017663f001e3ca84 Reviewed-on: https://chromium-review.googlesource.com/1093980 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565873}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3fb5aa7..c3e514e git log 3fb5aa7..c3e514e --date=short --no-merges --format='%ad %ae %s' 2018-06-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c3e514e The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I03b68d7c69166e8460ed2f2f5b9ddbbd283e75e3 Reviewed-on: https://chromium-review.googlesource.com/1094158Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#565872}
-
Sergey Ulanov authored
This is a skeleton for Scenic Ozone platform implementation. It doesn't talk to Scenic yet. Bug: 829980 Change-Id: I19d800d7183a932a4793c9fccf193540f1e6df55 Reviewed-on: https://chromium-review.googlesource.com/1081473 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565871}
-
Devlin Cronin authored
Move //base/test/user_action_tester* to //base/test/metrics, and update all associated includes. There should be no behavior change from this CL. TBR=derat@chromium.org (//ash) TBR=thestig@chromium.org (//chrome, //base) TBR=sdefresne@chromium.org (//components, //ios) TBR=alexmos@chromium.org (//content) NOPRESUBMIT=true No-Presubmit: true (Gerrit, why you no respect TBRs?) Bug: 846421 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idc51ae8b13a2d444f40e07acfbf74d21966d44c4 Reviewed-on: https://chromium-review.googlesource.com/1092239 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565870}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2638e9ef. With Chromium commits locally applied on WPT: e8832df8 "webrtc wpt: remove test_state_change_event" fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests." c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order." 4049f639 "[LayoutNG] Orthogonal flows need available inline size for min/max calculation." 69af6f38 "webrtc wpt: add cleanup to close peerconnections" 03ef65db "Update existing WebUSB WPT to be multi-global" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19212 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mlamouri@chromium.org: external/wpt/mediasession TBR=foolip No-Export: true Change-Id: I203afb79d930c2586e24bd5db8fecfe89fc74bfb Reviewed-on: https://chromium-review.googlesource.com/1094326 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#565869}
-
Aleks Totic authored
Small change with a complex background story. This fixes NG test fast/css3-text/css3-text-decoration/text-decoration-skip-ink.html The test is 2 vertical-lr divs inside the flexbox: <div style="display: flex;"> <div class="target" style="writing-mode:vertical-lr"> <p class="decoration ">Ép Ép Ép</p> <p class="decoration ">Ép Ép Ép</p> </div> <div class="target" style="writing-mode:vertical-lr"> <p class="decoration ">Ép Ép Ép</p> <p class="decoration ">Ép Ép Ép</p> </div> Bug manifests itself in weird ways. The main symptom is that #target intrinsic_content_size is calculated incorrectly. It can manifest itself as an extra scrollbar, or flex item that is too wide. The cause is incorrect constraint space. The root cause is Flex item gets positioned by old layout, which sets OverrideContainingBlockContentLogicalHeight to -1. NGBlockNode::RunOldLayout block_size = -1; SetOverrideContainingBlockContentLogicalHeight(block_size) When #target is getting positioned, it creates a constraint space: NGConstraintSpace::CreateFromLayoutObject Because child is orthogonal, this calls box.PerpendicularContainingBlockLogicalHeight which ends up calling LayoutBox::AvailableLogicalHeight. LayoutBox returns 0 as AvailableLogicalHeight instead of -1 because it does ConstrainContentBoxLogicalHeightByMinMax(-1) which returns 0. The fix, to allow AvailableLogicalHeight to return indefinite values, fixes the bug, and has no other effects on our test suites. Another fix that was considered was to write an NG routine to compute PerpendicularContainingBlockLogicalHeight. There is a lot of legacy logic behind this routine, and it is unclear how to implement it in NG on top of Legacy code. Bug: 849751 Change-Id: Ia948ccc2e6d1c0274d23f3d558eb773843a248ed Reviewed-on: https://chromium-review.googlesource.com/1093996Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#565868}
-
Gabriel Charette authored
TBR=fdoray@chromium.org Bug: 850450, 786597 Change-Id: Iaa8a9d713c5202f371b0fd549d140bbe791e4089 Reviewed-on: https://chromium-review.googlesource.com/1094296 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#565867}
-
Dmitry Gozman authored
This is a small refactor to further split start and commit code paths. Bug: 789577 Change-Id: I4776467982cc1c1cb14a72693a0791965169bf9e Reviewed-on: https://chromium-review.googlesource.com/1083825 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#565866}
-
Jan Wilken Dörrie authored
This change provides implementations for the IVector WinRT interface. Vector is a thin wrapper around a std::vector, and also implements the IObservableVector interface. Bug: 821766 Change-Id: I2e81b843d87e53f023b659a07af46d2752a65cc9 Reviewed-on: https://chromium-review.googlesource.com/1059784 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#565865}
-
Joe Downing authored
This CL adds the MacOS implementation for the KeyboardMap API and hooks it up via the RenderWidgetHostViewMac class. This is a bit different than on the Aura platforms as the WindowTreeHost class is used there, however those classes do not exist on MacOS so the RWHVM is the next best place to put it. BUG=832811 Change-Id: I2eaa36bb4b8ab0328678219bba9973f80c04dcb6 Reviewed-on: https://chromium-review.googlesource.com/1089633 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#565864}
-
Emily Stark authored
In https://chromium-review.googlesource.com/#/c/821410/, we stopped reporting raw headers to the renderer for protected subresources, to avoid sending cookies or other sensitive raw headers into a renderer process that isn't supposed to be able to access them. The report_raw_headers flag also controls whether security details (certificate, TLS protocol information, etc.) are sent into the renderer, so this change broke the Security Panel's display of security details for subresources. Security details are less sensitive than the raw headers because they don't contain secrets like cookies, so this CL introduces a separate flag to control whether security details are reported, even if raw headers aren't. In the long-term, we should have a way to send network request details (both raw headers and security details) to DevTools without having them go through the untrusted renderer process. Bug: 834771 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I59397d18bb412a32dad43628f29ebe0f09c7b5ed Reviewed-on: https://chromium-review.googlesource.com/1087721 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#565863}
-
Charlie Ma authored
Bug: 851191 Change-Id: I1513a343824d04ad84d3572a0245359141c7d411 Reviewed-on: https://chromium-review.googlesource.com/1094216 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#565862}
-
wutao authored
This cl makes accelerator for Keyboard Shortcut Viewer work when running as a standalone app. Bug: 847615 Test: manual. Change-Id: I55d161896b8268532dbc884cd9d6573fafb66b44 Reviewed-on: https://chromium-review.googlesource.com/1087838 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565861}
-
Xiaocheng Hu authored
This patch converts the layout test with W3C testharness to reduce usage of deprecated js-test.js. This is also a preparation for fixing hit test bugs when more NG inline fragments are preserved. Bug: 851075 Change-Id: Iec606756c9b089f69dcc443b436a1c53130d1848 Reviewed-on: https://chromium-review.googlesource.com/1093987 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#565860}
-
Yuri Wiitala authored
gfx::ColorSpace can convert to a SkColorSpace, but there was no simple way to convert the other way around. This change addresses that need. Bug: 758057,810131 Change-Id: Id6bb1b079f17cc632ab04cddd162dc94ee50a287 Reviewed-on: https://chromium-review.googlesource.com/1090234 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#565859}
-
Sadrul Habib Chowdhury authored
RemoveLatency() is no longer used, so it is removed. BUG=849719 Change-Id: I1e3b9338f7e70d4e31e0e2bb2cae96966592210e Reviewed-on: https://chromium-review.googlesource.com/1092631 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#565858}
-
Liquan(Max) Gu authored
The layout test event-timing-bufferbeforeonload.html is not flaky any more. Removing the flakiness expectation from TestExpectations. Bug: 847496 Change-Id: Ia6d819881d69dc8d3ab0d5886a7c5271f12ae418 Reviewed-on: https://chromium-review.googlesource.com/1093778Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#565857}
-
Tommy C. Li authored
Previously the URL Formatter code would misbehave for intranet hosts while trying to trim trivial subdomains. This CL fixes the issue and adds a unit test. Bug: 850751, 797354 Change-Id: Ia60782e6ce1b3b8a7261b26f7e1fe6b48d2577fd Reviewed-on: https://chromium-review.googlesource.com/1093743Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#565856}
-