- 16 Jul, 2018 40 commits
-
-
David Quiroz Marin authored
Adding a new attribute to the TextMetrics object to expose glyph advances for a given text. This will be a list of pixel widths for each glyph in the text measured in pixels from the text alignment origin in the text direction (rtl or ltr). Added some basic test and commented some edge cases that we still need to resolve. Bug: 853376, 277215 Change-Id: I7df30ce493c843032d974ca79ca793c89b318d82 Reviewed-on: https://chromium-review.googlesource.com/1134202Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575470}
-
Fabio Tirelo authored
Bug: 861996 Change-Id: Ie3d579b3d59ba230ceec5229b2aebb3921deeda2 Reviewed-on: https://chromium-review.googlesource.com/1138801Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#575469}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: I83ee6e6280999c9e2b51a0ea3b1cee3d030cfd3f Reviewed-on: https://chromium-review.googlesource.com/1128095Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#575468}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4fb310a1..66a2db59 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib154ed6860c1c40ff2c0abb95c7cb981f9d1720b Reviewed-on: https://chromium-review.googlesource.com/1138831Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575467}
-
Martin Kreichgauer authored
This moves the AuthenticatorGetInfo request to determine whether an authenticator supports the kCtap ProtocolVersion out of FidoTask and into FidoDiscovery. As a result, no half-initialized FidoDevice instances are passed into the FidoRequestHandler and FidoTask subclasses. This is going to make it easier to centralize checking of certain request preconditions, like AuthenticatorSelectionCriteria e.g.. Currently checking for those is handled within FidoTask (after completion of the AuthenticatorGetInfo dance), and therefore TouchIdAuthenticator evades it. Determining FidoDevice capabilities upfront allows us to move these checks out of FidoTask such that TouchIdAuthenticator can be covered by them. Bug: 678128 Change-Id: Ie0f9101eeca5ee6d0fbf2d7f8885d9a1dc46d032 Reviewed-on: https://chromium-review.googlesource.com/1135120 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575466}
-
Ben Pastene authored
I'd like to run this test (and others) on chromeos bots on chrome's CQ. Chrome's test dependency management works a little different than cros's/autotest's. We push to the cros device only the test target's runtime deps (as determined by GN). Consequently, we get ENOENTs due to these missing images. This'll fix that. Bug: 860066 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9b2fc1deed0bbefcfa9fccc51969571b8056f30e Reviewed-on: https://chromium-review.googlesource.com/1138752Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#575465}
-
John Abd-El-Malek authored
Bug: 840404 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia73f1165adc28625f396437d394606d259317a7c Reviewed-on: https://chromium-review.googlesource.com/1134023 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#575464}
-
rajendrant authored
Report the ResourceInfo-less requests to site-breakdown other hostname. These requests will not be tracked by page load metrics infra which only handles requests scoped to page loads. Bug: 836029 Change-Id: I23180e05f367e79e1c6a6802913293988a558de8 Reviewed-on: https://chromium-review.googlesource.com/1134506 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#575463}
-
CJ DiMeglio authored
This CL is 3/3 in effort to fix the regressions caused by sending unneeded compositor frames. This CL provides a signal from the SurfaceLayerImpl to the VideoFrameSubmitter to prevent compositor frames from being sent at undesired times (occlusion, not being added into the layer tree). Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I428860047eaf4c50abc2e662914a643158f1276b Reviewed-on: https://chromium-review.googlesource.com/1101708 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575462}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3643aef89c78..056d811b6a04 git log 3643aef89c78..056d811b6a04 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 hta@webrtc.org Add counting of PCs with private IP addresses exposed 2018-07-16 shampson@webrtc.org Fix so that codec max bitrate doesn't override. 2018-07-16 emircan@webrtc.org Add color space information to webrtc::VideoFrame and extract from VP9 2018-07-16 buildbot@webrtc.org Roll chromium_revision a0e2753f..36688868 (575203:575305) 2018-07-16 peah@webrtc.org AEC3: Adding explicit handling of microphone gain changes 2018-07-16 mbonadei@webrtc.org Removing find_bad_constructs from system_wrappers. 2018-07-16 mbonadei@webrtc.org Removing clang:find_bad_constructs from stats/. 2018-07-16 stefan@webrtc.org Move allocation and rtp conversion logic out of payload router. Created with: gclient setdep -r src/third_party/webrtc@056d811b6a04 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:718508,chromium:None,chromium:863826 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5df87bef7a64c730355d76c3f111ae9250ba264b Reviewed-on: https://chromium-review.googlesource.com/1138674Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575461}
-
Xiaocheng Hu authored
Bug: 860706 Change-Id: I763095091eead566f92aacf421e6a45cd7a4bc25 Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1138998Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575460}
-
Raymond Toy authored
When the execution context is being destroyed, inform the destination handler of that so that we don't try to access the execution context that is in the process of going away. This CL only handles the specific case in bug 848306, and is a simple fix for that issue. This really needs to be fixed in a better way, but that requires significant design work. Bug: 848306 Test: Manually run repro case and see that it doesn't happen Change-Id: I89a4d397af15a823d9c25ef814195706f7b30b21 Reviewed-on: https://chromium-review.googlesource.com/1138722 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#575459}
-
Taylor Bergquist authored
In https://crrev.com/c/1121386 the tab's layout height was increased by one dip to create an overlap between the tab and the toolbar. The tab content was then incorrectly laid out slightly lower as a result. This CL includes that space in the tab's content insets, so content is laid out into the visible tab region as intended. Bug: 863493 Change-Id: Iae13fb5bc9a726a1b9f29329ebecd23197b2b0fb Reviewed-on: https://chromium-review.googlesource.com/1137353 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#575458}
-
Lei Zhang authored
Change it to 8 from 7. Do this programmatically rather than with hard-coded constants. BUG=851101 Change-Id: I638dfcfc641c92af860f4b0d4e630914bc6426f9 Reviewed-on: https://chromium-review.googlesource.com/1137236Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#575457}
-
Tommy Martino authored
* Introduces a maximum width for the Autofill dropdown. * Creates a subclass for Warnings with styles different from regular rows, and introduces logic to allow the long strings inside to wrap. This subclass also makes click events on the warning message a no-op, since the warning is not meant to be interactive. * Changes the color of the text in warnings to use a Refresh value. Bug: 860352 Change-Id: I320949e3965faf758286af8fbdf3487e0cb91794 Reviewed-on: https://chromium-review.googlesource.com/1130106 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#575456}
-
Victor Costan authored
This CL documents the thread-safety arguments for the thread-safe DatabaseTracker members mentioned in the class-level comments. It makes a member const, so that accessing it is indeed thread-safe, and renames a getter to hacker_case, to make it slightly more obvious that it's just accessing a const member. Change-Id: I9b8aa97ef84c504ea6b421de1091d35cf06a48c1 Reviewed-on: https://chromium-review.googlesource.com/1137983Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575455}
-
Victor Costan authored
DatabaseConnections::connections_ is only mutable so that DatabaseConnections::GetOpenDatabaseSize() can use std::map::operator[] while being const. This CL removes the mutable qualifier and replaces operator[] use in GetOpenDatabaseSize() with find() and const_iterator, to make it easier to reason about thread safety and invariants. Change-Id: Ifb9df3733c099d9b686096f71156d0a4b2c6271a Reviewed-on: https://chromium-review.googlesource.com/1137929Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#575454}
-
Peter Mayo authored
These tests hit DCHECKs and so they only crashes on DCHECK enabled bots. (dbg on the waterfall and the blink-rel trybots.) see https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/layout_ng_experimental/fast/pagination/auto-height.html%20virtual/layout_ng_experimental/fast/pagination/first-letter-inherit-all-crash.html%20virtual/layout_ng_experimental/fast/pagination/modal-dialog-crash.html%20virtual/layout_ng_experimental/printing/fixed-positioned-child-repeats-even-when-html-and-body-are-zero-height.html%20virtual/layout_ng_experimental/printing/fixed-positioned-child-shouldnt-print.html%20virtual/layout_ng_experimental/fast/multicol/multicol-becomes-paged-auto-height.html Bug: 626703,591099 Change-Id: I20f409e2dbba4246fee31c9c0e4d678e8a033685 Reviewed-on: https://chromium-review.googlesource.com/1138989Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#575453}
-
Chris Blume authored
Vulkan on Android was previously enabled by default in https://chromium-review.googlesource.com/c/chromium/src/+/1110754 However, it caused an increase in binary size. We want to take some time to investigate and attempt to reduce the binary size inflation. The next branch point will happen before we get a chance to investigate. So for now, let's put the Vulkan code behind a compile-time flag. That will let us easily switch it back on later & continue to test the Vulkan code path. BUG=862144 TBR=tobiasjs@chromium.org, qinmin@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I52e499c792f13aa7208400650bffbc31a200f0c5 Reviewed-on: https://chromium-review.googlesource.com/1137348Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#575452}
-
Yuri Wiitala authored
The new implementations have been live for a bit more than a milestone. It's safe now to delete the old ones. TBR=jam@chromium.org Bug: 806366 Change-Id: Icde37e386f975dcc0cee70c17ef482191e74ceba Reviewed-on: https://chromium-review.googlesource.com/1137453 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575451}
-
Theresa authored
BUG=814880 Change-Id: I1c4bab6db1d53b4cf91b4a549c286dd7d39789bb Reviewed-on: https://chromium-review.googlesource.com/1138869Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575450}
-
Hongchan Choi authored
The refactoring CL (https://chromium-review.googlesource.com/c/chromium/src/+/1115516) removed the redundant checks for the destination node in some getters. In rare cases, however, these checks turned out to be necessary due to the problematic design, which needs a long-term solution. This CL adds those checks back in as a short-term workaround. Bug: 860626 Change-Id: I78acb597851249a09d00094e6f1984d8c5b76613 Reviewed-on: https://chromium-review.googlesource.com/1138650 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#575449}
-
Emircan Uysaler authored
Bug: webrtc:9376 Change-Id: I9a6b6c98705cd75243e5ee40926f493866b6b770 Reviewed-on: https://chromium-review.googlesource.com/1137437 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575448}
-
Sammie Quon authored
Using OnCompositorStarted does not work for overview anymore. See stack trace in bug. Test: manual Bug: 863795, 843851 Change-Id: I3dc8965cbece03ac36f1dc404c9b19b7dcac5b5e Reviewed-on: https://chromium-review.googlesource.com/1138737 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#575447}
-
Evan Stade authored
Follow up to 0a98cc85 Bug: none Change-Id: I1295fe4dbf4ae913689b8d2b1bd57e8554483566 Reviewed-on: https://chromium-review.googlesource.com/1138986Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#575446}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 94489a86. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21470 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I8fbf4e8d2688224db02bc1adf954eab59bdb12ab Reviewed-on: https://chromium-review.googlesource.com/1138854 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575445}
-
Reilly Grant authored
This change migrates users of net::URLFetcher in //services/device/geolocation to network::SimpleURLLoader. The asynchronous plumbing for requesting a net::URLRequestContextGetter in the device service is replaced with simply passing in a network::SharedURLLoaderFactory. The tests are migrated from net::TestURLFetcherFactory to network::TestURLLoaderFactory. Bug: 844976 Change-Id: Icdc35cb973554a9ac2592ced9873bf15bf0bc82d Reviewed-on: https://chromium-review.googlesource.com/1119398 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#575444}
-
Matthew Jones authored
This patch adds the ability of the bottom toolbar to hide while the keyboard is showing. This patch is able to use existing simpler infra (KeyboardVisibilityListener) to solve this problem because we are trying to hide UI rather than show it on top of the keyboard. The challenge with showing UI above the keyboard is the inconsistency of the signals that we receive (with keyboard modes like PAN, RESIZE, etc.). If we receive no visibility signal, the keyboard simply draws on top of the bottom toolbar (making it invisible). In the more reliable case where the screen is resized, we hide the bottom toolbar's components and tell the renderer that the bottom controls height is 0. Bug: 852109,860071 Change-Id: I056c47bea33dd426f3b488925ff169735ac95c2f Reviewed-on: https://chromium-review.googlesource.com/1125326 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#575443}
-
John Rummell authored
BUG=861869 Change-Id: I72d0a581e3d82980f5da30aa12d794b1f9abe0ad Reviewed-on: https://chromium-review.googlesource.com/1130007Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#575442}
-
Christopher Cameron authored
Update logic for counting spare compositors (otherwise would be broken by this change), and add optional "force new compositor" argument. This is a speculative "revert", to determine the cause for GPU crashes in GLFence::Create. Bug: 863817 Change-Id: I47cae1fb78e73481d1272d4ce9d56b19dcb4079c Reviewed-on: https://chromium-review.googlesource.com/1138872Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#575441}
-
Shimi Zhang authored
We still need to do 3-way patch to avoid break downstream. We remove the usage of ClassRegister first then remove the declaration in part 2. part 2: http://crrev/c/1137105 Downstream CL: http://crrev/i/651721 Bug: 850652 Change-Id: I9148fdd7dfcb61e4f804b23e817e5bbd3dabc75d Reviewed-on: https://chromium-review.googlesource.com/1138815Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#575440}
-
Scott Chen authored
Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id7c7ea9aa79c704c6971fe477a386f755261e822 Reviewed-on: https://chromium-review.googlesource.com/1135842 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#575439}
-
Peng Huang authored
This CL will create Vulkan instance and Vulkan GrContext when --enable-vulkan is specified. And SkiaOutputSurfaceImpl and SkiaOutputSurfaceImplOnGpu will use the Vulkan GrContext to renderer to replay the SkDDL. Known issues: * RasterDecoder still produces GL textures, it should use the GrContext from GpuServiceImpl. * Media still produce GL textures. * WebGL still produce GL textures. * Browser UI doesn't use RasterDecoder. Bug: 838899 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1026c70e0916d25a9878767336b106299b9dbce7 Reviewed-on: https://chromium-review.googlesource.com/1126166Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#575438}
-
rbpotter authored
Due to a bug in createCloudJobTicket(), portrait printing to cloud, extension, and privet printers was not working correctly. While auditing new vs old UI in cloud print tickets, also discovered that the old UI sent copies as an integer, not string, and changed new UI to match. Also added tests for createPrintTicket() and createCloudJobTicket(). Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I064a8e323b40cf411d2e12a72d4ffd1d501cd4a0 Reviewed-on: https://chromium-review.googlesource.com/1137475Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#575437}
-
Fady Samuel authored
When surface synchronization is off, we lock the UI compositor on Android during the first frame and resize in order to avoid producing a CompositorFrame until the renderer has an appropriate frame ready. Prior to this CL, with surface sync on, we used the default deadline for synchronization. With this CL, we use the same deadlines that were used prior to surface sync on versions of Android O or newer. On versions older than O, we set the deadline for resize to 0. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Idb8f2b3891a9ae1bd43be4d81dbec3ccdb5ff436 Bug: 672962, 857542 Reviewed-on: https://chromium-review.googlesource.com/1132324 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#575436}
-
Xiaocheng Hu authored
Bug: 833380 Change-Id: Ibbe5e66786930313ea10bcba1988df93e91f05e3 Tbr: kenrb@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1138993 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575435}
-
Mustafa Emre Acer authored
Change-Id: I0d891c28e8e1adb48ab1bd19dbb1aff35970bb5a Reviewed-on: https://chromium-review.googlesource.com/1136977Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575434}
-
Jacob Dufault authored
LoginDisplayHost owns WizardController, this makes it more obvious. Bug: 851012 Change-Id: Ideb743276be051024b237cd04e68838a02a85ef7 Reviewed-on: https://chromium-review.googlesource.com/1124944 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575433}
-
Rohit Rao authored
BUG=805213 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I347e8d51e721b776de1a3e484de21b48a8a27a15 Reviewed-on: https://chromium-review.googlesource.com/1138337Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575432}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/70331946770e..ee72342a5342 git log 70331946770e..ee72342a5342 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 dgarrett@chromium.org Revert "InitSDKStage: Remove chroot_replace argument." Created with: gclient setdep -r src/third_party/chromite@ee72342a5342 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0a81249ccd43c255400430c58918e00dfabaeb6 Reviewed-on: https://chromium-review.googlesource.com/1138416Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575431}
-