- 20 Apr, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
Close any pending reauth UI since the opt-in pref wouldn't be set upon success. Bug: 1045515 Change-Id: Ie7fcc17413adba447cf4045185d4717a9068350e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151459 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760474}
-
Colin Blundell authored
This KeyedService will be needed in the integration of translate functionality in //weblayer. The factory is adapted from that of //chrome (with one subtlety documented in crbug.com/1072334). Bug: 1072334, 1025620 Change-Id: Id1a53fd79c64b157224cf78d436f3567c5c0a837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153161Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#760473}
-
Philipp Hancke authored
in order to avoid RTX probes showing up on the receiving end BUG=chromium:1066819 Change-Id: Icfeead1bc08557f6cb2fc3080c20b7f4bd92be29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144080Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#760472}
-
Nasko Oskov authored
These tests use a custom observer for navigations which watched for navigation starts. As we make some internal navigation changes in WebUI the navigation starts before |observe_new_contents| returns a new WebContents. To fix this, the CL removes WaitForDidStartNavigate in favor of the more generic content::TestNavigationObserver. This is based on lukasza@'s work in https://chromium-review.googlesource.com/c/chromium/src/+/1815980. Bug: 883549, 1069939 Change-Id: I55bcfcb5bd96f32c566cca5ca0de2efd1844af70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150056 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#760471}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bb3815208a9a..869374bcab6f git log bb3815208a9a..869374bcab6f --date=short --first-parent --format='%ad %ae %s' 2020-04-20 tvanderlippe@chromium.org Port shared test runner logic into separate package 2020-04-20 sigurds@chromium.org [issues] Misc CSS improvements Created with: gclient setdep -r src/third_party/devtools-frontend/src@869374bcab6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1057979,chromium:1071369 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8334c73b6f0e4d24a1af080d30e456cb0bb9e674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156435Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760470}
-
Rune Lillesveen authored
These tests were flaky timing out occasionally on multiple platforms. Bug: 1071114, 1071418 Change-Id: Ia1e1b5edab76d35731b0d384f78d68fa79487bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152800Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#760469}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/34b3e095fffc..f059df7a4390 git log 34b3e095fffc..f059df7a4390 --date=short --first-parent --format='%ad %ae %s' 2020-04-20 skyostil@google.com base: GCC 7.1 compatibility fix Created with: gclient setdep -r src/third_party/perfetto@f059df7a4390 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibf824fa0b7425df41080692617d7de9b5cb93414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156434Reviewed-by:
-
Kazuhiro Inaba authored
This reverts commit 6aac6001. Reason for revert: Suspected culprit breaking all GAIA tests b/154460326 BUG=b:154460326 Original change's description: > cros: Enable GaiaActionsButton by default > > Bug: 1068314 > Change-Id: I5189e4dd76f6e168d9d17b2bd1bdfceeada68bc2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138072 > Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760004} TBR=rsorokin@chromium.org,raleksandrov@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068314 Change-Id: I1e51924d767996dc7725b7f231a6f08b229817f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156331Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#760467}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/chromeos/login. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=antrim@chromium.org Bug: 714018 Change-Id: I66fe82c1ecab99daed5099c6894a3372f5b4ab66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132254Reviewed-by:Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760466}
-
Mike Reed authored
See https://skia-review.googlesource.com/c/skia/+/284323 Change-Id: I2f1cf0bb519e07710b5bf179b3b69ae00ff07ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153832 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#760465}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/chromeos. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=achuith@chromium.org Bug: 714018 Change-Id: I511c3f3144faefa53f1329486d803982bc851872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132389 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: -
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/chromeos/policy. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=rsorokin@chromium.org Bug: 714018 Change-Id: I271a8e72d97a9f42ece083d6ee3257a5ac882896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132132Reviewed-by: -
Chromium WPT Sync authored
Using wpt-import in Chromium 54546e2c. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 68a6734c "[blink] Add tests for destructive writes with JavaScript modules" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: pwnall@chromium.org, mkwst@chromium.org: external/wpt/native-io NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I219f29d3186a8bf02e42522f215a8ae05abb077e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156507Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760462}
-
Roman Sorokin authored
Do not try to store kUserSpokenFeedbackEnabled in known_user for signin and LockScreenApp profiles. Known_user system is meant to store user prefs. Fixed: 957944 Change-Id: Ia55c9fd243dfdea60f60550c0d09ac21ec7d72fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153080Reviewed-by:
-
Viktor Semeniuk authored
Added aria-label for a button to fix SettingsA11yPasswordsV3 test. Bug: 1072318 Change-Id: I9cc1e79b0ed6d624d161cd02d6bc450af325c172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153043Reviewed-by:
-
Nohemi Fernandez authored
Currently we only stop the activity indicator spinning animation when the user presses 'Cancel' on the user sign-in screen. This otherwise infinite animation causes deadlocks in EarlGrey during the authentication flow. We move all activity indicator handling to the user sign-in delegate. Bug: 1005509 Change-Id: Ia775ab32346d8b67ef4842d5952a250d3208a11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144014Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#760459}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/372da931..fd2697aa Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3d34d89e7f1ef899f395d8215bfd90ade6a3b4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156506Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760458}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf3571fa2a27..361890eb3994 Created with: gclient setdep -r src-internal@361890eb3994 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sahel@google.com,pdr@google.com,mamir@google.com,meredithl@google.com Change-Id: I874dd14184879db05e0ef2f08bda375732bbecce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156427Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760457}
-
Marc Treib authored
It verifies that the watcher notifies its client when the opt-in state changes (due to a change in the sign-in state, or a change to the opt-in state itself), and also when the default storage location changes. Bug: 1024332 Change-Id: I6eeb86f95e3957f36d420f94ce68b95e6ec0bc21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153427 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#760456}
-
Swapnil authored
According to the current UMA statistics, some of the force installed extensions are installed successfully but failed to load due to some reasons. To investigate this, we report number of blacklisted extensions which are listed as force installed. Following histogram is added: Extensions.ForceInstalledAndBlackListed Bug: 1063024 Change-Id: I238f40fa269cf096d0113df2667bdf9ce6cce362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149649Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#760455}
-
Marc Treib authored
The watcher covers more than just the opt-in state, notably also the default storage location. So this makes the name more accurate. Bug: 1024332 Change-Id: Ie9fe00493b4ea4798a3e1c08c8affdf5b51407d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156405 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d51b7587167..bb3815208a9a git log 9d51b7587167..bb3815208a9a --date=short --first-parent --format='%ad %ae %s' 2020-04-20 szuend@chromium.org [issues] Remove rendering of issues kind for MVP Created with: gclient setdep -r src/third_party/devtools-frontend/src@bb3815208a9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1057979 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I691a89f746572540203408ca25decdedd3d7fa88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156432Reviewed-by:
-
Rushan Suleymanov authored
This patch fixes some crashes which may happen when a removed bookmark is restored and the corresponding entity is in unsynced state yet. Bug: 1071061 Change-Id: I857d518319e099190ecda7d33b647a3be3247d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135700 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760452}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/33b58ebb7ea8..6b265ec1dc9d git log 33b58ebb7ea8..6b265ec1dc9d --date=short --first-parent --format='%ad %ae %s' 2020-04-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 4d2298bfd78a..3f4e5c456306 (2 commits) Created with: gclient setdep -r src/third_party/angle@6b265ec1dc9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: Ife438beb21f52facd198bf7f07e900e17e039cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156425Reviewed-by:
-
Michael Lippautz authored
Rework ephemeron handling to avoid exposing marking state (HeapObjectHeader::IsMarked()) to trace traits, as this would require exposing marking state over the API of the Oilpan library. This work builds on the fact that custom weakness has been removed from collections and regular weakness is built solely around WeakMember. Using the fact that only WeakMember references need to be checked for liveness, we can eliminate the need for a trace callback for key which would just check the mark bits of a WeakMember. Removing the trace callback for key allows for removing the boolean return value of those collection-related trace methods. Followups: - Threading through WeakCallbackInfo through TraceInCollectionTrait<T>::IsAlive to avoid the last mark bit accessor from trace traits. - TraceEphemeron should not take void* and TraceEphemeronCallback for value but rather take a type T and get the callback from TraceTrait which the library allows to override. Change-Id: I4b4b369d18cbd94ab4a22a1542092cb0eb3540a5 Bug: chromium:1071168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153429 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#760450}
-
Alex Ilin authored
During the feature rollout, it may happen that the user switches back to the old consent flow after have passed through the new flow. The old flow doesn't communicate back to Chrome which account has been chosen by the user. Gaia id cached by IdentityAPI may contain incorrect information at this point, so it'd be better to clean the cache. This CL also makes Chrome send the full version number in the "lib_ver" parameter so Gaia can determine whether the current version contains the fix. Bug: 1026237 Change-Id: Icbb64afd03df9bcc344d7db1ce77072240a042c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152795Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760449}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/15a15152f054..4a5765265d3d git log 15a15152f054..4a5765265d3d --date=short --first-parent --format='%ad %ae %s' 2020-04-20 khokhlov@google.com [Telemetry] Support collecting CPU and power usage data Created with: gclient setdep -r src/third_party/catapult@4a5765265d3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:839068 Tbr: wenbinzhang@google.com Change-Id: I238469b58d7dac672e144744493da862cb9b1d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156430Reviewed-by:
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser/sync_file_system. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=nhiroki@chromium.org Bug: 714018 Change-Id: Iac1f4a57601fa88f6dec8e0c9b3c116d86bb87df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132189Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760447}
-
Yutaka Hirano authored
https://crrev.com/c/2103998 removed the only call to FrameFetchContext::CreateFetcherforImportedDocument. Now we don't need FrameOrImportedDocument any more. Bug: 961614 Change-Id: I712d18edaaa5747b0f35d778240a26c0c8f477a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105685 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Migrate this test out of web_tests/fast/css-grid-layout/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: Id3fe39a3ce2d81e8e378d55fc0b21bc74426670d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152791 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#760445}
-
Henrique Ferreiro authored
Migrate this test out of web_tests/fast/css-grid-layout/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: I52c5fb0db32eacdfe338b4970dab7841875fe150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152834 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
-
Gyuyoung Kim authored
This CL migrates grid-container-width-should-include-scroll-bar-width.html from fast/css-grid-layout to external/wpt/css/css-grid/grid-model with WPT styles, adding links to the relevant specs, and test description. Additionally, this test is renamed to grid-scrollbars-sizing-002.html to be align with existing tests. Bug: 1063749 Change-Id: Iec5c026bdcbf8d23cdef4a4789ee4c68c87e40ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153456 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
Henrique Ferreiro authored
Change-Id: I38d28df0f566aeb44c9aa3b2bbcbbdae7403e48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154794Reviewed-by:
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/POv5E.....bWXd9... Created with: gclient setdep -r src/third_party/aemu-linux-x64@bWXd9... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: Iaaf904d751331af162d3f899cc6bf6b4fe988159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156124Reviewed-by:
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //ppapi. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=bbudge@chromium.org Bug: 714018 Change-Id: If865855e4a21b08c359bc48f08ce3db258e41ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132411Reviewed-by:Bill Budge <bbudge@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760440}
-
Rushan Suleymanov authored
This patch introduces unit tests for the client tag based remote update handler. Most of cases are copied from the model type processor unit tests. Bug: 947044 Change-Id: Iac2bde9c59425760dad5c6847e7b398dec8dfe3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152786 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chrome/browser. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 714018 Change-Id: I38f7239eda0598eaeee0921e7cf666a215cabe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132370 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#760438}
-
Mohamed Amir Yosef authored
This reverts commit 830cf2c5. Reason for revert: I guess this is the reason for crbug.com/1072348 Sorry if I am mistaken! Original change's description: > Add ServiceWorkerStorageControl::ApplyPolicyUpdates() > > This is a wrapper of ServiceWorkerStorage::ApplyPolicyUpdates(). > > Bug: 1055677 > Change-Id: I85329c4651dc53851c77183b889b2abb76d2f9ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154638 > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760402} TBR=kinuko@chromium.org,bashi@chromium.org,shimazu@chromium.org Change-Id: Ic2008979c432164a3296b7bfb2b0fe860b2ad147 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154795Reviewed-by:
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: If8c6168e8bc24839e5a594412fcd0c8ac420d27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152823 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //device. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 714018 Change-Id: Ie566724abb5410a4d53751fa439972bf8db7bc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132134Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#760435}
-
