- 21 May, 2020 40 commits
-
-
Yi Gu authored
This test has been flaky under virtual/threaded test suite. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=external%2Fwpt%2Fscroll-animations%2Felement-based-offset.html Bug: 1080609 Change-Id: I2fce270915b921028411e144c0fef7326ad14e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212361Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771019}
-
Mike Wittman authored
Implements the Android native/Java stack unwinder within the stack_unwinder dynamic feature module. Adds visibility/assert_no_deps constraints to //base/BUILD.gn to avoid leaking module implementation types into general Chrome code, which would defeat the purpose of using the module to avoid Chrome binary size increase. Adds required stub declarations/implementation for MemoryRegionsMap. Bug: 1083530, 1004855 Change-Id: If9d31c4e1b9d214bb0baabe3afa8475ba7adef4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209297 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#771018}
-
François Degros authored
BUG=None TEST=out/release/browser_tests --gtest_filter="*FilesApp*" --gtest_list_tests TEST=testing/xvfb.py out/release/browser_tests --gtest_filter="*FilesApp*" --test-launcher-jobs=10 Change-Id: Id60e003aa889f6f1886f2c1332e50fb5f6080b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210041Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#771017}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b4efb6ecad4e..f045c636f9b4 2020-05-21 tvanderlippe@chromium.org Use terser rollup plugin 2020-05-21 yangguo@chromium.org Revert "Only enable custom formatters for the current session." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1016755 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icdfa4cd4da001dfc13795f3af1a42a7bfa4a269c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771016}
-
Gayane Petrosyan authored
Bug: 1084787 Change-Id: Iba082a91843becfb0080fc22029fa8a518e3d73e Tbr: tiborg@chromium.org for lint suppression Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211065 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#771015}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I2fa3f7ae8e9254c3df63a5dca80314ee27004d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211902Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771014}
-
Jiawei Shao authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d638d2df9c8c..287e93ff80ee $ git log d638d2df9..287e93ff8 --date=short --no-merges --format='%ad %ae %s' 2020-05-20 dsinclair Roll dependencies 2020-05-20 post GLSL: Add more test shaders for hit attribute types. 2020-05-20 post GLSL: Support ray payloads and hit attributes declared as Block. 2020-05-20 post GLSL: Add some more focused RT test shaders. 2020-05-19 post HLSL: Implement image queries for UAV images. Created with: roll-dep src/third_party/spirv-cross/spirv-cross TBR=cwallez@chromium.org Bug: dawn:267 Change-Id: Id9d3c0124a78ab6eff9f6c02ea55fabe5ef31af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211923Reviewed-by:
Jiawei Shao <jiawei.shao@intel.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#771013}
-
David Black authored
Bug: b:129411551 Change-Id: If61cb8184b9a2de77d8051a03d6ad5f593577c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209280 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#771012}
-
Adithya Srinivasan authored
This CL makes sure the indicator (which is a notification on android) is shown if a portal is capturing media. Currently the only way this is possible is if a page that is capturing media is adopted into a portal, but this will change in the future. Bug: 1080740 Change-Id: Iec2d5e41368e2233e86a4aba308f104dbd7ec520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170988Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#771011}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590047700-f78bd2d622c61ab01f15ac85a9b78063006149d8.profdata to chrome-mac-master-1590061793-cada8ca96f7665a04948a973b6cd8e2e12d92609.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic0a563bec6d828ad8f07ee7f390752e65f96626c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212345Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e8b8b8164520..ce285f432c39 2020-05-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 63fa9114a931 to 3c47dac28208 (17 revisions) 2020-05-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b6e8c3f0f483 to cc5cda0f997d (1 revision) 2020-05-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 4683991f7675 to a6d833327f7e (6 revisions) 2020-05-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from ca8958de1238 to 0c4ea014bf28 (2 revisions) 2020-05-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 0ab78114a9e1 to 6f723ebbe3b0 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: If277ae672b4143682307087ef8f6776c163b8941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211897Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/529df8d63450..66bd749aed4d 2020-05-21 hjd@google.com trace_processor: Add missing header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I67e6bd9c60017c98f4303a57f99f58c9f4ac1022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211898Reviewed-by:
-
Gabriel Charette authored
This reverts commit e1334196. Reason for revert: it was the wrong fix. See crbug.com/1057995#c11 for details. (keeps comment tweak on the EXPECT_CHECK_DEATH) Original change's description: > Support DCHECK-death-tests in official builds too > > This is required by win-asan which has the following GN config: > dcheck_is_configurable = true > is_chrome_branded = true > is_debug = false > is_official_build = true > target_cpu = "x86" > > R=thakis@chromium.org > > Bug: 1057995 > Change-Id: I337e214f2194d3533ea329c22fd240dddae50e5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090136 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Auto-Submit: Gabriel Charette <gab@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748849} R=wez@chromium.org Bug: 1057995 Change-Id: I549dba1babb9fdfc996b34775bd1d102ed26ba6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210489 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#771007}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3bc19daeb343..4c5b1b3a9278 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1084879 Tbr: vasilii@google.com Change-Id: I34337ab128a7592613fab9b3e7bd99cb7b433c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211620Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771006}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/11c3e48f9821..b4efb6ecad4e 2020-05-21 tvanderlippe@chromium.org Fix regex for name matching 2020-05-21 tvanderlippe@chromium.org Add rollup-plugin-terser If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1084578 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5963fa0fc2643304dc9e3b0f3ad7388df1e39df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211896Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8a3cc5c4dfd8..214c71769bbb 2020-05-21 jiawei.shao@intel.com Disallow using combined textures and samplers in shaders If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia7460d73b1992f3ed8a6a9723ca4dd01308f84db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211894Reviewed-by:
-
Eric Seckler authored
Chrome traces use CLOCK_MONOTONIC as their trace clock. If the trace only contains Chrome data, it doesn't make sense to convert its timestamps to CLOCK_BOOTTIME - in fact, this conversion could lead to cross-thread timestamp skew and misaligned system tracing events on CrOS/chromecast. This patch accomplishes this by configuring the correct clock (CLOCK_MONOTONIC in this case) as trace clock for chrome-only traces, thereby instructing trace processor not to convert timestamps. Requires aosp/1315608. Bug: 1085002,1060400 Change-Id: I5ff8660a6e27f28d27f68d72bb7cf312494431bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210427Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#771003}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: cr-fuchsia+bot@chromium.org Change-Id: I346a244ec5937979a28740b5c6c5ad60d093e398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211889Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/45e268005af3..529df8d63450 2020-05-21 ilkos@google.com Merge "Find closest timestamp when looking up RSS mem" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7180fdb603c045fa37535e40ce3b20b940088532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211892Reviewed-by:
-
Denis Kuznetsov authored
1) Rename SetDelegate to Bind in accordance with other handlers. 2) Remove unnecessary page_is_ready()/show_on_init_ logic: calls to ShowScreen / JSCall are automatically deferred until JS side is initialized. 3) Pass screen parameters as the part of the Show method. Bug: 1084928 Change-Id: I9c33b8b7330a04db430ead770eae8c347c95a5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210440 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771000}
-
Alexander Timin authored
http(s) pages are guaranteed not to have WebUI bindings. Add an explicit comment about this. R=nasko@chromium.org Change-Id: I3bf084c1e69c2bac1252c79a770659f7b26de2c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209218 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ce0a830cd582..11c3e48f9821 2020-05-21 tvanderlippe@chromium.org Move rollup configuration to front_end/rollup.config.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1084578 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2613fd480afad4374acd3f52885d06fbe7519230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211890Reviewed-by:
-
Alex Chau authored
- Methods are a mirror of NearbySharingChimeraService in Android - Added a few data types and callback to define NearbySharingService methods - Only data related methods are introduced for now. Implementations are empty Bug: 1084283 Change-Id: I18e691b76bc4872bb4a4f4771af1b368b07af6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207374 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#770997}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d10ba166d865..e8b8b8164520 2020-05-21 rafael.cintron@microsoft.com Eliminate Program::mLinkResolved boolean 2020-05-20 kbr@chromium.org Support OES_texture_{half_}float on ES 3.0 without these extensions. 2020-05-20 ianelliott@google.com Vulkan: Create a pre-rotation test for 400x300 windows 2020-05-20 jmadill@chromium.org Vulkan: Don't invalidate XFB buffers on FBO switch. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Iaa17720e98fa46692ac5094de7c1e0c43ace34c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210063Reviewed-by:
-
Nidhi Jaju authored
The order of |user_data| and |status| is different in ServiceWorkerStorage::GetUserKeysAndDataInDBCallback so this change is made to remove this indirection, allowing for the helper function in control_impl.cc to be removed. Bug: 1055677 Change-Id: Iae8b92b2574c0767887bc401325276f9db7419be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211563 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#770995}
-
yjliu authored
Summary: This is a Hackthon week project and I reworked the PrewalkTree function to be more streamlined. Please see the design doc at the following link for purpose of the project and other details. https://docs.google.com/document/d/1D1MTNTaJnZjbmMZGMz0u150N3u5evEFSmJU-ou2vcFw/edit#heading=h.c0uts5ftkk58 In short, the original PrewalkTree() is as follows: --------------------- // Returns the damage rect of the surface gfx::Rect PrewalkTree(Surface* surface) { ...... // Gather all the embedded child surfaces into a flat_map FindChildSurfaces(&child_surfaces, ...) // Iterate through the child surfaces to accumulate damage gfx::Rect damage_rect; for (child_surface : child_surfaces) { damage_rect += PrewalkTree(child_surface); // apply quad transform here } // ...do some other stuff return damage_rect; } ----------------- I modified it to: ----------------- // Returns the damage of a surface gfx::Rect PrewalkTree(Surface* surface) { ...... RenderPass* root_pass = surface->GetActiveFrame()->render_pass_list.back(); return PrewalkRenderPass(root_pass); } // Returns the accumulated damage of a render pass gfx::Rect PrewalkRenderPass(RenderPass* render_pass) { gfx::Rect damage_rect; for (DrawQuad* quad : render_pass->quad_list.reverse()) { // in reverse order if (quad is SurfaceDrawQuad) damage_rect += PrewalkTree(quad_surface); // apply quad transform here else if (quad is RenderPassDrawQuad) damage_rect += PrewalkRenderPass(quad_render_pass); // apply quad transform here } return damage_rect; } ---------------- Bug: N/A Change-Id: I662e93b3f61cd7102c54ca4ba1c2183d6233ac0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175315 Commit-Queue: Jun Liu <yjliu@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Also adds a new service-emitted field to the privacy whitelist. Forked from crrev.com/c/2211474: --- Roll Perfetto from 169feea71d1f to 45e268005af3 (4 revisions) https://android.googlesource.com/platform/external/perfetto.git/+log/169feea71d1f..45e268005af3 2020-05-21 taylori@google.com Merge "ui: Add binder atrace categories to record page" 2020-05-21 taylori@google.com Merge "perfetto-ui: Don't catch query errors" 2020-05-20 treehugger-gerrit@google.com Merge "clock: Support specifying an authoritative trace clock in the config." 2020-05-20 treehugger-gerrit@google.com Merge "build: Fix libperfetto NaCl build" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Change-Id: I3a769225a7837885701868096cfa181326622f0f Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210448 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#770993}
-
Jinsong Fan authored
The NetLog is now an internal detail of the network service. And this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1695293 still left dead codes about NetLog. The CL removes it for code health. Bug: 963875 Change-Id: I01c246b95a961b219bb4c93fd4b40743f9ba5e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192536 Auto-Submit: Jinsong Fan <jinsong.van@gmail.com> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#770992}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590019092-d032408a4c7d66eb8e8eaad56f5f62575a89e2db.profdata to chrome-win32-master-1590047700-a706b1a99569faae4b31ea10afb5af7a8db8e3e7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I31ef5b5680f1f16e83a9057e750b290ae33581fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211888Reviewed-by:
-
Gabriel Charette authored
R=grt@chromium.org Change-Id: Ibcc042cddf089adb42aafb5d98fcb71888306ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210022Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#770990}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 84-4129.0-1589191546-benchmark-84.0.4142.0-r1 to 84-4136.1-1589797128-benchmark-84.0.4147.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I65b580882f7906aaf602ce3234a2f5fa5ef287c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211884Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 84-4136.1-1589194235-benchmark-84.0.4142.0-r1 to 84-4136.1-1589794882-benchmark-84.0.4147.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ieb9265dc978c69e7fc4b1a034d25ed69c6420089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211883Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590033536-e720add817899a0a9587c78e7de615e881dda3e9.profdata to chrome-mac-master-1590047700-f78bd2d622c61ab01f15ac85a9b78063006149d8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3baa469e2587ddb2fd4e30fcdfc80ec8f96f33f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211881Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d0ecac7c1172..e5d042ae732b 2020-05-21 abennetts@google.com Aggressively defer imports in sheriff_config_client. 2020-05-21 abennetts@google.com Update bq_rows export job for updated schema. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1082639 Tbr: sadrul@google.com Change-Id: I5469de1c381d72d42480b27e0669de525d42d0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211617Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie5e87ddca7426bf08231bb3368341ab196a78ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211721Reviewed-by:
-
Johann authored
Use HeapMojoRemote wrapper for authenticator_, credential_manager_, and sms_receiver_. This puts the objects on the heap so that Oilpan will manage/GC them. Bug: chromium:1049056 Change-Id: I7d8d281780c667cfd9feeded592587d74572c90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144805Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#770984}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2e0f0a0517e4..6f723ebbe3b0 2020-05-21 mbechard@users.noreply.github.com fix incorrect error when multiple compilation units don't declare layouts (#2238) 2020-05-21 shuizhuyuanluo@126.com Add an option to make Exceptions enabled (#2239) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I4c0833f4c1681d673c21419c331148a17c601350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211616Reviewed-by:
-
Hitoshi Yoshida authored
"unspecified" is not a member of IDL enum 'CookieSameSite'. Before this CL, the code set the invalid value on CookieListItem. sameSite. This CL fixes it, and leaves the dictionary member unset if UNSPECIFIED was passed. Bug: 839389 Change-Id: I61c01c6cd20990f9dd48456c7e50d06f7c93d385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210293 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770982}
-
Giovanni Ortuño Urquidi authored
This CL helps fix two issues: 1. For default apps, `add_to_applications` is set based on `create_shortcuts`, which according to its documentation controls whether the app is pinned to the shelf. Currently, no default app sets `create_shortcuts` to true, so `add_to_applications_menu` is always false. This wasn't an issue with Extensions because the field was ignored, but it is an issue with BMO where we use that field to decide whether the app should show in the app launcher or not. To address this issue, we could simply set `add_to_applications_menu` to true, but that would be a problem for default apps that don't want to be shown in the launcher. 2. Some default apps don't want to be shown in the launcher, but currently there is no way for them to specify this. To address both issues, we introduce a new `hide_from_user` field for default apps. The value defaults to false, so it fixes issue 1. above, and can be set to true by apps that don't want to appear to users, which addresses issue 2. Also fixes some test files that were missing the user_type field. Bug: 1084887 Change-Id: Id77a4f50eae3fb4517bca26b76aeb737161df431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210179 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#770981}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 84-4136.1-1589189756-benchmark-84.0.4142.0-r1 to 84-4136.1-1589799722-benchmark-84.0.4147.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I8344a095e42ac9a215a52e57720af5344774b02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211522Reviewed-by:
-
