- 28 May, 2019 40 commits
-
-
Xiaocheng Hu authored
Since we have now supported CSS-generated contents in |NGOffsetMapping|, we should make sure an |NGOffsetMappingUnit| is not CSS-generated before calling |GetOwner()|, otherwise we should use |AssociatedNode()| instead. This patch converts too calls of |GetOwner()| into |AssociatedNode()| so that we don't hit the DCHECK in |GetOwner()|. Bug: 967106 Change-Id: I62c362d93ba0608d0e6bcdd74c0d27fe0ffa7554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632900 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#663983}
-
Ehsan Karamad authored
The process of creating MimeHandlerView is: * Navigation to resource starts * MimeHandlerViewEmbedder is created * HTMLPlugInElement::UpdatePlugin is called * MimeHandlerViewContainerManager is notified * HTMLPlugInElement creates a frame * MimeHandlerViewEmbedder observes the new frame and attaches GuestView, and destroys itself. These steps are legitimately disturbed when the embedder is not authorized to load plugins (e.g., in <webview> when using permissions). In such cases, the update from HTMLPlugInElement does not reach the MimeHandlerViewContainerManager and also a plugin frame is not created. Therefore, MimeHandlerViewEmbedder does not get destroyed. This CL will change the update process so that even for blocked plugins the MHVCM is notified (of the failure) which gives it a chance to notify the browser in turn and clean up the MimeHandlerViewEmbedder. In line with the change, the test: WebViewPluginTest.TestLoadPluginInternalResource is modified to assert no MimeHandlerViewEmbedders are lying around. Bug: 967045 Change-Id: Ic63a980883240fe8098a4ee8d5e3ae3b9cc46415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629071Reviewed-by:Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#663982}
-
Mei Liang authored
This CL refactors some tab group specific logic in TabLiseMediator#onMovedTab() to TabGroupModelFilter. And TabListMediator should listen to additional the TabGroupModelFilter.Observer to update the UI model. Change-Id: Ieb7bf00b4811956b11dbb0a44fcc3f6415cd4340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628272 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#663981}
-
Kyle Milka authored
Add a flag to show a Google Search shortcut on the NTP by default. Only add the shortcut if this is a Chrome branded build. Bug: 962558 Change-Id: I4f5cd18b0dc3182264057f55eb381cb94d6ee49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614457Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#663980}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I26ffa0087edc9ef4feea29b7ab7f30b566ae3c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663979}
-
Evan Stade authored
ShowWarningBanner() and HideWarningBanner() are combined into UpdateWarningMessage(). TBR=tsepez@chromium.org Bug: 958206 Change-Id: I1569d2cec960357c5e6151bdfc32800be495c268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629428 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#663978}
-
Khushal authored
R=piman@chromium.org Bug: 958981 Change-Id: I28cc5808f02c17b372e0557652c188ae1e2b9a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632899 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663977}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/12d7da217249..698a4380c296 git log 12d7da217249..698a4380c296 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 tsepez@chromium.org Remove unneeded circular include between fpdfdoc and fpdfapi/page 2019-05-28 thestig@chromium.org Minimize allow_circular_includes_from entries for fxge. 2019-05-28 thestig@chromium.org Move AdobeCMYK_to_sRGB functions to fxge. 2019-05-28 thestig@chromium.org Break circular dependency between fxge and fpdfdoc. 2019-05-28 thestig@chromium.org Rename |g_CMYK| to |kCMYK|. Created with: gclient setdep -r src/third_party/pdfium@698a4380c296 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ib132633eff1dea4222e61e1f2096ae25c1cddc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632972Reviewed-by:
-
Gil Dekel authored
A lightweight WebP parser that validates that a given data stream encodes a lossy WebP image by following the WebP Container Specification found at: https://devsite.googleplex.com/speed/webp/docs/riff_container After format validation, the parser uses the Vp8Parser to parse the VP8 key frame and returns a Vp8FrameHeader when parsing succeeds. Note: This parser only supports lossy WebP formats. There are two reasons in favor of rolling out a new lightweight WebP parser (instead of using libwebp): 1) It's going to be used both by the render and gpu processes. Avoiding a third-party lib is preferable. 2) the Vp8Parser was written to fit the VA-API better, i.e. it produces objects that can be fed into the VA-API with minimum processing. This change also moves the VP8 parser from //media/filters to //media/parser. Bug: 877694 Test: WebpParserTest.* Change-Id: Ia553bc320cf0c136a859d24a4422e2bcc6e9c2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617637 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#663975}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bcf517c0..2cb25737 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2b96edd135093ea4854ccce28cea1bfe0d06381c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632878Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663974}
-
James Cook authored
It was added as part of the mustash project to work around test failures due to minimum window sizes. "chromeos: converts WindowState to aura::Window" https://codereview.chromium.org/2901663003 That CL's comments mention making the windows bigger as a better workaround. This CL increases the window widths to >104 dips, which appears to be our current minimum. Bug: none Test: ash_unittests Change-Id: Icb79d12bb48dc8335bdfb6346297fc777d0abe9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620485 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Drew Stonebraker authored
This is primarily to move the main content from https://www.chromium.org/developers/androidwebview/android-webview-beta to our new location for docs in markdown. Also, this adds some detail that the previous chromium.org page didn't have. Bug: 965357 Test: Click on the markdown file in this CL, then click "gitiles" at the Test: top of the page to view in formatted markdown. Change-Id: I55dffa24e3fb72b5a2eaf87de2a47a8d9e362af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621490 Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#663972}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c5b8a73247c4..10e57cf61851 git log c5b8a73247c4..10e57cf61851 --date=short --no-merges --format='%ad %ae %s' 2019-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@10e57cf61851 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I194e77a3dc7ba23f35e6ce8b6d83163f65575ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632808Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd40163541b4..0499a4436c35 Created with: gclient setdep -r src-internal@0499a4436c35 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Idc5b3a5eebec4fb56b6bdda957d6793716c85b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632971Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663970}
-
Mounir Lamouri authored
We would like to skip M76 as we may need to revisit the design based on new features coming into the Picture-in-Picture API. Bug: 940404 Change-Id: Iec0912a249fd0fbbed16103548aaa64fb0842921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632119Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#663969}
-
David Bienvenu authored
This matches the behaviour of ClipboardAuraX11, which allows OmniboxViewViewsClipboardTest to use the test clipboard. Bug: 963112 Change-Id: I59cdc24bb7ecd2bd904505e38df133b31ed48104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630012Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#663968}
-
Eric Roman authored
Change-Id: I787964b93b8f96200172d01b52f8865de2679c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629014Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663967}
-
Brandon Wylie authored
* Adding abstract methods to ContentCaptureController for data clearing. * Adding observer for content capture. * Hooking up the observer to the HistoryDeletionBridge. Bug: 954404 Change-Id: I80ef890d619914d3b4f9f7fe50fc192ac5f9a10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623529 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#663966}
-
Zhenyao Mo authored
It looks like nouveau driver changed their GL_RENDERER string and avoided being blacklisted by Chrome. BUG=959766 TEST=bots R=piman@chromium.org Change-Id: I118f3796f101ed26517c9e360370a7176d55de21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625817Reviewed-by:
-
Jeremy Roman authored
Bug: 967095 Change-Id: I85ffd419c43f4715ce6fcf9857b08d340d605554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629287Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#663964}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a53cda46. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" be76d09e "[ServiceWorker] Reject update() from within installing workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure igrigorik@chromium.org, yoavweiss@chromium.org: external/wpt/preload nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Iab9504d8b33771061ba767abddd54f5388227939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632869Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663963}
-
Nicolas Ouellet-Payeur authored
The policy is not completely implemented yet, so it should have been marked 'future'. Bug: 958659 Change-Id: I814d39f998de5d55466e95fbeaf2d70a11dcfc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630975 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#663962}
-
Adam Ettenberger authored
I wasn't able to reproduce the failure, but according to the error logs they suggested that for some reason, word-wrapping was likely different from public Chromium and closed Chrome. This could be something subtle like differences in fonts, scroll bars, or potentially DPI differences in the test environment. Updating the test to avoid these types of differences. Adjusted the text so that line breaks will be more predictable, leaving ample room for and scrollbar differences. The error was : --- error: Expected equality of these values: L"G H I J K L " provider_content Which is: L"G H I J K L M " --- Bug: 966344 Change-Id: If978ce1fe03984c64151241e6241cdfc29d900c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627927Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663961}
-
Paul Jensen authored
This was an accidental bug introduced in r659155 that only happens in the weird cases where NetworkChangeNotifierWin fails to watch for address changes. Bug: 967297 Change-Id: Ic4a575599be4ae4e150f19f672cf07aa82376e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632449 Auto-Submit: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#663960}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3971b19ba242..90cb260644cd git log 3971b19ba242..90cb260644cd --date=short --no-merges --format='%ad %ae %s' 2019-05-28 bclayton@google.com Reactor: Fix all memory leaks with rr::DebugInfo. Created with: gclient setdep -r src/third_party/swiftshader@90cb260644cd The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133399620 TBR=swiftshader-team+autoroll@google.com Change-Id: I6e3b9720aa4e962e36613ae14ff1806d57f194b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632807Reviewed-by:
-
Peter Kotwicz authored
This CL changes the test WebAPK APK to handle file sharing BUG=967792 Change-Id: Id184bd063f5a43d2d10d11d9e19494a0bdbf073a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632793Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#663958}
-
Vladislav Kaznacheev authored
There is no way to add an icon to a menu item provided by a platform app via chrome.contextMenus API. This CL detects that this particular item is being added (by checking the app id and the menu item label) and adds an appropriate icon to it. This method can be applied to other apps if necessary, which will require hard-coding app id, label and icon for each new case. Bug: 943319 Test: manual Change-Id: I9536e8dc7ab2d8623fca8b4d68cfb776e5053a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632909 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#663957}
-
Andrew Xu authored
A recent CL allows to focus on the notification. As a result, when notification gets the focus from AppList, AppList will be dismissed because of losing the focus. This CL fixes the issue. Bug: 948344 Change-Id: I0fd7d150548afc8e74d1ab406407fe3c1d7b2334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627701 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Azeem Arshad authored
This CL adds a base-page element and skeleton ui for all steps of the cellular setup flow. Texts and page body for all page contain placeholder texts. Actual implementation and styling for theses pages will be added in a follow-up CL. See go/cros-cellular-activation-ui-design for UI design. Bug: 962702 Change-Id: Id4999fe6cb0f53838ce9d5b6fce9d99c5a85eca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616449Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#663955}
-
Elly Fong-Jones authored
Bug: 406227 Change-Id: I01b4eda623ff850daa5954fc55b617cd15931441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632390 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Vlad Tsyrklevich authored
Long-lived allocations can consume all of GWP-ASan's memory early, resulting in uneven sampling over the process' lifetime. Report how many total allocations (e.g. taking into account the the sampling frequency) it took before OOM. Break these reports out by allocator and process since behavior varies significantly based on these factors. This metric will help measure whether we are frequently running out of allocations early for a given allocator/process and will help track future memory improvements. Bug: 963711 Change-Id: Ifef2d61ee3fb589a4b55fcf2b93f7f64096e43f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628288 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#663953}
-
Haiyang Pan authored
Add shard maps and disable failing tests for pixel2 devices This involves updating the shard number in bot_platforms.py and perf_data_generator.py, and running the following commands to update the json files: ./tools/perf/generate_perf_sharding update \ --builders android-pixel2-perf \ --builders android-pixel2_webview-perf ./tools/perf/generate_perf_data The tag "Pixel2_Webview" in expectations.config will be added in this review: crrev.com/c/1628818 Bug: 867592 Change-Id: I332a5ae8cff1598729775889418f28a67230a82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628172 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#663952}
-
Sébastien Séguin-Gagnon authored
Filter out devices with the same name as the local device from the list of target devices. This is because there can be different device_info objects for the local device that have different cache guids. Bug: 957716 Change-Id: Idf279a9cb2298657c6d6cfa03f0dde62b0587473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625904 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#663951}
-
Will Harris authored
This is Neilsen//NetRatings NetSight DLL and is causing hangs and crashes. Tested with NeilsenOnline v8.3.0.14084. BUG=712548 Change-Id: I5b9e960a4027a772a34eb7243363871075155fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625932Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#663950}
-
Fabio Rocha authored
DevTools: Fix small bug where Console shortcuts were only displayed if Console had been previously launched The Console shortcuts were only displayed in the shortcuts panel (in Settings) if the Console had been loaded previously, otherwise the Console shortcuts section would be empty. The reason was that the Console's descriptors weren't registered in the same place as all the other shortcut descriptors. The fix was a small refactor to extract descriptors into ShortcutScreen.js. Also did some cleanup in there to improve consistency. Change-Id: Ifee95da25208c6eace4a5be9775432bfb1880138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625926Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#663949}
-
Ben Pastene authored
Bug: 966656 Change-Id: Ia50f38ee1b39ed9239f0f45192f29f758a677a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629697Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#663948}
-
Robert Ogden authored
The stale timestamp histogram is not logged with the new UI unless the page info dialog is opened which can't be done in a ChromeDriver test. Bug: 966667 Change-Id: I7ea17209352a1e18b0b4012da4c396c96125a51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632116 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#663947}
-
arthursonzogni authored
When a frame is unloading in one process, it must not be visible from the other processes at some point. Previously, it was done when the frame completed the unload, now it will be done when it starts unloading. To achieve that, the RenderFrameProxyHost are removed when the frame starts unloading. Moreover, no new RenderFrameProxyHosts are created in a frame with an unloading current document. + 2 tests added, originally made by lukasza@chromium.org (Thanks!) Addition in the reland: ======================= + 1 regression test. A subframe is focused and unloaded, then another document commit. To prevent the previous regression, the focused frame is reset when unloading starts, instead of when it ends. Bug: 960006, 950625 Change-Id: I225118ee6385b3f843107adefe05d605d27703cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626412 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#663946}
-
danakj authored
RegisterInProcessThreads() is called to set up using single process with child processes running in threads. It must be called for: - Chrome unit tests - Android Content browser tests - Android Chrome browser tests Currently it is called in ContentBrowserTestSuite and ChromeUnitTestSuite which excludes the 3rd case. This adds a call in ChromeTestSuiteRunner, which is used to run Chrome browser tests. Bug: 961849 Change-Id: I371eb8777ba1fbe8b1dd7f4426dc15144392cad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610717Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Peter Kasting authored
* Convert some to range-based for * Convert some to STL algorithms * int -> size_t for object counts in a few places * Other misc. cleanup, e.g. removing unnecessary {} Bug: 940126 Change-Id: I9c50e1d40cef2f09d1e8dee9b051ab34cf0c59b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629712 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
