- 21 May, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1589947115-d59e956e9f0cd8de69b108c77019d85951a98a26.profdata to chrome-win32-master-1590019092-d032408a4c7d66eb8e8eaad56f5f62575a89e2db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5e9e61eb1ff5dfcf41ba611e6a572186d22fbf08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770895}
-
David Tseng authored
R=hirokisato@chromium.org AX-Relnotes: n/a Fixed: 1056072 Test: manual Change-Id: Ia4e93e745ab8bdd93ca7fee324efbae258e4d236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209992Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#770894}
-
Will Cassella authored
This CL fixes all style warnings in FFmpegDemuxer that make error/warning based IDE navigation cumbersome. There should be no functional changes in this CL. Change-Id: I30371e6a889d29d553f95aa275e98cfd05591b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211081 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#770893}
-
Eric Lawrence authored
Update two comments about the behavior of the http2-grease-frame-type feature to better describe exactly what it does. Change-Id: I2b5269a3117a499067f111fa25cacd5cc067f0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209606 Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#770892}
-
Kent Tamura authored
It's helpful to adjust line height for ruby annotation text. This CL has no behavior changes. The new code is behind a runtime flag. Bug: 1069817 Change-Id: If6b9a89927239c8e92a882e4e0a7bb049f736189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210033 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#770891}
-
Jeremy Roman authored
It merely calls another function and passes all its arguments. Change-Id: I49f072fc5a0d4d902987f065b24ff99aa11271c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211084Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770890}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/87caae61cdf1..f83baf230c69 2020-05-20 egdaniel@google.com Fix D3d window context after submit change. 2020-05-20 reed@google.com use strokeandfill patheffect, and fix it 2020-05-20 csmartdalton@google.com Use pow2 rectanization for the hw tessellation atlas If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I977a515ccb55474ba42b996c3b590fb4164460d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209956Reviewed-by:
-
Yulun Wu authored
The hotseat widget was refactored to calculate its own opacity. As a result, we are seeing unintended behavior where SetDimmed() is setting the shelf opacity to 0 because the hotseat widget's CalculateOpacity() returns 0 in the auto hidden state. We are fixing this by: 1. ignoring calls to SetDimmed when the shelf is in the hidden state. It doesn't make any sense to modify animate opacity of something hidden. 2. setting up an auto-hide lock while setting up opacity animations. This prevents the auto hide state from changing during animation setup. 3. Activating/undimming the shelf when it is no longer auto hidden. Bug: 1081835 Change-Id: I87ccf82947d1ca98a154c718f63413ae60a03fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207976 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#770888}
-
Brian Sheedy authored
Suppresses the test failures on the Windows 10 UHD 630 machines caused by SCALING being reported instead of DIRECT. TBR=ynovikov@chromium.org Bug: 1079393 Change-Id: I9fbaaa00355ceecabfa336c6ecf34b4984b6153b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211047Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770887}
-
Tomasz Wiszkowski authored
This change introduces only a flag variant for existing feature switch that will allow presenting PZPS on NTP. Bug: 1085256 Change-Id: I29a03f9bfaca6c521adaaad37c6eb652d8d52a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211240 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#770886}
-
Kyle Horimoto authored
This is required so that Launcher code can generate parent subpage/section results. Bug: 1082249, 1071700 Change-Id: I19cfba1c5f99df7621e7b3614371c4227965ad62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211234 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770885}
-
yilkal authored
This cl updates string identifiers for coexistence info in chromeos_strings. The strings have not been updated. The string identifiers are updated to help us enforce the update of kConsentScreenTextVersion. Bug: 1082336 Change-Id: Ic2d4f346056ee76326322bb8c8870edffed62d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211143 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#770884}
-
Nidhi Jaju authored
The order of |values| and |status| is different in GetUserDataCallback and GetUserDataInDBCallback, so it is standardized to (status, values). Hence, the helper function in control_impl.cc can also be removed. Bug: 1055677 Change-Id: Ia469fa2b8e6212a8d3fe7d50bbb56e356b4a6def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206860Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770883}
-
Xing Liu authored
This reverts commit 502e4320. Reason for revert: incorrect revert, the error log is for the original CL. Original change's description: > Revert "Reland "Add simple info bar to opt-out for conditional tab strip"" > > This reverts commit 496003a3. > > Reason for revert: Appears to still be breaking the build. See: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879762809032212800/+/steps/compile/0/stdout > > Original change's description: > > Reland "Add simple info bar to opt-out for conditional tab strip" > > > > This reverts commit 2808b517. > > > > Reason for revert: Add missed dependency. > > > > Original change's description: > > > Revert "Add simple info bar to opt-out for conditional tab strip" > > > > > > This reverts commit e4d36bfb. > > > > > > Reason for revert: breaks download stream compile, might be build issue. please do "gn check target". > > > > > > https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8879764778699702672/+/steps/compile/0/stdout > > > > > > Original change's description: > > > > Add simple info bar to opt-out for conditional tab strip > > > > > > > > This CL adds an info bar for conditional tab strip to allow user to > > > > opt-out the feature. Some behavior of the info bar: > > > > > > > > * It will show after three consecutive sessions of dismissals. > > > > * If user clicks the "Don't show again" button, conditional tab strip > > > > will never show for this user in later sessions. > > > > * If user clicks the "Show later" button, conditional tab strip > > > > will show again for this user in later sessions, and the info bar will > > > > never reshow. > > > > * If user clicks the dismiss button to dismiss the info bar, the info > > > > bar will reshow after another three consecutive dismissal, but the > > > > limit times of info bar showing is two, i.e. 6 consecutive sessions of > > > > dismissal. > > > > * When the info bar shows, the undo snackbar will not show. > > > > > > > > Note that this is the simple version of info bar that we want, in that > > > > it is tied to one tab and cannot live across tab navigation. > > > > > > > > Bug: 1076295 > > > > Change-Id: Icbb322af639ff5cf4ab8421d12ce428cc1b006eb > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206216 > > > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > > > Reviewed-by: Evan Stade <estade@chromium.org> > > > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > > > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#770632} > > > > > > TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org > > > > > > Change-Id: Id57987bdbf4cb0bb461e9b3ee44f636fa9db330e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1076295 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209899 > > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > > Commit-Queue: Xing Liu <xingliu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#770647} > > > > TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,xingliu@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org > > > > # Not skipping CQ checks because this is a reland. > > > > Bug: 1076295 > > Change-Id: I89ec83eb3211a090f8e21004418eede65330959d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209902 > > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > > Reviewed-by: Yue Zhang <yuezhanggg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#770763} > > TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,xingliu@chromium.org,hnakashima@chromium.org,yuezhanggg@chromium.org > > Change-Id: I0681a7197eead16839263f4bdada5058856e73e7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1076295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210973 > Reviewed-by: Kyle Milka <kmilka@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770827} TBR=estade@chromium.org,yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,xingliu@chromium.org,hnakashima@chromium.org,kmilka@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1076295 Change-Id: I40300673dd705d6622ac9eddab926383376aabdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211058Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770882}
-
Sammie Quon authored
Spec wants a cross fade animation that is linear and 120ms. The target bounds are often changing as well since the window is in a drag. Modify current cross fade animation to take in different tween and times. Since the animation happens while the window is in a drag and the bounds are being updated, add a new animation observer. The new created layer animates towards identity transform so changing the bounds is ok. The old layer is a bit trickier to deal with so on a animation tick, update the transform so that the old layer is always aligned with the new layer. Follow up will add metrics so we can have a perf test. Test: manual Bug: 1081986 Change-Id: I46882c0a11b7ea2c97b1c8802a9c65184b384c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204813Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#770881}
-
Xianzhu Wang authored
to avoid the extra dependency of Chrome to org.apache.http.legacy. Bug: 1084879 Change-Id: I8975bf0d82e56301bec74d54fef2e4ace058ff50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211145 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#770880}
-
Kyle Horimoto authored
This CL adds a Hierarchy::SubpageMetadata::ToSearchResult() function which can be used to create a search result for any arbitrary subpage. This will be used to add parent subpage results corresponding to any child setting. Bug: 1082249, 1071700 Change-Id: Ie80b84c4c465d8442a642461b4c25256c058319d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211003 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Tom Anderson authored
We haven't yet whitelisted the necessary dri files in the GPU sandbox, which is leading to issues like 1077609 and 1077626. Since GMBs are not yet supported, avoid loading GBM unless --enable-native-gpu-memory-buffers is passed. Bug: 1077609, 1077626, 1031269 Change-Id: Ic052d2e89330c6558da86a91b77637229808102f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211120 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#770878}
-
Stefan Zager authored
BUG=1060884 R=pdr,horo Change-Id: I02dd164be11fc206379ecf08da6f4b4129cc1a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202125Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#770877}
-
Kenichi Ishibashi authored
We still want to have these UMAs. Bug: 1084053 Change-Id: I6224cef8fec9feca95be87ca9165b03c2ec17253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208158 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#770876}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590004011-c7e121da0d5a86abd485d92fadbd2d4beb7d781b.profdata to chrome-mac-master-1590019092-0150ca95063dc0ad33468a89535d4804f9e0bc6b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I8aace7ab099334863d49d655e97c004cd047958f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211029Reviewed-by:
-
Devlin Cronin authored
We still need it around. Extend it through M87. Bug: 1085244 Change-Id: I61c18a1968687d4cf822ea8f8fcd684a98bf6340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210447Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770874}
-
Takashi Toyoshima authored
This reverts commit c24f6f28. Reason for revert: enabled back again. Original change's description: > OOR-CORS: Disable by default on Android for safe WebView launch at M83 > > Disable OOR-CORS by default on Android again to mitigate risks on > launching the feature on WebView M83. > > Bug: 1084380 > Change-Id: Idd1a1aa9ef2ce813de78fe7d6ea3d5835bf8f2e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206565 > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769990} TBR=kinuko@chromium.org,toyoshim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1084380 Change-Id: Ia5d8477fffaa77eaf5181d8106c734f1c5529cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210178Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#770873}
-
Michael Hansen authored
Adds the FastInitiationManager class which will broadcast advertisements with the service UUID 0xFE2C. The broadcast data will be 0xFC128E along with 2 additional bytes of metadata at the end. Some remote devices background scan for Fast Initiation advertisements, as a signal to begin advertising via Nearby Connections. Bug: b:154846208 Change-Id: I73667d99993e289488b7719e10467c9344b7b3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190743Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#770872}
-
Adam Langley authored
With all the changes recently to handle known key types, this change adds a test to ensure that RPs and authenticators can still negotiate an unknown public key algorithm and the key will pass through successfully. Change-Id: Ia63cdc89beef9182835a02ab28b9f64164917c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204086Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#770871}
-
Allen Bauer authored
NotificationOverflowView Bug: 1044687 Change-Id: I4625c0c13447b930c7f1c87b8ea33cdcc3d10f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209301Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#770870}
-
Jeff Yoon authored
* mb configs are set in mb_config.pyl * *.star changes are for setting the recipe to Chromium * the release branches use the mac_ios_builder definitions, so we cannot set recipe:Chromium as default. Will do this after M83. * tests are defined under testing/buildbot * crashpad tests have been left out as they were unable to be migrated to EG/EG2 formats, per conversation w/ rohitrao@ Bug: 1078906,912681 Change-Id: I65c9db47f9173f542ddd4d0e28757f8a54c06367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188234 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#770869}
-
David Bertoni authored
GetAuthTokenFunctionPublicSessionTest.Whitelisted was disabled for flakiness in 2018. I tested this on both release and debug configurations of ChromeOS and it passed 3000 iterations. Bug: 830052 Change-Id: Ibdca8b58eb9800946791c919f098dd16284e22bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209388Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#770868}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/008b71ab1384..d3affaa62488 2020-05-20 sokcevic@google.com Use OS level locking in git_cache.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1049610 Tbr: agable@chromium.org Change-Id: I72cbbaecc3ab7ebd9f5dd5b767d7f05738d379ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211023Reviewed-by:
-
Thomas Guilbert authored
This CL adds new video.requestVideoFrameCallback tests, that verify the behavior of the API when it is used on elements that are not visible, or that have been removed from the DOM. The CL also adds videos created in existing tests into the DOM, which makes the tests closer to the expected usage of the API. This addresses the following github issue: https://github.com/WICG/video-rvfc/issues/30 Bug: 1012063 Change-Id: Ic9bf3fc1a09fd77b20abbfdcfb39bbd1851da99e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207947 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#770866}
-
Joel Hockey authored
Turning on DesktopPWAsWithoutExtensions flag in crrev.com/c/2208319 has caused a crash when logging into CrOS. Bug: 1084846 Change-Id: Iaddf78f84231b1ed4ef103c9961b411e1dab6171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210195 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#770865}
-
Alice Boxhall authored
Bug: 1051141 Change-Id: I1566eb705f583ee44fcf627b38a7bd99895f83de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208807 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#770864}
-
Brian Sheedy authored
Carries over a pixel test suppression specific to Intel HD 630 GPUs to Intel UHD 630 GPUs, as the same failure is showing up on the newer GPUs. TBR=ynovikov@chromium.org Bug: 1053803, 997313 Change-Id: Ica3dbfec3f0041a0726a76a008da7272500c0912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202784Reviewed-by:
-
Clark DuVall authored
We were recreating the AutofillProvider every time TabImpl.updateFromBrowser() was called, which cancels the current autofill request. updateFromBrowser() is called for various reasons, and can be called multiple times with the same context. Bug: 1083051 Change-Id: I7336566002b20f4dbcbaa5c489e4bfa92d1c4ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211041Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770862}
-
Eric Lawrence authored
Logging calls to NetLog in the SpdyStream object were inconsistent and overly verbose. This patch makes them simpler and consistent. There should be no functional change. Change-Id: I689dcdbcea4673223c5a34c173065b72125e6686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210553 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770861}
-
François Degros authored
Added tests showing that the zip-no-nacl flag has no impact on Files App at the moment. BUG=912236 TEST=browser_tests --gtest_filter="ZipFiles/*" --gtest_list_tests TEST=browser_tests --gtest_filter="ZipFiles/*" Change-Id: I40d3bc780e75b90407e07fcecc4e90f3e0aea83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203169 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#770860}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f02db5d3be5..c256b1f2a5f3 2020-05-20 soxia@microsoft.com [DevTools Frontend] Add missing icons. 2020-05-20 sigurds@chromium.org Typescriptify HeapProfilerModel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8c7607af4677265cc63e82611ee7a6b809ba6548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211022Reviewed-by:
-
Hiroki Nakagawa authored
This CL modernizes the test using async/await, arrow functions etc for improving code readability. Bug: 1075582 Change-Id: I00b9da946299fd0e9e93204514e0857adc85ef93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208885Reviewed-by:
-
Jing Wang authored
- Record coverage metrics only when we show the suggestions - Change current coverage metrics to match metrics. - Add disabled metrics Previously we were recording coverage metrics for personal info in a wrong place. Now we moved it to the correct place and added a new metric for all the match scenarios. Add disabled metrics for cases where we could show suggestion but the feature is turned off. For personal info suggester, we only record coverage metrics when we first show a suggestion so that we won't record dup metrics when the user keeps typing with suggestion shown. Test: tested with Chrome on Linux Bug: 1042084 Change-Id: I6559d81f8d3fc5fa2f9385a4df617f0ac06c5848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208577Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#770857}
-
Will Cassella authored
base::TimeDelta will fail a DCHECK if you ever try to add -INF and +INF time deltas. A consequence of this is if you have a video with a -INF start_time and you try to seek to +INF, the current code will trigger that DCHECK. This CL fixes that by settings -INF start times to 0. This is consistent with how +INF start times are handled. Bug: 1077685 Change-Id: I4e7fd453aab7a6b15befbb52b708d56febb943ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194917Reviewed-by:
-
