GitLab

Security requires fingerprint lock out after too many attempts. So remove
try again later from the message.
See discussion in go/cros-fingerprint

Bug: 835357
Change-Id: Id3551dceb0d80d3f839172c1e321ff168c8b8c92
Reviewed-on: https://chromium-review.googlesource.com/1165951Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581340}

This reverts commit 96cfcfde.

Reason for revert: reenable Telemetry perf benchmark coverage

Original change's description:
> Temporarily disable Telemetry perf test on Mac builders
> 
> NOTRY=true  # covered by PRESUBMIT tests
> 
> Bug: 868675
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: Ia5fb548ba314edda307b5b7d7d7d27ff9e24fb30
> Reviewed-on: https://chromium-review.googlesource.com/1164565
> Reviewed-by: David Tu <dtu@chromium.org>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#581082}

TBR=dtu@chromium.org,nednguyen@google.com

Change-Id: Ifaf628ca1d733df24365e5231f687b4e20eb467a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868675
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Reviewed-on: https://chromium-review.googlesource.com/1166122Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#581339}

https://android.googlesource.com/platform/external/perfetto.git/+log/ef73f7b272a5..181422428b90


git log ef73f7b272a5..181422428b90 --date=short --no-merges --format='%ad %ae %s'
2018-08-07 primiano@google.com Merge "Introduce legacy JSON importer and "slices" vtable"
2018-08-07 hjd@google.com Merge "perfetto-ui: Remove ControllerProxy"


Created with:
  gclient setdep -r src/third_party/perfetto@181422428b90

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I905941ad24b71dc080873ea61e2758fa01e67eb6
Reviewed-on: https://chromium-review.googlesource.com/1165326Reviewed-by: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581338}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/67c8e92b..cbcf8cb1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I62acaa6bf12836a1f83725fe55cce74f8ba42b0d
Reviewed-on: https://chromium-review.googlesource.com/1165600Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581337}

Bug: 734672
Change-Id: I97941d577b6993170b4f5a506e51a9451623dccd
Reviewed-on: https://chromium-review.googlesource.com/1162772
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581336}

OOBE now has a white background across the entire display. The status area tray
icons were not visible in this environment.

Bug: 857221
Change-Id: I025b8f0d243df6be4d1b0258628dc72730467341
Reviewed-on: https://chromium-review.googlesource.com/1162780
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581335}

The class is deprecated. Eliminate empty methods. Inline code from
remaining methods.

TBR=rcui@chromium.org

Bug: 866523
Change-Id: I6c785a5c58b4b95f2a3b543ab80b66610fc88519
Reviewed-on: https://chromium-review.googlesource.com/1164629Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581334}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3cd5de0de3a1..36668c6ef51c


Created with:
  gclient setdep -r src-internal@36668c6ef51c

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I17d28747972146fad6119e8c029b9fa57db7702d
Reviewed-on: https://chromium-review.googlesource.com/1165627Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581333}

BUG=871784
TBR=joenotcharles@chromium.org
NOTRY=true

Change-Id: If114b2364922392b3e9a56c62a47dd45f1101b62
Reviewed-on: https://chromium-review.googlesource.com/1165832Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581332}

This crash can happen when a user turns data saver off after the InfoBar
is shown, but before the page is closed. In this case, it is fine to
ignore reporting the opt out as the user will not see the InfoBar again
until they turn data saver back on.

Bug: 871835
Change-Id: I6ab20290e64cb31179e4473d95fe892ce47e6b94
Reviewed-on: https://chromium-review.googlesource.com/1165623Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581331}

The hovered tab state was visually too close to active state
so this CL reduces the opacity. The method for calculating
interpolation range and hover radial gradient opacity is
changed to use target contrast ratios. This approach ideally
will adapt better to various themes and color schemes,
ensuring the right level of contrast by adjusting opacity
automatically.

Bug: 856893
Change-Id: I2799b722c1d84d7c323e4f587fa8f5e58106bf58
Reviewed-on: https://chromium-review.googlesource.com/1147605
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581330}

The original problem has been fixed in the latest Widevine CDM.

Bug: 847591,851027
Test: This CL enables a test
Change-Id: I3245bb98672b9ae872354d9f2ac6b419bc0b84b4
Reviewed-on: https://chromium-review.googlesource.com/1162907
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581329}

Instead of providing an object that creates fake framebuffers in tests,
create fake GbmBuffers and import them into the fake DrmDevice.

Bug: 869206
Test: ozone_unittests
Change-Id: Ib00eb4befeda0ffd9299499b1f451036fa1aa2bb
Reviewed-on: https://chromium-review.googlesource.com/1162656
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581328}

GET or HEAD, per https://fetch.spec.whatwg.org/#origin-header.

Bug: 860478
Change-Id: I1dfda7fb630fbd200c5ed635228ebf81dd003156
Reviewed-on: https://chromium-review.googlesource.com/1165163
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581327}

Caused by a DCHECK crash from a pointer pointing to deallocated memory.

Bug: 866535
Change-Id: I96d76aeaeb8c89316cd6ffb237928cd2bfcfb744
Reviewed-on: https://chromium-review.googlesource.com/1165850Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581326}

ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development.

It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly.

The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects.

Bug: 868579
Test: clean build for
1. prior to this patch
2. after this patch

Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image.

Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56
Reviewed-on: https://chromium-review.googlesource.com/1165787Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581325}

This is required to remove the |local_state_task_runner| member
of BrowserProcessImpl only used to implicitly wait on pref store.
Ref. https://crrev.com/c/1163628.
Synchronous callback semantics are required on EndSession() as a nested
RunLoop is not suitable to observe a reply.
https://chromium-review.googlesource.com/c/chromium/src/+/1163628/8/chrome/browser/browser_process_impl.cc#594

Also implemented in services/preferences' SegregatedPrefStore but
not in the Mojom interface where I don't think it's used yet? Or if
it is then it was already wrong as |local_state_task_runner| is
decoupled from that Mojom. The DCHECK will tell and make this future
proof.

Bug: 848615
Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie72f2d30d30bfa7f96a04d780d1591949a173b78
Reviewed-on: https://chromium-review.googlesource.com/1164522Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581324}

To allow external symbolization the profile has to include modules info.

BUG=803276
TBR=pfeldman@chromium.org

Change-Id: I0802678210e07ec89a2d2e5eae9a02f7d5dc1568
Reviewed-on: https://chromium-review.googlesource.com/1147525Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581323}

In order to keep the extensive unittests set functional, a couple of
extensions were made, apart from the migration itself. Remarkably:

- Added a new method to ExtensionDownloaderDelegate class,
  ::OnExtensionDownloadRetryForTests, used exclusively for tests.
  Basically, *various* unit tests in ExtensionUpdaterTest (namely
  TestSingleExtensionDownloading* and ProtectedDownload*) perform
  intentional load failures/retries, where resource
  request parameters and load results are set up and verified differently
  for each load fail/retry sequence.
  Prior to this CL, with URLFetcher, tests could control when to call
  URLFetcherDelegate::OnURLFetchComplete.
  In SimpleURLLoader worlds, we can not really control when the "load
  complete" callback is called, since it is a mojo call. Hence, this
  testing-only API was added so that tests can more fine-grained control
  when loads are triggered.

BUG=773295

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ife6f51837648036c8b96dbedcb093113be2fc987
Reviewed-on: https://chromium-review.googlesource.com/1066370
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581322}

This reverts commit d7c2fe50.

Reason for revert: Breaks the ASAN bots. Details in the followup email to this revert CL.

Original change's description:
> Don't show camera icon in guest mode
> 
> This CL hides camera icon of internal camera app in guest mode. Since
> extensions are not allowed in guest mode, users can't perform any
> actions after clicking on the camera icon.
> 
> Bug: 866412
> Test: Tested on eve that there's no camera icon in guest mode.
> Change-Id: Idf7cc42a50087aeced3283eafd6372144281b570
> Reviewed-on: https://chromium-review.googlesource.com/1152147
> Reviewed-by: Tatiana Gornak <melandory@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
> Cr-Commit-Position: refs/heads/master@{#581198}

TBR=stevenjb@chromium.org,melandory@chromium.org,shenghao@google.com

Change-Id: Iae87ba198da16262d6c7a79527234051994a54ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866412
Reviewed-on: https://chromium-review.googlesource.com/1165962Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581321}

Update (create or destroy) the FirstLetterPseudoElement and its style
at the point where the block level element's layout sub-tree is up-to-
date. This means we will always attach the layout tree for the
::first-letter element in Element::AttachLayoutTree, but the pseudo
element and its style may be created/updated at style recalc time,
layout tree rebuild time, or layout tree attachment time depending on
when we know what will be the LayoutText from which we will format the
first letter if any.

UpdateFirstLetterPseudoElement is split out from UpdatePseudoElement to
make the code easier to read as the former case has some exceptional
cases.

We no longer use the pseudo style cache for ::first-letter as we will
now compute the style only once per pass with the correct inheritance
parent.

Bug: 847218
Change-Id: I7a1e2a60122891fa38998ff85e566bec0a38b513
Reviewed-on: https://chromium-review.googlesource.com/1155591Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581320}

Adding to -CollectionViewTextItem.enabled to avoid changing the
-CollectionViewTextItem.commandID to enable/disable the cell.

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifb93b949cc1f58e84e021ca7823677a08c8bc0b9
Reviewed-on: https://chromium-review.googlesource.com/1163603
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581319}

As part of this CL, a method has been added to LoginScreenControllerObserver to be notified when the OOBE dialog visibility changes.

Bug: 871186
Change-Id: I7b8d9fb7de99c16df6166c43f2eb55f56b93736e
Reviewed-on: https://chromium-review.googlesource.com/1164248Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581318}

BUG=871910
TBR=pkasting@chromium.org
NOTRY=true

Change-Id: I4c1100d7b95e654edeaa9b416c2cf9b0f6759339
Reviewed-on: https://chromium-review.googlesource.com/1165829Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581317}

R=proberge

Bug: 830892
Change-Id: I2dca13dc4046021fa7091ae737b4dba093c6e87f
Reviewed-on: https://chromium-review.googlesource.com/1165844
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581316}

I added this early on. My understanding is we're assuming the client is
pushing the cursor if necessary, so there is nothing to do here.

BUG=none
TEST=none

Change-Id: I94922f0ce442d881e03722562b9094ff90603dd1
Reviewed-on: https://chromium-review.googlesource.com/1161051Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581315}

This implements the "transceiverAdded" and "transceiverModified"
events that show up in chrome://webrtc-internals/, as described under
"Option C: API Events and Transceiver Added/Modified Events" of design
doc https://docs.google.com/document/d/1rsJSvHulqdbc3kfs70-PvRFrCYYuNP3W1t6XAQRLiEg/edit?usp=sharing.

That is when transceivers (Unified Plan) is used. If Plan B is used,
the events shows up as "senderAdded", "senderModified",
"senderRemoved", "receiverAdded", "receiverModified" or
"receiverRemoved" instead.

This CL does not add the API Events for "addTrack", "removeTrack",
"ontrack", "onmute", etc. That will require a follow-up CL. However,
the transceiver events does include information about what API caused
the transceiver to be modified.

Here is an example of how the events show up in
chrome://webrtc-internals/ when performing a call[1]:

- In Plan B:
  https://photos.app.goo.gl/SMukRLW6KuHPZVC78
  https://photos.app.goo.gl/CV2jK8n4y1VrSiqR8
- In Unified Plan:
  https://photos.app.goo.gl/zbsjfizQSizwdPwA8
  https://photos.app.goo.gl/CwCibJ19vRR9P7gY7
  https://photos.app.goo.gl/MWWDZEdZvyiXT4o49

This CL also performs the following related changes:
1. RTCPeerConnectionHandler::rtp_receivers_ changes type from a map to
   a vector so that each receiver has an index corresponding to its
   insertion order.
2. RTCPeerConnection::GetTransceiverIndex() obtains the index of the
   transceiver (or sender or receiver if Plan B).
3. RTCRtpSenderOnlyTransceiver and RTCRtpReceiverOnlyTransceiver is
   updated to use template<> as to allow these helper classes inside
   of peer_connection_tracker_unittest.cc.
4. peer_connection_tracker_unittest.cc is refactored to minimize the
   amount of duplicate code to set up tests. Various fake classes and
   helpers are added that should probably be moved into its own file
   in the future (https://crbug.com/868868) but I don't want to mess
   around with BUILD files to make merging easier.
5. PeerConnectionTrackerTest is lacking a lot of test coverage. This
   CL adds extensive test coverage for all the Track*Transceiver()
   methods.

[1] https://codepen.io/anon/pen/OwpYvw?editors=0010
    This sets up two RTCPeerConnections and performs two offer/answer
    cycles. In the first, two tracks are added to both PCs. In the
    second, one track is removed from each PC.

Bug: 866447

Change-Id: I33df774e8b2b22df6890a90a80e7d83e0aec0524
Reviewed-on: https://chromium-review.googlesource.com/1154975
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581314}

This change updates the OfflineContentProvider onItemUpdated observer
function to include whether the visuals need to be updated.
This allows to change the notification icon from the offline item.

Bug: 865063
Change-Id: I47fb04700c550fb630fefa328b634c979c25cd27
Reviewed-on: https://chromium-review.googlesource.com/1156592Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581313}

Query SupportsSeparateFramebufferBinds to determine if the framebuffer
target should be GL_DRAW_FRAMEBUFFER_EXT or GL_FRAMEBUFFER_EXT.

Update tests so that one test uses an ES2 context and tests target
GL_FRAMEBUFFER_EXT, while the other test uses an ES3 context and tests
target GL_DRAW_FRAMEBUFFER_EXT.

Bug: 848952
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If9ff227498e10aef912f38e7bc26700c7513ed87
Reviewed-on: https://chromium-review.googlesource.com/1165597
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581312}

For OOPD, the display compositor is in the viz process.
The LayerTreeFrameSinkLocal used by exo is for submitting frames to
a local display compositor, so it will not work with OOPD. To make it
work, we need use the AsyncLayerTreeFrameSink which can submit frames
to the remote display compositor in viz process via mojo IPC. And the
AsyncLayerTreeFrameSink also works with a local display compositor, so
we will use it for non-OOPD case as well.


Bug: 866898
Change-Id: I2003c8a6744547ee0c62c38667727c594ccb4537
Reviewed-on: https://chromium-review.googlesource.com/1153404Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581311}

https://chromium.googlesource.com/angle/angle.git/+log/1bd4bfb0c2d8..b983a4b28b83


git log 1bd4bfb0c2d8..b983a4b28b83 --date=short --no-merges --format='%ad %ae %s'
2018-08-07 jmadill@chromium.org Pass Context to Framebuffer::invalidateCompletenessCache.
2018-08-07 jmadill@chromium.org Remove excess gl:: prefixing in validationES.cpp.


Created with:
  gclient setdep -r src/third_party/angle@b983a4b28b83

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Id7a4cfa3b1403fde12b1fc946eb2a42643dd4d74
Reviewed-on: https://chromium-review.googlesource.com/1165523Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581310}

This relands the following change:

Enable FlingSchedulerMac

Enable tests that were disabled because of this functionality missing.

Bug: 842325
Change-Id: I6f540460f4e5f81d7ff8dd36e4abf369f0bd4785
Reviewed-on: https://chromium-review.googlesource.com/1149612Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577957}

This was identified as a cause of flakiness in Mac webkit_layout_tests. But that
test's flakiness also pre-dated this patch. The test in question has also been
marked to expect fails on Mac. The source of that flakiness will be investigated
separately.

Change-Id: I22364cb8e18507b528c6c0c32f452fcf208caf7e
Reviewed-on: https://chromium-review.googlesource.com/1162716
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581309}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

We are using SERIAL_EXECUTOR in clearSharedImages and shareImage since
they don't appear to be thread safe, and they could potentially be
called multiple times.

We are using the UI thread in getShareableIconAndName since we
immediately call get() on it anyway. This negates any benefit for having
an AsyncTask.

Bug: 869907, 729737
Change-Id: I9ea44efba2155bb2b643f6d4d8f2b38c8365f418
Reviewed-on: https://chromium-review.googlesource.com/1161218
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581308}

Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This
exector is good for preventing concurrency errors since it guarantees
serial execution, but bad for performance since the entire app shares
this single queue.

It looks like this callsite is stuck on the SERIAL_EXECUTOR. We make
this requirement explicit.

Bug: 869907
Change-Id: I651a27380b514600793a248babd41aa556983fb1
Reviewed-on: https://chromium-review.googlesource.com/1162714Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581307}

Prevent FindIt from auto-reverting import CLs.

Bug: 871392
Change-Id: If4fb4abfcbf0e1e7bf95b8272701031ccb96ee38
Reviewed-on: https://chromium-review.googlesource.com/1164030Reviewed-by: Chan Li <chanli@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581306}

This change causes all buttons to use focus rings on platforms that use
them.

Bug: 847121
Change-Id: Ida4fba2004d03d6482fd7c4da6dd3cbb8b13a72b
Reviewed-on: https://chromium-review.googlesource.com/1163315Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581305}

This CL uses ui::PlatformEventSource observer API to hook into pre and post
native event dispatch on Linux.

Timestamps for X11 events are in X11 server time. The implementation makes a
round-trip to the X11 server to obtain a delta, and then uses that delta with
base::TimeTicks::Now() to convert to a base::TimeTicks.

The overhead from the rount-trip seems reasonable. 99th percentile X11 RTT is
3ms. 99.9th percentile is 16ms. 99.99th percentile is 40ms. These include the
time for syscalls to base::TimeTicks::Now().

To further reduce overhead, this CL changes the UMA metric to only be computed
with 1/1000 frequency, to avoid two calls to base::TimeTicks::Now().

Note: The implementation of native event observer will be turned on via Finch
experiment to measure overhead.

Change-Id: I786537f093e862a7a19630c9150606a2eb8267d9
Bug: 859155
Reviewed-on: https://chromium-review.googlesource.com/1162658Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581304}

Add STREAM_MP3 in GetSupportedStreamEncodings to unblock open media in browser before decoder is ready.

Bug: b:112162166
Change-Id: I7cbc3a753742ac9626877b8b76acc052328c90a1
Reviewed-on: https://chromium-review.googlesource.com/1164164Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581303}

Replace current ThreadId check with a sequence checker.

We also add a test that tests font fallback, so
PpapiBlinkPlatformImpl::SandboxSupport::GetFallbackFontForCharacter
actually gets tested somewhere.

Bug: 866645
Change-Id: I743eb9cd6a1004c25074b907a50e9b4cf680f805
Reviewed-on: https://chromium-review.googlesource.com/1165312Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581302}

There are failurs in Win7 FYI Release (AMD) bot after removing it from
the test suit exceptions. Now add it back to the list to keep the bot green.

Bug: 868143
Change-Id: I5af929eba7db8f57b334ab759e0a194d8e29e5f9
Reviewed-on: https://chromium-review.googlesource.com/1165662Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581301}