- 22 Mar, 2018 40 commits
-
-
Fyodor Gayokho authored
By spec, if a member (OptionalStorage) has potentially-throwing move constructor (when T is not trivially move constructible), the implicit move constructor is also potentially-throwing (OptionalBase and Optional). However, if T is nothrow move constructible, noexcept is explicitly specified to the Optional's move constructor. This hits the following statement in the spec (11.4.2 [dcl.fct.def.default]) If a function that is explicitly defaulted has an explicit exception-specification that is not compatible (18.4 [except.spec]) with the exception-specification on the implicit declaration, then - if the function is explicitly defaulted on its first declaration, it is defined as deleted; So, move constructor would be deleted. Note that, practically, with -fno-exceptions as we build Chrome, clang outputs is_nothrow_move_constructible<Optional<T>>::value will be false, although move ctor itself looks generated. This is the fix for that case. Also note that, without -fno-exceptions, clang would report "error: exception specification of explicitly defaulted move constructor does not match the calculated one". This is a clang bug (https://bugs.llvm.org/show_bug.cgi?id=22325). Change-Id: I7c5775084e2c75157b337c97b04a84e9d2879e11 Reviewed-on: https://chromium-review.googlesource.com/964961Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#545156}
-
Allen Vicencio authored
This CL adds a bool success field to FindHostCallback to indicate if the HostLocator was successful in querying for hosts. Bug: chromium:757625 Change-Id: Ie1a2c4ee0c8392157234cc1f1eefdb0d3bc4d88f Reviewed-on: https://chromium-review.googlesource.com/963757 Commit-Queue: Allen Vicencio <allenvic@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#545155}
-
Michael Lippautz authored
The DCHECKs were use to verify that promptly freed objects are not present in callback lists. This is only a problem with non-atomic marking. This can be ensured in another way: - Assuming promptly freeing immediately writes a FreeListEntry - Assuming callback list presence implies the header is marked - Exception: Weak tables Then, - We should never promptly free a marked object (check already in place) - Exception: We should also not promptly free weak tables (check already in place) - We should never mark a FreeListEntry Bug: chromium:757440 Change-Id: Ie80dc3197679e3e5f4482a8f7e3dae22b4ea97b4 Reviewed-on: https://chromium-review.googlesource.com/975601Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545154}
-
bsheedy authored
Moves fastpath_urls and urls_list in tools/perf/page_sets/key_mobile_sites_smooth.py to constants in the same file so that the same list of URLs can be used in multiple files. Bug: 732830 Change-Id: I8eba6c147f61f27f50999a540122ac50aba931c6 Reviewed-on: https://chromium-review.googlesource.com/965164Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545153}
-
https://skia.googlesource.com/skia.git/+log/dab15f7a02dd..5fba7ad39a96 $ git log dab15f7a0..5fba7ad39 --date=short --no-merges --format='%ad %ae %s' 2018-03-22 bsalomon Support GL_RGB textures and render targets. 2018-03-22 ethannicholas switched SPIR-V vertexid to vertexindex Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I99e5f03eee3eb31f90f6869762d372b912e602df Reviewed-on: https://chromium-review.googlesource.com/975924 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545152}
-
erikchen authored
Change-Id: Iacba2281ea810a3b4c56c36b4a0edcc66b456f40 Reviewed-on: https://chromium-review.googlesource.com/976088 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#545151}
-
Vaclav Brozek authored
SavePasswordsPreferences currently contain code to handle showing stored passwords, searching in them, and also exporting them. While searching passwords is tighly coupled with displaying them, exporting has nothing in common with displaying, apart from handling the same data. To make the classes more focused and reasonably sized, this CL splits the explort flow UX logic from SavePasswordsPreferences.java to a new class, ExportFlow.java. The Espresso tests for export remain part of SavePasswordsPreferencesTest.java, because from the user point of view nothing changes and the export flow is still part of the functionality offered on the settings page provided by SavePasswordsPreferences. Not changing the tests during a refactoring also ensures that no unintentional behaviour was introduced. Bug: 810016 Change-Id: I90e1a5b62f3a3ed7573d62fcf97d49519cbfc074 Reviewed-on: https://chromium-review.googlesource.com/973205 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#545150}
-
Guido Urdaneta authored
Bug: 824129 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I77fc7a50478cca7f398f8896bfadd19409b12277 Reviewed-on: https://chromium-review.googlesource.com/973377 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545149}
-
Julia Tuttle authored
Change-Id: Ieabb6e4b6a48f6fa34c13456270092b0757e9537 Reviewed-on: https://chromium-review.googlesource.com/970941 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#545148}
-
Mustafa Emre Acer authored
Bug: 814901 Change-Id: Ie4cc59294b1301c19a22e587db8b59c3ad104bb2 Reviewed-on: https://chromium-review.googlesource.com/974364Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#545147}
-
Moe Ahmadi authored
This reverts commit 03251dfb. Reason for revert: Compile error caused Chrome build tree closure https://ci.chromium.org/buildbot/chromium.chromiumos/chromeos-daisy-rel/8564 Original change's description: > ash: Position power button menu next to power button. > > doc: go/add-power-button-location > > changes in this cl: > - Add a switch kAshPowerButtonPosition with value to store the related > power button position info that read at ChromeOS side. > > - Parse the value of the switch in PowerButtonController. > > - Get the menu bounds origins in different screen orientations according > to the position info in PowerButtonMenuScreenView. This will help to > set the bounds of the menu in each screen orientation. > > - Get the menu animation direction and transform distance according to the > position info in PowerButtonMenuView. We need to minus the animation > transform when setting the bounds of the menu before showing the menu. > > - Add PowerButtonControllerWithPositionTest*. > > > Bug: 818331 > Change-Id: I0a1191072b85db59ed2d1d20e5ce25266a357e95 > Reviewed-on: https://chromium-review.googlesource.com/963644 > Commit-Queue: min c <minch@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Qiang Xu <warx@google.com> > Cr-Commit-Position: refs/heads/master@{#545130} TBR=derat@chromium.org,minch@chromium.org,warx@google.com Change-Id: I9480d8cbf20c6ee0dd3970a88e6221badbc29906 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 818331 Reviewed-on: https://chromium-review.googlesource.com/976097Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545146}
-
Peng Huang authored
This method will be used by viz::SkiaRenderer to get a resource metadata, and then the viz::SkiaRenderer will make a SkImage by SkDeferredDisplayListRecorder::makePromiseTexture(), and then draw the SkImage to a Skia DDL which will be played back on GPU thread later. This CL is part of CL https://crrev.com/c/947047 which makes SkiaRenderer use Skia DDL to render frames. Bug: 824382 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie182ee9f8ebba0f6f838e6fb191f84b97ee43545 Reviewed-on: https://chromium-review.googlesource.com/973806Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
-
Eugene But authored
Previously the task was added in Coordinator's start, which can be called multiple time for the same task and will add the second observer to DownloadTask. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0023f632a315961a5e4d5612abbac7288c5a93f1 Reviewed-on: https://chromium-review.googlesource.com/974659 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#545144}
-
Thomas Anderson authored
This reverts commit fdf8f25c. Reason for revert: Broke Google Chrome Win: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/28332 Original change's description: > [3p-Conflicts] Fix whitelisting of modules with matching cert's subject > > A previous CL was meant to whitelist modules whose cert's subject > matches the cert's subject of the executable, but the code was added in > the wrong file. > > Move the check from ModuleListFilter where it doesn't belong and move it > to the ProblematicProgramsUpdater class. > > Also added a unit test to make sure the issue is really fixed. > > Bug: 819793 > Change-Id: Ibd6a3c599d6b5ec2bf0a50c5ae0536159bb30fc6 > Reviewed-on: https://chromium-review.googlesource.com/969601 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545128} TBR=pmonette@chromium.org,grt@chromium.org Change-Id: Id7b2f78ae9caaf950920185551099c40acc36988 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819793 Reviewed-on: https://chromium-review.googlesource.com/976161Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#545143}
-
Mustafa Emre Acer authored
Screenshots can be added for both grd and grdp files. The current upload tool only finds screenshots for grd files. This CL adds support for grdp files and files added via <structure> tags. Bug: 814901 Change-Id: I2cb427b502e050c1b3ee6e39fa7bd94f26e54060 Reviewed-on: https://chromium-review.googlesource.com/974657Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Scott Violet authored
Additionally Ozone's PlatformEvent is ui::Event, rather than void*. BUG=none TEST=covered by tests Change-Id: Ie98f332a11c5b69c89be75d46fee997eaea8c7aa Reviewed-on: https://chromium-review.googlesource.com/972645 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#545141}
-
Sonny Sasaka authored
This CL adds feature to enable/disable the use of newblue Bluetooth daemon instead of BlueZ. This is only the Chrome-level switch and does not include the lower-level switch to enable kernel splitter and bluetoothd/newblued restarts. That will be done separately. BUG=chromium:812468 TEST=Unit tests still pass, manual device test doesn't regress. Change-Id: I8ce9625040e0abb6f20f8707fafc897caa898ac8 Reviewed-on: https://chromium-review.googlesource.com/961498Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#545140}
-
Miriam Gershenson authored
Update comments on HostResolverImpl, ProcTask, and DnsTask. Change-Id: I0f9a82b1cbb87e972835ae57d475eca08f30f76d Reviewed-on: https://chromium-review.googlesource.com/975632Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#545139}
-
Lei Zhang authored
PwgRasterConverterHelper owns a mojo::InterfacePtr and passes a reference to itself as the InterfacePtr's connection error handler. Change-Id: Ie78386416ed57d4f8a28e3bcd8cc3accc4267355 Reviewed-on: https://chromium-review.googlesource.com/974908Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#545138}
-
yoshiki iguchi authored
ViewsTestBase was the cause of the crash in this context. This CL fixes the crash by replacing it with AshTestBase. Bug: 785539 Test: Ran ui_arc_unittests Change-Id: I445277b0a192579854ff986e7c78ba95145e7995 Reviewed-on: https://chromium-review.googlesource.com/975721Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#545137}
-
Elly Fong-Jones authored
This change merges the separate Cocoa and Views implementations of these functions into a single implementation that chooses the correct table at runtime. This fixes GlobalKeyboardShortcutsTest.* in polychrome-cocoa, and all but one of GlobalKeyboardShortcutsTest.* in polychrome-views. Bug: 817408 Change-Id: I57e333ee2fcec2ac21fb2920a7d5794b774de204 Reviewed-on: https://chromium-review.googlesource.com/975583Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545136}
-
https://webrtc.googlesource.com/src.git/+log/b3179c75ed40..29e7bee3308d $ git log b3179c75e..29e7bee33 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3c424aa834e5da83259062cdade580900e5166d7 Reviewed-on: https://chromium-review.googlesource.com/975824Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545135}
-
Yunlian Jiang authored
Newer lld failed to link chrome, it complains about duplicate symbol. It looks like an ODR violation. BUG=chromium:822334 TEST=lld links Chrome now. Change-Id: I2894b49b68d0a0a952f290af81f38eb30aa34cbd Reviewed-on: https://chromium-review.googlesource.com/974455Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Cr-Commit-Position: refs/heads/master@{#545134}
-
Qiang Xu authored
changes: Toggle tablet mode is set to update caption buttons to update size button visibility. In minimized state, frame is not maximized or fullscreen, thus the size button will be set to MAXIMIZE button not RESTORE button. This CL avoids such update when window is minimized. Bug: 822890, 783310 Test: manual test and added test coverage Change-Id: Id35db6dcfbc79e6783caf8706fb83d25402f9c21 Reviewed-on: https://chromium-review.googlesource.com/967414Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#545133}
-
Ian Vollick authored
Previously the background and hit test planes would be sized incorrectly if a disc button's corner radii were set. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1aeb4792aa06b51ac2fb8a839e672097690cabfa Reviewed-on: https://chromium-review.googlesource.com/975581Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545132}
-
Michael Thiessen authored
On non-rooted devices, the flag setting will fail, but the installing and logcat are still useful, so we should continue to do them regardless. Change-Id: I8d7b167de4c5e7c59668e2a74aa18e5f81bc41ae Reviewed-on: https://chromium-review.googlesource.com/972021 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#545131}
-
MinChen authored
doc: go/add-power-button-location changes in this cl: - Add a switch kAshPowerButtonPosition with value to store the related power button position info that read at ChromeOS side. - Parse the value of the switch in PowerButtonController. - Get the menu bounds origins in different screen orientations according to the position info in PowerButtonMenuScreenView. This will help to set the bounds of the menu in each screen orientation. - Get the menu animation direction and transform distance according to the position info in PowerButtonMenuView. We need to minus the animation transform when setting the bounds of the menu before showing the menu. - Add PowerButtonControllerWithPositionTest*. Bug: 818331 Change-Id: I0a1191072b85db59ed2d1d20e5ce25266a357e95 Reviewed-on: https://chromium-review.googlesource.com/963644 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#545130}
-
Peng Huang authored
This CL adds a GLContext and a GrContext in GpuServiceImpl. They are created when viz::SkiaOutputSurface needs a GrContext to create a SkSurface for the framebuffer. This CL also creates a SequenceId for viz::SkiaOutputSurface to play back Skia DDLs on the GPU thread. This CL is part of CL https://crrev.com/c/947047 which makes SkiaRenderer use Skia DDL to render frames. Bug: 824382 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9091fd46cbaafe0ace363bfe63e61b5a0d9fe32d Reviewed-on: https://chromium-review.googlesource.com/973757 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Patrick Monette authored
A previous CL was meant to whitelist modules whose cert's subject matches the cert's subject of the executable, but the code was added in the wrong file. Move the check from ModuleListFilter where it doesn't belong and move it to the ProblematicProgramsUpdater class. Also added a unit test to make sure the issue is really fixed. Bug: 819793 Change-Id: Ibd6a3c599d6b5ec2bf0a50c5ae0536159bb30fc6 Reviewed-on: https://chromium-review.googlesource.com/969601 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#545128}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/7b5a57449ba0..1f82e0612293 $ git log 7b5a57449..1f82e0612 --date=short --no-merges --format='%ad %ae %s' 2018-03-20 jianj VP9 SVC: Add control to disable inter layer prediction. 2018-03-18 marpan vp9-svc: Improve frame dropper for spatial layers. 2018-03-19 johannkoenig visual studio: add yasm instructions 2018-03-19 johannkoenig build: remove stale .git files 2018-03-14 johannkoenig reland "use intrinsics for 'emms'" 2018-03-16 jzern CopyFrameTest: reduce max size for 32-bit targets 2018-02-21 jianj VP8: Fix out of range index for mvcost. 2018-03-16 jzern vpx_scale_test: reduce max size for 32-bit targets 2018-03-14 marpan vp9-svc: Frame dropper for SVC. 2018-03-15 jzern Revert "vp9_loopfilter.c: zero lfl_uv" 2017-06-26 jzern libs.mk,vcxproj generation: split srcs in invocation 2018-03-14 marpan vp9-svc: Bugfix to dyanmic enabling/disabling of layers. 2018-03-14 johannkoenig vp9_resize.c: assert vp9_highbd_resize_plane conditions 2018-03-12 johannkoenig remove spatial svc experiment 2018-03-14 johannkoenig vp9_loopfilter.c: zero lfl_uv 2018-03-14 johannkoenig vp8 rdopt.c: zero rd.[rate_uv|distortion_uv] 2018-03-14 johannkoenig vp8 mfqe: zero map[] 2018-03-14 johannkoenig temporal svc: zero layer_target_bitrate 2018-03-14 johannkoenig Revert "use intrinsics for 'emms'" 2018-03-13 johannkoenig spatial svc: set window_size to 15 (...) Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Iff8288bbb3d1e8d0e36d469b5cb7f1ee8b38962e Reviewed-on: https://chromium-review.googlesource.com/973744Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#545127}
-
Alexander Timin authored
Measure the amount of work done in background when keep-active signal is present. This is to allow us to test the theory that we stopped stopping timers in background after 5 minutes on Android due to widespread keep-active signal. R=panicker@chromium.org,rkaplow@chromium.org BUG=823482 Change-Id: I653016d795a1903ea9d943e3c2b962ab9c1ba088 Reviewed-on: https://chromium-review.googlesource.com/973225Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
-
Matt Wolenetz authored
Mark as flaky in Win TBR=hbos@chromium.org,hta@chromium.org BUG=824830,823003 NO-TRY=True Change-Id: Iabd4ddc714220082b332754c093652178ce91c27 Reviewed-on: https://chromium-review.googlesource.com/976048Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545125}
-
Kristian H. Kristensen authored
With CL:801974 we started using RGBA for primary framebuffers so that the alpha channel will be well-defined. Boards without atomic modesetting should not use overlays and scanout the primary framebuffer as RGB, but this didn't quite work. We tried to modeset and pageflip to RGBA buffers on boards with RGB-only overlays (peppy). This commit makes sure that we always pick the opaque framebuffer for the lowest plane. Bug: 821944, b/74997524 Change-Id: I79929d59bc8a568d7a6090a3ab5a4b31fad658b6 Reviewed-on: https://chromium-review.googlesource.com/964984 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#545124}
-
Roger Tawa authored
To create a "binary" std::string with embedded nulls from a C string, use the 2 argument constructor so that std::string does not use embedded nulls to determine the full length of the string. Bug: None Change-Id: I6003984b6179d03753fef402134329523fe4c31a Reviewed-on: https://chromium-review.googlesource.com/973692 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
-
Mohsen Izadi authored
OverscrollControllerDelegate::OnOverscrollBehaviorUpdate() is always called before OverscrollControllerDelegate::OnOverscrollModeChange(). This CL merges the former into the latter by passing overscroll-behavior value directly to OnOverscrollModeChange(). BUG=800047 TEST=none Change-Id: I97f6b33b46fd9e5815e3a26fc36d04ded21c6864 Reviewed-on: https://chromium-review.googlesource.com/969611Reviewed-by:
-
Sigurdur Asgeirsson authored
Bug: 749785 Change-Id: Ib52b3dd62b5b5386353cdc031d57c4ac74b13410 Reviewed-on: https://chromium-review.googlesource.com/975633Reviewed-by:
lpy <lpy@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545121}
-
Sadrul Habib Chowdhury authored
Validate that the |changed_button_flags_| field is allowed only the set of flags that makes sense. BUG=779372, 824629 Change-Id: I5e4d8b8f07fbf6d881d8510f45414814d074278d Reviewed-on: https://chromium-review.googlesource.com/974078 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Alex Moshchuk authored
This can be removed since https://crbug.com/823493 has been fixed by r544591. Bug: 638375 Change-Id: Ia07a35fa7725b7b38eeda495b05db35ad6fa6c13 Reviewed-on: https://chromium-review.googlesource.com/974473Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#545119}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2d4815d9..61c909d6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifd2157dee74405d6b4637a8ad4b6a911495725cb Reviewed-on: https://chromium-review.googlesource.com/975662Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545118}
-
Ryan Hansberry authored
Also add a test double for BackgroundEidGenerator. Bug: 819279 Change-Id: I24e2352d72deb00632a4d955f17cc508f7d4cbb5 Reviewed-on: https://chromium-review.googlesource.com/952462Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#545117}
-
