GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a51d9227..1e323b4a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I63a1bd780da7aa81e25d7275df3ee206420938a3
Reviewed-on: https://chromium-review.googlesource.com/569262Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486249}

Given that for now the call must remain present but the precise semantics
of the call aren't important (see
https://codereview.chromium.org/2882063002/#msg64), it's worthwhile having
as clean and simple an implementation of reasonable semantics as possible.

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2974363002
Cr-Commit-Position: refs/heads/master@{#486248}

- Added missing data_deps to ui_test.pak.

Bug: 737433
Change-Id: I4cb4ad39b8baebeb40ef2bc081741182e2ff2b5b
Reviewed-on: https://chromium-review.googlesource.com/567785Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486247}

Also rename Chromium Win 10 GCE Tests to Chromium Win 10 GCE Tests (Win 7 Build).

Bug: 738255
Change-Id: I526e1be2530e56176fcc6e6ef9b1884ad481b579
Reviewed-on: https://chromium-review.googlesource.com/569310Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: smut <smut@google.com>
Cr-Commit-Position: refs/heads/master@{#486246}

deqp/functional/gles3/shaderstruct.html is still failing on
Win7/NVIDIA.

BUG=668223
TBR=geofflang@chromium.org
NOTRY=true

Change-Id: Ib689a88c08e94114d947c4ca8e3890bc71508f56
Reviewed-on: https://chromium-review.googlesource.com/569456
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486245}

TBR=dimu@chromium.org

Change-Id: I1282f598472bd4a462a91202abc9058cdb779c2b
Reviewed-on: https://chromium-review.googlesource.com/569405Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486244}

This is a reland of b3c9a824
Original change's description:
> [GRC] Add Tab-level CPU Usage Attribution Tests
> 
> This CL adds tab-level CPU usage attribution tests for GRC. Tab-level CPU usage attribution is tested under a variety of different coordination unit graph topologies.
> 
> A set of mock coordination unit graph topologies has also been added to the code base as a common set of coordination unit graph topologies has emerged across the coordination unit unittests. 
> 
> Bug: 691886
> Change-Id: I2e9178ca5454846320add15f9f004ba0d9df2a9f
> Reviewed-on: https://chromium-review.googlesource.com/562549
> Commit-Queue: Matthew Halpern <matthalp@google.com>
> Reviewed-by: Zhen Wang <zhenw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485024}

Bug: 691886
Change-Id: I91b5a898c4a9a6cf016a851c3637bebff17962ff
Reviewed-on: https://chromium-review.googlesource.com/567239
Commit-Queue: Matthew Halpern <matthalp@google.com>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486243}

Adds api tests for launching lock screen note taking action.
Verifies that:
 * app_launch test
   *  requesting new (lock screen) note action launches the app with
      action launch event indicating the action is launched from lock
      screen
   *  the app can create lock screen enabled app window
   *  the created window is maximized by default (and the window can
      accedd window.current API)
   *  the app background page can observe the app window closure
   *  the app cannot access identity API in lock screen context
      (even though the app has identity permission)
   *  the app cannot create more than one window per launched action
 * non_lock_screen_context:
   * attempt to create lock screen enabled app window fails if called
     in a context different than lock screen context

The cl enables following APIs in lock screen context:
 *  chrome.runtime
     *  to expose onInstalled event - without it the
        tests hit NOTREACHED when the event is dispatched on the app
        install. This event is also required in production to instigate
        initial app's event page (and registration of event listeners).
     * apps should have access to getManifest, getURL, messaging API (so
       it can communicate with the event page), getPlatformInfo
 *  chrome.test - to expose testing APIs (needed by API tests)

BUG=715781

Change-Id: I850319e98091506204d9e467bd46507b9f4863a8
Reviewed-on: https://chromium-review.googlesource.com/563543
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486242}

Update Clang static analysis Markdown doc.
This CL adds additional information pertaining to the proper use
and maintenance of the Clang static analyzer in Chrome.

R=wez@chromium.org

Bug: 
Change-Id: Ie421d79440051d9285d6ead0f42eb2c4d0a69326
Reviewed-on: https://chromium-review.googlesource.com/535305
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486241}

Move mac_sdk_min into build/config/overrides.gni and assert that it is used.
This prevents unused arg warnings from subprojects that override it.

Bug: 740693
Change-Id: Ib40a52c59c852aab46781a0d44812b07b0e5061c
Reviewed-on: https://chromium-review.googlesource.com/566595Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486240}

Bug: 739631
Change-Id: Iecabaae34cd2e20124a5721d65bb8ab92460acf5
Reviewed-on: https://chromium-review.googlesource.com/569181Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486239}

Cursors with convenient read and write methods to ease manipulation of
raw data.

Bug: 729154
Change-Id: I8a7303964b02b9df7ef033de8756b09716a91eae
Reviewed-on: https://chromium-review.googlesource.com/560657
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486238}

BUG=none

Review-Url: https://codereview.chromium.org/2979653004
Cr-Commit-Position: refs/heads/master@{#486237}

Remove unsupported perm, symlink calls for Fuchsia.
Fuchsia's POSIX support does not extend to file permission bit or
symbolic links. This CL conditionally removes the relevant calls from
file_util and disables affected tests under Fuchsia builds.

R: thakis@chromium.org
Bug: 706592
Change-Id: Id6b68fd9a440f37debe50feb7ce3f457bbee3e4f
Reviewed-on: https://chromium-review.googlesource.com/562901Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486236}

Four strings from android_chrome_strings were copied into
generated_resources in r478708 for use in Chrome OS. This CL moves the
original strings from android_chrome_strings into generated_resources
and deletes the duplicates. Now those strings are available to both
Android and Chrome OS.

Note that IDS_INTENT_PICKER_BUBBLE_VIEW_INCOGNITO_* are now found under
the different name of IDS_EXTERNAL_APP_LEAVE_INCOGNITO_*.

Bug: 678141
Change-Id: I14fb5fbca40e172bcb895afc31c5cf57359b001a
Reviewed-on: https://chromium-review.googlesource.com/564741Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486235}

All of that code is UI Service specific. There's no reason GPU Service should
depend on it. Before this change, services/ui/common was getting pulled into
Mac and Android builds.

BUG=NONE

Review-Url: https://codereview.chromium.org/2976923002
Cr-Commit-Position: refs/heads/master@{#486234}

- Note that AES is still NOT supported.

      password protected zip.

Bug: 359837
Test: Enable --enable-zip-archiver-on-file-manager flag. Try to open a
Change-Id: I52435d7cf027a14a0c95b84a6f3f81116d528f85
Reviewed-on: https://chromium-review.googlesource.com/569321Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486233}

This reverts commit aa273aed.

Reason for revert: I have disabled the test on Android and filed
crbug.com/741925 to track data dependency issue on Android test bots.

TBR=jbroman,dpranke,yzshen

Bug: 699569
Change-Id: Ic007cf56937c586b90fc3b68a76369cd489aff53
Reviewed-on: https://chromium-review.googlesource.com/568272Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486232}

GrBackendTextureDesc is being phased out.

Change-Id: I0c2d00b0a80c63037ecc937021ef8bf978f4c359
Reviewed-on: https://chromium-review.googlesource.com/563119Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486231}

changes:
Set all apps indicator negative transition offset limit to the place of
initial suggested apps indicator.
This will make:
(1) when scrolling up, all apps indicator will stop at 21px padding
away from search box, while all apps tiles scrolling underneath it.
(2) all apps indicator will be shown on non-first page due to (1).

Bug: 741009
TEST: tested with fullscreen app list enabled
Change-Id: I7fa71f041f81b0939c507fb246589cfdb6dbc06a
Reviewed-on: https://chromium-review.googlesource.com/569378Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486230}

This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of
/buildtools/third_party/libc++:config into //build/config/c++/c++.
This has several advantages:
* Users can remove libc++ config if they want since it's added in
  BUILDCONFIG.gn
* Allows removal of libcxx_proxy
* libc++-specific configs are in buildtools and non-libc++ configs are
  in build/config
* Allows changing c++ flags without having to roll buildtools
* Removes a bit of duplicated build configuration

buildtools change:
https://codereview.chromium.org/2962423002

BUG=593874
R=thakis@chromium.org
TBR=dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng

Review-Url: https://codereview.chromium.org/2964243002
Cr-Commit-Position: refs/heads/master@{#486229}

The button defaults to FocusBehavior::ACCESSIBLE_ONLY which (apart from
on Mac) only affects buttons in AccessiblePaneViews (which the close
button is not). Make it FocusBehavior::NEVER so the behaviour is
consistent across platforms.

Note this does not affect screen readers' ability to focus the element.
Keyboard access to this element when not using a screen reader is done
via the ESC key handler in DialogClientView.

BUG=741251

Review-Url: https://codereview.chromium.org/2982533002
Cr-Commit-Position: refs/heads/master@{#486228}

Bug: 287726
Change-Id: I521fad3c7ca7b77aff23b4b4d1a609b8efefcd40
Reviewed-on: https://chromium-review.googlesource.com/568793
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486227}

This cl moves folderSelector, folderEditor and editViewController to
a common super class from bookmark handset and table view controllers.

Bug: 705339
Change-Id: I0ed26a3a6dac8d89ff8498f2753995e4772e4a8d
Reviewed-on: https://chromium-review.googlesource.com/566778
Commit-Queue: Ramya Sharma <ramyasharma@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486226}

With the new ChromeOS settings page, accessing the lock screen settings requires
the user to reauth with their password. This obsoletes the previous behaviour of
reauthing specifically for EasyUnlock.

BUG=740290

Change-Id: I4788e81a750fb36217a4de3bff8e1e5505985bc2
Reviewed-on: https://chromium-review.googlesource.com/565778
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486225}

Bug: 740794
Change-Id: I7e4de04dfd2230b1eef2d7e85d7874055122b6dd
Reviewed-on: https://chromium-review.googlesource.com/567902Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486224}

This patch changes where we keep the lcd state flag to be on the layer
instead of the raster source. This cleans up a bunch of code that was
there since the days of tile sharing. Since tiles are no longer shared,
we can afford to make the code cleaner and eliminate a bunch of lcd text
references throughout.

This also allows us to remove the pseudo copy constructor from the
raster source, meaning that we can now store truly uncopyable types on
it.

R=enne@chromium.org, khushalsagar@chromium.org

Bug: 741775
Change-Id: I376e34f547de03cc5914686eaac60825ccbf2aeb
Reviewed-on: https://chromium-review.googlesource.com/568660Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486223}

After landing crrev/2956553002 which removes the metrics, these two
elapsed timers are no longer needed.

Bug: 738126
Change-Id: I04b29e4728cedb9e7f1fc740036d1a6106cbf0a5
Reviewed-on: https://chromium-review.googlesource.com/566990Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486222}

BUG=741764

Review-Url: https://codereview.chromium.org/2976913002
Cr-Commit-Position: refs/heads/master@{#486221}

Removes a CHECK which was being hit in the wild. Poorly muxed media
can trigger the CHECK condition. Replace check with early return
in splicing code (no splice).

BUG=736740

Change-Id: Icf8f64d7283a6ff41ab98333676ba18341523819
Reviewed-on: https://chromium-review.googlesource.com/567680
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486220}

Blink generates many files from scripts and templates. Only a few of
the generated files listed the source files used to create their output.

Clearly and consistently documenting the input for generated files
makes it easier to understand code and how to change it.

A new macro is introduced in templates/macros.tml and is consistently
used in all templates.

The parameters needed are added to all generating scripts.

Example output in generated files:
grep -r -C 10 "Generated from template" out/Release/gen
https://drive.google.com/file/d/0Bx8PJXs-5E92eTdkZnU0bHBYekk

Change-Id: I50b43d4257568118b63194859c06325d1ff1ead2
Reviewed-on: https://chromium-review.googlesource.com/568668
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486219}

So that this class could be reused by bookmark_collection_view for
keeping track of the syncing status. (and in later CL, it will show
a loading spinner when bookmark is syncing.)

Bug: 696893
Change-Id: I370c91ad1f9815c6d3c70021939140478beaebcc
Reviewed-on: https://chromium-review.googlesource.com/567786
Commit-Queue: Marti Wong <martiw@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486218}

This is a reland of c3dec2b9
Original change's description:
> gpu: Fix FD leak when importing DMA-bufs with multiple FDs.
> 
> CreateFromHandle is expected to take ownership of all FDs so
> when passed multiple FDs we need to make sure they are closed
> if not used.
>     
> BUG=b/63409814
> TEST=exo_unittests --gtest_also_run_disabled_tests --gtest_filter=DisplayTest.DISABLED_CreateLinuxDMABufBuffer
> 
> Change-Id: I2a8a7b0149a08f08890a725c6ce9aff8aeaab97f
> Reviewed-on: https://chromium-review.googlesource.com/566879
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: David Reveman <reveman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485761}

Bug: b/63409814
Change-Id: I3ff7bc12f17be39b721f75610e336a322d909502
Reviewed-on: https://chromium-review.googlesource.com/566960
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486217}

Previously the function was declared, but not defined.

Bug: 734791
Change-Id: I848bca19b1e79f33c8f4b796f5b340fdade315f9
Reviewed-on: https://chromium-review.googlesource.com/565796Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486216}

provider is not Google.

Bug:736038
TEST:unit tested, device tested with --enable-features=EnableFullcreenAppList

Change-Id: Ib305fbbdfea06b7f21fad2aa717af91e0f20aec0
Reviewed-on: https://chromium-review.googlesource.com/557505
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486215}

Change QuicChromiumPacketWriter's socket to specify DatagramClientSocket, which it already is.  No functional change.

R=rch@chromium.org

Bug: 
Change-Id: I2ecd1abf335c29bee1a1791ebeab2d31ca393dbb
Reviewed-on: https://chromium-review.googlesource.com/568841Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ian Swett <ianswett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486214}

This CL ensures that Isolate is set to V8 parameters (e.g., HeapLimitMode) only
one time.

Isolate can be shared by WorkerThreads for worklets. Before this CL, Isolate is
set to the parameters every time a new WorkerThread is created. This is harmless
because Isolate is shared only by homogenous global scopes and given parameters
are always the same, but it shouldn't be a good design.

Bug: 710364
Change-Id: Ic44f1d5d2faebcc8b44c15d91e6afaa715045343
Reviewed-on: https://chromium-review.googlesource.com/567794Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486213}

After all the clients have been converted to use wake lock mojom interfaces,
the power_save_blocker should be hidden inside Device Service.

One exception is //remoting which is the only client that still directly uses
the power save blocker instead of wake lock mojo interfaces. The crbug.com/689423
records the reason.

BUG=689429

Change-Id: I485369f1d7b3984ecaabb667b15562702cc9b5b1
Reviewed-on: https://chromium-review.googlesource.com/563159Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#486212}

This came from https://crrev.com/c/559933. The cast was added to satisfy
a Windows compile error as it couldn't resolve the arguments to
operator!=.

A less ugly fix is to just get the raw pointer out of Member.

Bug: 
Change-Id: I14ed38a936aaf0457c2001a5e2c75b1a5ed91ac5
Reviewed-on: https://chromium-review.googlesource.com/567171Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486211}

After https://skia-review.googlesource.com/21821, Skia performs the same
optimization internally.

Change-Id: Ibf228865a4dfc1e0b9e3a851e4867c808862d67e
Reviewed-on: https://chromium-review.googlesource.com/568855Reviewed-by: Mike Reed <reed@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486210}