GitLab

BUG=141842
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10782030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163860


Review URL: https://chromiumcodereview.appspot.com/11663025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175505 0039d316-1c4b-4281-b951-d872f2087c98

This CL is preparation for server path injection, especially for testing.
It Extracts URL constructing logic from GetURL methods of the classes in
drive_api_operations.{h,cc}, and puts them into a new class
DriveApiUrlGenerator.
DriveApiUrlGenerator is given via operation classes' constructors from their
client (DriveApiService).
The concept of this CL is very similar to the following CLs:
https://codereview.chromium.org/11411086
https://codereview.chromium.org/11418084
https://codereview.chromium.org/11417108
https://codereview.chromium.org/11417109

BUG=162155
TEST=ran unit_tests and chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/11799003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Ran test locally.
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11648013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=35811
TEST=drag the [Next] image from http://www-sul.stanford.edu/tools/tutorials/html2.0/img.html and drop it on the desktop; the resulting file should be named "nextbtn.gif", not "tables.gif"


Review URL: https://chromiumcodereview.appspot.com/11790003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175502 0039d316-1c4b-4281-b951-d872f2087c98

Without this, e.g. a navigation to about:srcdoc looks like a navigation to
about:blank during the provisional phase, and suddendly the internal
about:srcdoc URL is leaked to the embedder.

BUG=168611
TEST=WebContentsImplTest.FilterURLs
R=creis@chromium.org

Review URL: https://codereview.chromium.org/11801011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175501 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167135


Review URL: https://chromiumcodereview.appspot.com/11776033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175500 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175499 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11747020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175498 0039d316-1c4b-4281-b951-d872f2087c98

These 5 tests:
DragDropControllerTest.DragDropInSingleViewTest
DragDropControllerTest.DragDropInMultipleViewsSingleWidgetTest
DragDropControllerTest.DragDropInMultipleViewsMultipleWidgetsTest
DragDropControllerTest.ViewRemovedWhileInDragDropTest
DragDropControllerTest.PressingEscapeCancelsDragDrop

pass locally but fail on the buildbot.

BUG=154081
TBR=ben
Review URL: https://codereview.chromium.org/11783026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175497 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167680

Review URL: https://chromiumcodereview.appspot.com/11617006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175496 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11791020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=154081
Review URL: https://codereview.chromium.org/11787005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175494 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175493 0039d316-1c4b-4281-b951-d872f2087c98

http://trac.webkit.org/log/?rev=139010&stop_rev=138895&verbose=on

TBR=dglazkov

BUG=

Review URL: https://codereview.chromium.org/11813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175492 0039d316-1c4b-4281-b951-d872f2087c98

[javac] /b/build/slave/Android_Builder__dbg_/build/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java:62: cannot find symbol
[javac] symbol  : method onEvaluateJavaScriptResult(int,java.lang.String)
[javac] location: class org.chromium.content.browser.test.util.TestContentViewClient
[javac]         super.onEvaluateJavaScriptResult(id, jsonResult);
[javac]              ^
[javac] /b/build/slave/Android_Builder__dbg_/build/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java:63: cannot find symbol
[javac] symbol  : method onEvaluateJavaScriptResult(int,java.lang.String)
[javac] location: class org.chromium.content.browser.ContentViewClient
[javac]         mWrappedClient.onEvaluateJavaScriptResult(id, jsonResult);
[javac]                       ^
[javac] /b/build/slave/Android_Builder__dbg_/build/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java:60: method does not override or implement a method from a supertype
[javac]     @Override
[javac]     ^
[javac] 3 errors

> Switch Android code to use ExecuteJavascriptInWebFrameCallbackResult.
> 
> BUG=168169
> TEST=should all pass
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11788005

TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/11778034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=Compiles and test chrome://histograms/Tabs.SadTab


Review URL: https://chromiumcodereview.appspot.com/11775012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175490 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168169
TEST=should all pass


Review URL: https://chromiumcodereview.appspot.com/11788005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=165338

Review URL: https://chromiumcodereview.appspot.com/11498008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175488 0039d316-1c4b-4281-b951-d872f2087c98

Shut down explicitly, rather than doing it in a virtual destructor, which leads
to a vtable race.

(Possibly also related is http://crbug.com/70075, but I haven't been able to
reproduce, so I'll try to re-enable that separately.)

BUG=25841
TEST=ipc_tests + TSAN still happy


Review URL: https://chromiumcodereview.appspot.com/11761038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175487 0039d316-1c4b-4281-b951-d872f2087c98

Now that it is only used in one place, this class needlessly increases inheritance complexity

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11753018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175484 0039d316-1c4b-4281-b951-d872f2087c98

Extract the code from AppLauncherHandler into a ExtensionEnableFlow so that it
can be reused by app list and launcher bar.

BUG=157996
TEST=No change. Wait until app list/launcher code changes land to test.

R=estade@chromium.org,benwells@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11644077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175483 0039d316-1c4b-4281-b951-d872f2087c98

* Apply original change from CL 10389088 (https://chromiumcodereview.appspot.com/10389088)

* Change BinaryValue to use "scoped_ptr<char[]>" instead of "scoped_ptr<char>". By contract, the memory owned should be deleted with the "delete[]" operator.

BUG=127630

Review URL: https://chromiumcodereview.appspot.com/11745016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175482 0039d316-1c4b-4281-b951-d872f2087c98

SurfaceTexture.detachFromGLContext is not present in ICS and the old
workaround of using a NullCompositor lead to the test creating
TextureImageTransportSurface in ImageTransportSurface::CreateSurface.
This path is wrong and not well tested in single-process mode and recently
lead to a deadlock hang in release build only tests (see bug).

Fixed by creating the real compositor but just avoid calling the missing
method in ICS. The Java method is loaded lazily so this does not cause
an error at run time.


BUG=167236,161864
Android only change. Ran through Android trybots.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11787031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175480 0039d316-1c4b-4281-b951-d872f2087c98

Without this, we have no chance to start polling for new app until we make a local change.

BUG=167739
TEST=DriveFileSyncServiceTest.RegisterNewOrigin

Review URL: https://codereview.chromium.org/11665029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175479 0039d316-1c4b-4281-b951-d872f2087c98

> [Media Galleries] Add an ImageCaptureCore listener for Mac. (part 2)
> 
> This listener uses the ImageCapture API to watch for attach and detach
> events of PTP devices and other devices which can be read through the
> library. It forwards such notifications through the SystemMonitor.
> 
> Also provides an API for clients to access such devices directly and
> retrieve the media contents from them.
> 
> R=thestig@chromium.org,sail@chromium.org
> BUG=151681
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11442057

TBR=gbillock@chromium.org
Review URL: https://codereview.chromium.org/11779036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175475 0039d316-1c4b-4281-b951-d872f2087c98

This change reduces the number of usage cache update on appending data to a file, and improves the write performance from 75.72 MB/s (σ = 23.255) to 229.238 MB/s (σ = 31.442) on a benchmark.

https://www.googledrive.com/host/0B0EZi1x_1MtFSnNRZy1nalVNdlk/append-write.html

BUG=166158

Review URL: https://codereview.chromium.org/11639037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175474 0039d316-1c4b-4281-b951-d872f2087c98

With this change all contexts should share the same features.
Another CL can try to make it so there is only one global
instance of a FeatureInfo.

BUG=168628


Review URL: https://chromiumcodereview.appspot.com/11791032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175473 0039d316-1c4b-4281-b951-d872f2087c98

This listener uses the ImageCapture API to watch for attach and detach
events of PTP devices and other devices which can be read through the
library. It forwards such notifications through the SystemMonitor.

Also provides an API for clients to access such devices directly and
retrieve the media contents from them.

R=thestig@chromium.org,sail@chromium.org
BUG=151681


Review URL: https://chromiumcodereview.appspot.com/11442057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175471 0039d316-1c4b-4281-b951-d872f2087c98

Still need to investigate when this might happen and how to fix it,
but this will allow it to just break accessibility rather than crashing
the whole browser in the meantime.

BUG=161726


Review URL: https://chromiumcodereview.appspot.com/11787024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175470 0039d316-1c4b-4281-b951-d872f2087c98

lookups. The measurement code has been in long enough to draw conclusions.
This is simply a revert of r151312 and r151710.

BUG=139811


Review URL: https://chromiumcodereview.appspot.com/11734020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175469 0039d316-1c4b-4281-b951-d872f2087c98

Part of work to use standard font sizes instead of "DeriveFont +/- N Pixels". Also per direction of designers and PM to move to Medium non-bold instead of "offsize" bold font for titles and headers.
Changed UIs were seen and ok-ed by either sgabriel@ or kuscher@.

Please see crbug.com/166679 for details and screenshots

BUG=166679, 137349
TEST=manual
for sad tab: navigate to chrome://crash
for password generation bubble: run with flag --enable-password-generation, navigate to www.target.com and begin to create an account, click on password text box
for global error bubble: I modified code in browser.cc to force an error
for extension: Chrome Web Store -> Extensitons -> Click on ADD TO CHROME


Review URL: https://chromiumcodereview.appspot.com/11698005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175468 0039d316-1c4b-4281-b951-d872f2087c98

Change infobar creation to use a public static Create() method on the infobar delegate classes.  Make constructors as private as possible.

This has several purposes:
* By preventing direct instantiation, it prevents callers from leaking if they create an infobar and don't add it to an InfoBarService.
* By moving decision-making about when to show infobars into these Create() functions, there's a pattern for where such code should go, and caller code becomes simpler and easier to read.
* The two bullets above together mean that for infobars which should only be displayed in certain circumstances, code can't accidentally bypass the decision logic.
* It enables us to eliminate a common InfoBarService* temp on the caller side since the caller no longer needs to both pass the pointer to the infobar _and_ call AddInfoBar() on the pointer.  This was also a somewhat redundant-looking pattern.
* It makes it easier to change the ownership model for infobars in the future by limiting the affected callsites to only the Create() functions.

Note that right now, this still feels pretty redundant since we pass all the same args to Create() functions as constructors most times.  In the new ownership model constructors will no longer need to take InfoBarService*s, which will make this better.

Additionally, this makes AddInfoBar()/ReplaceInfoBar() take scoped_ptr<>s to indicate they're receiving ownership.  This sort of change is easy to make since we only need change the create functions.

This change also has a functional effect: it eliminates some cases where we tried to only show infobars when no other infobars were already showing (discussed and approved by Glen).

BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11644059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175467 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a login hang with content security policy error output.

BUG=168525
TEST=manually login on Chrome OS.


Review URL: https://chromiumcodereview.appspot.com/11778017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175466 0039d316-1c4b-4281-b951-d872f2087c98

This comment points to a bug that only applies to HistoryQuick.  It's not
appropriate to link to here.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11734029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175465 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11787030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175464 0039d316-1c4b-4281-b951-d872f2087c98

Now that the new sourceDevice field introduced in WebGestureEvent is
used in WebKit, we can safely remove references to the old one (in
WebGestureEvent::data.flingStart) in Chromium, so that the old one can
be completely removed from WebKit.

BUG=164389


Review URL: https://chromiumcodereview.appspot.com/11740009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175463 0039d316-1c4b-4281-b951-d872f2087c98

Introduces a new class that represents an item's position within an
arbitrarily ordered list.  It's currently biased towards bookmarks, but
it could be made more generic if there was a need for it.

This class supports inserting before, after, or between other
UniquePosition items.  It never runs out of position values, though it
can use up unbounded space in the worst case.

In addition to the basics mentioned above, it also has support for other
functions that are particularly useful for bookmark sync.  The positions
are serializable and de-serializable, for storage and transimission.
They also support conversion to and from int64 values, allowing them to
operate with old-style positions.

The class is not currently used anywhere.  This commit includes only its
implementation and some tests.

BUG=145412


Review URL: https://chromiumcodereview.appspot.com/11569045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168257


Review URL: https://chromiumcodereview.appspot.com/11782015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175461 0039d316-1c4b-4281-b951-d872f2087c98

over a year ago, but it's our only test for some features of extension
messaging, and we've recently been changing that.

If ExtensionApiTest.Messaging starts failing, this will be why. However,
don't get it confused with PlatformAppApiTest.Messaging. Those failures
are unrelated.

BUG=96725

Review URL: https://codereview.chromium.org/11778010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175458 0039d316-1c4b-4281-b951-d872f2087c98