GitLab

BUG=417463
TEST=build with clang plugin

Review URL: https://codereview.chromium.org/885703002

Cr-Commit-Position: refs/heads/master@{#313561}

It's not used anymore, last usage was removed
in https://codereview.chromium.org/583883003

R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/877183003

Cr-Commit-Position: refs/heads/master@{#313560}

The flake should hopefully be fixed by https://codereview.chromium.org/877213002/

R=earthdok
BUG=451988

Review URL: https://codereview.chromium.org/879053004

Cr-Commit-Position: refs/heads/master@{#313559}

There is a check in build-webapp.py (line 197) that ensures that
non-dev builds have this set to 'prod'. Up 'til now, we've been
setting this manually (hence the check in build-webapp), but it
is better to set it correctly in the gyp file.

This also allows the bots to build Official builds without
triggering the build-webapp check.

BUG=

Review URL: https://codereview.chromium.org/886543002

Cr-Commit-Position: refs/heads/master@{#313558}

Right now --disable-sync disables a lot of signin; any signin errors aren't surfaced, because nothing attempts to ping GAIA. This will help address that.

BUG=NONE
TEST=Run Chrome with the --disable-sync flag. Sign into a Profile and
the name (from G+) should appear in the Avatar Menu.

Review URL: https://codereview.chromium.org/870803003

Cr-Commit-Position: refs/heads/master@{#313557}

This fixes a problem where event listeners could stick around for a
short time period after an extension is unloaded, causing problems
with the onInstalled event for a new version of an extension.

BUG=449654

Review URL: https://codereview.chromium.org/877233002

Cr-Commit-Position: refs/heads/master@{#313556}

The CL dumps gesture property values for touch devices that run
with the CrOS gesture library. The format is designed to be
backward-compatible with the X11 behaviour.

Contributed by sheckylin@chromium.org

BUG=450159
TEST=samus ChromeOS build

Committed: https://crrev.com/8b1fb4fdf2b13b71e969cd541e500549163f742b
Cr-Commit-Position: refs/heads/master@{#313446}

Review URL: https://codereview.chromium.org/864253002

Cr-Commit-Position: refs/heads/master@{#313555}

r227327 Fix indents on argument parsing code. No behavior change.
r227326 Make asan_symbolize.py not crash on Windows.

BUG=451741
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/884043004

Cr-Commit-Position: refs/heads/master@{#313554}

r313118 removed unused Cloud Devices code.
Cloud Print code must be untouched.

BUG=452871

Review URL: https://codereview.chromium.org/885683002

Cr-Commit-Position: refs/heads/master@{#313553}

R=lcwu@chromium.org,erickung@chromium.org
BUG=408189

Review URL: https://codereview.chromium.org/886583002

Cr-Commit-Position: refs/heads/master@{#313552}

BUG=447332

Review URL: https://codereview.chromium.org/853523004

Cr-Commit-Position: refs/heads/master@{#313551}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fb46751..db3c2b2

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/881363002

Cr-Commit-Position: refs/heads/master@{#313550}

Opus audio codec is supported by the android platform starting from Lollipop.
This CL enables canPlayType() support for Opus on Clank and MSE playback of Opus
in Clank. This brings Opus feature parity with Desktop Chromium.

BUG=318436

Review URL: https://codereview.chromium.org/866573004

Cr-Commit-Position: refs/heads/master@{#313549}

As in the UsbEventRouter the UsbService must be observed from the FILE
thread (until bug 427985 is resolved, which will be soon). This change
fixes a DCHECK(CalledOnValidThread()) in UsbService::AddObserver when
permission to access an ephemeral (no serial number) device is added and
the DevicePermissionsManager starts listening for disconnection of that
device.

BUG=452652

Review URL: https://codereview.chromium.org/882813002

Cr-Commit-Position: refs/heads/master@{#313548}

The SkSurface that was being cached within the Resource was being held
and counted against skia's budget.  cc's budget is 512MB, and skia's is
~100MB, so cc would always blow skia's budget.  In the case of the ugam
page, we would end up redecoding, reupload and regenerating all of the
mip maps for each of the images on every frame.

Solution is to stop caching the SkSurface.

Additionally, we should investigate if this situation should even be
counted against skia's budget.  See crbug.com/452344

BUG=452138
BUG=447291

Review URL: https://codereview.chromium.org/874353007

Cr-Commit-Position: refs/heads/master@{#313547}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c2893c5..073720e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/878013003

Cr-Commit-Position: refs/heads/master@{#313546}

In this change we elevate the me2me native messaging host before calling into the daemon controller for the tasks that requires elevation. The daemon controller still depends on the com component for those tasks but the elevation is now done in the me2me native messaging host itself.

In followup CLs I will remove the elevated daemon controller com component and move its implementation to DaemonControllerDelegateWin.

Note that the pin confirmation dialog is removed with this CL. This change has been approved by the chrome security team.

BUG=447246

Review URL: https://codereview.chromium.org/880133003

Cr-Commit-Position: refs/heads/master@{#313545}

BUG=447311
TEST=Start Chrome. Click on the "People" menu in the OS menu bar. Any profiles
with default avatar should display the low res, transparent background images
(i.e. not the high res images with the grey background)

Review URL: https://codereview.chromium.org/882113003

Cr-Commit-Position: refs/heads/master@{#313544}

d:\src\cr3\src\base\win\pe_image.h(250): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\win\pe_image.h(250): warning C4302: 'reinterpret_cast': truncation from 'LPCSTR' to 'WORD'

Separate ptr->int from truncation to WORD.

Also, while we're here, fix a cast in IsOrdinal.

R=cpu@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/883873002

Cr-Commit-Position: refs/heads/master@{#313543}

BUG=

Review URL: https://codereview.chromium.org/871543003

Cr-Commit-Position: refs/heads/master@{#313542}

BUG=451959

Review URL: https://codereview.chromium.org/878383003

Cr-Commit-Position: refs/heads/master@{#313541}

Adds a new file to //printing to hold the enums to be included
during the IPC generation. This allows to use them in more than
one generator at the time.

BUG=311308

Review URL: https://codereview.chromium.org/857053002

Cr-Commit-Position: refs/heads/master@{#313540}

This is a clean-up, getting rid of many manual deletes and comments about who owns forms passed around in vectors.

BUG=451018

Review URL: https://codereview.chromium.org/825773003

Cr-Commit-Position: refs/heads/master@{#313539}

This reverts the revert of https://chromiumcodereview.appspot.com/715203004/ by
fixing the build error.

BUG=376014, 376006, 376091

Review URL: https://codereview.chromium.org/868313004

Cr-Commit-Position: refs/heads/master@{#313538}

The major re-factoring for this has been done, this is mostly just
moving the files, with a small addition to ExtensionsBrowserClient.

For extensions/browser/api/networking_private/DEPS:
TBR=jamescook@chromium.org
BUG=363776

Review URL: https://codereview.chromium.org/870163002

Cr-Commit-Position: refs/heads/master@{#313537}

This CL replaces the use of XChangeActivePointerGrab() (of
which there is no XI2 equivalent) with XGrabPointer (of
which there is an XI2 equivalent).

BUG=426380
TEST=None

Review URL: https://codereview.chromium.org/821803002

Cr-Commit-Position: refs/heads/master@{#313536}

Created StatusUploader class to manage the uploading of device status.

Refactored status uploading functionality in cloud policy infrastructure - the
timing and contents of the device upload are now controlled by StatusUploader,
while CloudPolicyClient exposes an API to create the upload job.

BUG=430908

Review URL: https://codereview.chromium.org/845313008

Cr-Commit-Position: refs/heads/master@{#313535}

Remove scrolling action for pages of Top10PageSet.
Measurements that are paired with Top10PageSet are
TabSwitching & PageCycler.  Both of these originally set
action_name_to_run='' which means that they don't expect
RunPageInteraction to run anything.

BUG=418375

Review URL: https://codereview.chromium.org/885493004

Cr-Commit-Position: refs/heads/master@{#313534}

To suppress upcoming changes in text blob bounds calculation.

BUG=451401
R=reed@google.com

Review URL: https://codereview.chromium.org/881323002

Cr-Commit-Position: refs/heads/master@{#313533}

BUG=448626

Review URL: https://codereview.chromium.org/867073002

Cr-Commit-Position: refs/heads/master@{#313532}

Background: ContentVideoView displays fullscreen video in a
VideoViewSurface. Currently, each Android content embedder
(WebView, ContentShell, and ChromeShell) is responsible for
releasing this surface when exiting fullscreen.

Problem: Releasing ContentVideoView from each embedder leads to
code duplication. Worse, this was never done for the WebView:
when it exits fullscreen video playback, AwContents's
exitFullScreen removes the VideoViewSurface which triggers
ContentVideoView's surfaceDestroyed(). surfaceDestroyed()
releases the MediaPlayerAndroid. Releasing the MediaPlayerAndroid
during playback gives a frozen video (see bug).

Solution: For all content embedders on Android, tear down
ContentVideoView, from content-layer (before the embedder
specific "exit fullscreen"-work).

BUG=449152
TEST=For unencrypted video, manually verify that video playback
continues inline when exiting fullscreen (tested in
com.android.browser, ContentShell and ChromeShell). Added
automatic test for VIDEO_HOLE-playback in WebView.

Review URL: https://codereview.chromium.org/845193005

Cr-Commit-Position: refs/heads/master@{#313531}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8b0a05a..c2893c5

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/876343006

Cr-Commit-Position: refs/heads/master@{#313530}

This covers some Omnibox stuff, which is probably responsible for the jank in keyboard messages processing and drilling down some of issues.
There are some issues that require advanced investigations that are not included in this CL:
1. PeekMessage, which is probably processing hooks
2. DispatchMessage, maybe, having same issues
3. GetQueueStatus (!!!)
4. DefWndProc

BUG=440919

Review URL: https://codereview.chromium.org/879153002

Cr-Commit-Position: refs/heads/master@{#313529}

First part of the orderfile generating script refactor. The aim here is to make
sure that all scripts parse the object files the same way, using the same
tool. This commit extracts the parsing logic from patch_orderfile.py. It uses nm
from the Android NDK.

BUG=452879

Review URL: https://codereview.chromium.org/884113002

Cr-Commit-Position: refs/heads/master@{#313528}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0d1eda3..fb46751

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/877373002

Cr-Commit-Position: refs/heads/master@{#313527}

BUG=none
NOTRY=true
TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/886533002

Cr-Commit-Position: refs/heads/master@{#313526}

This is a relanding of the original CL mentioned below, with
a fix for bug http://crbug.com/448599, where some strange cameras
were listed.

The problem was the filtering out of devices with
V4L2_CAP_VIDEO_OUTPUT_MPLANE capabilities, which is the case for
the strange camera enumerated in the mentioned bug, corresponding
to a V4L2 memory-to-memory  graphics processor.

FI: the enumerated device is called exynos-gsc.m2m and is indeed
defined as having such capability in line [1]

[1] http://lxr.free-electrons.com/source/drivers/media/platform/exynos-gsc/gsc-m2m.c#L286

Original Reland description follows -------------------------------------
Relanding: Linux Video Capture: Add support for multiplanar YUV420 format enumeration.

This is a relanding of the original CL _with the designated initializers
changed by typical struct fields accesors_.

Note: Gcc does not support designated initializers and it seems that
there are still a few such builds around, hence the change.

Original CL description follows -----------------------------------------

multiplanar --> V4L2_CAP_VIDEO_CAPTURE_MPLANE

M420 is an example of I420 triplanar format, used
for testing and to be landed since there must be
at least one multiplanar format for this CL to be
consistent.

Following reviewer's hints, the VCDFLinux code is
refactored internally. Given that, some struct
initializations change from

struct A a = {}    _or_   struct A a; memset(&a, 0, sizeof(a));
a.bla1 = foo1;
a.bla2 = foo2;

to

struct A a = {
  .bla1 = foo1,
  .bla2 = foo2,
};

Which is a very common idiom to initialize structs in
interactions with V4L2 IOCTL. I'm introducing it here and
I'm planning to use it further in VCDLinux CLs down the line.

This CL only adds support for enumerating multiplane
format, while the actual capture will be reviewed in
a later CL (WIP @ http://crrev.com/804473008).

BUG=441836, 448599

Review URL: https://codereview.chromium.org/877193005

Cr-Commit-Position: refs/heads/master@{#313525}

This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.

Rather than binding a large number of callbacks for every device, pass a
single new object DeviceEventDispatcherEvdev to each device.

BUG=449710
TEST=boot link_freon & move mouse

Review URL: https://codereview.chromium.org/869613003

Cr-Commit-Position: refs/heads/master@{#313524}

BUG=None
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/883003002

Cr-Commit-Position: refs/heads/master@{#313523}

Revert of Dump property values for the touch log source (patchset #11 id:200001 of https://codereview.chromium.org/864253002/)

Reason for revert:
Broke the arm-generic-freon builder on Chrome OS:

https://uberchromegw.corp.google.com/i/chromeos/builders/arm-generic_freon%20nightly%20chromium%20PFQ/builds/549/steps/BuildPackages/logs/stdio

See crbug.com/452911 - looks like a printf format specifier is wrong on 32 bit

Original issue's description:
> Dump property values for the touch log source
>
> The CL dumps gesture property values for touch devices that run
> with the CrOS gesture library. The format is designed to be
> backward-compatible with the X11 behaviour.
>
> Contributed by sheckylin@chromium.org
>
> BUG=450159
> TEST=samus ChromeOS build
>
> Committed: https://crrev.com/8b1fb4fdf2b13b71e969cd541e500549163f742b
> Cr-Commit-Position: refs/heads/master@{#313446}

TBR=achuith@chromium.org,spang@chromium.org,alexst@chromium.org,adlr@chromium.org,miletus@chromium.org,sheckylin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450159

Review URL: https://codereview.chromium.org/881353002

Cr-Commit-Position: refs/heads/master@{#313522}