- 01 Mar, 2018 40 commits
-
-
Greg Thompson authored
It seems that this has never been used. BUG=511300 Change-Id: If8c07c5b8a713873742e1b8e628b4f718cdda5ff Reviewed-on: https://chromium-review.googlesource.com/939962 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#540102}
-
https://skia.googlesource.com/skia.git/+log/ba7a16519468..9e8a59490531 $ git log ba7a16519..9e8a59490 --date=short --no-merges --format='%ad %ae %s' 2018-02-28 scroggo Support pngs with incorrect CMF bytes 2018-02-28 benjaminwagner Upgrade the Radeon GPU drivers. 2018-02-28 benjaminwagner Revert "Upgrade IntelIris540 Win10 GPU driver." 2018-02-28 benjaminwagner Switch remaining Win10 Skolo bots to new Windows image. 2018-02-28 caryclark make SkDestinationSurfaceColorMode private 2018-02-28 jvanverth Fall back to blurs for unsupported DrawShadow cases 2018-02-28 halcanary SkPDF: encode metadata strings correctly 2018-02-28 egdaniel Respect disable driver correctness workaround flag in Vulkan 2018-02-22 jvanverth Remove deprecated drawShadow interfaces 2018-02-27 ethannicholas Update certain instrinsic calls in SkSL SPIR-V gen to not mix vectors and scalars. 2018-02-27 benjaminwagner Upgrade IntelIris540 Win10 GPU driver. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I286a8af78d4ba525fb55095db781ffff7fe0c40f Reviewed-on: https://chromium-review.googlesource.com/941985Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540101}
-
Zhuoyu Qian authored
Editor::DispatchClipboardEvent() is only called in EditorCommand.cpp, Move it to make |Editor| class simpler for improving code health. Bug: 672405 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Id7f8647cbd3eaa7d101ce46dae1f56b42b08edc0 Reviewed-on: https://chromium-review.googlesource.com/940785Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540100}
-
Victor Costan authored
Currently, CookieStore implementations are responsible for storing cookies and dispatching notifications when the cookies they store change. The dispatch logic is non-trivial, and will grow to support the Async Cookies API (see the associated bug), so it deserves its own class. This CL splits off the change notification dispatch as follows: * CookieStore -> CookieChangeDispatcher * CookieMonster -> CookieMonsterChangeDispatcher * AwCookieStoreWrapper -> AwCookieStoreChangeDispatcherWrapper * CookieStoreIOS -> CookieChangeDispatcherIOS Due to complexities and upcoming refactoring in the iOS CookieStore implementations, the existing implementation is not split up. Instead, CookieChangeDispatcherIOS is a proxy that directs AddCallback*() calls to CookieStoreIOS. The other CookieStore implementations (CookieMonster, AwCookieStoreWrapper) have the change notification dispatch code moved into the ChangeDispatcher classes. This CL also changes the listener registration APIs to pass base::Callbacks by value instead of passing them by reference, per https://chromium.googlesource.com/chromium/src/+/master/docs/callback.md This CL is large, but only does renames / code moving / minor cleanups. It opens up the way for a small (but dense) CL that will revamp the notification dispatch logic. Bug: 729800 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie56b036419a85f7802c6b1d4bb2c935b58232374 Reviewed-on: https://chromium-review.googlesource.com/919159 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#540099}
-
Tsuyoshi Horo authored
This reverts commit 65478d12. Reason for revert: Caused build failure on Mac https://ci.chromium.org/buildbot/chromium/Mac/38768 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FMac%2F38768%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Undefined symbols for architecture x86_64: "extensions::ShellNativeAppWindowAura::ShellNativeAppWindowAura(extensions::AppWindow*, extensions::AppWindow::CreateParams const&)", referenced from: extensions::(anonymous namespace)::TestAppWindowClient::CreateNativeAppWindow(extensions::AppWindow*, extensions::AppWindow::CreateParams*) in shell_extension_loader_unittest.o "extensions::ShellTestBaseAura::SetUp()", referenced from: extensions::ShellExtensionLoaderTest::SetUp() in shell_extension_loader_unittest.o "extensions::ShellTestBaseAura::ShellTestBaseAura()", referenced from: testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_Extension_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_AppLaunch_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_NotFound_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_ReloadFailure_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_LoadAfterReloadFailure_Test>::CreateTest() in shell_extension_loader_unittest.o testing::internal::TestFactoryImpl<extensions::ShellExtensionLoaderTest_LoadDisabledExtension_Test>::CreateTest() in shell_extension_loader_unittest.o ... "extensions::ShellTestBaseAura::~ShellTestBaseAura()", referenced from: extensions::ShellExtensionLoaderTest_Extension_Test::~ShellExtensionLoaderTest_Extension_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_Extension_Test::~ShellExtensionLoaderTest_Extension_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunch_Test::~ShellExtensionLoaderTest_AppLaunch_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunch_Test::~ShellExtensionLoaderTest_AppLaunch_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test::~ShellExtensionLoaderTest_AppLaunchAndReload_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test::~ShellExtensionLoaderTest_AppLaunchAndReload_Test() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_NotFound_Test::~ShellExtensionLoaderTest_NotFound_Test() in shell_extension_loader_unittest.o ... "extensions::ShellTestBaseAura::TearDown()", referenced from: extensions::ShellExtensionLoaderTest::TearDown() in shell_extension_loader_unittest.o "extensions::ShellTestBaseAura::InitAppWindow(extensions::AppWindow*, gfx::Rect const&)", referenced from: extensions::ShellExtensionLoaderTest_AppLaunch_Test::TestBody() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_AppLaunchAndReload_Test::TestBody() in shell_extension_loader_unittest.o extensions::ShellExtensionLoaderTest_ReloadFailure_Test::TestBody() in shell_extension_loader_unittest.o ld: symbol(s) not found for architecture x86_64 Original change's description: > AppShell: Support reloading > > Implement reloading in ExtensionLoader. Uses keep-alives while apps are > reloading. A future CL will observe these keep-alives to keep app_shell open > during reload. > > Bug: 762642 > Change-Id: Ia20b81378d1aeab4ace119d9d2a8b44c2461fdcf > Reviewed-on: https://chromium-review.googlesource.com/912694 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540079} TBR=michaelpg@chromium.org,rdevlin.cronin@chromium.org Change-Id: I2db08946671be6eb37fd3f4d658573b87dd3c1b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762642 Reviewed-on: https://chromium-review.googlesource.com/942701Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#540098}
-
Dominic Mazzoni authored
At least one issue was that the loadComplete event was sometimes being received on a frame with an empty url. Bug: 808343,622387 Change-Id: I7040a75c91f409ba07d3b9ad4e4598805e94b6ce Reviewed-on: https://chromium-review.googlesource.com/938495Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#540097}
-
Alexander Semashko authored
These fonts are used on android too. Change-Id: I0280f681579c2c227f4da4534a194cd04d53000d Reviewed-on: https://chromium-review.googlesource.com/937207 Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540096}
-
Adam Rice authored
- Add an optional |signal| property to RequestInit - Add a |signal| property to Request, chained from RequestInit's signal - Create a chained AbortSignal in Request clone() - Add an Abort() method to FetchManager::Loader - Add an AbortSignal parameter to FetchManager::Fetch() - Add an AbortSignal member to FetchManager::Loader and BodyStreamBuffer The implementation closely follows the Fetch standard, particularly the initialisationn of |signal| in the Request constructor: https://fetch.spec.whatwg.org/#request-class and the signal-related steps in the fetch method: https://fetch.spec.whatwg.org/#fetch-method. The AbortSignal member of BodyStreamBuffer is only set for Response objects. It is not meaningful for Request objects. In addition, it is not set when a Response is created from a stream, as there is no associated Request that JS code could use to abort the response. The design doc is at https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit. The Intent to Ship thread is at https://groups.google.com/a/chromium.org/d/msg/blink-dev/9vNZh4fhV2U/ZVxD2iQACgAJ. Known issues: when abort is signaled between a body access method like arrayBuffer() being called and the returned promise resolving, the promise will reject with a TypeError rather than an AbortError. See http://crbug.com/817687. BUG=750599 Change-Id: I19dfb311f55fcdc566b07449ef2c61ef7be301c7 Reviewed-on: https://chromium-review.googlesource.com/934542Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#540095}
-
Dominic Mazzoni authored
See bug for motivation. Adds separate AXPlatformNodeDelegate interfaces for clipped and unclipped for maximum code clarity. Note that we still want clipped bounds around for hit testing. Bug: 810762 Change-Id: I1b08977e9753fb918b6a4b41f152a238caae12e3 Reviewed-on: https://chromium-review.googlesource.com/938024 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#540094}
-
Wez authored
- Removes sys/resource.h, requiring some additional conditionals around includes of that header under OS_POSIX. - Improves the system PRNG implementation to reduce the potential for lock contention. TBR: scottmg Bug: 707030, 801353, 809660, 738275, 817241, 817586 Change-Id: I4e01a0b23ad66c060ac7a6776a45329775117886 Reviewed-on: https://chromium-review.googlesource.com/942685Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#540093}
-
Nicolás Peña authored
Bug: 773591 Change-Id: Id49125101500155aa291fb7d3d13ff6ae2e4889d Reviewed-on: https://chromium-review.googlesource.com/940285 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#540092}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iccc5b7e77827613fa56a15a9f9e9ea16390ee347 Reviewed-on: https://chromium-review.googlesource.com/942691 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540091}
-
chrome://flagsTrent Apted authored
Bug: 801582 Change-Id: Ib2afbbeee9fb45137d7942159ef517d3c769f13b Reviewed-on: https://chromium-review.googlesource.com/942584Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#540090}
-
Koji Ishii authored
Following bot results are included. 3996 4000 4001 11 new text rendering differences and 1 improved JS test result are rebaselined after manual reviews, included in this patch. 113 lines were removed and 44 lines were deflaked by consecutive results since 3964. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I10496a02c0ad4abc37e40716f15bed833f3b6211 Reviewed-on: https://chromium-review.googlesource.com/940365 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#540089}
-
Dominic Mazzoni authored
Bug: 622387 Change-Id: I68252a1dbfa88eae8e5c4c7801dcbf9cf8f507fe Tbr: aboxhall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/938159Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#540088}
-
Jochen Eisinger authored
R=mmoss@chromium.org,thestig@chromium.org,thomasanderson@chromium.org Change-Id: Idaeee1d4eb957b6685c5c10a4fdc18716d841c3c Reviewed-on: https://chromium-review.googlesource.com/940131Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540087}
-
Jochen Eisinger authored
R=bshe@chromium.org,wzang@chromium.org,xdai@chromium.org,allenvic@chromium.org,baileyberro@chromium.org,zentaro@chromium.org Change-Id: Iecd1aafb445ea058a583c1161b71a4369a199a48 Reviewed-on: https://chromium-review.googlesource.com/939788Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540086}
-
Jochen Eisinger authored
in accordance with https://cs.chromium.org/chromium/src/docs/code_reviews.md?l=198 R=bradnelson@chromium.org,mseaborn@chromium.org Change-Id: I60ccf24402c0ef5a2c3713aa07e9847228a6630a Reviewed-on: https://chromium-review.googlesource.com/939789 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Cr-Commit-Position: refs/heads/master@{#540085}
-
Jochen Eisinger authored
R=dpranke@chromium.org Change-Id: If69ba9ea2ae4b692878de80587c64e244c12dd09 Reviewed-on: https://chromium-review.googlesource.com/941141Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540084}
-
Koji Ishii authored
Test runner distinguishes such tests and writes the result into the 'text_mismatch' field of json. Following values are included in this rebaseline. spaces and tabs only newlines only spaces, tabs and newlines only from: https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/3996/layout-test-results/results.html TBR=eae@chromium.org, xiaochengh@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I2aea5b5d016575db009d8a87f2f2e6200a6a5717 Reviewed-on: https://chromium-review.googlesource.com/942646Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Check whether the context is valid before dispatching a message from a GinPort (the native representation of a runtime.Port object in the Extension API). Add a unittest for the same. Bug: 812363 Change-Id: If985250fb8d2631bda50b803f95c6a6d30cd8fc5 Reviewed-on: https://chromium-review.googlesource.com/933105 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540082}
-
Devlin Cronin authored
We should (finally) remove support for manifest v1. One of the last significant dependencies is that a lot of our tests aren't manifest v2 yet. This CL updates the majority of manifest.json files under chrome/test/data/extensions. This CL only modifies files that update cleanly (i.e., no other test updates necessary). A separate CL will address those. Bug: 816679 Change-Id: I0ae5a47efd9929c5db2c74d58e4d04de7099ef1c Reviewed-on: https://chromium-review.googlesource.com/938261Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540081}
-
Kinuko Yasuda authored
Remaining BUILD.gn and DEPS changes. The new targets are currently configured as following: - //third_party/WebKit/public/common -- former common:blink_common - //third_party/WebKit/public/mojom -- former common:mojo_bindings - //third_party/WebKit/public/mojom:mojom_platform -- former common:mojo_platform_bindings I chose target names that look common in other directories, while there can be some other alternatives, e.g. WebKit/public/common can be WebKit/public:common (like other public:foo targets), but turning WebKit/public/mojom into WebKit/public:mojom in the same way would be too confusing as we still have WebKit/public:mojo_bindings. R=jam@chromium.org,haraken@chromium.org,mek@chromium.org,dcheng@chromium.org,jbroman@chromium.org Bug: 809983 Change-Id: I3028e0f2aeb34a9efe23508dd58a36f50c6f8f82 Reviewed-on: https://chromium-review.googlesource.com/940042 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
Implement reloading in ExtensionLoader. Uses keep-alives while apps are reloading. A future CL will observe these keep-alives to keep app_shell open during reload. Bug: 762642 Change-Id: Ia20b81378d1aeab4ace119d9d2a8b44c2461fdcf Reviewed-on: https://chromium-review.googlesource.com/912694 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540079}
-
Jia authored
This cl also logs time-since-last-touch in UKM. Previously we treat touch events as mouse events. In this cl, we break them into two. Bug: 784232 Change-Id: I30f1a2a22f4df7bd39e2b07bebfb4f74b8db9967 Reviewed-on: https://chromium-review.googlesource.com/940724Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#540078}
-
Yuki Shiino authored
As same as callback function (V8PersistentCallback*Function*), this patch implements V8PersistentCallback*Interface* in the completely same way. (Also see https://crrev.com/c/931561 .) Following patches will changes CallbackInterfaceBase to use wrapper-tracing instead of v8::Persistent, and then everything will look the same as callback function. Note that V8PersistentCallbackInterface is not yet actually used in this patch. Bug: 778580 Change-Id: I08b70f5756d7a9128d8bff2a7a86c0b5cc4244a4 Reviewed-on: https://chromium-review.googlesource.com/940786Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Adam Langley authored
https://boringssl.googlesource.com/boringssl/+log/672f6fc2486745d0cabc3aaeb4e0a3cd13b37b12..8df8e64205d0f8334ee4d403306bfcd4287004b0 BUG=none Change-Id: Id6f34f24ddd54b27ed9b92ee83566d98163dcf05 Reviewed-on: https://chromium-review.googlesource.com/942311Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#540076}
-
David Tseng authored
- other attribute changes fire a lot causing ChromeVox to repeatedly speak. For example, if ChromeVox has its focus on a paragraph, and the page keeps changing attributes on the paragraph, we will echo the paragraph repeatedly. - suppress meaningingful attribute changes when they are as a result of an action. They should be picked up by more meaningful events e.g. focus or occur on a future message (which would no longer be an action). Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id6cf71dce8f417680c6e489385b38f9f8aa616f3 Reviewed-on: https://chromium-review.googlesource.com/941021Reviewed-by:
-
Timothy Loh authored
This patch implements the basic Crostini install flow UI, for now just a dialog with an install and cancel button. The message strings are just placeholders. As the actual install is not ready yet, naturally the install button doesn't do anything. BUG=813699 Change-Id: I89b36e0a773e1b6968dd250719202ec2fc45afe9 Reviewed-on: https://chromium-review.googlesource.com/930503 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#540074}
-
Wei Li authored
During refactoring of SetPrinting() in LocalFrame, for local subframes, we accidentally forgot to call EndPrinting to restore its size. Fix it and set correct expectation for unit test. BUG=817285 Change-Id: I5187f9646cc9ed13a21f7093b33e2afa3bed88a4 Reviewed-on: https://chromium-review.googlesource.com/941885Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e5131a07..0638561d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I50f3bcfabc83a94623669a979764aed4315d76d3 Reviewed-on: https://chromium-review.googlesource.com/941917Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#540072}
-
yoshiki iguchi authored
This CL adds auto-expanding of notification at the top of the message center. If the notification at top is expandable and never manually-expanded-or-collapsed, the message center expands it automatically. And This Cl also implements the manually-expanded-or-collapsed flag on ARC notifications, which has been already implemented for non-ARC notification. Bug: 810656 Test: manual test Change-Id: I50fe1d15271ad8d38f889b65a6dcccc8d82ff403 Reviewed-on: https://chromium-review.googlesource.com/915642 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#540071}
-
Kent Tamura authored
PageOverlay::Update() crashed due to null frame_impl_->FrameWidget() on showing a validation message on the email input below: # main document <body> ... <iframe src="origin different from the main document"> #document <body> <iframe src="origin same as the first iframe"> #document <body> <form> <input type=email> *** <input type=submit> </form> </body> </iframe> </body> </iframe> </body> PageOverlay::Update() uses LocalRootFrameWidget() instead of FrameWidget(). Bug: 807004 Change-Id: I311c2c736fabb2ba97860a3e411266928deb30f5 Reviewed-on: https://chromium-review.googlesource.com/940781Reviewed-by: -
Tsuyoshi Horo authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=mediasource-config-change-mp4-v-bitrate.html TBR: jrummell@chromium.org Bug: 807110 Change-Id: Id44cc9fa07e779f03c74866b41399795dcaca7cf Reviewed-on: https://chromium-review.googlesource.com/942125Reviewed-by:
-
Sammie Quon authored
Preserve round edges after animation. Calculates the bounds after animation and applies identity transform. Test: manual Bug: 808283 Change-Id: I8370f63983bf3fd568d7cb5712e7cd09e380edeb Reviewed-on: https://chromium-review.googlesource.com/940568 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#540068}
-
Adam Langley authored
This is a last-minute change requested by UI team. TBR=srahim Bug: 793985 Change-Id: Ied38eeb3a89f9dd0b1c93686fb7ede182621da6d Reviewed-on: https://chromium-review.googlesource.com/942054Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#540067}
-
Darren Shen authored
The correct ordering of properties depends on the type of style map: - Computed: css properties first, then vendor prefixed ones, then custom properties. Within each category, sort by code point. - Inline: same order as the CSSStyleDeclaration. - Declared: same order as the CSSRule. Spec: https://drafts.css-houdini.org/css-typed-om-1/#stylepropertymapreadonly Bug: 545318 Change-Id: I34fe8f0741bdcc2188926b37635672a4dda32625 Reviewed-on: https://chromium-review.googlesource.com/940381 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#540066}
-
Oliver Chang authored
Mount chromium src dir instead of only the output directory so that paths are more consistent (for e.g. symbolization). TBR=eugenis@chromium.org Bug: 751218 Change-Id: I25baceb53a63c6fdd1f422dff364036d49f29afa Reviewed-on: https://chromium-review.googlesource.com/942124 Commit-Queue: Oliver Chang <ochang@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#540065}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ccdfae76. With Chromium commits locally applied on WPT: 1f9508a4 "[css-layout-api] Populate children, and pass into layout() function" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13023 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy jrummell@chromium.org: external/wpt/encrypted-media jsbell@chromium.org: external/wpt/resources mkwst@chromium.org: external/wpt/mixed-content mkwst@chromium.org, jochen@chromium.org: external/wpt/subresource-integrity TBR=kereliuk No-Export: true Change-Id: Ie15945959e7850f8abed3439de0a2e3ddc768df4 Reviewed-on: https://chromium-review.googlesource.com/942142 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#540064}
-
Shu Chen authored
Currently the input_method_chromeos_unittest.cc is mistakenly excluded in ui_base_unittests, by this cl: https://chromium-review.googlesource.com/c/chromium/src/+/632636 So, this cl includes the tests back again and clean up the compiling errors. This cl also adds some unit tests in InputMethodChromeOSKeyEventTest to cover the logic for JP106 keys. This cl doesn't remove the similar logic in ash::ImeController. It will be removed after a couple of milestones. Bug: 816341 Change-Id: Id3d8b7dd2b8a70632af21cb16220fe7fbd09e9b5 Reviewed-on: https://chromium-review.googlesource.com/936923Reviewed-by:
James Su <suzhe@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540063}
-
