- 29 Oct, 2020 40 commits
-
-
Hiroshige Hayashizaki authored
Before this CL, there are three slightly different methods for module script evaluation: - Modulator::ExecuteModule() - ModuleRecord::Evaluate() - V8ScriptRunner::EvaluateModule() To unify the code paths and behavior, this CL - Merges them into V8ScriptRunner::EvaluateModule() (Mostly just inlining) - Merges Modulator::CaptureEvalErrorFlag into V8ScriptRunner::RethrowErrorsOption, and - Introduces a thin wrapper ModuleScript::RunScriptAndReturnValue() to align with the ClassicScript conterpart. The new behavior of V8ScriptRunner::EvaluateModule() is the same as the previous ModulatorImplBase::ExecuteModule(). This CL shouldn't change the non-test behavior, because all non-test code path went through ModulatorImplBase::ExecuteModule(), This CL also replaces some Modulator calls (that were in Modulator::ExecuteModule() and are now in V8ScriptRunner::EvaluateModule()) with equivalent direct calls to ExecutionContext, to avoid many more overrides in DummyModulator subclasses in unit tests. Bug: 1111134 Change-Id: Icbda1e657b33077f0ae1e681045b04857229cbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462885Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#822046}
-
Kenichi Ishibashi authored
There seems a situation where multiple operations are queued at a time for the same resource id. Since `active_entry_calls_` and `active_doom_calls_` used resource id as a key, only one callback was preserved. When DidGetEntryResult() or DidDoomEntry() were called for the second time, these tried to find active calls from the maps but callbacks were already consumed. This CL replaces keys of `active_entry_calls_` and `active_doom_calls_` with monotonically increasing `call_id_` to make sure we don't lose the callback of each operation. Bug: 1142779 Change-Id: Ie4a999c50bcee3417453da8bbe4b2b529462b91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505338 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822045}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/77defeb04693..f418c109094a 2020-10-29 ianelliott@google.com Vulkan: Document how to turn on debug markers 2020-10-28 ianelliott@google.com Vulkan: App-compat for apps that disable validation & don't link 2020-10-28 cnorthrop@google.com Tests: Update COD:Mobile trace 2020-10-28 cnorthrop@google.com Tests: Add PUBG Mobile Lite trace 2020-10-28 geofflang@google.com Work around Mac glGenerateMipmap with missing levels bug. 2020-10-28 cnorthrop@google.com FrameCapture: Disable GL_OES_mapbuffer during capture 2020-10-28 cnorthrop@google.com FrameCapture: Track surface width/height per context If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: Capture PUBG MobileTest: Test: Capture PUBG Mobile LiteTest: Test: angle_perftests --gtest_filter="*cod_mobile*"Test: Test: angle_perftests --gtest_filter="*pubg_mobile_lite*" Change-Id: I2306b49c5acc06747db6656e01399616647f204f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822044}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/5ede1190cf97..d2fa57d26dff 2020-10-29 dsinclair@chromium.org [doc] Add some documentation around translations. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: Id8ec10288703153b7dab16ac017c939b507cee01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506606Reviewed-by:
-
Dirk Pranke authored
Currently, when a bot runs a test (say, url_unittests) on an Android build, it'll launch `python test_env.py logdog_wrapper.py bin/run_url_unittests` (roughly speaking). This CL flips that around so that the generated bin/run_url_unittests script will invoke test_env.py to launch url_unittests (and the bot will then invoke bin/run_url_unittests directly). This slightly reduces the discrepancy between what a dev runs locally and what the bot runs, and will make Android consistent with every other platform. Bug: 816629 Change-Id: I76727641b5a4362f37762ed4ed4b175eea58ce2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506634Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#822042}
-
Emircan Uysaler authored
This CL applies the crop rect calculated by the overlay processor on Scenic's scene graph. Bug: 1127984 Change-Id: Ifc4a7078c1323fcdc2921e8fccb367e05dfd3824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503857 Auto-Submit: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822041}
-
Harvey Yang authored
This commit extracts ECLidAngleDriverSupported information from AccelerometerUpdate and adds a public function GetECLidAngleDriverStatus() in AccelerometerReader to provide this information because it doesn't change. It also adds SetECLidAngleDriverStatusForTesting() to fake the status for unittests. BUG=b:171446270 TEST=unit tests, and run on jacuzzi & hatch Change-Id: I80cb66e6caf77f9d193b92e9a675d649576fcc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491462 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#822040}
-
Abigail Klein authored
Expose the caption bubble text accessibly in multiple AXVirtualViews, which are a type of AXPlatformNode. Each node has its name set as caption text. Each node corresponds to a line, where line wrapping is done by RenderText. The motivation for this change is that braille displays are sensitive to frequent updates, and exposing the caption bubble text in a single accessible node resulted in that same node to updating multiple times a second, leading to the braille display keeping the user's focus at the beginning of the text. This change allows users to read the captions at their own speed without noticing other nodes updating. Bug: 1055150, 1105676 AX-Relnotes: N/A (feature has not launched) Change-Id: I6433677652c0ebaf14617f4ac216f1fbade28e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462689 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#822039}
-
Sinan Sahin authored
Bug: 1134927 Change-Id: Icd06307a11bdfd218c77f8aaf3ab6e651bb1e978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500483Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#822038}
-
Mark Pearson authored
Change-Id: I908a337129062e882b185a08329fecfd7db6c496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504593Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#822037}
-
Shik Chen authored
The ESLint version listed in peerDependencies of the upstream eslint-config-google is too old and does not support id-denylist yet, so we fix it in our codebase directly instead. Bug: 1123783 Test: CQ Change-Id: I0d7ba088dccbe9dc96ce72d526483d37d68bcc0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505257 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822036}
-
Chong Gu authored
Bug: 1130706 Change-Id: Iaf8bf9e37a06747d74c0722ce490e1dbd26ee9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504202 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#822035}
-
Ben Joyce authored
Bug: None Change-Id: I9f31aa8a2e1194825806969b7deba6a4ad4cd398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506297Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#822034}
-
Luciano Pacheco authored
First batch of files in metadata that Audio Player depends on: - metadata_provider.m.js - image_orientation_unittest.m.js - image_orientation.js - metadata_request.js Note on the image_orientation_unittest: assertArrayEquals() andassertDeepEquals() now check for the type, so changed to use Uint8ClampedArray in the expected value. Bug: 1133186 Change-Id: Icbf9d58039eaa94d732c62c29f9bef08dbd39390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503767 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#822033}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2971eb674935..2bb8035ddc14 2020-10-28 kainino@chromium.org Integrate deprecation testing into DawnTestBase 2020-10-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from e8dc46a8c88b to 5ede1190cf97 (1 revision) 2020-10-28 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c23a5652bda1 to e8dc46a8c88b (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Id29654462a94a9cedcef7228533a76d3cb194668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506603Reviewed-by:
-
Kent Tamura authored
TextControl NG: Fix All/HTMLTextAreaElementTest.ValueWithHardLineBreaks/1 test on linux_layout_tests_layout_ng_disabled bot HTMLTextAreaElementTest is a parameterized test for LayoutNGTextArea flag. However, the feature can be disabled even with GetParam() == true because we can disable LayoutNG flag. This CL fixes the issue by checking LayoutObject instead of GetParam(). Bug: 1040826 Change-Id: I160037df5b2f52694f96379188724b578fb77d59 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505343 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#822031}
-
Hiroki Nakagawa authored
This CL mechanically renames files (isolated_prerender to prefetch_proxy) and classes (IsolatedPrerender to PrefetchProxy) based on the discussion in this design doc: https://docs.google.com/document/d/1e_8buEEhqgY72R2_kjGC3ChBRbA9lt5jEAZr8RLc-5Q/edit?usp=sharing For keeping compatibility with external components, this CL doesn't rename runtime flags and UMA/UKM names. Bug: 1142211 Change-Id: Ic821fa2b1550e7caee9234d378890a58de85a444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503378 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#822030}
-
Chris Lu authored
This change adds logic to show a modal detailing Chromium's use of location data after First Run and showing the prompt if the user taps on the primary action button. This is hidden behind the kLocationFirstRunModal flag. Bug: 1138603 Change-Id: I5ba49231b547edaeaef1ee025744a344f9135998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485748 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#822029}
-
Eric Lawrence authored
Now that OVERLAY_NEW_LAYOUT has launched, remove the flag, resources, and code related to the old layout. Bug: 1110709 Change-Id: I89e8fa4b6e6a3e5fee8f82305794c81d0c3f7df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504329Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#822028}
-
wutao authored
The Recent Highlights has 2x2 preview images. Screenshot: https://screenshot.googleplex.com/56hG78STNTdvCGC Bug: b/168068860 Test: Add new js tests. Change-Id: I1c830667327e18f465f568eb8abacea0929bc409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486285 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#822027}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iaf843991f6a22efa0b9322cfc23164f9564683fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506385Reviewed-by:
-
Alexandre Courbot authored
Before passing frames to convert to the backend, the image processor checks that the storage type of the frame is the same as the storage type the backend has been configured for. This check is however very strict, and does not take into account the fact that for some backends, different storage types might be equivalent. For instance on the V4L2 backend, GMB and DMABUF frames are processed the same way, and are entirely interchangeable. The VideoDecoderPipeline class always create the image processor for use with GMB, but when using the VideoDecoder from ARC, frames are backed by DMABUF. We have no easy way to differentiate these use-cases, and ARC decoding using the VD will thus fail if an image processor is involved. The backend will reject invalid frames when it tries to process it anyway ; so remove that check and let the backend decide whether it can work with a given frame or not. Bug: b:171683262 Test: ./video_decode_accelerator_tests passes on Kukui. Test: ./video_decode_accelerator_tests --use_vd passes on Kukui. Test: ./video_decode_accelerator_tests --use_vd_vda passes on Kukui. Change-Id: I99154597c77c7df99c5cfc6cb104da6b95b66c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503913 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822025}
-
Yue Li authored
Bug: b/169453041 Test: Run existing tests Change-Id: I85a2c447098602ddb6b5734af5b1bb05c343d844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504596Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#822024}
-
manukh authored
Bug: 1062446 Change-Id: Ia983fd212354e0161f2a3f637b2fda2aa8e11ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505895 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#822023}
-
Thomas Guilbert authored
MediaStreamVideoSinks may disconnect from a MediaStreamVideoTrack in response to a OnReadyStateChanged() nofitication. This can lead to an invalid iterator if the sinks disconnect synchronously. This CL fixes the issue by iterating over a copy of sinks instead. Bug: 1143213 Change-Id: I71fc43696d6b239f0bc4668b85474dc713e674b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505552 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#822022}
-
Sven Zheng authored
This mainly gives me the ability to use resultdb to do some analysis because experimental steps are not stored. crbug.com/1115614. Bug: 1111979 Change-Id: Ie185dadc54d36ec6d2815652290806f477fb0298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505726Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822021}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45c5d9f3ebea..5a566e7c6849 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1117343,chromium:1140148 Tbr: patricialor@google.com Change-Id: Id54431127130d714d92cb68e0705a6872c531d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506387Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822020}
-
Gavin Williams authored
This change creates the basic structure of the 'Scan To' dropdown responsible for choosing the directory to save completed scans. This iteration will only have one option defaulted to the 'My files' directory and the follow up CL will let the user choose the directory through the select dialog. 'My files' needs to be created as separate string for displaying because the underlying filepath is always "../../MyFiles". Screenshot: http://screen/AZ6RRV9pPGUKEsN Bug: 1059779 Change-Id: I3f6ebff75c9a81ca8ed13c8d8cd49f5346978cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503854 Auto-Submit: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Jaeyong Bae authored
This patch means using font that allows to distinguish otherwise indistinguishable characters. e.g between O and 0 or l and 1. For this one, fonts that are applied on different platforms: macOS - Menlo Windows - Consolas Chrome OS - DejaVu Sans Mono Linux - DejaVu Sans Mono while Roboto Mono is not among the TextAppearances that Chrome on Android specifies, we can use InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD on the text view to get a similar result. Bug: 768825 Change-Id: I87146a61a8d8d681f04cbe69fd9403327f1c21c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490325 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#822018}
-
Chris Whelan authored
On fuchsia, network connectivity does not guarantee that the time has synced. This change adds TimeSyncTracker in order to give fuchsia a means to block global connectivity until this process is complete. Bug: 162553428 Test: Manual Change-Id: Ied2fa293247a860ddc85b62dbbf554abb2c75be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503406 Commit-Queue: Christopher Whelan <chwhelan@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#822017}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/15be7eb5cbfb..e40e5df22e17 2020-10-28 bsheedy@chromium.org [typ] Disable typ ResultSink integration If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1143021 Tbr: nuskos@google.com Change-Id: I0b999eb5b024100d246cfd9e798601f59f95cf58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506460Reviewed-by:
-
Panos Astithas authored
This changeset also adds a Value::DictClear() in order to deprecate DictionaryValue::Clear(). Bug: 646113 Change-Id: I4783407a861edab475aff1a117c8ac86a01b086b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434102 Commit-Queue: Panos Astithas <pastithas@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Yu Su authored
5G connection type is not added in network_change_notifier_mac.mm currently. It leads to crash in Cronet when testing 5G network on iOS (b/171830601). Change-Id: I781ef9a253ff0e473fba7eceaf549ef2bc011c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506300 Commit-Queue: Yu Su <yuyansu@google.com> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#822014}
-
Hitoshi Yoshida authored
back-send-referrer test assumed that `window.name` refers a same object over same-site navigation including backward navigation. According to an investigation[1], it violates the spec. Chrome's behavior on this point changes if we enable same-site browsing instance swap or backward/forward cache. This CL updates the test to work with BI swap and bf cache. The new test expects to navigate following pages in order of a -> b -> c -> b. When Chromium navigates to b for the first time, its history length is 2 (a and b), but when it navigates back to b again, its history length is 3 (a, b, and c). a: back-send-referrer.html b: back-send-referrer-helper.php c: back-send-referrer-helper.php?x=42 It detects whether showing b with the referrer, which should refer a, and the length of history. [1] https://docs.google.com/document/d/1p7XNboPb-gsQ4d6oOnYbSK3WEwLWzp5DviQFAg-l388/edit# Bug: 1136383, 1132180 Change-Id: I948e6b73cc3956e95481c240b8dd43f9f47dbcf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501881Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#822013}
-
Dirk Pranke authored
Currently, when a bot runs a test (say, url_unittests) on a is_chromeos_device build, it'll launch `python test_env.py bin/run_url_unittests` (roughly speaking). This CL flips that around so that the generated bin/run_ wrapper script launches url_unittests via test_env.py (and the bot will invoke bin/run_url_unittests directly). This will make ChromeOS consistent with every platform other than Android; Android will be converted to match as well in a separate CL. Note that apart from the test_env.py inversion, the location of various other command line argument injections is unchanged, so bin/run_url_unittests should run with the same args as before. Bug: 816629 Change-Id: I5d0ac2ed847acb9685b27c41df1ed616311f64a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368537 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/81a2c08d..cd60eacd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7909d67f796a5155dfb588cd76bb499efa6974ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506483Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822011}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603907949-48bee2a7f2855ac438725bf6194390f836d0af96.profdata to chrome-mac-master-1603929441-b6b34c1c4b0f9e2ddac4473f28fe820beebad5c9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I61e137ef8c945a87d8d9131b1e7276cbdef540f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506601Reviewed-by:
-
Yuly Novikov authored
Not running any tests at this point. Bug: 1004356 Change-Id: Ibad14747b12121f8abb13dba001d83346f84cc80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506459 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Shik Chen authored
Bug: 1123783 Test: CQ Change-Id: I89fdcae6b7be07326137f2c7cc03c77ac49e7646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505360 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I317893d9411f5b0888ae696f20dabb333389c25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506611Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822007}
-
