- 05 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/74f8dbb95782..378347c17f31 2020-10-05 jleconte@google.com Bisect on a chart with empty Bug ID fails. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1134978 Tbr: oysteine@google.com Change-Id: I8bc8e875344b9e52938897296d369ab1ff2d3f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813773}
-
Richard Knoll authored
Notification Triggers OT has been restarted so we want to keep collecting data for its duration. Note that the collection code has not been removed when the metric was marked as obsolete. Bug: 1104957, 1053086 Change-Id: I7a2b819f799a920aae6b83520f9797c8cb1bcd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440839Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813772}
-
Lucas Radaelli authored
This change fixes the bug where chrome was sending the full semantic tree only for the first time that semantics were enabled. This happened because the semantic tree was not getting cleared on the chrome side when disabled. when semantic were disabled / enabled, the events fired on the tree included only the diffs from the previous state of the tree. Test: web_engine_browsertests Bug: fuchsia:59680, 1134147 Change-Id: I8266d6436f9bfb9ee9e89a0f46c0916bac7a5e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442646 Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#813771}
-
David Bokan authored
This test incorrectly allows overscroll actions like gesture-navigation which would interfere with the reported overscroll delta. This CL disables overscroll actions with |overscroll-behavior:none|; however, Chrome has a bug where it consumes overscroll delta, even when overscroll-behavior is set to none. Because of this bug, this test uses very approximate values for expectations and were right on the edge of what was frequently being seen. However, due to the nature of the bug a timing change here nudged it below the thresholds so I've loosened these. Bug: 1112183 Change-Id: If4ecf7a263385ddc3211f7776aca21eb8ec3aa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442152Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813770}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c401923f3ee3..8e4cda7de008 2020-10-05 tommi@webrtc.org Give PseudoTcp its own FifoBuffer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1a6a4d4e9c54a774ecfa2e3aeac74981ffd023e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450114Reviewed-by:
-
Rohit Agarwal authored
Incognito notification tests were using @TargetApi annotation to ensure not running the tests in older android versions but the @TargetApi annotation has no effect in runtime and only has Class level retention which is useful for lint checks only. This CL uses @MinAndroidSdkLevel annotation instead. Bug: 1134241 Change-Id: I25788cb1492d1d719a667b0da1683e52a5caf1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448371Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#813768}
-
sauski authored
Previously limitations on the number of surveys displayed to a user were keyed on a survey trigger. This is fine when the number of surveys displayed is small and intentionally partitioned via finch, but as the number of surveys is expected to grow this could result in users being shown surveys too frequently. This CL adds a generic cooldown that prevents any survey from being shown if the user has already seen one within the last 7 days. Bug: 1110888 Change-Id: I59189b6e1d67de19bf5359de42a7ed7691810d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445270 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#813767}
-
Clark DuVall authored
Due to b/169196314 the OS does not use the split's class loader to load services even when the service is in the split's manifest. To work around this, all services need to be defined in the base module's dex. This uses a similar approach to what was done for the Application class in http://crrev.com/c/2425404. Since there are multiple Service base classes which chrome services inherit from, I ended up using jinja templates to reduce duplication of common service methods since I couldn't find a good way to do this in pure Java. Alternatively I could also copy the base Service methods for the split compat version of each Service subclass. I converted an example Service, JobService, and IntentService to show usage. A follow up will convert the rest of the services used in chrome. Note that gerrit is not doing a good job of detecting renamed files here, so Patchset 1 contains strictly the moved service files, and future patchsets have the diffs from that. I would recommend reviewing with the base set to Patchset 1. Bug: 1126301 Change-Id: I8ccda76ee410e20d847791700b2987349e05959a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441250Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#813766}
-
Kristi Park authored
This reverts commit bd7b15d0. Reason for revert: PasswordViewControllerTestCase failures for ios_chrome_integration_eg2tests_module_* https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/12479 Original change's description: > Reland "[iOS][Password Check] Rewriting Passwords test with new details screen" > > This is a reland of 7b693e30 > > Fixed failing tests: > testStoredEntriesAlwaysShown > testCancelDeletionInDetailView > testSearchPasswords > > Original change's description: > > [iOS][Password Check] Rewriting Passwords test with new details screen > > > > This change rewrites Passwords tests with new Password Details screen. > > Obsolete tests are deleted. Fixed flakiness for > > testSearchAndDeleteAllPasswords. > > > > Bug: 1075494, 1129441 > > Change-Id: Id6d44a2f77c20edb1788f1d3dcaa04e9e645cdb5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418853 > > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811668} > > Bug: 1075494 > Bug: 1129441 > Change-Id: Ibfe28ea3ee68f9fb69fcb50085da9c1c558f86d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438380 > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813660} TBR=eugenebut@chromium.org,gambard@chromium.org,vsemeniuk@google.com Change-Id: Ia803bf926c7dc689daf0a25abb49008e8fd92aef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075494 Bug: 1129441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450409Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#813765}
-
Roman Sorokin authored
* Use AsWeakPtr instead of base::Unretained in the WizardController * Check chrome::IsAttemptingShutdown together with browser_shutdown::IsTryingToQuit. IsAttemptingShutdown covers call to chrome::AttemptUserExit() which is common in the Chrome OS login/policy code. Bug: 1132397 Change-Id: I6c0e28138918a998c94f82f5c9e7736df92e5ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450051Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813764}
-
Sergey Ulanov authored
content_shell uses ui.policy.Presenter API to present UI. The API wasn't listed in content_shell.cmx, so it was failing to connect to the presenter. Also added content/shell/fuchsia/OWNERS file (required by presubmit checks for all cmx files). Bug: 1067477 Change-Id: I477644a28549f9314e9ffd007d1da9abcc6c8b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443449Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813763}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b3c1e71eb1cb..01144ed91c35 2020-10-05 bclayton@google.com third_party/cppdap: Roll forward to 1fd23dda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I814d1b6e001d1d599e691c3650af9fd65171e5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449647Reviewed-by:
-
Patrick Brosset authored
The new jump-to-var feature in the devtools frontend repository is changing the way css variables and css colors appear in the UI. Because of this, 3 web tets fail. In order to land the feature in the front-end repo, I'm disabling the tests temporarily. I'll fix and re-enable them as soon as the code is in Bug: 1135145 Change-Id: I676c644c6fb2c75bf219eb40e7a5e5d914470512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448056 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813761}
-
Eric Robinson authored
This CL adds UseCounters for activation of third party frames, as well as for general access to these frames, and third parties that had frames that were both activated and accessed. Change-Id: Ib366336a2553c5625341147e82875c4265b42225 Bug: 1115657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402196 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#813760}
-
Kushagra Sinha authored
Add a bare bones AccountManagerFacade interface definition and 2 stub implementations - AccountManagerFacadeAsh and AccountManagerFacadeLacros. Additionally, add a factory function - GetAccountManagerFacade, to return the correct implementation. Bug: 1117472 Change-Id: Ied4b50e08ecee78f72412b64c86341fb097bdc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424229Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#813759}
-
Leonid Baraz authored
The flakiness seems to be a test issue: apparently calling waiter.Signal by the callback directly sporadically blocks. The fix moves this call to a threadpool, and after that change 100 runs got no failures under stress (without the fix about 20 runs out of 100 crash). I would prefer to move whole callback to the thread in DmServerUploadService, but all my attempts to do so still ended up with the test being flaky. We may need a better fix inside the code rather than the test, but for now I see no other option. Bug: 1133968 Change-Id: I8ecde7f5c65911b75679cae5130985713233016f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448657 Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#813758}
-
Caitlin Fischer authored
The study and params were added here: https://codereview.chromium.org/2108053004. Bug: 1126640 Change-Id: Ib73c71702e6fb5c0cc151ddddc20b4788e4c17d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427073 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#813757}
-
kylechar authored
Tests should use --enable-gpu-rasterization instead. For the most part this was already the case, except for any of the stories based on PolymerPage in the rendering benchmark, which are disabled anyways. Bug: 1133368 Change-Id: Icffefd3800813b1e9c156f50ff69f2c9ff3c012e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436535Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Chris Sharp authored
args.gn has been a dependency for blink_web_tests_support_data for a while, but it isn't deterministic. TBR=thakis@chromium.org Bug: 1135151 Change-Id: I8f56ad9d25c4453e1afbb8e5ddaaf7295dc5c004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449930Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813755}
-
Sebastien Lalancette authored
SharingCoordinator will now handle add/edit bookmark commands sent from the Bookmark Activity, and will make use of the new BookmarkEditCoordiator to handle showing the Edit Bookmark UI. Bug: 1133294 Change-Id: I7f69f241b49646ffb1853a4a78322f5b941b6cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441957 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813754}
-
Thiabaud Engelbrecht authored
Bug: 1134257 Change-Id: I7a5da462acc3031fbe940345c907db1abfb1d11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441946Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#813753}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/497b7a37..69b996bd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I719ca57ded415c52762bea513873242b70f91f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449909Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813752}
-
Ilya Nikolaevskiy authored
The crash is now fixed. Bug: webrtc:11485 Change-Id: I56b09aca9fb547bc49b24ae1f634b9a4a878d07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449990 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813751}
-
Sebastien Lalancette authored
This new Coordinator will enable an edit-only scenario, requiring only a minimal set of dependencies. Without this new Coordinator, the "Edit Bookmark" flow ended up being dependent on the SharingCoordinator (via the BookmarkHomeViewController). Since bookmarks can be edited via the sharing activities ("Edit Bookmark"), we ended up with a cyclic dependency. The creation of this new Coordinator enables such flow. e.g. Open a page -> Add it to Reading List -> Add it to Bookmarks -> Open Reading List -> Long-press on the entry -> Select Share -> Select "Edit Bookmark". Bug: 1133294 Change-Id: Ib646a7e79e6c46b5cd4b373417caa447a4365ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441956 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fbcd4c1d714d..0afca615a816 2020-10-05 bmeurer@chromium.org [ts] Type-check ui/ShortcutRegistry.js with TypeScript 2020-10-05 tvanderlippe@chromium.org Typecheck sources/SearchSorucesView.js with TypeScript 2020-10-05 aerotwist@chromium.org TypeScriptify JsMain 2020-10-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-05 tvanderlippe@chromium.org Typecheck sources/ScriptFormatterEditorAction.js with TypeScript 2020-10-05 sigurds@chromium.org Improve template types in Target/SDKModel 2020-10-05 tvanderlippe@chromium.org Typecheck sources/TabbedEditorContainer.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5483d07b0fbf1aa8e0f7d915112a2c2fd5b2792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449646Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/97440de4b947..750261f41af6 2020-10-05 kjlubick@google.com [canvaskit] Update npm to 0.18.0 2020-10-05 kjlubick@google.com [canvaskit] Flesh out remaining docs for core CanvasKit. 2020-10-05 kjlubick@google.com [canvaskit] Add docs/types for Font and related. 2020-10-05 kjlubick@google.com [canvaskit] Add docs/types for Path 2020-10-05 kjlubick@google.com [canvaskit] Add docs/types for Paint and Filters/Effects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Idd66978369793e11f2f4e267971abb40bbd10d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449645Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium df979ead. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I9e212494b9bf7d1c7e3fbc0826813dcbcb41277d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449809Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813747}
-
sauski authored
To capture when a HaTS Next survey fails to load a histogram entry is created when loading of the dialog times out. Bug: 1110888 Change-Id: Ibe55385e557cb1da7debb156019995a4fac22c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443733Reviewed-by:
-
Francois Beaufort authored
This CL renames MediaTrackConstraint IsEmpty method to IsUnconstrained to avoid confusion with the Vector IsEmpty method. Change-Id: I5111b661ff0440f353d8c3533d988130bbe3485b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437813 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#813745}
-
Oriol Brufau authored
Consider this testcase: <style>div { width: min-content; padding: 5px; }</style> <div contenteditable>line1<wbr>line2</div> which is rendered as line1 line2 Before this patch, when clicking at the beginning of the 2nd line, the caret would appear at the end of the 1st one, because CanonicalPosition would search backwards even with a downstream affinity. Also, when clicking at the beginning of the 1st line and pressing the down arrow key, the caret would move to the end of the 1st line instead of to the beginning of the 2nd one. And pressing the key again would have no effect, the caret would refuse to go down. This patch fixes these problems by making CanonicalPosition take a TextAffinity parameter which affects whether the canonical position is first searched backwards or forwards. If no suitable candidate is found, it will still search in the other direction. And then, VisiblePosition::Create takes care of deciding between the upstream and the downstream canonical positions, depending on the affinity and whether there is a line break. Bug: 1002937 Web tests: TEST=external/wpt/editing/run/caret-navigation-around-line-break.html Unit tests: TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/0 TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/1 TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/0 TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/1 TEST=VisiblePositionTest.ShadowV0DistributedNodes TEST=VisibleUnitsLineTest.endOfLine TEST=VisibleUnitsLineTest.isEndOfLine TEST=VisibleUnitsLineTest.isLogicalEndOfLine TEST=VisibleUnitsLineTest.isStartOfLine TEST=VisibleUnitsLineTest.logicalEndOfLine TEST=VisibleUnitsLineTest.logicalStartOfLine TEST=VisibleUnitsLineTest.startOfLine TEST=VisibleUnitsTest.canonicalPositionOfWithHTMLHtmlElement TEST=VisibleUnitsTest.canonicalPositionOfWithInputElement TEST=VisibleUnitsTest.canonicalizationWithCollapsedSpaceAndIsolatedCombiningCharacter Change-Id: I82d86d40a87513b2e92c024735957e9f71154094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410404 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813744}
-
Sebastien Lalancette authored
Splitting the "bookmarks" target further than it previously was. This will allow the reuse of various components and creation of another target which will enable an edit-only flow, with reduced dependencies. Bug: 1133294 Change-Id: I62469eee5deb06279dc16d6a7a02d56fe48e76a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440310 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#813743}
-
Owen Min authored
It should be "unlisted" instead of "private only". Change-Id: I20922745236070fcdea0dac74c6d835029b59777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448685 Commit-Queue: Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813742}
-
Alessio Bazzica authored
ConfigAutomaticGainControl now supports two additional AGC2 params that are needed for experimentation. Tested: checked feature activation via AECdump using appr.tc $ out/Default/Chromium.app/Contents/MacOS/Chromium \ --enable-features=WebrtcHybridAgc Bug: webrtc:7494 Change-Id: I81225ebc05a66ca18e5c4b2edc350cd42f19c31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446052 Commit-Queue: Ale Bzk <alessiob@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: If858a8ff19c757b7fbae59e86005608f5dfa687c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445870Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813740}
-
Matthias Körber authored
Test causing deterministic failures. TBR=sophiechang@chromium.org Bug: 1135134 Change-Id: I6bdfc88a2a2e2bd7e1721101e94e545b9d7b11b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449949Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#813739}
-
Maksim Moskvitin authored
This CL plumbs PendingSharedURLLoaderFactory to TrustedVaultConnectionImpl, and address noisy NOTIMPLEMENTED in TrustedVaultConnectionImpl. Bug: 1113598 Change-Id: I3287ed4ac1bb4599d1227e9cb90563ce0d650d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435227 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#813738}
-
Sebastien Lalancette authored
Created the BookmarkPageCommand which takes a title and URL parameter in order to create (or trigger edit for) a bookmark. Added it to a new BookmarksCommands protocol - allowing it to not be required by BrowserCommands (BVC). Bug: 1133294 Change-Id: If73503350d7d63fd467c45941113bcbafe06ad2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441910 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Alessio Bazzica authored
ConfigAutomaticGainControl now supports more AGC2 params that are needed for experimentation. The CL includes a refactoring to avoid base::Optional boilerplate and it improves the docstring for `ConfigAutomaticGainControl()`. Tested: checked feature activation via AECdump using appr.tc $ out/Default/Chromium.app/Contents/MacOS/Chromium \ --enable-features=WebrtcHybridAgc Bug: webrtc:7494 Change-Id: I0d226b9e7e6f17acb8408af8ded80d80db7cabe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446149 Commit-Queue: Ale Bzk <alessiob@chromium.org> Reviewed-by:
-
Andrei-Laurențiu Olteanu authored
Add function to dispatch an event from callback. Add browser test for each lid event. Bug: b:162051831 Change-Id: I09412b2be19c702a7fd47b5c069efab9c061b73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448490 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#813735}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/895556e19c08..c401923f3ee3 2020-10-05 yunz@fb.com Take max bitrate into account for target bitrate decision when min bitrate is empty 2020-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0de57436..ac83b0e7 (813540:813657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icaf3585c34ade91bc60388c90592be059b9e74d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449640Reviewed-by:
-
